From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30045.outbound.protection.outlook.com [40.107.3.45]) by dpdk.org (Postfix) with ESMTP id 44CE01B319 for ; Mon, 5 Feb 2018 07:31:51 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=8NfutTCW1lN1+KglBEmXZUzvdR+LZGbto0mBGUnB9M4=; b=KC8A7ulGERRljUrYJtm2rF/Ll5F0EArgnSSukVdMW5dILOXnh+SqyeBNt5XM4IkSxzrq8UymLv2UnzrHgefFc0MjTT8GG+L4xg3dAkEVEtPRWzd7Ai67aZwSLVgjMwGGWxnaplPq3sLn4D0rh6MX8Bib6f2ICPeVNcS3QEYCI4g= Received: from AM5PR0401MB2451.eurprd04.prod.outlook.com (10.169.244.20) by AM5PR0401MB2564.eurprd04.prod.outlook.com (10.169.245.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.464.11; Mon, 5 Feb 2018 06:31:50 +0000 Received: from AM5PR0401MB2451.eurprd04.prod.outlook.com ([fe80::1d27:f187:80d8:d5e7]) by AM5PR0401MB2451.eurprd04.prod.outlook.com ([fe80::1d27:f187:80d8:d5e7%13]) with mapi id 15.20.0464.015; Mon, 5 Feb 2018 06:31:49 +0000 From: Shreyansh Jain To: Nipun Gupta CC: "dev@dpdk.org" , "santosh.shukla@caviumnetworks.com" , Hemant Agrawal , Sunil Kumar Kori , "thomas@monjalon.net" , "jerin.jacob@caviumnetworks.com" Thread-Topic: [PATCH 2/4] bus/dpaa: fix registering dpaa mempool ops Thread-Index: AQHTnkFQHSSHpVKEXUq6thf9UIDSCqOVWBiA Date: Mon, 5 Feb 2018 06:31:32 +0000 Deferred-Delivery: Mon, 5 Feb 2018 06:31:09 +0000 Message-ID: References: <1517808117-28562-1-git-send-email-nipun.gupta@nxp.com> <1517808117-28562-2-git-send-email-nipun.gupta@nxp.com> In-Reply-To: <1517808117-28562-2-git-send-email-nipun.gupta@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shreyansh.jain@nxp.com; x-originating-ip: [92.121.36.198] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM5PR0401MB2564; 7:3CFXgVoTcvzExW/M2+l1UCfKaOcPs1u+yeQcNtIdCGoS2gugRJaTTqbQaQVEZJfw7lStWNkOx6xtuiJZ6V7vVjnCxQ+UOoZy+dO799sH5UbAcle3YqlEFoW/D8axrwmhfOBZhdWOPMUhJ35C7+d5FUYWo1AGsw4TRbanDgLVHmUrG5uWJNjZn0UmA96GCdZGmgOTDN/xqMlWQirYtvjigZ6hbv46Y7wKGcK8zQmI29FvOnyXIDAVRrl2obLZxUrV x-ms-exchange-antispam-srfa-diagnostics: SSOS;SSOR; x-forefront-antispam-report: SFV:SKI; SCL:-1; SFV:NSPM; SFS:(10009020)(396003)(346002)(39380400002)(376002)(366004)(39860400002)(199004)(51444003)(13464003)(189003)(5250100002)(2906002)(74316002)(54906003)(305945005)(106356001)(66066001)(2950100002)(6436002)(14454004)(76176011)(6636002)(102836004)(7696005)(6506007)(2900100001)(575784001)(53546011)(86362001)(6666003)(7736002)(229853002)(3846002)(5660300001)(478600001)(6116002)(316002)(81156014)(8676002)(26005)(3660700001)(6246003)(6862004)(55016002)(59450400001)(9686003)(53936002)(81166006)(8936002)(68736007)(4326008)(99286004)(97736004)(105586002)(33656002)(25786009)(3280700002)(334744003); DIR:OUT; SFP:1101; SCL:1; SRVR:AM5PR0401MB2564; H:AM5PR0401MB2451.eurprd04.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: ac422028-6484-43e5-d446-08d56c62235e x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(3008032)(2017052603307)(7153060)(7193020); SRVR:AM5PR0401MB2564; x-ms-traffictypediagnostic: AM5PR0401MB2564: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(185117386973197); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040501)(2401047)(8121501046)(5005006)(10201501046)(93006095)(93001095)(3002001)(3231101)(2400082)(944501161)(6055026)(6041288)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123564045)(20161123562045)(6072148)(201708071742011); SRVR:AM5PR0401MB2564; BCL:0; PCL:0; RULEID:; SRVR:AM5PR0401MB2564; x-forefront-prvs: 0574D4712B received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: LhGpd3ALIKKuT1nf7F9Raa2KtwpJ1u3s/ly/H3QF4VhV1s60jFX9j0GgPxFJHIvmhio3Nc4Ns+KU/+cr7f/f8A== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: ac422028-6484-43e5-d446-08d56c62235e X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Feb 2018 06:31:49.8180 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0401MB2564 Subject: Re: [dpdk-dev] [PATCH 2/4] bus/dpaa: fix registering dpaa mempool ops X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Feb 2018 06:31:51 -0000 > -----Original Message----- > From: Nipun Gupta > Sent: Monday, February 5, 2018 10:52 AM > To: thomas@monjalon.net; jerin.jacob@caviumnetworks.com > Cc: dev@dpdk.org; santosh.shukla@caviumnetworks.com; Hemant Agrawal > ; Shreyansh Jain ; > Sunil Kumar Kori ; Nipun Gupta > > Subject: [PATCH 2/4] bus/dpaa: fix registering dpaa mempool ops >=20 > Fixes: 2bd0d5b951a9 ("bus/dpaa: register platform HW mempool on > runtime") >=20 > Signed-off-by: Nipun Gupta > --- > drivers/bus/dpaa/dpaa_bus.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/bus/dpaa/dpaa_bus.c b/drivers/bus/dpaa/dpaa_bus.c > index 1946bbe..290b967 100644 > --- a/drivers/bus/dpaa/dpaa_bus.c > +++ b/drivers/bus/dpaa/dpaa_bus.c > @@ -495,10 +495,16 @@ int rte_dpaa_portal_fq_close(struct qman_fq *fq) > ret =3D drv->probe(drv, dev); > if (ret) > DPAA_BUS_ERR("Unable to probe.\n"); > + > break; > } > } > - rte_mbuf_set_platform_mempool_ops(DPAA_MEMPOOL_OPS_NAME); > + > + /* Register DPAA mempool ops only if any DPAA device has > + * been detected. > + */ > + if (!TAILQ_EMPTY(&rte_dpaa_bus.device_list)) > + > rte_mbuf_set_platform_mempool_ops(DPAA_MEMPOOL_OPS_NAME); >=20 > svr_file =3D fopen(DPAA_SOC_ID_FILE, "r"); > if (svr_file) { > -- > 1.9.1 >=20 Just a note: there is an extra line insertion in this patch which is not re= lated to the patch fix. Though, I think that makes the code more readable a= s preceding if() for this new line is without {}. Acked-by: Shreyansh Jain