From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0081.outbound.protection.outlook.com [104.47.1.81]) by dpdk.org (Postfix) with ESMTP id A8BB11B64C for ; Mon, 5 Feb 2018 17:26:05 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=25+6UW6pZaKvpG7rKvS1bbVqWezTCAYesyVt71Vmfbo=; b=WPfv0vyKzbNuTx93VQ4VFkLoUtnG3CIY02sJKlhOhTOzKXpgWyn/cu1WOThbQHy3uFBb61+aHyulOY1h/8xV0f8gw9fSC0tyyI/vCOKub3cd02gQyH6mg/F5Rs5karFuXyRNhZtHLS9KLA1IzYSpfUftKaDybmWBuG++Oh0O2Nc= Received: from AM5PR0401MB2451.eurprd04.prod.outlook.com (10.169.244.20) by AM5PR0401MB2642.eurprd04.prod.outlook.com (10.169.245.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.464.11; Mon, 5 Feb 2018 16:26:05 +0000 Received: from AM5PR0401MB2451.eurprd04.prod.outlook.com ([fe80::1d27:f187:80d8:d5e7]) by AM5PR0401MB2451.eurprd04.prod.outlook.com ([fe80::1d27:f187:80d8:d5e7%13]) with mapi id 15.20.0464.015; Mon, 5 Feb 2018 16:26:04 +0000 From: Shreyansh Jain To: Thomas Monjalon CC: "dev@dpdk.org" Thread-Topic: [PATCH v3] raw/skeleton_rawdev: fix device start test Thread-Index: AQHTnnLJ4Pi227MALkeDZsDR98aKQaOV2UuAgAAkbZA= Date: Mon, 5 Feb 2018 16:25:59 +0000 Deferred-Delivery: Mon, 5 Feb 2018 16:25:08 +0000 Message-ID: References: <20180205112425.17579-1-shreyansh.jain@nxp.com> <20180205113108.19340-1-shreyansh.jain@nxp.com> <14198513.UUEtOtHhuI@xps> In-Reply-To: <14198513.UUEtOtHhuI@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shreyansh.jain@nxp.com; x-originating-ip: [182.69.212.229] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM5PR0401MB2642; 7:9Mo14y/3uqoCUBSEu9pnHZtoRY1/B0hckuYiUGTxzOZ8/NZ8QjJuFXrBMV6x8UHzUynviWakOD6AIQ2imeN9iO1H1LjAUy5gsMnFP3ymejzqYfV3N6ApJJN1HhUIXapiBdKCHL9smUa0czx7aljfpSr2NcAReQTWc/Cg9HjKmNWAqBkLpHifUb0wzriGW6PCHo2Td5IE0QZKIE6P5/JgVUUhqk/ALpL3LU+NR0v5uwRZ6ybxC3waH9W4nqjwQy8a x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: c3d8570d-023c-4cfd-3a02-08d56cb5276a x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(3008032)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603307)(7153060)(7193020); SRVR:AM5PR0401MB2642; x-ms-traffictypediagnostic: AM5PR0401MB2642: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(185117386973197); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040501)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(10201501046)(3231101)(2400082)(944501161)(6055026)(6041288)(20161123560045)(20161123564045)(20161123562045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:AM5PR0401MB2642; BCL:0; PCL:0; RULEID:; SRVR:AM5PR0401MB2642; x-forefront-prvs: 0574D4712B x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(39380400002)(366004)(376002)(396003)(39860400002)(13464003)(189003)(199004)(106356001)(4326008)(74316002)(86362001)(575784001)(6436002)(7736002)(305945005)(3280700002)(5250100002)(105586002)(66066001)(2900100001)(6246003)(55016002)(9686003)(53936002)(14454004)(97736004)(8676002)(68736007)(6916009)(53546011)(6506007)(26005)(81166006)(186003)(5660300001)(99286004)(102836004)(81156014)(76176011)(478600001)(7696005)(3846002)(6116002)(3660700001)(2950100002)(2906002)(6666003)(8936002)(229853002)(33656002)(316002)(25786009); DIR:OUT; SFP:1101; SCL:1; SRVR:AM5PR0401MB2642; H:AM5PR0401MB2451.eurprd04.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: 4NGBcUuU/FZG3W2uM1YlX5scQwKECZgLeP8WQX1sx5MSQo/711zFfvdEK+f/WflrnTGUUiTFQlNilNuwmvlwCA== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: c3d8570d-023c-4cfd-3a02-08d56cb5276a X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Feb 2018 16:26:04.8477 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0401MB2642 Subject: Re: [dpdk-dev] [PATCH v3] raw/skeleton_rawdev: fix device start test X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Feb 2018 16:26:05 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Monday, February 5, 2018 7:41 PM > To: Shreyansh Jain > Cc: dev@dpdk.org > Subject: Re: [PATCH v3] raw/skeleton_rawdev: fix device start test >=20 > 05/02/2018 12:31, Shreyansh Jain: > > Device can only be started if firmware is loaded, as per Skeleton > > rawdev driver semantics. This patch fixes original implementation > > which attempted to start the device without loading firmware. > > > > Fixes: 55ca1b0f2151 ("raw/skeleton: add test cases") > > Cc: shreyansh.jain@nxp.com > > > > Signed-off-by: Shreyansh Jain > > --- > > v3: > > - Moving 'Fixes' below commit message > > - patch headline made specific > > > > v2: > > - Fixed headline from drivers/raw to raw/skeleton_rawdev >=20 > Actually, it should be raw/skeleton because it is shorter > and it is what was chosen for previous commits :) Yes, that is shorter but not correct as per directory name. And, I thought = I had made a mistake in previous commit. In hindsight, my choice for driver name itself was not correct - I had thou= ght of type_subtype but it doesn't sound right now that it is directory. I = will change that in next release, I guess. I will send v4 with 'raw/skeleton'.