From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30061.outbound.protection.outlook.com [40.107.3.61]) by dpdk.org (Postfix) with ESMTP id B47002B9E for ; Fri, 1 Dec 2017 07:24:27 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=P6j2FJ60r/KV8P6IMljBtMjeKMPD+EfbRLnCK2ZvHVY=; b=CSIqyaPMiwnGowa1iBwJKPKtQ/p665PBr++AeA4GGSYnkkkFyvSnWYTCB/khBG6wTRxTiYT5xWZeBznMtW0Fs6K0FWlqbUVwW2mMacTaCv/XI3tv9JyMrY4+Se1rv8vGa8p5aQI4jpVmT4gRA4iIhE64xu5jmeOOuvN3fLSLntg= Received: from AM5PR0401MB2451.eurprd04.prod.outlook.com (10.169.244.20) by AM5PR0401MB2452.eurprd04.prod.outlook.com (10.169.244.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.282.5; Fri, 1 Dec 2017 06:24:26 +0000 Received: from AM5PR0401MB2451.eurprd04.prod.outlook.com ([fe80::c15d:c7a5:4c3e:e5ca]) by AM5PR0401MB2451.eurprd04.prod.outlook.com ([fe80::c15d:c7a5:4c3e:e5ca%18]) with mapi id 15.20.0282.007; Fri, 1 Dec 2017 06:24:26 +0000 From: Shreyansh Jain To: Ferruh Yigit CC: "dev@dpdk.org" Thread-Topic: [PATCH 3/7] ethdev: separate driver APIs Thread-Index: AQHTakxkBrmr2CyDRU6KNujHYfP3cqMuAs/A Date: Fri, 1 Dec 2017 06:24:20 +0000 Deferred-Delivery: Fri, 1 Dec 2017 06:23:15 +0000 Message-ID: References: <20171201022957.64329-1-ferruh.yigit@intel.com> <20171201022957.64329-3-ferruh.yigit@intel.com> In-Reply-To: <20171201022957.64329-3-ferruh.yigit@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shreyansh.jain@nxp.com; x-originating-ip: [192.88.169.1] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM5PR0401MB2452; 6:4HCc2I0w3h1ZgQvyxBs6UH/qMbr8t+yT7akPvgEJTmaKNAs7PR/yzn4iRXPh6TKZ8ew6ssrhsFYEENOgsSlNUt54BeDfEnZsN/rFj96ELckLZspEqdtFChntEdyeflVTZNWjbDNCxyPRqyiwiskbZYHhg4ODSrAG1KCUIUCX7TJe34YCBJCdiuPAgArUc0BKMtjVJ5gdYgaFpGSc7ANOzC/KHKXdNPHxgKCIukUP7caUPuyCcfmyu3PbeMP0NL2vk5v6Y0Q/HeFU7YCe76ofFZjy5d5Xw863OusV8PGZVxZ4w67ocDGdcG3HWADJm0gRYtTcuG3D75hfnbNYKrLE8oMFTKsuLIP7oiU1PwaQ1pU=; 5:4MJhQMKV03/gJmsM7MdC7nw8l+mHeSXJnrdAgfoV3qDwbL5iwSSaioTuEEK7ePCh8vZlsdIscdpRVMJ+Mu/KP41uY9szLLTx2SYV2wgkHn2vsNnBg1BE3kCDNRmvOOPF5r9Omyz6TMRgYg8yy1L+S+qfL5R3l6S9npGWZiD1N34=; 24:/0Aqib2Y0sbCf7fmAsP+jocPpV2hb2sOFAhAf/P3EtmzlLP8SFJegDGllxXROu9PA3dhrlkCgvjsc50KXLR/vbbUBWbW5FTXtI5VkI9pcaU=; 7:X373oXG7n4AapT0KQabYw+Qo9xVUH7LRoRt42jHYGfsOIJ7zM2CuaECi1eMj5cT5PIL+moq4V3Mg/C/2hNsrXmrAD+u36o6iCL6e3rvaEQCHWLi1xnPuCdrk0a/55ydFuNmzG/6dxsfAp6p8OCDDVZ6dRsoAl5VrM7SXyXbMIH8bShOfKmO4Y5T33k69UdPjpbLdP2ork5rmG8KqlIzqsD78WdUbV3EaSd8b81cnXpjnRq2/mRCngRPCAcabGMM8 x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 7c367024-d611-40cf-32b6-08d538842beb x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(2017052603286); SRVR:AM5PR0401MB2452; x-ms-traffictypediagnostic: AM5PR0401MB2452: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(278428928389397)(185117386973197)(275809806118684)(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040450)(2401047)(5005006)(8121501046)(10201501046)(3002001)(93006095)(93001095)(3231022)(6055026)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123562025)(20161123560025)(20161123564025)(20161123558100)(6072148)(201708071742011); SRVR:AM5PR0401MB2452; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:AM5PR0401MB2452; x-forefront-prvs: 05087F0C24 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(376002)(346002)(39860400002)(366004)(189002)(199003)(5660300001)(189998001)(86362001)(4326008)(316002)(6246003)(53376002)(74316002)(7736002)(9686003)(101416001)(25786009)(305945005)(6306002)(2950100002)(8676002)(81156014)(81166006)(33656002)(6666003)(6916009)(66066001)(53936002)(966005)(3280700002)(14454004)(3660700001)(2900100001)(478600001)(106356001)(5250100002)(6436002)(3846002)(6116002)(55016002)(2906002)(102836003)(8936002)(105586002)(229853002)(76176011)(68736007)(54356011)(7696005)(6506006)(97736004)(99286004); DIR:OUT; SFP:1101; SCL:1; SRVR:AM5PR0401MB2452; H:AM5PR0401MB2451.eurprd04.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7c367024-d611-40cf-32b6-08d538842beb X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Dec 2017 06:24:26.5059 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0401MB2452 Subject: Re: [dpdk-dev] [PATCH 3/7] ethdev: separate driver APIs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Dec 2017 06:24:27 -0000 Hello Ferruh, (Somehow it seems that patch was not delivered to dev@dpdk ML). One comment below: []=20 >=20 > There is no update in header content and since ethdev.h included by > ethdev_driver.h, nothing changed from driver point of view, only > logically grouping of APIs. From applications point of view they can't > access to driver specific APIs anymore and they shouldn't. >=20 > More PMD specific data structures still remain in ethdev.h because of > inline functions in header use them. Those will be handled separately. +1=20 >=20 > Signed-off-by: Ferruh Yigit > --- [...] > diff --git a/drivers/bus/dpaa/include/fman.h > b/drivers/bus/dpaa/include/fman.h > index 9890e09ce..fec154545 100644 > --- a/drivers/bus/dpaa/include/fman.h > +++ b/drivers/bus/dpaa/include/fman.h > @@ -44,7 +44,7 @@ > #include > #include >=20 > -#include > +#include > #include >=20 > #include > diff --git a/drivers/bus/fslmc/fslmc_bus.c b/drivers/bus/fslmc/fslmc_bus.= c > index 480857e57..8f4993f3a 100644 > --- a/drivers/bus/fslmc/fslmc_bus.c > +++ b/drivers/bus/fslmc/fslmc_bus.c > @@ -40,7 +40,7 @@ > #include > #include > #include > -#include > +#include >=20 > #include > #include > diff --git a/drivers/bus/fslmc/fslmc_vfio.c b/drivers/bus/fslmc/fslmc_vfi= o.c > index 7831201ad..eec5cdd94 100644 > --- a/drivers/bus/fslmc/fslmc_vfio.c > +++ b/drivers/bus/fslmc/fslmc_vfio.c > @@ -48,7 +48,7 @@ >=20 > #include > #include > -#include > +#include > #include > #include > #include > diff --git a/drivers/bus/fslmc/portal/dpaa2_hw_dpbp.c > b/drivers/bus/fslmc/portal/dpaa2_hw_dpbp.c > index 334e1f5ad..55c38fd8d 100644 > --- a/drivers/bus/fslmc/portal/dpaa2_hw_dpbp.c > +++ b/drivers/bus/fslmc/portal/dpaa2_hw_dpbp.c > @@ -45,7 +45,7 @@ > #include > #include > #include > -#include > +#include >=20 > #include > #include > diff --git a/drivers/bus/fslmc/portal/dpaa2_hw_dpci.c > b/drivers/bus/fslmc/portal/dpaa2_hw_dpci.c > index ae189c72a..7a86d047a 100644 > --- a/drivers/bus/fslmc/portal/dpaa2_hw_dpci.c > +++ b/drivers/bus/fslmc/portal/dpaa2_hw_dpci.c > @@ -44,7 +44,7 @@ > #include > #include > #include > -#include > +#include >=20 > #include > #include > diff --git a/drivers/bus/fslmc/portal/dpaa2_hw_dpio.c > b/drivers/bus/fslmc/portal/dpaa2_hw_dpio.c > index f00070f3f..6a6c8c3b6 100644 > --- a/drivers/bus/fslmc/portal/dpaa2_hw_dpio.c > +++ b/drivers/bus/fslmc/portal/dpaa2_hw_dpio.c > @@ -50,7 +50,7 @@ > #include >=20 > #include > -#include > +#include > #include > #include > #include > diff --git a/drivers/event/dpaa2/dpaa2_eventdev.c > b/drivers/event/dpaa2/dpaa2_eventdev.c > index eeeb23127..a20a556d4 100644 > --- a/drivers/event/dpaa2/dpaa2_eventdev.c > +++ b/drivers/event/dpaa2/dpaa2_eventdev.c > @@ -52,7 +52,7 @@ > #include > #include > #include > -#include > +#include > #include >=20 > #include > diff --git a/drivers/event/dpaa2/dpaa2_hw_dpcon.c > b/drivers/event/dpaa2/dpaa2_hw_dpcon.c > index 005e6234d..a8da9803b 100644 > --- a/drivers/event/dpaa2/dpaa2_hw_dpcon.c > +++ b/drivers/event/dpaa2/dpaa2_hw_dpcon.c > @@ -44,7 +44,7 @@ > #include > #include > #include > -#include > +#include >=20 > #include > #include With respect to DPAA and DPAA2 and overall aim of patch: Acked-by: Shreyansh Jain [...] > diff --git a/lib/librte_ether/rte_ethdev_driver.h > b/lib/librte_ether/rte_ethdev_driver.h > new file mode 100644 > index 000000000..3e77d1439 > --- /dev/null > +++ b/lib/librte_ether/rte_ethdev_driver.h > @@ -0,0 +1,163 @@ > +/*- > + * BSD LICENSE > + * > + * Copyright(c) 2017 Intel Corporation. All rights reserved. > + * All rights reserved. > + * > + * Redistribution and use in source and binary forms, with or without > + * modification, are permitted provided that the following conditions > + * are met: > + * > + * * Redistributions of source code must retain the above copyright > + * notice, this list of conditions and the following disclaimer. > + * * Redistributions in binary form must reproduce the above copyrig= ht > + * notice, this list of conditions and the following disclaimer in > + * the documentation and/or other materials provided with the > + * distribution. > + * * Neither the name of Intel Corporation nor the names of its > + * contributors may be used to endorse or promote products derived > + * from this software without specific prior written permission. > + * > + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS > + * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT > + * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS F= OR > + * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGH= T > + * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTA= L, > + * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT > + * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF US= E, > + * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON A= NY > + * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT > + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE U= SE > + * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE= . > + */ > + > +#ifndef _RTE_ETHDEV_DRIVER_H_ > +#define _RTE_ETHDEV_DRIVER_H_ Now that it is almost agreed to move towards SPDX based licensing text [1][= 2], and this new file is being introduced - do you think it makes sense to = do it for this file? [1] http://dpdk.org/ml/archives/dev/2017-November/082382.html [2] http://dpdk.org/ml/archives/dev/2017-November/082639.html [...]