From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0070.outbound.protection.outlook.com [104.47.2.70]) by dpdk.org (Postfix) with ESMTP id C1524282 for ; Thu, 2 Feb 2017 12:19:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=bvJR+SsX7sN1raHSNRusHMCFPjub05w0GfFD9UPW9BQ=; b=Rc/rnX9c6MHBB9/c5ndHi57Y77PsbL/xIt2OvihOlCNFYiGzlgrkiQp6arixWFXMy9Zz7ZkMfwfUUr1LVhMPJ6zgLGrjKD2k35fQiLSIxfsMorklZAXPlhvoi1X7uuxADIFNSvc4Zy7U5bNhAiUbr2x8wm0lIDd3zoR3o9Gn8qM= Received: from AM5PR0401MB2514.eurprd04.prod.outlook.com (10.169.244.146) by AM4PR04MB1604.eurprd04.prod.outlook.com (10.164.78.150) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.888.16; Thu, 2 Feb 2017 11:19:45 +0000 Received: from AM5PR0401MB2514.eurprd04.prod.outlook.com ([10.169.244.146]) by AM5PR0401MB2514.eurprd04.prod.outlook.com ([10.169.244.146]) with mapi id 15.01.0874.021; Thu, 2 Feb 2017 11:19:45 +0000 From: Nipun Gupta To: Jerin Jacob , "dev@dpdk.org" CC: "thomas.monjalon@6wind.com" , "bruce.richardson@intel.com" , Hemant Agrawal , "gage.eads@intel.com" , "harry.van.haaren@intel.com" Thread-Topic: [dpdk-dev] [PATCH v4 3/6] eventdev: implement the northbound APIs Thread-Index: AQHSW2xmlsHxSFO9S0KYzID5OyLj+KFUAgwg Date: Thu, 2 Feb 2017 11:19:45 +0000 Message-ID: References: <1480996340-29871-1-git-send-email-jerin.jacob@caviumnetworks.com> <1482312326-2589-1-git-send-email-jerin.jacob@caviumnetworks.com> <1482312326-2589-4-git-send-email-jerin.jacob@caviumnetworks.com> In-Reply-To: <1482312326-2589-4-git-send-email-jerin.jacob@caviumnetworks.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=nipun.gupta@nxp.com; x-originating-ip: [192.88.169.1] x-microsoft-exchange-diagnostics: 1; AM4PR04MB1604; 7:/u73naGgYCP6BsaC54vuVjEgVxA0W9joa/7nYwWQFTE1C3QWSbRlpwYMrn34xjUjpxTdxp8PAVy0KpIkEJ8tj5DbazasRY/JK7KpyhkWLjy9QRqur0zfFbXygC1mdvO6P4XGlaqngA76WCZmqpZTd+yo4VU0OdPQkJCT8fZBld21dMg7EvRbMt3wSpePDCyWAvMhZlIuxVyEu6+05O8EYexcu9z6CBMdpdH2TjtUzL8OWVM/CEf2ST+LyWQrUfZYuXm/z2YPKRTRgDe0C2MWuEz1kOHQ1yfflGo42j1AuAdT696NN7RAgASK/W42y6GTyycdiL53NmYzbzkjRAs9Y130Fys9l7m5NQHC56PSYY3owpo1FDsILQDU52AcDftcrNmiG+MIlogOTEXjuNLLGTZxpaoAPyHd9Ga0yQnp9kcarnxfYqCSlLHlvOQGKtSmtQ3ptqr9SuMG6eoTEiDiCWKTDubJMFlCV+u6OqRkC/82xcItvukOlwE3D/RzCQ++xI9aUaY3+DdaINYjU6iJWw== x-forefront-antispam-report: SFV:SKI; SCL:-1SFV:NSPM; SFS:(10009020)(6009001)(7916002)(39840400002)(39450400003)(39860400002)(39410400002)(39850400002)(199003)(189002)(13464003)(4326007)(66066001)(2906002)(101416001)(81166006)(122556002)(8676002)(2950100002)(9686003)(76176999)(54356999)(50986999)(81156014)(86362001)(6506006)(229853002)(2900100001)(92566002)(6436002)(53936002)(77096006)(106356001)(5660300001)(38730400001)(106116001)(54906002)(7696004)(99286003)(3660700001)(68736007)(102836003)(55016002)(33656002)(105586002)(74316002)(3280700002)(8936002)(3846002)(97736004)(25786008)(7736002)(189998001)(6116002)(5001770100001)(305945005)(2501003); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR04MB1604; H:AM5PR0401MB2514.eurprd04.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; x-ms-office365-filtering-correlation-id: 401c9bce-5868-49bc-5ae0-08d44b5d644d x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(48565401081); SRVR:AM4PR04MB1604; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(185117386973197)(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6055026)(6041248)(20161123564025)(20161123560025)(20161123555025)(20161123562025)(20161123558025)(6072148); SRVR:AM4PR04MB1604; BCL:0; PCL:0; RULEID:; SRVR:AM4PR04MB1604; x-forefront-prvs: 02065A9E77 received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Feb 2017 11:19:45.1964 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR04MB1604 Subject: Re: [dpdk-dev] [PATCH v4 3/6] eventdev: implement the northbound APIs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Feb 2017 11:19:47 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jerin Jacob > Sent: Wednesday, December 21, 2016 14:55 > To: dev@dpdk.org > Cc: thomas.monjalon@6wind.com; bruce.richardson@intel.com; Hemant > Agrawal ; gage.eads@intel.com; > harry.van.haaren@intel.com; Jerin Jacob > Subject: [dpdk-dev] [PATCH v4 3/6] eventdev: implement the northbound API= s >=20 > This patch implements northbound eventdev API interface using southbond > driver interface >=20 > Signed-off-by: Jerin Jacob > Acked-by: Bruce Richardson > --- > config/common_base | 6 + > lib/Makefile | 1 + > lib/librte_eal/common/include/rte_log.h | 1 + > lib/librte_eventdev/Makefile | 57 ++ > lib/librte_eventdev/rte_eventdev.c | 986 > +++++++++++++++++++++++++++ > lib/librte_eventdev/rte_eventdev.h | 106 ++- > lib/librte_eventdev/rte_eventdev_pmd.h | 109 +++ > lib/librte_eventdev/rte_eventdev_version.map | 33 + > mk/rte.app.mk | 1 + > 9 files changed, 1294 insertions(+), 6 deletions(-) create mode 100644 > lib/librte_eventdev/Makefile create mode 100644 > lib/librte_eventdev/rte_eventdev.c > create mode 100644 lib/librte_eventdev/rte_eventdev_version.map >=20 > +static inline int > +rte_event_dev_port_config(struct rte_eventdev *dev, uint8_t nb_ports) { > + uint8_t old_nb_ports =3D dev->data->nb_ports; > + void **ports; > + uint16_t *links_map; > + uint8_t *ports_dequeue_depth; > + uint8_t *ports_enqueue_depth; > + unsigned int i; > + > + RTE_EDEV_LOG_DEBUG("Setup %d ports on device %u", nb_ports, > + dev->data->dev_id); > + > + /* First time configuration */ > + if (dev->data->ports =3D=3D NULL && nb_ports !=3D 0) { > + dev->data->ports =3D rte_zmalloc_socket("eventdev->data- > >ports", > + sizeof(dev->data->ports[0]) * nb_ports, > + RTE_CACHE_LINE_SIZE, dev->data->socket_id); > + if (dev->data->ports =3D=3D NULL) { > + dev->data->nb_ports =3D 0; > + RTE_EDEV_LOG_ERR("failed to get mem for port meta > data," > + "nb_ports %u", nb_ports); > + return -(ENOMEM); > + } > + > + /* Allocate memory to store ports dequeue depth */ > + dev->data->ports_dequeue_depth =3D > + rte_zmalloc_socket("eventdev- > >ports_dequeue_depth", > + sizeof(dev->data->ports_dequeue_depth[0]) * > nb_ports, > + RTE_CACHE_LINE_SIZE, dev->data->socket_id); > + if (dev->data->ports_dequeue_depth =3D=3D NULL) { > + dev->data->nb_ports =3D 0; > + RTE_EDEV_LOG_ERR("failed to get mem for port deq > meta," > + "nb_ports %u", nb_ports); > + return -(ENOMEM); > + } > + > + /* Allocate memory to store ports enqueue depth */ > + dev->data->ports_enqueue_depth =3D > + rte_zmalloc_socket("eventdev- > >ports_enqueue_depth", > + sizeof(dev->data->ports_enqueue_depth[0]) * > nb_ports, > + RTE_CACHE_LINE_SIZE, dev->data->socket_id); > + if (dev->data->ports_enqueue_depth =3D=3D NULL) { > + dev->data->nb_ports =3D 0; > + RTE_EDEV_LOG_ERR("failed to get mem for port enq > meta," > + "nb_ports %u", nb_ports); > + return -(ENOMEM); > + } > + > + /* Allocate memory to store queue to port link connection */ > + dev->data->links_map =3D > + rte_zmalloc_socket("eventdev->links_map", > + sizeof(dev->data->links_map[0]) * nb_ports * > + RTE_EVENT_MAX_QUEUES_PER_DEV, > + RTE_CACHE_LINE_SIZE, dev->data->socket_id); > + if (dev->data->links_map =3D=3D NULL) { > + dev->data->nb_ports =3D 0; > + RTE_EDEV_LOG_ERR("failed to get mem for port_map > area," > + "nb_ports %u", nb_ports); > + return -(ENOMEM); > + } I think we also need to set all the 'links map' to EVENT_QUEUE_SERVICE_PRIO= RITY_INVALID on zmalloc. > + } else if (dev->data->ports !=3D NULL && nb_ports !=3D 0) {/* re-config= */ > + RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->port_release, - > ENOTSUP); > + > + ports =3D dev->data->ports; > + ports_dequeue_depth =3D dev->data->ports_dequeue_depth; > + ports_enqueue_depth =3D dev->data->ports_enqueue_depth; > + links_map =3D dev->data->links_map; > + > +int > +rte_event_port_setup(uint8_t dev_id, uint8_t port_id, > + const struct rte_event_port_conf *port_conf) { > + struct rte_eventdev *dev; > + struct rte_event_port_conf def_conf; > + int diag; > + > + RTE_EVENTDEV_VALID_DEVID_OR_ERR_RET(dev_id, -EINVAL); > + dev =3D &rte_eventdevs[dev_id]; > + > + if (!is_valid_port(dev, port_id)) { > + RTE_EDEV_LOG_ERR("Invalid port_id=3D%" PRIu8, port_id); > + return -EINVAL; > + } > + > + /* Check new_event_threshold limit */ > + if ((port_conf && !port_conf->new_event_threshold) || > + (port_conf && port_conf->new_event_threshold > > + dev->data->dev_conf.nb_events_limit)) { As mentioned in 'rte_eventdev.h', the 'new_event_threshold' is valid for *c= losed systems*, so is the above check valid for *open systems*? Or is it implicit that for open systems the 'port_conf->new_event_threshold= ' should be set to '-1' by the application just as it is for 'max_num_events' of 'struc= t rte_event_dev_info'. > + RTE_EDEV_LOG_ERR( > + "dev%d port%d Invalid event_threshold=3D%d > nb_events_limit=3D%d", > + dev_id, port_id, port_conf->new_event_threshold, > + dev->data->dev_conf.nb_events_limit); > + return -EINVAL; > + } > + Regards, Nipun