From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0085.outbound.protection.outlook.com [104.47.2.85]) by dpdk.org (Postfix) with ESMTP id A25AB2BE5 for ; Fri, 3 Feb 2017 07:59:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=gvC/UsYche7BRre+BDsgG2ZnlU6mmH6+DhwpHCLOizw=; b=PUydDamNp+EqCLDvJTZbaF4R0yg13/UHFO2KT1VDQyZWPmw1S/6Dnv+g557TRysXFqyucmEGSUY23/aInIot+J509Es0U14QHAtktK4wgAEyIc3lFdpy82n4E18t/2QzM4vMpel/gx+eri3u6htfrpj8E+ErsqAVFkQfZOD7ko4= Received: from AM5PR0401MB2514.eurprd04.prod.outlook.com (10.169.244.146) by AM4PR04MB1603.eurprd04.prod.outlook.com (10.164.78.149) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.874.12; Fri, 3 Feb 2017 06:59:20 +0000 Received: from AM5PR0401MB2514.eurprd04.prod.outlook.com ([10.169.244.146]) by AM5PR0401MB2514.eurprd04.prod.outlook.com ([10.169.244.146]) with mapi id 15.01.0874.021; Fri, 3 Feb 2017 06:59:19 +0000 From: Nipun Gupta To: Jerin Jacob CC: "dev@dpdk.org" , "thomas.monjalon@6wind.com" , "bruce.richardson@intel.com" , Hemant Agrawal , "gage.eads@intel.com" , "harry.van.haaren@intel.com" Thread-Topic: [dpdk-dev] [PATCH v4 3/6] eventdev: implement the northbound APIs Thread-Index: AQHSW2xmlsHxSFO9S0KYzID5OyLj+KFUAgwggAIJaACAAPPQwA== Date: Fri, 3 Feb 2017 06:59:19 +0000 Message-ID: References: <1480996340-29871-1-git-send-email-jerin.jacob@caviumnetworks.com> <1482312326-2589-1-git-send-email-jerin.jacob@caviumnetworks.com> <1482312326-2589-4-git-send-email-jerin.jacob@caviumnetworks.com> <20170202143215.GA28028@localhost.localdomain> In-Reply-To: <20170202143215.GA28028@localhost.localdomain> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=nipun.gupta@nxp.com; x-originating-ip: [192.88.169.1] x-microsoft-exchange-diagnostics: 1; AM4PR04MB1603; 7:2vjACNX0fwg5/CaVGl8Q83RPe61SZg4N+fCqcVudhTEWG/wLicCoDeOKqf+vmFYeOkb2Nq1x2hZQVCrhaybHy86eiRy23l44nI3kn96/tz07swu/le2hD0qEdnEZU9VP4hSTbPYyiUkyBRkuTZWjXl/rk9OV1LSf2mZiXhdDm+64qx6dF6L18CslD9gqaQjddgiz5GuidyvQkyJSA33HHqgZw3xY/q9gGkcH2l/h260G5a8LYKM+UV4ZfWyOf56P3gc8XqCzog/qYXIXjJKcIzgrduAUM1sN99vv4Nl76exBL2V+HCv/iG6tegX9hpGBnEGcqShsvEMmwRRhvS6zI62UuqoK/5ykpDJuaQXcUom4DesSGtogwtslgjneGamEP0tRMXM0E2YwQNv+K3zUF3chSXvwZ+UYOc0xc5EI5y7qM5j1yv/O/acAWyqm4fY8RLkmFF0L15eeTg2GeTWEjeSo6AlEzkGTpiSoc15j9AOc3Wg8JtnYsM4jEZLxHlM23mQxIVuCVgkGe+6BwdfgGA== x-forefront-antispam-report: SFV:SKI; SCL:-1SFV:NSPM; SFS:(10009020)(6009001)(7916002)(39450400003)(39860400002)(39410400002)(39850400002)(39840400002)(13464003)(199003)(24454002)(189002)(86362001)(54906002)(76176999)(102836003)(55016002)(9686003)(99286003)(105586002)(54356999)(77096006)(33656002)(50986999)(25786008)(106356001)(2906002)(106116001)(6436002)(66066001)(8936002)(97736004)(6246003)(38730400001)(3846002)(6116002)(74316002)(7736002)(8676002)(305945005)(81156014)(92566002)(4326007)(189998001)(5660300001)(2900100001)(7696004)(229853002)(101416001)(6506006)(3660700001)(81166006)(110136003)(53936002)(3280700002)(2950100002)(6916009)(68736007)(93886004)(122556002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR04MB1603; H:AM5PR0401MB2514.eurprd04.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; x-ms-office365-filtering-correlation-id: c9fad9ab-3be4-42d3-fa6d-08d44c022d30 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(48565401081); SRVR:AM4PR04MB1603; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(185117386973197)(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6055026)(6041248)(20161123558025)(20161123560025)(20161123555025)(20161123564025)(20161123562025)(6072148); SRVR:AM4PR04MB1603; BCL:0; PCL:0; RULEID:; SRVR:AM4PR04MB1603; x-forefront-prvs: 02070414A1 received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Feb 2017 06:59:19.5860 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR04MB1603 Subject: Re: [dpdk-dev] [PATCH v4 3/6] eventdev: implement the northbound APIs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Feb 2017 06:59:21 -0000 > -----Original Message----- > From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com] > Sent: Thursday, February 02, 2017 20:02 > To: Nipun Gupta > Cc: dev@dpdk.org; thomas.monjalon@6wind.com; > bruce.richardson@intel.com; Hemant Agrawal ; > gage.eads@intel.com; harry.van.haaren@intel.com > Subject: Re: [dpdk-dev] [PATCH v4 3/6] eventdev: implement the northbound > APIs >=20 > On Thu, Feb 02, 2017 at 11:19:45AM +0000, Nipun Gupta wrote: > > > > > > > -----Original Message----- > > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jerin Jacob > > > Sent: Wednesday, December 21, 2016 14:55 > > > To: dev@dpdk.org > > > Cc: thomas.monjalon@6wind.com; bruce.richardson@intel.com; Hemant > > > Agrawal ; gage.eads@intel.com; > > > harry.van.haaren@intel.com; Jerin Jacob > > > > Subject: [dpdk-dev] [PATCH v4 3/6] eventdev: implement the northbound > APIs > > > > > > This patch implements northbound eventdev API interface using southbo= nd > > > driver interface > > > > > > Signed-off-by: Jerin Jacob > > > Acked-by: Bruce Richardson > > > --- > > > config/common_base | 6 + > > > lib/Makefile | 1 + > > > lib/librte_eal/common/include/rte_log.h | 1 + > > > lib/librte_eventdev/Makefile | 57 ++ > > > lib/librte_eventdev/rte_eventdev.c | 986 > > > +++++++++++++++++++++++++++ > > > lib/librte_eventdev/rte_eventdev.h | 106 ++- > > > lib/librte_eventdev/rte_eventdev_pmd.h | 109 +++ > > > lib/librte_eventdev/rte_eventdev_version.map | 33 + > > > mk/rte.app.mk | 1 + > > > 9 files changed, 1294 insertions(+), 6 deletions(-) create mode 100= 644 > > > lib/librte_eventdev/Makefile create mode 100644 > > > lib/librte_eventdev/rte_eventdev.c > > > create mode 100644 lib/librte_eventdev/rte_eventdev_version.map > > > > > > > > > > > > +static inline int > > > +rte_event_dev_port_config(struct rte_eventdev *dev, uint8_t nb_ports= ) { > > > + uint8_t old_nb_ports =3D dev->data->nb_ports; > > > + void **ports; > > > + uint16_t *links_map; > > > + uint8_t *ports_dequeue_depth; > > > + uint8_t *ports_enqueue_depth; > > > + unsigned int i; > > > + > > > + RTE_EDEV_LOG_DEBUG("Setup %d ports on device %u", nb_ports, > > > + dev->data->dev_id); > > > + > > > + /* First time configuration */ > > > + if (dev->data->ports =3D=3D NULL && nb_ports !=3D 0) { > > > + dev->data->ports =3D rte_zmalloc_socket("eventdev->data- > > > >ports", > > > + sizeof(dev->data->ports[0]) * nb_ports, > > > + RTE_CACHE_LINE_SIZE, dev->data->socket_id); > > > + if (dev->data->ports =3D=3D NULL) { > > > + dev->data->nb_ports =3D 0; > > > + RTE_EDEV_LOG_ERR("failed to get mem for port meta > > > data," > > > + "nb_ports %u", nb_ports); > > > + return -(ENOMEM); > > > + } > > > + > > > + /* Allocate memory to store ports dequeue depth */ > > > + dev->data->ports_dequeue_depth =3D > > > + rte_zmalloc_socket("eventdev- > > > >ports_dequeue_depth", > > > + sizeof(dev->data->ports_dequeue_depth[0]) * > > > nb_ports, > > > + RTE_CACHE_LINE_SIZE, dev->data->socket_id); > > > + if (dev->data->ports_dequeue_depth =3D=3D NULL) { > > > + dev->data->nb_ports =3D 0; > > > + RTE_EDEV_LOG_ERR("failed to get mem for port deq > > > meta," > > > + "nb_ports %u", nb_ports); > > > + return -(ENOMEM); > > > + } > > > + > > > + /* Allocate memory to store ports enqueue depth */ > > > + dev->data->ports_enqueue_depth =3D > > > + rte_zmalloc_socket("eventdev- > > > >ports_enqueue_depth", > > > + sizeof(dev->data->ports_enqueue_depth[0]) * > > > nb_ports, > > > + RTE_CACHE_LINE_SIZE, dev->data->socket_id); > > > + if (dev->data->ports_enqueue_depth =3D=3D NULL) { > > > + dev->data->nb_ports =3D 0; > > > + RTE_EDEV_LOG_ERR("failed to get mem for port enq > > > meta," > > > + "nb_ports %u", nb_ports); > > > + return -(ENOMEM); > > > + } > > > + > > > + /* Allocate memory to store queue to port link connection */ > > > + dev->data->links_map =3D > > > + rte_zmalloc_socket("eventdev->links_map", > > > + sizeof(dev->data->links_map[0]) * nb_ports * > > > + RTE_EVENT_MAX_QUEUES_PER_DEV, > > > + RTE_CACHE_LINE_SIZE, dev->data->socket_id); > > > + if (dev->data->links_map =3D=3D NULL) { > > > + dev->data->nb_ports =3D 0; > > > + RTE_EDEV_LOG_ERR("failed to get mem for port_map > > > area," > > > + "nb_ports %u", nb_ports); > > > + return -(ENOMEM); > > > + } > > > > I think we also need to set all the 'links map' to > EVENT_QUEUE_SERVICE_PRIORITY_INVALID > > on zmalloc. >=20 > Just after the port_setup, we are setting to > EVENT_QUEUE_SERVICE_PRIORITY_INVALID in > rte_event_port_unlink(). So it looks OK to me. >=20 > diag =3D (*dev->dev_ops->port_setup)(dev, port_id, port_conf); >=20 > /* Unlink all the queues from this port(default state after > * setup) */ > if (!diag) > diag =3D rte_event_port_unlink(dev_id, port_id, NULL, 0); >=20 >=20 In case of NULL parameter as queues, in the rte_event_port_unlink(), the number of 'links_map' which are being set to EVENT_QUEUE_SERVICE_PRIORITY_INVALID equals the number of configured queues: if (queues =3D=3D NULL) { for (i =3D 0; i < dev->data->nb_queues; i++) all_queues[i] =3D i; queues =3D all_queues; nb_unlinks =3D dev->data->nb_queues; } So, the EVENT_QUEUE_SERVICE_PRIORITY_INVALID does not gets set for complete 'links_map' memory. The API rte_event_port_links_get() will probably return wrong number of lin= ks as the loop there is on RTE_EVENT_MAX_QUEUES_PER_DEV: for (i =3D 0; i < RTE_EVENT_MAX_QUEUES_PER_DEV; i++) { if (links_map[i] !=3D EVENT_QUEUE_SERVICE_PRIORITY_INVALID) { queues[count] =3D i; priorities[count] =3D (uint8_t)links_map[i]; ++count; } } > > > > > + } else if (dev->data->ports !=3D NULL && nb_ports !=3D 0) {/* re-co= nfig */ > > > + RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->port_release, - > > > ENOTSUP); > > > + > > > + ports =3D dev->data->ports; > > > + ports_dequeue_depth =3D dev->data->ports_dequeue_depth; > > > + ports_enqueue_depth =3D dev->data->ports_enqueue_depth; > > > + links_map =3D dev->data->links_map; > > > + > > > > > > > > > +int > > > +rte_event_port_setup(uint8_t dev_id, uint8_t port_id, > > > + const struct rte_event_port_conf *port_conf) { > > > + struct rte_eventdev *dev; > > > + struct rte_event_port_conf def_conf; > > > + int diag; > > > + > > > + RTE_EVENTDEV_VALID_DEVID_OR_ERR_RET(dev_id, -EINVAL); > > > + dev =3D &rte_eventdevs[dev_id]; > > > + > > > + if (!is_valid_port(dev, port_id)) { > > > + RTE_EDEV_LOG_ERR("Invalid port_id=3D%" PRIu8, port_id); > > > + return -EINVAL; > > > + } > > > + > > > + /* Check new_event_threshold limit */ > > > + if ((port_conf && !port_conf->new_event_threshold) || > > > + (port_conf && port_conf->new_event_threshold > > > > + dev->data->dev_conf.nb_events_limit)) { > > > > As mentioned in 'rte_eventdev.h', the 'new_event_threshold' is valid fo= r > *closed systems*, > > so is the above check valid for *open systems*? >=20 > new_event_threshold is valid only for *closed systems*. If you need any > change then please suggest. This is fine, but I think we also need to mention in the new_event_threshol= d description in 'rte_eventdev.h' that for open systems this needs to be set = to '-1', because otherwise the check here will fail. And this is also for ' struct rte_event_dev_config'->'nb_events_limit', whi= ch is required to be set to '-1' for open systems by the application. Right? I'll send a patch updating this in rte_eventdev.h file. Regards, Nipun >=20 > > Or is it implicit that for open systems the 'port_conf->new_event_thres= hold' > should be > > set to '-1' by the application just as it is for 'max_num_events' of 's= truct > rte_event_dev_info'. >=20 >=20 >=20 > > > > > + RTE_EDEV_LOG_ERR( > > > + "dev%d port%d Invalid event_threshold=3D%d > > > nb_events_limit=3D%d", > > > + dev_id, port_id, port_conf->new_event_threshold, > > > + dev->data->dev_conf.nb_events_limit); > > > + return -EINVAL; > > > + } > > > + > > > > > > > > Regards, > > Nipun