From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 905E3A04AC; Tue, 1 Sep 2020 12:56:50 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1EDBF1515; Tue, 1 Sep 2020 12:56:49 +0200 (CEST) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60074.outbound.protection.outlook.com [40.107.6.74]) by dpdk.org (Postfix) with ESMTP id 2EE55137D for <dev@dpdk.org>; Tue, 1 Sep 2020 12:56:48 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iCEfdKoCddvVdrOJbssT/nF0ijRHLewjTJFdDHj8RUx3otSk9UijGFWpXVr6kPBKQtVkf8IUBtlZ3dfdNUlz11ZEVP3Vu6PYB4UVScRIcPuXk0XFNACz/sCMkcWXc/SyCJ10u1YGB5bC9XdfSjgHfU8MHnkLIsvcMPUc6uEy6AXP/+dHhBkj9qQGlfyJjKrgentyKL/1sW2bN4UqHWnNSCkMxwF6qiLmljxg1HUrUrxOHajG37ZmIj3boX0FxLank40TR71FvMiWVY6XBOpwPWv9A1+m3UwEZKlEsOyWQagEdHXb/DlwW8IFo9Ebfe5DyyCVrSNE5afVrzFuCvya3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vQWWIkA3POkmTy9MWfx5EFUFDhMnD3uyME2mFt1Hltg=; b=YqNvavoAidxnpPJ7ipsoVBaeBKrtHqx+OYwSKpzSRtgB2LP90aJ5DR+MNeL3CHE/fnlkCCxFXaxQN2hYQmDDtpvetFPGi1RLJ9NBgyVkGPMATuJY2fWEtzXmttUWorMkcdQ6YG2lreEIvVPx9GgH/Qu5nCCwJAYtxrw1zb3LUm9XSCe7agnVbt7VW/dRrjZUuGl+gCiwifFW7SPnnSM4odE5E14DddQECXZoEfqysTtDWBk6Wt/lJ6buRDiUQAySd1zQDAACvlRVRn1AC1hdf/M/e80Xjr92RyZ0FqaPJqUJj3Ux6PLiCU8yWmAItb3A1EWTRTqgolet/ri241I7Gw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vQWWIkA3POkmTy9MWfx5EFUFDhMnD3uyME2mFt1Hltg=; b=dC7VciCrOf6+NFEq26gMPQ3RDNtgDLudeZbmhNoN/CUNMXRWirQUbeVJL4b59Os5ESQZmdONF/2vY4spcmtmhnzaOJptpwSuAMZIX2flYuLmvDZQmMOI6PjcGo4yQPJ56KBAU0xVavOOtD1fzgGbFiUdJc3ruTUBfdxIhdfKjgI= Received: from AM5PR0401MB2593.eurprd04.prod.outlook.com (2603:10a6:203:37::20) by AM6PR04MB5912.eurprd04.prod.outlook.com (2603:10a6:20b:ab::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3326.23; Tue, 1 Sep 2020 10:56:47 +0000 Received: from AM5PR0401MB2593.eurprd04.prod.outlook.com ([fe80::c5e3:98fa:174b:2c4c]) by AM5PR0401MB2593.eurprd04.prod.outlook.com ([fe80::c5e3:98fa:174b:2c4c%7]) with mapi id 15.20.3326.025; Tue, 1 Sep 2020 10:56:47 +0000 From: Nipun Gupta <nipun.gupta@nxp.com> To: Thomas Monjalon <thomas@monjalon.net>, Stephen Hemminger <stephen@networkplumber.org>, "orika@mellanox.com" <orika@mellanox.com> CC: "dev@dpdk.org" <dev@dpdk.org>, "ferruh.yigit@intel.com" <ferruh.yigit@intel.com>, "arybchenko@solarflare.com" <arybchenko@solarflare.com>, Hemant Agrawal <hemant.agrawal@nxp.com>, Rohit Raj <rohit.raj@nxp.com>, "olivier.matz@6wind.com" <olivier.matz@6wind.com> Thread-Topic: [dpdk-dev] [PATCH] ethdev: add rx offload to drop error packets Thread-Index: AQHWf2yu+5PoA43LB064sMpgzuulH6lScZCAgAD+BICAAC3AcA== Date: Tue, 1 Sep 2020 10:56:46 +0000 Message-ID: <AM5PR0401MB25936A953DB806CE6DEE6526E62E0@AM5PR0401MB2593.eurprd04.prod.outlook.com> References: <20200831075333.10135-1-nipun.gupta@nxp.com> <20200831100019.11e5c916@hermes.lan> <1900043.OHW9WeN1RR@thomas> In-Reply-To: <1900043.OHW9WeN1RR@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=nxp.com; x-originating-ip: [182.69.1.104] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: d34f8b5a-d545-47ef-1bd6-08d84e65b8bc x-ms-traffictypediagnostic: AM6PR04MB5912: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: <AM6PR04MB5912CD352C87B12C5FB38B0DE62E0@AM6PR04MB5912.eurprd04.prod.outlook.com> x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: gRjKt+36rv4xpYOpfDzqLo4tR8o5cx1kU+EwbdrCYe70hR/wnCRNB/ZVS+Kr38XLjBHBp8LVS0qta7iED7oXlbJc+tgJgOIGw6h1FjSXljEYmqXRgFCCJS2in7pF0ctXqPAs790OnBeyOIVqtgpyYXWKNiAKlSKrFhrLx3vCsOJKG1mUYWgAKVwFSNH+iJXlwh4aS/0u8EGsIjO+bF8usWkcxjievOHRoVuEh1D2r1d8wnND5u1cWSsxFjWHQj98b9Bvt5X+FjXCJdB/6lrBP5eg8SwB8mbstoQ7gHqrxB822Ub/9VA0iqWcsIWPXyu2 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM5PR0401MB2593.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(396003)(136003)(366004)(346002)(376002)(26005)(66446008)(54906003)(71200400001)(83380400001)(316002)(8936002)(110136005)(8676002)(66476007)(76116006)(52536014)(9686003)(6506007)(53546011)(55016002)(2906002)(86362001)(7696005)(4326008)(33656002)(478600001)(44832011)(186003)(66556008)(5660300002)(64756008)(66946007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: rQSlpEkF3aCeuyUtQ/DTVcE2t9xfrk3XMSSAbLualgjmRQnHBprC7eFI5cOESkCBWMrBpedFQEtflkAWamBnxIpSV7dRzQNBHVRFh4YXaeLMWJNQ2NJn8L5Coc7hvS5NlnvuQkRcTcFewbflex/FhBogQHb7i2y0rA0CCrCpS1qNUb70nzNEhMLTRgFyfCekH4LKaKM57atRomxCVc6VsqkFb6kHSt2J7G6JtZP+7bjduYR0ggriEEnCX08DGFnrVypUpV/3XWt1kfvIWDR3cN2ndgXSTZBUpWRouVbGpxnYaFffS2x7SQO8ENZkcEPAHCa+bqZdalITc6/gSfx1GG2FZsfRvNCVBCHASc5MCE5wqlBPqBaA+lC3AG7pSwW20VGL2IoCMF+vdPf+LkUN0gJygcpQtgJi8GEjTszCZb6xxyPKZGsgv90uDS27NIj6kf2oHdykKs0aFqsDJ7E6FMBGmS7EtUK/JeVD0kzzTpAuCP6fJ8dJFf+kf0oue5r6XmXYVuKlOjFyqs0h3mYHf2S0pZxH21RKxRDNXHgnf1H7D2iuYzRf82mafJ/G4Me3pHqtV3DDlSExWGTBLk+PwulrRIEtnhKIIbxpIRfN7JswwQjw+Z20jGZVVCU29ZczAR9rDYOWd+p0SMjhEjE1bQ== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM5PR0401MB2593.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d34f8b5a-d545-47ef-1bd6-08d84e65b8bc X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Sep 2020 10:56:46.9974 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: yML1b+oLrIwyCSD7JKm7C4RzwnFl4oIiBp9Knj1438fmw6BuuwTtu3zrqErl65EW9NETDhc3f9HNcuKRwqM9ag== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB5912 Subject: Re: [dpdk-dev] [PATCH] ethdev: add rx offload to drop error packets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> > -----Original Message----- > From: Thomas Monjalon <thomas@monjalon.net> > Sent: Tuesday, September 1, 2020 1:39 PM > To: Nipun Gupta <nipun.gupta@nxp.com>; Stephen Hemminger > <stephen@networkplumber.org>; orika@mellanox.com > Cc: dev@dpdk.org; ferruh.yigit@intel.com; arybchenko@solarflare.com; > Hemant Agrawal <hemant.agrawal@nxp.com>; Rohit Raj <rohit.raj@nxp.com>; > olivier.matz@6wind.com > Subject: Re: [dpdk-dev] [PATCH] ethdev: add rx offload to drop error pack= ets >=20 > 31/08/2020 19:00, Stephen Hemminger: > > On Mon, 31 Aug 2020 13:23:33 +0530 > > Nipun Gupta <nipun.gupta@nxp.com> wrote: > > > > > This change adds a RX offload capability where hardware can drop the > > > packets in case there is an error in the packet such as L3 checksum > > > error or L4 checksum. > > > > > > Signed-off-by: Nipun Gupta <nipun.gupta@nxp.com> > > > Signed-off-by: Rohit Raj <rohit.raj@nxp.com> > > > --- > > > +#define DEV_RX_OFFLOAD_ERR_PKT_DROP 0x00100000 >=20 > Please add RTE_ prefix, even if older macros don't have it. > We could (in a separate effort) alias old ones with RTE_ prefixed names. Agree, will update and send the change along with testpmd and dpaa2 driver = change. >=20 > > Could/should this be an rte_flow action as well? >=20 > I feel rte_flow API is not appropriate here. > Ori, any opinion? >=20