From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B9BC8A04B7; Sun, 4 Oct 2020 12:53:40 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 141B91BB4F; Sun, 4 Oct 2020 12:53:39 +0200 (CEST) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60077.outbound.protection.outlook.com [40.107.6.77]) by dpdk.org (Postfix) with ESMTP id 387AD1BB43; Sun, 4 Oct 2020 12:53:36 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ixUZrS5sAYfr5Q4hoYtCO7jOKIqMOZk2A/qvDzp+l3rm+/JHcCWk/wV+J3C0aMyqVdZSKHIlh9mvDtZbyRgUsCgqgBAUgTlBGm/IQ2kLNYwCFtJfdsPiCcaTe401+3OIWFTMLeKReMOIe3bp8TROsh/JRR0awRPhcVjv54cONr5pPwGr4MJAXhEMqjEEzL+Yz7xyi5l1ejOu1tUEtz6m/Sq4ABfHtRwX7yrILirHndcFVDWAsBiipyzyBAAlYVvyqj4eYzjyz8mCKfmDbuNneclhTWre5S3nB8/yoXtbv1yHkv0oce5EgpWTrZW36QpfssNQa7ZlTCLEsfMgUKRNXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Nu01aloSUxVLKwxg1iDrjz9m0pLjaa+NrqmvCY5I//0=; b=aIdHp7abMVQLtqHTzmTu44nTLkLyWrpsO0vM0PAR3Z37D03hxsi3V24kfDyarXJJu5la0YBjH0WKu1HBAdIoJskAHcJr1p/EohafJnOBLAD/7XBBR04IyO4p1thAHgzmC+fOvdIgXtWfQwzNQJ8a7lmbfmR3GBbMmV+wYJVxoWBsmMI4taSGD13KWeJhEsRmGpxCatx6ocC3LA51ZzOjlbEHieBBvOHzGuLoapHBVdkl06uNNar3VHLDsSXEelRBqAT2VvZwFAi0gKHA7CZlh9Qdb0I0geF51hforSb+rD3mrtjcwnGHmKyRyslx6eotTzMpySznAHutUocUUGjFkg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Nu01aloSUxVLKwxg1iDrjz9m0pLjaa+NrqmvCY5I//0=; b=L24rrEKYxXTeaJjrB4KMZJqofZMl8R4URTvOrbrZznH597A1J0YnEr5KGm4QHjQQftDM+c3F6QysJ1S1SW5rXX2sln7TTl96srv1mjSg/v/+VvB5j2FF/DXQxCyKEc5d3tYBrlrqGqDgjOkfAsCV3E3eFxheKVIsjBNaOZ5aH+M= Received: from AM5PR0401MB2593.eurprd04.prod.outlook.com (2603:10a6:203:37::20) by AM7PR04MB7143.eurprd04.prod.outlook.com (2603:10a6:20b:112::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3433.32; Sun, 4 Oct 2020 10:53:33 +0000 Received: from AM5PR0401MB2593.eurprd04.prod.outlook.com ([fe80::3c2c:e6e1:4e49:2e5c]) by AM5PR0401MB2593.eurprd04.prod.outlook.com ([fe80::3c2c:e6e1:4e49:2e5c%11]) with mapi id 15.20.3433.043; Sun, 4 Oct 2020 10:53:33 +0000 From: Nipun Gupta To: wangyunjian , "dev@dpdk.org" , Hemant Agrawal CC: "jerry.lilijun@huawei.com" , "xudingke@huawei.com" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] event/dpaa2: fix dereference before null check Thread-Index: AQHWe6nsw8ag6OJZX06GI6HxL4e9zqmHgdFw Date: Sun, 4 Oct 2020 10:53:32 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: huawei.com; dkim=none (message not signed) header.d=none;huawei.com; dmarc=none action=none header.from=nxp.com; x-originating-ip: [182.69.89.171] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: b005f4b5-2643-4546-5864-08d86853bcc7 x-ms-traffictypediagnostic: AM7PR04MB7143: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2399; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: UUnfrWqJ0+BK21vwd/+bKSPlkZR12yS7aODspLCch9S/tJoT5WwdrlQ8SDfiSvZPL0QWhOJ0VeoRp32A45hS6LF+q+umQOvpOz44mBlyB/kFLpWZG/oPeQrOxhKGvNq+2oFSee9hoZAJHZLiu0sl0FpGk8RyGlWpZXIr7P4g96E9no+JvV3BUWMXmUEI+BZox0u6pyQ57py2/cxv6r7boTtEY7OwNe0khFv2Bl1szyat1ZUyhF+TrBrzKkt+WlDAss08OStiyHP+0tMzG21vKVl13MIRFpOdEWBkPKhufJRDrz3Cx9PHtyRCJxR2vBaSf+zGuVvaaI5XOUIa9LgsmA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM5PR0401MB2593.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(346002)(376002)(136003)(39850400004)(396003)(76116006)(52536014)(5660300002)(2906002)(86362001)(54906003)(7696005)(316002)(110136005)(8676002)(4326008)(83380400001)(8936002)(53546011)(6506007)(26005)(33656002)(55016002)(9686003)(478600001)(186003)(71200400001)(66476007)(66446008)(66946007)(66556008)(6636002)(64756008)(44832011); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: zHhL3HASSeCvTQeo6E+Z9gbcNHWBXU7MbaKXltzyOJxDxe+dZPUCHXDySqIUyZd+jj2Y+PjxHm5ZfuCdhaq1DXgFxsi5TjhKRU5uySS4JvOvI70qnW0lNFRAjMBPx9iSfOcvD5dHxk8r2fPNW07XYK/ANetoxfAuaCufJogJ7aKKY8F6hYpoR/OmN+34zkSrNWr8q6sm/iNFTFNsToQgfZVBgnwRWH8ZL30gWe/5XXvwTwg94mus/vF9iYlYgMwVGtxe2uDUblXlcBMUAFL8TMAzwkN0k3f5CikAHhizmjsJuT+RHoIrS8E+r3X5CvhMuJTjG3smJptGqvWCIm3G2u9PQowFheb1SzvdnXb1419toePYACZieXGAMve20AsAOz7oD+l8unRhbqvxFw3t0BT5vtLacnq408keYQUvdDfrWsd47KhWl9/QZdQaBtblT1xE+06ILJnazX3JkuwM4FGvngHI8M0T7leaXpWvvN69o/u2QQWOyyaAJYdBs2SE6h3hjj9SWMC10CHPu/Wyu3k2TZfvPtNSh/AGstpd4jT1euTQzvpbCatK25o3jtIGe+ZF0Tf2FOsun9Nyx5/aTQgYCy6lrSXts2JnpVleg3Nnu8T2HtRjRO61IlBKUMFwHU/0HHb5J0Z7T5I28QD3iQ== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM5PR0401MB2593.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b005f4b5-2643-4546-5864-08d86853bcc7 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Oct 2020 10:53:33.0630 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Upyy2F3EdDA4Niaf2w/7GRYq7Ah2+w+F2UYDrUc7e5HfaM6uBP+V99KJsJikEI4CJ0QUg2nwXFd0+EUWf6oaqA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB7143 Subject: Re: [dpdk-dev] [PATCH] event/dpaa2: fix dereference before null check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Acked-by: Nipun Gupta > -----Original Message----- > From: wangyunjian > Sent: Wednesday, August 26, 2020 6:38 PM > To: dev@dpdk.org; Hemant Agrawal ; Nipun Gupta > > Cc: jerry.lilijun@huawei.com; xudingke@huawei.com; Yunjian Wang > ; stable@dpdk.org > Subject: [dpdk-dev] [PATCH] event/dpaa2: fix dereference before null chec= k >=20 > From: Yunjian Wang >=20 > Coverity flags that 'portal' variable is used before > it's checked for NULL. This patch fixes this issue. >=20 > Coverity issue: 323516 > Fixes: 4ab57b042e7c ("event/dpaa2: affine portal at runtime during I/O") > Cc: stable@dpdk.org >=20 > Signed-off-by: Yunjian Wang > --- > drivers/event/dpaa2/dpaa2_eventdev.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) >=20 > diff --git a/drivers/event/dpaa2/dpaa2_eventdev.c > b/drivers/event/dpaa2/dpaa2_eventdev.c > index 3ae4441ee..f7383ca73 100644 > --- a/drivers/event/dpaa2/dpaa2_eventdev.c > +++ b/drivers/event/dpaa2/dpaa2_eventdev.c > @@ -569,14 +569,14 @@ dpaa2_eventdev_port_release(void *port) >=20 > EVENTDEV_INIT_FUNC_TRACE(); >=20 > + if (portal =3D=3D NULL) > + return; > + > /* TODO: Cleanup is required when ports are in linked state. */ > if (portal->is_port_linked) > DPAA2_EVENTDEV_WARN("Event port must be unlinked before > release"); >=20 > - if (portal) > - rte_free(portal); > - > - portal =3D NULL; > + rte_free(portal); > } >=20 > static int > -- > 2.23.0 >=20