From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9C9ECA04BC; Thu, 8 Oct 2020 17:45:17 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9C4D61C1BC; Thu, 8 Oct 2020 17:45:15 +0200 (CEST) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80043.outbound.protection.outlook.com [40.107.8.43]) by dpdk.org (Postfix) with ESMTP id 57CE31C1BB for ; Thu, 8 Oct 2020 17:45:12 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=L63DgMZBh95V7BQ64+EonTHA7sBsfhWOlrE848o7f/im0P3l7zioRVMMtWGDBg/k+kz6OeQhjuC+2DCLOK4WBgeRIwYcIDhqQEuDozl95e8eAOAPmDGvGWcRI9XtbSHmYdAZbG/R9Fsh29cLxSjq6xBusSafOxo8HeRcA1NJ/OhY/OBQIRmGrRt9M8Pm7ntRlTAXWoriWKYqGPOLXb6m9GWKut/A7U1Kg0si9+n3Btph43UbSGI9nah+JZ0qqIZi4p2srMOFytNUsCNhJ9hJWEZOu9Qk/AMLFOqk9qrQ5SLG1mGXBLXqQC3LaeF8OUaopyUSdU0InBcUCg7g2J7OsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WSoTroO2nbQGsJqVYfTIZF0Hvbyff2xRErYdNZO47iI=; b=bIlmwAylISC73Y/lTepEgU24u1ZP2BqtN6F9wGFgni6Ymn7dEi8dszbZuRskiwZUTkHAwYGMpAQ5YHts8+oDNHhxZ9q2UhEbjclA1Fm1qIU6UelHb16oTjn0hJ4MHgqQltl0GUNbu6NZ+/JbKKF5wBwyaGRiVgJuBQ0wpx3zDmjDvgmWCn9Io2Bg9E8kQW1WIxV7aOAjtumZPY+2NVPmvAbVE6581YuiA9p/P1eNHuk36r+sc7hCW3HGV3rqQmDgu/FnWrUBUGM3IdC4Q6r3mu9hAXkL5GT92n1c2u/Fs7S7//lZLoGfq/YY8AsjxzH0ecP+CtyA7mlSGPHKkDiK6g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WSoTroO2nbQGsJqVYfTIZF0Hvbyff2xRErYdNZO47iI=; b=a2Rf83lzXOxN4OdHQSnfUEFkHwIocDfjtiZaS6YQ5m+v5wfHjtrCmovUJYStjt9MbnUolnnPcSSIBMVr4nxCLpXtZIrJCrzFdExcvte3rE4RyNPqnfSAorx3az0smZkH2JFAiWVzwjkJQJXhzibg/vAXPkUZpzljbzy+79sFPcI= Received: from AM5PR0401MB2593.eurprd04.prod.outlook.com (2603:10a6:203:37::20) by AM6PR04MB6438.eurprd04.prod.outlook.com (2603:10a6:20b:fd::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3433.38; Thu, 8 Oct 2020 15:45:08 +0000 Received: from AM5PR0401MB2593.eurprd04.prod.outlook.com ([fe80::3c2c:e6e1:4e49:2e5c]) by AM5PR0401MB2593.eurprd04.prod.outlook.com ([fe80::3c2c:e6e1:4e49:2e5c%11]) with mapi id 15.20.3455.024; Thu, 8 Oct 2020 15:45:08 +0000 From: Nipun Gupta To: Asaf Penso , "dev@dpdk.org" CC: NBU-Contact-Thomas Monjalon , "ferruh.yigit@intel.com" , "arybchenko@solarflare.com" , Hemant Agrawal , Sachin Saxena , Rohit Raj Thread-Topic: [dpdk-dev] [PATCH 3/3 v2] testpmd: support hardware offload to drop error packets Thread-Index: AQHWnYSertwsOQQ76kGzQ/hEaXkI56mN2NLg Date: Thu, 8 Oct 2020 15:45:08 +0000 Message-ID: References: <20200831075333.10135-1-nipun.gupta@nxp.com> <20201005071506.28861-1-nipun.gupta@nxp.com> <20201005071506.28861-3-nipun.gupta@nxp.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nxp.com; x-originating-ip: [182.69.68.139] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: cb8748f6-bce9-4cb0-d290-08d86ba122ae x-ms-traffictypediagnostic: AM6PR04MB6438: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4125; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 5p9Z9gz/ZZ9mlHGoyrCv612SgDKa6LGnYF3XUgCD6tBbm78yS/ZQhG0QVjXveCvHiNLyCuSYs27ubAwNW+cNJpo/Mlbnhfbo7nmlFuvyzftEmPGF3gKvvaBKDRqkl3Sxe+ZiGF8rRboqOUOmHbRhl8mhvthikPlipvSpX4ZomnA0gxOu5ofCBqeFKDUIVIGoU6R1oAO2p/W5RbE+ojqFchX5BzdWEwFR3juBv2AEdE4yGbU1PR2NxTy6SRTOXjmq7IkYHOutBakgx1dLwalgmWDhUUkASQR7qrP2TGOeH0AWgfYX6ecg89JlQcNFUuUsJ0kUK6h5zi0An2yI+oqccQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM5PR0401MB2593.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(136003)(376002)(346002)(39850400004)(396003)(76116006)(66946007)(71200400001)(44832011)(9686003)(64756008)(66476007)(66556008)(186003)(53546011)(5660300002)(8936002)(83380400001)(66446008)(6506007)(55016002)(52536014)(86362001)(2906002)(7696005)(478600001)(26005)(110136005)(4326008)(316002)(54906003)(33656002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: QponKD1XO0p8T0lQNT/rM04YyS/xfd3Ab2JhdUS8qAjjgMkQnl8Rwy3F39cRJrRM4PtGSChzVjNgKL4WvMCkUXcrL1i1nPHcSmIrlTMtisrN8VYIJs9WWWFVzQErpZ+Qi2oThcytn1bW5iVkrhimJGDdVs/2JlWMjNkFbDPy0a9cFa3YRy0UC0piy+ZOfLNhtDkCJuyn667alM6pMXhmSokUGBICImbV8ow4zYGqg5YrzGmU9h7BMtDlx6AG2Qycwn1KLqNl+Uf92h9PPSIcOUnvtnWVWqiVzmh+d/0QTlRv6zdUPxOyxL5jJaVnFaHVxx7YS7LKmh0Kd7RtyRWGDVCOP711xkGuF7h0jov1ZhaKrXcirhfLfJ0w/soCLWlCroJCpP6a2Erc0dZBSapv5Kozc7W8vw7OGblHrNJC7NVO5ZyjXGvK0laKTXlPGPQH86dJCGkzdQQQfTlOdyObL0SrXlaihiOjrb9pkFu491kJNenFmXcBkuR7EwL7n0sZg31DqVdiPEJoVkocrld/y6O4MCjWRmgl/bVl44yRfRid4PNqkXonEcHsYNijCR/dWYHyhBqTCIVe5SqPMS+4bN+vLCZdMWtZEVZq7TpSqEbmpWxmcOBw4eAZM1WSRCCULLS/qtRB6sgPY9eqt4iONQ== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM5PR0401MB2593.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cb8748f6-bce9-4cb0-d290-08d86ba122ae X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Oct 2020 15:45:08.8294 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: YVzvbXquU1g8KTX+qyxuvZFvBQrXKqRJcZSmo+xUrd/xYbOKXTvN1dvajiiSvPqXI3qq6TjmDvpZPhDbZ88IgA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB6438 Subject: Re: [dpdk-dev] [PATCH 3/3 v2] testpmd: support hardware offload to drop error packets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Asaf Penso > Sent: Thursday, October 8, 2020 8:36 PM > To: Nipun Gupta ; dev@dpdk.org > Cc: NBU-Contact-Thomas Monjalon ; > ferruh.yigit@intel.com; arybchenko@solarflare.com; Hemant Agrawal > ; Sachin Saxena ; Rohit > Raj > Subject: RE: [dpdk-dev] [PATCH 3/3 v2] testpmd: support hardware offload = to > drop error packets >=20 > >-----Original Message----- > >From: dev On Behalf Of nipun.gupta@nxp.com > >Sent: Monday, October 5, 2020 10:15 AM > >To: dev@dpdk.org > >Cc: NBU-Contact-Thomas Monjalon ; > >ferruh.yigit@intel.com; arybchenko@solarflare.com; > >hemant.agrawal@nxp.com; sachin.saxena@nxp.com; rohit.raj@nxp.com; > >Nipun Gupta > >Subject: [dpdk-dev] [PATCH 3/3 v2] testpmd: support hardware offload to > >drop error packets > > > >From: Nipun Gupta > > > >With DEV_RX_OFFLOAD_ERR_PKT_DROP now defined as an offload > >capability, testpmd showcases this with a new added configuration option > >'enable-hw-drop-err'. > > > >Signed-off-by: Nipun Gupta > >--- > > app/test-pmd/parameters.c | 5 +++++ > > 1 file changed, 5 insertions(+) > > > >diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c index > >1ead59579..ada870e2d 100644 > >--- a/app/test-pmd/parameters.c > >+++ b/app/test-pmd/parameters.c > >@@ -142,6 +142,7 @@ usage(char* progname) > > printf(" --enable-hw-vlan-strip: enable hardware vlan strip.\n"); > > printf(" --enable-hw-vlan-extend: enable hardware vlan extend.\n"); > > printf(" --enable-hw-qinq-strip: enable hardware qinq strip.\n"); > >+ printf(" --enable-hw-drop-err: enable hardware packet drop for error > >+packets.\n"); > > printf(" --enable-drop-en: enable per queue packet drop.\n"); > > printf(" --disable-rss: disable rss.\n"); > > printf(" --port-topology=3D: set port topology > >(paired " > >@@ -631,6 +632,7 @@ launch_args_parse(int argc, char** argv) > > { "enable-hw-vlan-strip", 0, 0, 0 }, > > { "enable-hw-vlan-extend", 0, 0, 0 }, > > { "enable-hw-qinq-strip", 0, 0, 0 }, > >+ { "enable-hw-drop-err", 0, 0, 0 }, > > { "enable-drop-en", 0, 0, 0 }, > > { "disable-rss", 0, 0, 0 }, > > { "port-topology", 1, 0, 0 }, > >@@ -1037,6 +1039,9 @@ launch_args_parse(int argc, char** argv) > > "enable-hw-qinq-strip")) > > rx_offloads |=3D > >DEV_RX_OFFLOAD_QINQ_STRIP; > > > >+ if (!strcmp(lgopts[opt_idx].name, "enable-hw-drop- > >err")) > >+ rx_offloads |=3D > >DEV_RX_OFFLOAD_ERR_PKT_DROP; > >+ > > if (!strcmp(lgopts[opt_idx].name, "enable-drop-en")) > > rx_drop_en =3D 1; > > > >-- > >2.17.1 >=20 > I think it would be good also to update testpmd run_app.rst with this new= option. Sure. Will update in next spin. Thanks, Nipun