From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5424FA04DD; Wed, 28 Oct 2020 13:30:37 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 22F88CA12; Wed, 28 Oct 2020 13:30:36 +0100 (CET) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2043.outbound.protection.outlook.com [40.107.20.43]) by dpdk.org (Postfix) with ESMTP id 70F7BC9FC for ; Wed, 28 Oct 2020 13:30:33 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lF5k7Ev8VXSAGR50Rd3IyjfmO83JfkX9GKBLGO8FOkczTv5b3semL2ZC8mHcJvBYyHgh4rMVzPsq5w3Ka1i9w7/dm9bSiFYSQCB6t9gHadmr6nPxa5HEibMoGQJ5lYknlzT8VpqAM6v8gUSxPfg+f1NfqiHZDv40I+ez0sIV/hzYr6H7FyzuGft3lR3wO98vmAzHXRFm83z4ltaPp47YL7OiMIpgAytS/b7J2dWcjWEnX8w1/+7XDGC/aSEuxwcdEleM+mUWCpZx6NZ+mlORfP4LPfd/Z+IHBZs+OPu6UZcXanGE17VPK2ccNcyXYDNJuKovk/5rN36WbJXMUpd27w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ydGC8BsA215ILu4otn3aAvOCoBGciXrmmye5dN9eAKQ=; b=OBJklVs+h+qnx7Bp4T0zT9NfJ0AxoPUgSTBFMZO4LEqFDFZg5n5LCe9f5aJi/n8aIRsgJUGfJo3wI4CM71wAI4aCzjcB1N+Hkc2em8JKlNgwnYwuzpKKyzIZlbYq/ztjPat22SBEAP5uEJgrlqw919Bs02L99+segNuYA6cPWHfcvLZYa8SGBZQW1YtXx+xVNnaZpT9dj/D88Bw3KhogQG9oOCwK5mvRtnRXcXPHwcVLxTvF857ivhm70/K46gyixKlW1BUFgjIocACh5p2qbqsxH7y2FNEmxOjJTifXLq4d4FpulBfusbURI4nDLS2UrS57lig+njQfeHm1r34njw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ydGC8BsA215ILu4otn3aAvOCoBGciXrmmye5dN9eAKQ=; b=iXq3n/aBlrygDQG4HRVCPv+wO+AI5SNdVQJd2ps0m83WjFm08nqWyTVxVZsGhpxUUExW5vr0H6/qJnChPIumswUKjKkfb7wjm6VIqJJQCYk0m1Bnbm1hJNodkBejWjvc4QjxxFsYHnpWij6colXHSKp8LFxWxz/+RCy5UFGwJmM= Received: from AM5PR04MB3153.eurprd04.prod.outlook.com (2603:10a6:206:e::26) by AS8PR04MB7656.eurprd04.prod.outlook.com (2603:10a6:20b:29b::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.18; Wed, 28 Oct 2020 12:30:31 +0000 Received: from AM5PR04MB3153.eurprd04.prod.outlook.com ([fe80::91e5:1731:c6e:b79c]) by AM5PR04MB3153.eurprd04.prod.outlook.com ([fe80::91e5:1731:c6e:b79c%2]) with mapi id 15.20.3477.029; Wed, 28 Oct 2020 12:30:31 +0000 From: Akhil Goyal To: Vladimir Medvedkin , "dev@dpdk.org" CC: Radu Nicolau Thread-Topic: [PATCH] examples/ipsec-secgw: fix session mempool initialisation Thread-Index: AQHWrGoq12iVViNeBEebKmedyycMlKms8x6A Date: Wed, 28 Oct 2020 12:30:31 +0000 Message-ID: References: <1603807420-268020-1-git-send-email-vladimir.medvedkin@intel.com> In-Reply-To: <1603807420-268020-1-git-send-email-vladimir.medvedkin@intel.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=nxp.com; x-originating-ip: [171.50.183.179] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 49f7930c-c8ae-4670-b2fc-08d87b3d42ef x-ms-traffictypediagnostic: AS8PR04MB7656: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3173; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: dIJ+mh0JT31qPchaPDMj/bBNvmsJBCO2vWxEGvIVqceXYBlrqFo7Pz4YrYh6H3VzkNJv078BS9iDdzl4mufAi7JNAohVO+YSzPqKpxbOxJsoT5OalhEw+xCW0ZLYEfBRcpNKW/E0w8PriXZwCRD2Ydw3LSrZQY47LCKohp364vnlYLBCyUrtBS0boB2D1XXYR6snjHyOtFA5/jE0fIK5llIKbMlddDfhDHRdaMxy1R5yn8X05qtCNxZJENXWE9pq8uh+gJIPHDGj6z1k2IYy9G4b4mzvGRUBpcZyJLJoziIzqpkKdtCsVQj4PoaKAy4SCb3Buj4aLryvKsxLjP/vMA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM5PR04MB3153.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39850400004)(396003)(136003)(366004)(346002)(376002)(316002)(5660300002)(9686003)(52536014)(55016002)(8936002)(33656002)(2906002)(44832011)(110136005)(7696005)(186003)(76116006)(4326008)(86362001)(8676002)(71200400001)(26005)(83380400001)(66476007)(66556008)(64756008)(66446008)(53546011)(66946007)(6506007)(478600001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: oxkaG3vIHs25gQPnqg4Dfqnj6RAt1KaIPX6jprQPSGT5Oc5DCA8+MYyYAVu8J9fTxWBEaHNKjjaon8KokqDvHHH9vslSO+scBURRSwnm5uoKDXK50h+DO2Ykhp8mvSS6FZCumkKQ4LRszqWEi7cjuEIYEY2iY/YAAXboHKDhIbnA6MHw1y6IBYg9OQU4TZqdyf22/zVqYLlv9pJhDTHvFfwutEIhYv1EOp7CfnugSP2flmByL2pbYk7FR41bsL0RXrjLdKlEdoIlkpmZB9YzsIHaIl/ZqO8f+36gkOff5QyEQATrdrXE9kwXCdGOUdzP16Gw3KNKHPH9/h5CWVP94K5OnL1H+6kspcJN5OUz9lqhKSF0+K0j9MEYwjCe/1RDdIe9WxH4/TiZqUsO1D/ENSchCTmMqxAdYSW0MKUFp4ZgvcjIBYJ9Boi9bCFflL6WdADjBGu9Kn9Ina4nHR0mstZuQqghH2LqehqO2Am54Cw3Nt9kTQ2Yq+XJTvnwyl2Zt6pRJ3sCqou0hS05XrsJcW+SS0RqCN8kDHe1RV18BNx8nVZeFIubIl/7TjJNnQ4DXUHV64TvINYz+AW4caKav5OORGgg0oqFAzfLu/cDU7kXTHJlA5jF/TfpWa/cwOckVi2mABP4aeq7n900jvBOBw== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM5PR04MB3153.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 49f7930c-c8ae-4670-b2fc-08d87b3d42ef X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Oct 2020 12:30:31.8082 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: k6E0ft795PVCC795IBJG/kClBivze3bgizKyFv6D7aJ1GZoMopxXfLAn0D7850gbCxUHxyD3wk/2D5TH1sS/WA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7656 Subject: Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: fix session mempool initialisation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Vladimir, > -----Original Message----- > From: Vladimir Medvedkin > Sent: Tuesday, October 27, 2020 7:34 PM > To: dev@dpdk.org > Cc: Akhil Goyal ; Radu Nicolau > Subject: [PATCH] examples/ipsec-secgw: fix session mempool initialisation >=20 > Creation of a session mempool may fail in the case of a single lcore > and a low number of SA. >=20 I am not able to understand the reason why the number need to be increased. Could you please explain? > Fixes: e30b2833c47c ("security: update session create API") > Cc: akhil.goyal@nxp.com >=20 > Signed-off-by: Vladimir Medvedkin > --- > examples/ipsec-secgw/ipsec-secgw.c | 5 +++++ > 1 file changed, 5 insertions(+) >=20 > diff --git a/examples/ipsec-secgw/ipsec-secgw.c b/examples/ipsec- > secgw/ipsec-secgw.c > index 2219148..935829e 100644 > --- a/examples/ipsec-secgw/ipsec-secgw.c > +++ b/examples/ipsec-secgw/ipsec-secgw.c > @@ -65,6 +65,7 @@ volatile bool force_quit; > #define CDEV_QUEUE_DESC 2048 > #define CDEV_MAP_ENTRIES 16384 > #define CDEV_MP_CACHE_SZ 64 > +#define CDEV_MP_CACHE_MULTIPLIER 1.5 /* from rte_mempool.c */ > #define MAX_QUEUE_PAIRS 1 >=20 > #define BURST_TX_DRAIN_US 100 /* TX drain every ~100us */ > @@ -2350,6 +2351,8 @@ session_pool_init(struct socket_ctx *ctx, int32_t > socket_id, size_t sess_sz) > "sess_mp_%u", socket_id); > nb_sess =3D (get_nb_crypto_sessions() + CDEV_MP_CACHE_SZ * > rte_lcore_count()); > + nb_sess =3D RTE_MAX(nb_sess, CDEV_MP_CACHE_SZ * > + CDEV_MP_CACHE_MULTIPLIER); > sess_mp =3D rte_cryptodev_sym_session_pool_create( > mp_name, nb_sess, sess_sz, CDEV_MP_CACHE_SZ, 0, > socket_id); > @@ -2374,6 +2377,8 @@ session_priv_pool_init(struct socket_ctx *ctx, int3= 2_t > socket_id, > "sess_mp_priv_%u", socket_id); > nb_sess =3D (get_nb_crypto_sessions() + CDEV_MP_CACHE_SZ * > rte_lcore_count()); > + nb_sess =3D RTE_MAX(nb_sess, CDEV_MP_CACHE_SZ * > + CDEV_MP_CACHE_MULTIPLIER); > sess_mp =3D rte_mempool_create(mp_name, > nb_sess, > sess_sz, > -- > 2.7.4