From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50060.outbound.protection.outlook.com [40.107.5.60]) by dpdk.org (Postfix) with ESMTP id A0BE55598 for ; Thu, 23 Feb 2017 11:44:52 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=XpPy5LAidzdjhASweO6FElnTMTXbRgl3tQFz2WtnlQQ=; b=fecjlytRVKFMC+Ob+fK8cfI+OJvdTBZuj5Vt7MEEAka6eBUOrOUqu1hPbNFOlmHQ0l+InYALe2LhmSeCFQd0nUE2MsieCxkBKzP2HfA8IG3isU26Q8ppPG7jsvvuXS116BRqQwwYzAsA+Npx31hi3YCkNcG8IAZB2LmY85xhXDg= Received: from AM5PR0501MB2481.eurprd05.prod.outlook.com (10.169.150.14) by AM5PR0501MB2481.eurprd05.prod.outlook.com (10.169.150.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.933.12; Thu, 23 Feb 2017 10:44:51 +0000 Received: from AM5PR0501MB2481.eurprd05.prod.outlook.com ([10.169.150.14]) by AM5PR0501MB2481.eurprd05.prod.outlook.com ([10.169.150.14]) with mapi id 15.01.0933.011; Thu, 23 Feb 2017 10:44:51 +0000 From: Vasily Philipov To: Ferruh Yigit , "dev@dpdk.org" CC: Adrien Mazarguil , =?iso-8859-1?Q?N=E9lio_Laranjeiro?= Thread-Topic: [dpdk-dev] [PATCH v2 1/2] net/mlx4: split the definitions to the header file Thread-Index: AQHSjRGXjLGp7MW1ukuz3TiEISEIiaF1YuCAgAEE4RA= Date: Thu, 23 Feb 2017 10:44:51 +0000 Message-ID: References: <74798f347a5b1fad28037b713ad83048c227a2ca.1487685098.git.vasilyf@mellanox.com> <74798f347a5b1fad28037b713ad83048c227a2ca.1487770570.git.vasilyf@mellanox.com> <1964838c-9f28-1680-705d-148bcf0e816c@intel.com> In-Reply-To: <1964838c-9f28-1680-705d-148bcf0e816c@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=vasilyf@mellanox.com; x-originating-ip: [193.47.165.251] x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-ms-office365-filtering-correlation-id: e89abed6-e585-4a9c-30f2-08d45bd8fec6 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(48565401081); SRVR:AM5PR0501MB2481; x-microsoft-exchange-diagnostics: 1; AM5PR0501MB2481; 7:uXAZkw0KZkqBnI8Ru9L68XzikRw0FBuaOJJyNiAievI6BAlo6UkSd50WZTbzWWg701JusI7VsMBjtojbqiUB3ThsmDbC+8naxVShQBdk+InA2Rb/qKZ818LGIZFFrenyORxzSPIyANVbEtqbs6P4USH24rcQd+OXHVmq/KPOOsttP+3VUfSm7bxiQPIJK1LjIJknMwO4gPTsS6oOKD9J3OGnK+vD4r26Rmv1wMyOiDDlVdBxq7WyNNZW0P/qx173+77icMrZv6XFNJmNtE1pfzeqtpgx3L6WsOt4l9wB+WJYi07SiOz40w8zsrT8vKNZcydCYDPFiTuUivruGXI3Ag== x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6055026)(6041248)(20161123562025)(20161123555025)(20161123564025)(20161123558025)(20161123560025)(6072148); SRVR:AM5PR0501MB2481; BCL:0; PCL:0; RULEID:; SRVR:AM5PR0501MB2481; x-forefront-prvs: 02272225C5 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(7916002)(39860400002)(39840400002)(39450400003)(39410400002)(39850400002)(189002)(377454003)(199003)(24454002)(13464003)(2501003)(86362001)(575784001)(3846002)(6246003)(53936002)(53546006)(38730400002)(106116001)(105586002)(6116002)(102836003)(106356001)(54356999)(8936002)(33656002)(122556002)(189998001)(81166006)(97736004)(81156014)(8676002)(305945005)(7736002)(74316002)(55016002)(66066001)(68736007)(92566002)(76176999)(101416001)(50986999)(2900100001)(77096006)(9686003)(5660300001)(25786008)(229853002)(3280700002)(99286003)(2906002)(7696004)(6506006)(2950100002)(4326007)(3660700001)(54906002)(6436002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM5PR0501MB2481; H:AM5PR0501MB2481.eurprd05.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Feb 2017 10:44:51.0453 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0501MB2481 Subject: Re: [dpdk-dev] [PATCH v2 1/2] net/mlx4: split the definitions to the header file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Feb 2017 10:44:52 -0000 Hi Ferruh, > -----Original Message----- > From: Ferruh Yigit [mailto:ferruh.yigit@intel.com] > Sent: Wednesday, February 22, 2017 21:05 > To: Vasily Philipov ; dev@dpdk.org > Cc: Adrien Mazarguil ; N=E9lio Laranjeiro > > Subject: Re: [dpdk-dev] [PATCH v2 1/2] net/mlx4: split the definitions to= the > header file >=20 > On 2/22/2017 1:42 PM, Vasily Philipov wrote: > > Make some structs/defines visible from different source files by > > placing them into mlx4.h header. > > > > Signed-off-by: Vasily Philipov > > --- > > drivers/net/mlx4/mlx4.c | 183 > > ++-------------------------------------------- > > drivers/net/mlx4/mlx4.h | 187 > > +++++++++++++++++++++++++++++++++++++++++++++++- > > 2 files changed, 189 insertions(+), 181 deletions(-) > > > > diff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c index > > 79efaaa..82ccac8 100644 > > --- a/drivers/net/mlx4/mlx4.c > > +++ b/drivers/net/mlx4/mlx4.c > > @@ -1,8 +1,8 @@ > > /*- > > * BSD LICENSE > > * > > - * Copyright 2012-2015 6WIND S.A. > > - * Copyright 2012 Mellanox. > > + * Copyright 2012-2017 6WIND S.A. > > + * Copyright 2012-2017 Mellanox. >=20 > Can someone knowledgeable about Copyright help please? >=20 > What is the year field in Copyright line for? > And above change updates Copyright from 2012 to 2012-2017, is this correc= t? >=20 The year line was changes in order to show when the file was changed the la= st time... > > * > > * Redistribution and use in source and binary forms, with or withou= t > > * modification, are permitted provided that the following condition= s > > @@ -68,10 +68,6 @@ > > #pragma GCC diagnostic error "-Wpedantic" > > #endif >=20 > Above invisible lines are "#include " wrapped with > #pragma for pedantic. >=20 > That piece moved to "mlx4.h" [1], which included a few lines later, so ca= n > these line be removed from this line? >=20 > > > > -/* DPDK headers don't like -pedantic. */ -#ifdef PEDANTIC -#pragma > > GCC diagnostic ignored "-Wpedantic" > > -#endif >=20 > Comment says "DPDK headers don't like -pedantic", won't removing > #pragma cause compile error with pedantic option? >=20 It is not necessary anymore, was fixed with the next commit: commit c0362128c57a0ad22ea311a9657bb15a44b70793 Author: Adrien Mazarguil Date: Mon Jun 29 11:34:52 2015 +0200 eal: fix pedantic build of mlx4 debug mode > > #include > > #include > > #include > > @@ -86,9 +82,6 @@ > > #include > > #include > > #include > > -#ifdef PEDANTIC > > -#pragma GCC diagnostic error "-Wpedantic" > > -#endif > > > > /* Generated configuration header. */ #include "mlx4_autoconf.h" > > @@ -96,21 +89,6 @@ > > /* PMD header. */ > > #include "mlx4.h" > > > <...> >=20 > > diff --git a/drivers/net/mlx4/mlx4.h b/drivers/net/mlx4/mlx4.h index > > 4c7505e..70c9ecd 100644 > > --- a/drivers/net/mlx4/mlx4.h > > +++ b/drivers/net/mlx4/mlx4.h > <...> > > + > > +/* Verbs header. */ > > +/* ISO C doesn't support unnamed structs/unions, disabling -pedantic. > > +*/ #ifdef PEDANTIC #pragma GCC diagnostic ignored "-Wpedantic" > > +#endif > > +#include > > +#ifdef PEDANTIC > > +#pragma GCC diagnostic error "-Wpedantic" > > +#endif >=20 > --> [1] >=20 > <...> >=20 > > + > > +void priv_lock(struct priv *priv); > > +void priv_unlock(struct priv *priv); >=20 > It can be good to mention in commit log that these functions are now > exported. >=20 > > + > > #endif /* RTE_PMD_MLX4_H_ */ > > I will fix the rest of the issues and will send the v3 patches. Thank you, Vasily