From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 24844A034F; Tue, 8 Jun 2021 11:56:45 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AE7F14067A; Tue, 8 Jun 2021 11:56:44 +0200 (CEST) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60053.outbound.protection.outlook.com [40.107.6.53]) by mails.dpdk.org (Postfix) with ESMTP id 5383B4013F; Tue, 8 Jun 2021 11:56:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PuqQXOeTXN1fY5gGzQ/hIQ3z35AxQjBrrxwQ23mxCLE=; b=z6udFac467VNZEmruc8/vQV0qgLAZ9ALNkwNBspFGEyxuvjPWT4qouTclfPhLrmyvo/l7SIc4xW5RZq4qusBmHNEFT7U5jfhL7GZY8Bx0U/jkdo/4sk78yPaaqnDQDxnff/hmItJ+WUF+7Dub4aA/2NuxW2xK9TB/er/a/Wyo1k= Received: from DB6PR0801CA0053.eurprd08.prod.outlook.com (2603:10a6:4:2b::21) by VI1PR08MB3230.eurprd08.prod.outlook.com (2603:10a6:803:3e::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4195.22; Tue, 8 Jun 2021 09:56:32 +0000 Received: from DB5EUR03FT016.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:2b:cafe::d) by DB6PR0801CA0053.outlook.office365.com (2603:10a6:4:2b::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4195.22 via Frontend Transport; Tue, 8 Jun 2021 09:56:32 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT016.mail.protection.outlook.com (10.152.20.141) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4195.21 via Frontend Transport; Tue, 8 Jun 2021 09:56:32 +0000 Received: ("Tessian outbound 5e4f56e125a9:v93"); Tue, 08 Jun 2021 09:56:32 +0000 X-CR-MTA-TID: 64aa7808 Received: from 91319df725b6.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 4428AA81-5B7D-4CCC-9C60-FB81FB3EDE39.1; Tue, 08 Jun 2021 09:56:25 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 91319df725b6.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 08 Jun 2021 09:56:25 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nS7lXvzEDTR/cTGSXoTvPgkeAh5X9+xwPvACEnEOkAy/nWirSVhpPSTib0nILY3nn+O0Y1q7HZi2vA9t4yPsHQR9ge/CEaeDLaOulMF2+1/Uca0g66ds8ib+EOBTDWc01WFMp2m9u6ZMTW5YLSrUDyiI4VDKpcmDeAxD5UAECFcAGP5jqH5QjlrTlZ5NiXiUUr+0x4W8uRR6H6o77ZWeJxEmjfE7HlysWOLR0MxXRsXaR7mqAaYWsSNR4R3RTNhF5IbNNBBiv7FvlaByH8WDY0+LSXmulCwLhDZsbPRCEBBib4DsX458OjPwwBCgkmb/GqWaub3TvqpchWEn3HtCLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PuqQXOeTXN1fY5gGzQ/hIQ3z35AxQjBrrxwQ23mxCLE=; b=W/HIFMkhwCf7BsgnswapohXAITEM4S8RsgDfHgdzUj6fUycupA/As8LHLycIaswRFyDvwEO4RhbOekbB8ZozjoZtlxU7yjZULn9JX+VE18V+j5RnUYFnMlBc2tpz/maOeSdspPi4pHu7J5n3/2FxCHFkK+kBJKb5qiNxJB08Dy+ApeUtmRAdb9fc1cBQ/U0K0MKkqaGP4NufhT8iR0oaQjwc9xmwCbuw3XJ6gmINyBJBUs6GDMzvhPd8MilToirOmWG5kl8i+Fa8KEkpMuesNHlxZyltocrCwD5An+pqN/USWvRqGFz+AX0xaskH2ukxqfQmnMHhTjavoCBnsm5PJA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PuqQXOeTXN1fY5gGzQ/hIQ3z35AxQjBrrxwQ23mxCLE=; b=z6udFac467VNZEmruc8/vQV0qgLAZ9ALNkwNBspFGEyxuvjPWT4qouTclfPhLrmyvo/l7SIc4xW5RZq4qusBmHNEFT7U5jfhL7GZY8Bx0U/jkdo/4sk78yPaaqnDQDxnff/hmItJ+WUF+7Dub4aA/2NuxW2xK9TB/er/a/Wyo1k= Received: from AM5PR0802MB2465.eurprd08.prod.outlook.com (2603:10a6:203:9f::22) by AS8PR08MB6375.eurprd08.prod.outlook.com (2603:10a6:20b:31b::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.21; Tue, 8 Jun 2021 09:56:21 +0000 Received: from AM5PR0802MB2465.eurprd08.prod.outlook.com ([fe80::e890:2ff8:8cdf:83b2]) by AM5PR0802MB2465.eurprd08.prod.outlook.com ([fe80::e890:2ff8:8cdf:83b2%4]) with mapi id 15.20.4195.030; Tue, 8 Jun 2021 09:56:21 +0000 From: Ruifeng Wang To: Michael Pfeiffer , Jan Viktorin , "jerinj@marvell.com" CC: "dev@dpdk.org" , "kosar@rehivetech.com" , "stable@dpdk.org" , nd Thread-Topic: [PATCH v3] eal: arm: fix out of tree build Thread-Index: AQHXW2nW7nMSF5W6rkKboynxKUajXasJ3wIw Date: Tue, 8 Jun 2021 09:56:20 +0000 Message-ID: References: <20210607065325.12140-1-michael.pfeiffer@tu-ilmenau.de> In-Reply-To: <20210607065325.12140-1-michael.pfeiffer@tu-ilmenau.de> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 9319B432BB1656478DFBC26FC2754B50.0 x-checkrecipientchecked: true Authentication-Results-Original: tu-ilmenau.de; dkim=none (message not signed) header.d=none; tu-ilmenau.de; dmarc=none action=none header.from=arm.com; x-originating-ip: [203.126.0.112] x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: 34282c4a-48f2-48e6-3d75-08d92a63b1ca x-ms-traffictypediagnostic: AS8PR08MB6375:|VI1PR08MB3230: x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:7691;OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: iuloZTh8IYCa+BrG7/UktUDz5MirzLityjqSPyOOjj5RyJH2uEOBCDbb6Hfp9JqgriiHZaxu78x8qH2i/+QU2qsP/T4vu4CVfyrvyne5ZLOThDZI0HqxUWfZoA7VnlCo8kLU6LPDfY/3tpFUPou1YZ/jFqxunYXT8RGx/E+PtYBzY22PydxFx27SJAu+cqiFkzbbnTsAOnCp/eLzcyBArZI9KmW1SVlEqYQAS3u9EGzxv/EgZARMWRLvfEjjsuToGMHY+DSRQ10naIVLwyXLkRMudhLEneTg4gES+psHiPl2162y9fF6yYsQ7nDkRLfugyygGizyVMdNq6MfxuXIf/cddUH/3fH4/6XsoUOVp7GB8AauQPLXjkYPi898eat63oRUICJ1+IUe12PB/Z2Iq/Fl/AGYtPdXTdgpxY4esXeGskXjd6i7xYQQfDxLXLj8BxdM4T7UYWZcJ1MFhDHWkWcl0iMtW7xd/dPrKKP/1g7LBlkv3gbYW4HIfZTHHg/Cr4WBuyYDCv9M7i79Jnv2I9SZr24N0nXXYK+My1RlsW+UiOadp47ccxY0PAJYFKy5x28C70H2VAp58yKM0Y2gVT7xsxMkDZ9+XyNMprfgARE= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM5PR0802MB2465.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(396003)(376002)(346002)(366004)(39860400002)(478600001)(86362001)(54906003)(110136005)(71200400001)(5660300002)(7696005)(33656002)(76116006)(83380400001)(186003)(8936002)(38100700002)(66476007)(122000001)(66946007)(66556008)(64756008)(66446008)(6506007)(9686003)(8676002)(53546011)(55016002)(52536014)(26005)(2906002)(4326008)(316002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?yBPywiCNDkKrEKxiYQo4RTZnpritFC3YwK1JTPArUgNe/OY0wvoSfP4zWdvq?= =?us-ascii?Q?D3WSpe5mqMKGlh0Xnz25y8yx4bH0cNRvaaqmJS7ZxF1EHPhQbPAnQW9JM4ea?= =?us-ascii?Q?ZJAalFShD22GO7fGDIPyYzewOUrI3BaFAQPFXGZJBOU/arSMySrjy8E4gbj6?= =?us-ascii?Q?1fJaNoS2WDta58b9D+wHD5bnkfktKaLiFtMHu931wDg8ULKcLm7AmZ8sVwK+?= =?us-ascii?Q?rdX9hA3LHalysQrKhh5YWRaRkMChol5+2qX1oUOoVXY7S958PKEKG/ZhSDb1?= =?us-ascii?Q?vGjHXcssw6iH/dGcjmcQw7YyoLwtbHrXf2HUctvWDPx3BnZpi+HmzIUopt2l?= =?us-ascii?Q?qKDuiEdCzZNplODncdzC2ODSjxCrLb8UUWiNpLtxfTKS8dvLsN0cKOlAb72t?= =?us-ascii?Q?0facaNQbIFiQo18b9K65C+KfGQsF2YJdpiK9vMXxv9bg+YJ/TpQ4OrOupTWL?= =?us-ascii?Q?frYLO7l7qrWk9e+pss2gLRnyI+P4xNIhRSHT7fqfc2AT43o9xxBpkFlcmXvh?= =?us-ascii?Q?4uwwtHuYyc9YPaBVDPPtWGePI8ktvczX+Uf5EV1KGNTCUODrbu0qvSrKIZdb?= =?us-ascii?Q?X4WsE87+XfTtUzToDZ+CsyMSjSB5h23e36j+FqzEKTr6VsfjWcSVwdDiqKeY?= =?us-ascii?Q?ywTyDuio7J+Rb7J+uJ/eBvjD35Q6UdVd5Zz7H16GW1GXuY4nZrvGjyBZQ8xE?= =?us-ascii?Q?/S41AMZyy5ud0uWHkJMu6ifdgMkSOWSgQOYJ2S40cHWlAfR5rWe3nn0T9L9v?= =?us-ascii?Q?5u7nKRxnbdYj+KaT0Kt+Cey/bIzDF0c470ZXBLuOUowvRblg/uRMrcFCPrdE?= =?us-ascii?Q?ntDH4kOGn8lUyvfU7EM01tVMGF3nzkBrAWIi5d1loZemzjXgFAhtZczORie1?= =?us-ascii?Q?JXXQR78ptd301MdGEpm0EURJ6OZgUw04Rb/JGY+P1B/ND37XXiZDMGpUGp8C?= =?us-ascii?Q?idwCTuDbhyCD9nMRQo03qP/M5WymSC6kcfrfHm+zPsTjkC3/QgKquf0Cg/Pu?= =?us-ascii?Q?LRTZAS1uW2mwaf+buygtPVnHnEEdC1nTpuMtvEa0OYLr9KGuHgPVU2ERPzHr?= =?us-ascii?Q?QXK4nHmPrNt0dE2Pwd/dhTW4LYrwHt8/tUowDgs9EORyB/xVqvohMqzHUy0Z?= =?us-ascii?Q?2qoIstJSRm/bR8Q/1obqcXVJVKnnILDPrzOLGT4EnOr9d8QiXYnR07Xjonc2?= =?us-ascii?Q?vJZznGxFJhsjoPcTlKppBdnaSCr+qZ9w9nWrlTigEarHvgSbipjyDam/H75e?= =?us-ascii?Q?dLevyYf+Bj4Nnyy67nEIcNn3tKc1f1q8alJaWtpT9V9GjwuwvKA+CF+U/LO4?= =?us-ascii?Q?s0rVtmuI5TMLSbyF0K2sxIsD?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6375 Original-Authentication-Results: tu-ilmenau.de; dkim=none (message not signed) header.d=none; tu-ilmenau.de; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT016.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: aeb2476c-807e-4bf3-9ef6-08d92a63ab1b X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6HUzctfrrIivY5wi8vRX4lrTxxXQRgwewo95gOUrZB+etr+Vh1Nj8kumiu5gq7yYOEIejkMnZOkkAqWoucFq0yuJl9I+iEhdyCcHGpIS+X7bqhg3aGr7M7N4Z5YYjBnd1MpbMbbE5ypkoBB8hdZJvpzkfJXeP5L0xWXhVdCdnMRcKZHshmRYuBm9G7D4TX/eMzti9BQE67GyKDYSPi6cqPT7aGtyHFCW6C70dUQD9OTBTbMVn4n0wuh2ZLTWTxiGB1EAp9GGXJhZl2Fc88LxOhWq26QlVhrFZDR0SSkqaD50qjKjYlfywA5AudjgJdaEkOnrrzKEbbnjL0UVhYHz8UlaIeJylN1/spKKD7Ya0fVFUGNohlngA1cdk0IMJ7WTAgRE3zWQOitAWOt4/ictTpy9O9CfKhTrR7KqG8sQ+DYUCwut8x1U6AoHUhRdYtUhWOzTUbb1tFUlvXdoa6KoxUS1je8Wg4qAOmoL3E/13kP5axiozzZp2BjfWOrzZa/wse3eeuK6rbCiUAnuM6VID0QZQR59Dri0kaB5C/P0IMD1+KxogsV7rwBmdE/C8s7R5+/TXk+hND5PXLGdgeHCZwY1YrelRrq6RdJ18f9e+ZCE6zlf9FVXjdYw0EusaLjVUQPFlbMohH2w4HKsGrZg8g== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(346002)(376002)(396003)(39860400002)(136003)(36840700001)(46966006)(7696005)(110136005)(450100002)(478600001)(2906002)(81166007)(186003)(36860700001)(4326008)(54906003)(336012)(83380400001)(70586007)(5660300002)(9686003)(47076005)(316002)(53546011)(6506007)(82740400003)(86362001)(8936002)(55016002)(8676002)(82310400003)(70206006)(33656002)(356005)(26005)(52536014); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jun 2021 09:56:32.2486 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 34282c4a-48f2-48e6-3d75-08d92a63b1ca X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT016.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3230 Subject: Re: [dpdk-dev] [PATCH v3] eal: arm: fix out of tree build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Michael Pfeiffer > Sent: Monday, June 7, 2021 2:53 PM > To: Jan Viktorin ; Ruifeng Wang > ; jerinj@marvell.com > Cc: dev@dpdk.org; Michael Pfeiffer ; > kosar@rehivetech.com; stable@dpdk.org > Subject: [PATCH v3] eal: arm: fix out of tree build >=20 > Including rte_byteorder.h may fail for ARM builds with 'Platform must be > built with RTE_FORCE_INTRINSICS' if rte_config.h is not included before. > Include rte_config.h from rte_byteorder.h to solve the issue. >=20 > Fixes: de966ccdcd7f ("eal/arm: add byte order operations for ARM") > Cc: kosar@rehivetech.com > Cc: stable@dpdk.org >=20 > Signed-off-by: Michael Pfeiffer > --- > v3: > * Proper in-reply-to. >=20 > v2: > * Fixed subject line. > * Add "Fixes:" and CC to stable. >=20 > lib/eal/arm/include/rte_byteorder.h | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) >=20 > diff --git a/lib/eal/arm/include/rte_byteorder.h > b/lib/eal/arm/include/rte_byteorder.h > index df2f1d87ba..1f90db9943 100644 > --- a/lib/eal/arm/include/rte_byteorder.h > +++ b/lib/eal/arm/include/rte_byteorder.h > @@ -5,18 +5,19 @@ > #ifndef _RTE_BYTEORDER_ARM_H_ > #define _RTE_BYTEORDER_ARM_H_ >=20 > -#ifndef RTE_FORCE_INTRINSICS > -# error Platform must be built with RTE_FORCE_INTRINSICS -#endif > - Moving of this section solves the problem. > #ifdef __cplusplus > extern "C" { > #endif >=20 > #include > #include > +#include rte_config.h is included by rte_common.h in above line. > #include "generic/rte_byteorder.h" >=20 > +#ifndef RTE_FORCE_INTRINSICS > +# error Platform must be built with RTE_FORCE_INTRINSICS #endif > + > /* fix missing __builtin_bswap16 for gcc older then 4.8 */ #if !(__GNUC= __ > > 4 || (__GNUC__ =3D=3D 4 && __GNUC_MINOR__ >=3D 8)) >=20 > -- > 2.31.1 I see similar issue in rte_atomic32.h/rte_atomic64.h/rte_spinlock.h/rte_tic= ketlock.h/rte_mcslock.h in lib/eal/arm/include. Do you want to fix all these? Thanks.