From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A9413A0547; Thu, 29 Apr 2021 16:28:28 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2E1B5410DD; Thu, 29 Apr 2021 16:28:28 +0200 (CEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70050.outbound.protection.outlook.com [40.107.7.50]) by mails.dpdk.org (Postfix) with ESMTP id 086A9406FF for ; Thu, 29 Apr 2021 16:28:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=v8BegYzHNqugny8QIqDpP8cc2y/zmjMcn1OanfG0w/4=; b=5WM4LGBRz9lHBjNu9FxgoL+dRG9foD2GLwmjWJEluiHiuQVEvAFivbEkfIf5voLX4fDElu6YMhZ/TQjBgiN0UDkbAlEzHP/XOqawrFa0ayykSqaWm5hEb82fP4/jHxJKQY2YxwUNPqWZL2wmipeFnqswqeQezgeCD79tASeFYZs= Received: from AM6P195CA0071.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:87::48) by VE1PR08MB5055.eurprd08.prod.outlook.com (2603:10a6:803:115::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4087.25; Thu, 29 Apr 2021 14:28:24 +0000 Received: from AM5EUR03FT051.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:87:cafe::5) by AM6P195CA0071.outlook.office365.com (2603:10a6:209:87::48) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4087.27 via Frontend Transport; Thu, 29 Apr 2021 14:28:24 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT051.mail.protection.outlook.com (10.152.16.246) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4087.27 via Frontend Transport; Thu, 29 Apr 2021 14:28:24 +0000 Received: ("Tessian outbound 13cdc29c30b8:v91"); Thu, 29 Apr 2021 14:28:23 +0000 X-CR-MTA-TID: 64aa7808 Received: from c4216cf1b358.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 57B59F02-3581-4D0D-B160-108C30BB2DDE.1; Thu, 29 Apr 2021 14:28:17 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c4216cf1b358.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 29 Apr 2021 14:28:17 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lCtbf4+cizkRQ3nVS/JpWJktMaf5Daljhr+dpxNDVeOMS5l1YBdxU8/MFIR+eKFQHO4EILIiOIQcq0NOSyVNzcHWlubWxHqACL4NWC0GNicxiynuFyqjswEiTx45sXkjCm27F5uCq5G644ntbkVt2K6WO0SZvbPsS0TDljIkjwWBQOb3ATdm5H0lle6iPtpC4lCAG6xTK3QPP2uTJq74AbrHFKp/6WiKRTaY5TIDtNml5vqORRZfm98CLyP5RFVo9KAEaD+FHyr2fRkK3YxMyLNCg6B4t42play2LImXuLrSQdy7oDVSkUJsrFC1jFoRv61N2lOFuk8EgNikCcizUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=v8BegYzHNqugny8QIqDpP8cc2y/zmjMcn1OanfG0w/4=; b=FYg/voeaz6layD1/IsjNaBriArNi2zGJnIeOZ6LiL1m0GE5ljdUI41y2N+IVcmfQswNP/URkHXtSRttvHMFCyvHJgPFolAsD3xl+AwU33G3aZcPqe03VDp79tjQf6RUBe3BT5eeOgh+BM3Sx9dE81goFpnjnXpOClowIymedjk8KxSCwnftQifzoDi0Qh6pxKpi6eCHHQ4erXRv7mIhx4k1S3KelB6od8IXPjQSb3HVQhjYSbm0Gd7PkmTvYOWIHKiEnRrPLiDqUhXsjBKy2Pdnkk/hnIG8/6vMihGfMMnTVeZrGvXxQoaOgDEZi6xXWJKTmgPkjAmz/W4MtNYomzQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=v8BegYzHNqugny8QIqDpP8cc2y/zmjMcn1OanfG0w/4=; b=5WM4LGBRz9lHBjNu9FxgoL+dRG9foD2GLwmjWJEluiHiuQVEvAFivbEkfIf5voLX4fDElu6YMhZ/TQjBgiN0UDkbAlEzHP/XOqawrFa0ayykSqaWm5hEb82fP4/jHxJKQY2YxwUNPqWZL2wmipeFnqswqeQezgeCD79tASeFYZs= Received: from AM5PR0802MB2465.eurprd08.prod.outlook.com (2603:10a6:203:9f::22) by AS8PR08MB6920.eurprd08.prod.outlook.com (2603:10a6:20b:394::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.23; Thu, 29 Apr 2021 14:28:14 +0000 Received: from AM5PR0802MB2465.eurprd08.prod.outlook.com ([fe80::e890:2ff8:8cdf:83b2]) by AM5PR0802MB2465.eurprd08.prod.outlook.com ([fe80::e890:2ff8:8cdf:83b2%4]) with mapi id 15.20.4065.026; Thu, 29 Apr 2021 14:28:14 +0000 From: Ruifeng Wang To: "thomas@monjalon.net" CC: David Marchand , dev , "jerinj@marvell.com" , nd , Honnappa Nagarahalli , nd Thread-Topic: Use WFE for spinlock and ring Thread-Index: AQHXOZfiEaONiOZqSEmnDJAtoLql+6rJkOEAgAAZKsCAACHSgIABvJWw Date: Thu, 29 Apr 2021 14:28:14 +0000 Message-ID: References: <20200424070741.16619-1-gavin.hu@arm.com> <2370044.79WzprfWfc@thomas> In-Reply-To: <2370044.79WzprfWfc@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 53CA143DC8F0C2438C837C40F3B51238.0 x-checkrecipientchecked: true Authentication-Results-Original: monjalon.net; dkim=none (message not signed) header.d=none; monjalon.net; dmarc=none action=none header.from=arm.com; x-originating-ip: [101.80.29.169] x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: f65261be-7f84-4966-8db6-08d90b1b0bf0 x-ms-traffictypediagnostic: AS8PR08MB6920:|VE1PR08MB5055: x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:1468;OLM:1468; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 3/dakdnB0xrcxz5RrFBKEv4ng2Qouk704fRFA36Gimv/b1q/dzrVXbtEq71zUSi1+n+rWdeZdaEUlyRyGSxL6sH45Y4idGuYCfJFeK+Z/VAPJKO+7CUjnD9r6V0T3riJEAnOgsUngB+DS47vtA3dkiUP39Nhu4jOeyXGjeKEUvx7Kw8c91Aa46cgq2YbKibrtW+ZfdtUJXY/neVoNoFBjkU4nk/2GvuOeXdMTM6FpzBQedps2EyBMsNILk9bm3k6sDI9pKtcif/op06G0WSLNb9l5qukTTnlbtWLFrxzrxzBVZzJCuelsPnAFaHFqFGyVaZN1/Zr2REC/fzAaD1QTEncN7+3iS/N2J2es8vzpfD/udpzS4VPQRm7ryylYjgYQ5utzbm96+4MnCNUFJHMaUe4QaLMgExpXyLD1SKdxKZVUfFtq1or6IviCVVfxPcje4ZsAyuGUu3XfT0H4x5GMZfCIjdmRJdo6tf62YwM7wPH4uOSPqMXf7jrHNK85U2PZMMIe3eOXWQzL/CuFeN021FopCvOd1IehPRLphIblMueXMo16v+wt83lqhj9GHGjngeXDlNDgag09X+Zp0XvIvxGDbOySl8HHiaUBSyB7s2Ju8I1DWnEoCW0GwPJCDzXAJGyUxC8c3B3uSrt2b3gWA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM5PR0802MB2465.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(376002)(39860400002)(396003)(366004)(136003)(186003)(8936002)(6916009)(66946007)(4326008)(316002)(64756008)(33656002)(52536014)(54906003)(8676002)(5660300002)(6506007)(26005)(66446008)(66476007)(71200400001)(86362001)(38100700002)(55016002)(7696005)(76116006)(122000001)(2906002)(66556008)(9686003)(53546011)(478600001)(83380400001)(21314003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?RzXLZRNUmWZgtU2TqgGf3K/zyUkqCgtH/SeGi0PrIhPIG16kRKQ4N3pOa6Ba?= =?us-ascii?Q?hp25CV4doQ8CH2S0TtP9mqwu/rwJBEbJKhfcV3KQKaBFyWnRlTev5y90pL+v?= =?us-ascii?Q?B+z7mxY9KFBP13cDdKBgmQbix1C9t/InFShNN83TydOPWRHE5UE6o0xLoltL?= =?us-ascii?Q?13WL75itIKxzxnVi34v/Y5N6JbTyj2lncCsUu2Ki/En6lIHLUhl5cT8VVsN3?= =?us-ascii?Q?IN6MZxUtlHbMSXaZThiFa4LXGW/ZX8rgqzT3qr5EvopRmrHr35HAMRqwlDXn?= =?us-ascii?Q?BOxzgqFqHEGLZIQAGMBFqflB1zafpfuHKFjVuIZhtUasSPRpXXzl02IerRJT?= =?us-ascii?Q?+QkwVnvKsHBoP0modkTB/rBo5CSBsIpQqMcP6mMfW0YYsT6wiTtZEa97645Z?= =?us-ascii?Q?yHuT07wpshZ3jPEzgKi+alt4tPn5TPFpYA89XMb6Hn8YmGXxz2k0Nx30ic89?= =?us-ascii?Q?LDlrziK5/F5PbMGQ9GoDwrKLAyw2UpcnpIEqpmO2QtXp7BYeOGciBZW3lwiW?= =?us-ascii?Q?qYhtEo+PeMQ7/Cr4+LZISM5YpOSZEtGbYvK8UFYuDHmJ0+HRLCVjJt2iL11E?= =?us-ascii?Q?WWs9bjgdJd/XDB0gjKOeRRvOYB9pk9DQoUUOMpoGwYEPRj2jKTSw6UxnQmdl?= =?us-ascii?Q?dE+6O8gzN9bPE0P8V2K2CL3CriIud7/b7KF+/HWMaVoypQn28e+TmRhLHtyU?= =?us-ascii?Q?EcRkVrcHYdt+t5W6DGg6sgXXwEsSEXA9gCURO/QATnxg+5mA/8Mg2IvZnk+E?= =?us-ascii?Q?36rrdBXpMDD7I7M0yCns8W2XOK0XjWK7oG+YU0/OPCpRp/7XYAHup6MUE5u8?= =?us-ascii?Q?U/12GNO/x9byTKDHCB76iAE5wYji90P5mnk06bI2gUMQz/b3yiGFtSxCjMA0?= =?us-ascii?Q?jfwXxm70sAYREEHflJbdS3M8kou5na9z8CwBrpA2oRtqBOA5ImapKpCaTfnK?= =?us-ascii?Q?R/kumU9OhrwwLvJWIwcdCgkUXrk+UlCDps/wK1kproRE3Xjul5GmGF/30qMH?= =?us-ascii?Q?1Dz5bsYog6hIex56uqr7tDjeNQuyvVIcAtB4+ACsY0QICkSGyp8Fp8f8RdgX?= =?us-ascii?Q?wti5UGBqRc9QDcIRjP0qJ0K44g/SPQvB1jFtWT+Qowo35EwNQrfbPHGrQtHu?= =?us-ascii?Q?ZdcZJRWqW9UW4pnRDbTSxH9bDAVfMvYy3a+8ahDbe1TabR3+moZCLGyUwmt8?= =?us-ascii?Q?SVmPgkP/MN7XmyS+RdW/JZ0xdY/yO2x45nMuPJmOJJx0yFIeWQXgNSGrefWV?= =?us-ascii?Q?4BHiGFRo1UhahdJbbJGE6xTzB5iV5gkHvRvCqkEt+/4r37fZQ8qKxmPO/Dp/?= =?us-ascii?Q?emoAczpU5gDFsjl8gfJEmrMt?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6920 Original-Authentication-Results: monjalon.net; dkim=none (message not signed) header.d=none; monjalon.net; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT051.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 549fd2d8-3e10-4822-38e2-08d90b1b063f X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dy/MPVfHeT0taErUiuDFk6bBI/2AnzuTTJfUVL0F/RZilPkfDNO7+EP7n0hf8XO2S2xPaQ670nULZS2QPI7CBmXG8sxS3/ZfcVDpU8nfRu1g7eF4qcDNHySZt8obwo6gih+EAbUtEN2WVL0rOOGLkHufBxi5mKF0AV8WmFKf3QWgFV2jGYebp2n8Ggdofw3aw789LOxVlJfmPYhWVWVEyUhUQTKcKWxD93i/ogRvo2IfsrS3UbgfFDGzSO/ltY8btDk8aeVBrXO8oiEEINQ8nJwPsjWu0+UaeCpI/FUNPY34UzQqb3g69RZ09gtWZzR9FyVurY1GWQkDwcrm+xiLFmQ5+bCRiaQjQue6MlyeeYxXmyWh4cDA4lF/xds/stCndRkBDuxzPtGEyvSj1WkbknnGsuVUbTtYTiIim7420RBgyWV8GXnbZhd7wl2Mn28WONb70i7MajVas9cqVUwu8tly5aRgIbzxoK5faH4W22MujaL9/lvW/4l89nXoluNXMO+v71zcMUxBBYeGp8xNDtgofahJK5aono34dU9hQUVDG7Dc4AK9/b3UNH5yNOWj4qWFIfSCdyxikwJGdUSrjCqc1z8H32brgxIH5PWtT4WiXjPR0U8j3t3lJu/5+1kqUUnnN4LFI+F3WISpgTOT+3nLRSrvoyR+Ybc/lLiFLtnMzEhKtYegcr4jC+KAJbbTMsGDe2oxn7bilDNYjTplVQ== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(346002)(396003)(136003)(39860400002)(376002)(36840700001)(46966006)(70586007)(81166007)(2906002)(356005)(6862004)(33656002)(54906003)(7696005)(86362001)(83380400001)(8676002)(316002)(8936002)(70206006)(82310400003)(4326008)(186003)(34020700004)(47076005)(6506007)(5660300002)(36860700001)(55016002)(478600001)(82740400003)(26005)(52536014)(336012)(53546011)(9686003)(21314003); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Apr 2021 14:28:24.1382 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f65261be-7f84-4966-8db6-08d90b1b0bf0 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT051.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5055 Subject: Re: [dpdk-dev] Use WFE for spinlock and ring X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Thomas Monjalon > Sent: Wednesday, April 28, 2021 7:14 PM > To: Ruifeng Wang > Cc: David Marchand ; dev ; > jerinj@marvell.com; nd ; Honnappa Nagarahalli > > Subject: Re: Use WFE for spinlock and ring >=20 > 28/04/2021 11:30, Ruifeng Wang: > > From: David Marchand > > > On Sun, Apr 25, 2021 at 7:57 AM Ruifeng Wang > > > wrote: > > > > > > > > The rte_wait_until_equal_xxx APIs abstract the functionality of > > > > 'polling for a memory location to become equal to a given value'[1]= . > > > > > > > > Use the API for the rte spinlock and ring implementations. > > > > With the wait until equal APIs being stable, changes will not impac= t ABI. > > > > > > Afaics, there is no ARM target with WFE enabled and we lost ability > > > to enable WFE support with removal of the make build system. > > > > WFE can be enabled with direct meson file change. > > WFE is not intended to be enabled by default. It can be enabled based > > on benchmarking result on hardware. > > > > > > $ git grep RTE_ARM_USE_WFE > > > config/arm/meson.build: ['RTE_ARM_USE_WFE', false], > > > lib/eal/arm/include/rte_pause_64.h:#ifdef RTE_ARM_USE_WFE > > > > > > How did you enable WFE to test this series? > > > > I modified meson file to test. > > Tests were also done with WFE disabled to make sure no degradation with > generic implementation. >=20 > I don't understand the usage. > Which platform should use it? Platforms that implement WFE semantic (e.g. N1) can use. The user can enable this feature for power efficiency purpose. But there is= something to note as described in commit message 1be7855d77 when the API was introduced.= =20 > Should it be a compile-time option? Yes, it should be a compile-time option. It can be configured via c_args meson option? >=20