From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7F9A5A0540; Mon, 20 Jul 2020 06:50:42 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B15591AFB; Mon, 20 Jul 2020 06:50:40 +0200 (CEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2086.outbound.protection.outlook.com [40.107.20.86]) by dpdk.org (Postfix) with ESMTP id 0738A1023; Mon, 20 Jul 2020 06:50:38 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZZr5Q1qv1ShiAom/YQfxAMCtaWgtyZyqngczJk9Qsd9OquwJbmkHLLXivIyAASQmQKf2CQT2YZ+OaVeGUjceJxgifWTUIYcPjD+9iXAyGMbyxInn8F8ce166YHp169pIxfcDaEURl9aKepLn8iRaZt1zd/9XPrnmU32jNapHq2EgAm93gqGK4Luckhf7mkC65Ks2OY6T//TjQPI7dVa1krjOKtkUIoOqA+/zfvU7T6k9v6oFSHJr4PJtOBY2NU4b2USueT6CMd0XxzzLW7gLWSji8RRDkU6YYAuIVWVwFWkd3GISPJTAh8LKEoF7OV0R4v7eQo+RTJLnFo5u1uPVSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gw1bhWXioJAWAI7BNEHkNTOQ/0KM59cQ+YvAqR/JjFY=; b=PP/bb0HSKJYhOuukpidcVr1BPUy0CGxp4hr+0V1wgKpzK4vyYP2ObNp/Tks9jfTSN+SAjb8XtvPsbSiFabdG+4S/s1C2ZI2TN5wOjB8WYWqI+FQEgpKOXtDGGo4dQ5b3uu6dJ35XyP+Nk7cFhQFGWq/GY6BO3wEdBCQFM7031zV1zIErwZuYyC3ol7FYBpDN1Me90q3QZzBTzuwH7RkXpDc2PFaC6lDdS7GSoaPi+tAmNDQNUy1HqDTp1kKVJB7vR4ASI61pwrfucuft4oU+cUrbeeVYp742oqXJp4lAzRyKOeZAqSVkr9NOLJMT3hDupy4z7qE63tG7dPvRoxqxMQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gw1bhWXioJAWAI7BNEHkNTOQ/0KM59cQ+YvAqR/JjFY=; b=oT2GfLxHHMOMBpqOV9ygZ6xFWkkMDabA2KC+mXhZxVXTmKnErXDU7bWElok7xIOakRrc7oqz5q9sONG3FIolytiDpO/hSizLTMvJfMym0KnuN7yHtdX6txuVKLDBskd5Yi/xOjVCI7HdtFzJbCH7rDdMYKH53Z77XMEC/C/T2Xw= Received: from AM6PR04MB4456.eurprd04.prod.outlook.com (2603:10a6:20b:22::25) by AM6PR04MB5414.eurprd04.prod.outlook.com (2603:10a6:20b:9d::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.17; Mon, 20 Jul 2020 04:50:37 +0000 Received: from AM6PR04MB4456.eurprd04.prod.outlook.com ([fe80::50d:1b5:ef9f:655c]) by AM6PR04MB4456.eurprd04.prod.outlook.com ([fe80::50d:1b5:ef9f:655c%7]) with mapi id 15.20.3195.023; Mon, 20 Jul 2020 04:50:37 +0000 From: Hemant Agrawal To: Thomas Monjalon , Sachin Saxena CC: "dev@dpdk.org" , Ferruh Yigit , "techboard@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v3 1/8] net/dpaa: add support for fmlib in dpdk Thread-Index: AQHWV1xVljg7Gbarckqx4eakhkQwoqkLrkIAgAO0bACAAIrQ0A== Date: Mon, 20 Jul 2020 04:50:37 +0000 Message-ID: References: <20200710171946.23246-1-hemant.agrawal@nxp.com> <20200711081716.25173-1-hemant.agrawal@nxp.com> <69e3b354-ca32-e109-8385-ffc6b973f0cc@intel.com> <11996214.pnvohz1kia@thomas> In-Reply-To: <11996214.pnvohz1kia@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=nxp.com; x-originating-ip: [122.180.211.197] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 915f6836-0943-4ac0-384e-08d82c687251 x-ms-traffictypediagnostic: AM6PR04MB5414: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: mgrqopAcx7R/h+Zs7aReoRhscKXNRGmqxMYP9r8vICE5Gaf3Az9UcZFKIU3xz5h4h7b6zgYNLauHHQjeumae6GmmlIq41yV8nj69loqqURdZjbGSJ3URjsEQzclt4e7jm9hocyfgimgkcy+3s5ex9x4sOWoi6sOJUHzo2vjDG4ZrUbaQXe+dOigcM5ELSItdMHskGo7bZrqvBDBLDgxsRjoWPZtYV1SmB87G4cuxM/pFFq2NW4jjhvEoQxP6TqUiVZ2vVTg3HFXNCobYr5de8A87F3pOIxpn5M50UBJrB3SxecLCy5Ma2ZZxS5CRTa9Z3h/2/MD7s5xrt/JV+2uSCw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM6PR04MB4456.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(366004)(39860400002)(396003)(136003)(346002)(376002)(7696005)(316002)(83380400001)(186003)(44832011)(33656002)(4326008)(110136005)(54906003)(71200400001)(8676002)(55016002)(5660300002)(66946007)(66446008)(52536014)(66556008)(9686003)(6636002)(26005)(2906002)(8936002)(478600001)(53546011)(76116006)(64756008)(66476007)(86362001)(6506007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: mRFkIRRC2PlVQ38hSbJJCazQPrby0JAdyafdve+qY/6yxDmlhJH577Dn+pI5+WhodxcyDdQGIFhqb2padZtseUjG39S32xnnQTGX1Qsd4kAVUG5ytoplHyZ28KUMuKIjAXLc0LnI4OuzgfjhSdi625Nrf/+5JrShbi2PTfGIc/0Va3xVQGVNhSAx670nXVO0ZesZMkU9N8kXTSMwR+bXbyUylxNEvikRW6e3cWjKr8z/hOZOIOpF1jrsQ1St7XLFtYUg4cRUtC7XTRBeiAi26xvkQW/kEAx1EVy7pt2+vj8w06Hh2qybI/IR97kzwOUO/WXVGc5b2ePnmW2HvKdeBv6xm87bB8vpkB58v2RY7wJuxLHbFpr38s2dQ2jVIKPdq3eUxzPnv1S/XA0KDS4ockHR3Ik3A5j9bGadhlyG2Kjkjcphr9l4lVNOpFwxl6d1o2ff48sWbYaimeUuQa06oeMDl5xapRYxRh4ctPGcpz6TmO7cDA+LEsR56W9tlAKM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB4456.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 915f6836-0943-4ac0-384e-08d82c687251 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Jul 2020 04:50:37.8421 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: F3FTE4XSMVR0G9c+KG9WjhMXeZIJqvw/a5uO16qER3UJO92MceM8zR1itWgomZELNk4eW+XXL+ANxzov4D+s/g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB5414 Subject: Re: [dpdk-dev] [PATCH v3 1/8] net/dpaa: add support for fmlib in dpdk X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" HI Thomas, -----Original Message----- From: Thomas Monjalon =20 Sent: Monday, July 20, 2020 1:41 AM To: Hemant Agrawal ; Sachin Saxena Cc: dev@dpdk.org; Ferruh Yigit ; techboard@dpdk.org Subject: Re: [dpdk-dev] [PATCH v3 1/8] net/dpaa: add support for fmlib in d= pdk Importance: High 17/07/2020 13:36, Ferruh Yigit: > On 7/11/2020 9:17 AM, Hemant Agrawal wrote: > > DPAA platorm MAC interface is known as FMAN i.e. Frame Manager. > > There are two ways to control it. > > 1. Statically configure the queues and classification rules before=20 > > the start of the application using FMC tool. > > 2. Dynamically configure it within application by making API calls=20 > > of fmlib. > >=20 > > The fmlib or Frame Manager library provides an API on top of the=20 > > Frame Manager driver ioctl calls, that provides a user space=20 > > application with a simple way to configure driver parameters and PCD=20 > > (parse - classify - distribute) rules. > >=20 > > This patch integrates the base fmlib so that various queue config,=20 > > RSS and classification related features can be supported on DPAA platfo= rm. > >=20 > > This base fmlib is shared across multiple project. > > - it is not following block comments style for doxygen and other=20 > > comments. > > - it usages camel case for naming. > > - it is not following the 80 char limits in code > >=20 > > Signed-off-by: Sachin Saxena > > Signed-off-by: Hemant Agrawal > Series applied to dpdk-next-net/master, thanks. >Sorry, this time I don't agree with Ferruh's decision of merging this seri= es. >Checkpatch is sending too many warnings. [Hemant] The base codes, which are coming from common area was not original= ly meant for Linux. If we change the original starting code of it, the the maintenance become = very painful otherwise. >But most importantly, the licensing has not been agreed in techboard and g= ovboard. [Hemant] you are wrong here. Which license difference are you talking abou= t? Standard licenses do not need techboard and govboard approval. /* SPDX-License-Identifier: (BSD-3-Clause OR GPL-2.0) is the approved licen= se. It have been used in DPDK since long.=20 DPDK exception file states: Note that following licenses are not exceptions:- - BSD-3-Clause - Dual BSD-3-Clause OR GPL-2.0 - Dual BSD-3-Clause OR LGPL-2.1 - GPL-2.0 (*Only for kernel code*) Any base code which is shared among kernel and Userspace space - mostly lik= ely will have this kind dual license only. Note: you don't add "Dual" word while stating SPDX string - it is implicit.= =20 >Why dropping this codebase in DPDK instead of pulling it as a dependency? [Hemant] >I don't like seeing DPDK becoming a pile of code duplicated from = somewhere else. [Hemant] We are not using the library as it is and making some serious chan= ges in the generic library to suit the DPDK use-case. So, it is not possible for us to use the *original* code of fmlib, which is= public. [Hemant] >I will drop this series from 20.08, waiting for a clear consensus= . [Hemant] Why?=20 [Hemant] >Note: I don't remember having heard about such change before, esp= ecially not in the roadmap. [Hemant] So anyone not publishing a roadmap - you will not accept features?= =20