From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CAE29A00BE; Tue, 7 Jul 2020 05:48:38 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 481C11D9DE; Tue, 7 Jul 2020 05:48:38 +0200 (CEST) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2057.outbound.protection.outlook.com [40.107.21.57]) by dpdk.org (Postfix) with ESMTP id ABC301D94C for ; Tue, 7 Jul 2020 05:48:37 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=i/HhY9+sCvAXpePloNFAsLBii+pYEuiBNffSCpG0mpgrcIwlvPWl8gDx2MsOxKT3E4Og+TesT0KY7ps3d7AuMO1CLsl8OtsKaQMdZXjNpebG4Sk+hiFJqhutpfC4voiNhmpzVRv/ttGgw1TqG1cWCLFY+EVWl31o4VoIfEZ+W9vizWKZoQPfrjwB9iMtm8QEipWWLWeTvDEEtfD6iLnOVipIijTlW4Uk57aWeKpMIfNE102YGXIdAUGAPcoIBUI1osa63dlopIVYl4aYysEk2o9Gjzo80TWWzQXOW5+9FgShcc/SUDbn1YJw2DaWHc6/pPy76pBsMAwV3wj84agVKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=y1L5gp/MjIc+ZcAAYuFNk9Omkrfc0UaSK1aXQYwrEio=; b=fJn+s7sMw2ljpcfzcKDJDsyCzjnWiXRKoPFEy/srJXQhSBtm9LCZYeAj+7KrpanbW0nfg+sioOPaGfhxoVV86ncmtSgtMOxuk75C+Xr5TdkRIT6aq1B6R55oJRkNGnsv9wSkJjS8yqRMc7IV4NngIYf/V7sAxK5DNYelgzCDkwAnOGWb7tS6U05VbSg6QO4UdRG26rI7d3r3s/mfsowVe/apUvgW8ONt30QADTJsUTPOaxlRNV4LwMZkLF9DDrOsMa3w6avf4rjN8xOdl9iX2JvAxw4Pko7cgWkvUqhSHXatsEF/DV+qt8tGdYSSOKxu461eUpZvcyI+Ox7davK4dw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=y1L5gp/MjIc+ZcAAYuFNk9Omkrfc0UaSK1aXQYwrEio=; b=g4mz+QojzLcSDgKvSXxCAYM5hsiVi7kBx/++6sL/xrms140jwysUgDRUfTAEnQZF0rwQYhai+OWEERGGuMlMiODDCnDi1dY+b/wrwZ2F59Zm9GXmsufP3Nm2dB3VvANq285sX31DycUvg693qUgJoifd9sbLM0qVfR+ORC1rVwU= Received: from AM6PR04MB4456.eurprd04.prod.outlook.com (2603:10a6:20b:22::25) by AM5PR0401MB2674.eurprd04.prod.outlook.com (2603:10a6:203:30::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3153.27; Tue, 7 Jul 2020 03:48:36 +0000 Received: from AM6PR04MB4456.eurprd04.prod.outlook.com ([fe80::52:2324:96c9:f3ae]) by AM6PR04MB4456.eurprd04.prod.outlook.com ([fe80::52:2324:96c9:f3ae%7]) with mapi id 15.20.3153.029; Tue, 7 Jul 2020 03:48:36 +0000 From: "Hemant Agrawal (OSS)" To: Akhil Goyal , "dev@dpdk.org" CC: Akhil Goyal Thread-Topic: [PATCH 1/4] crypto/dpaax_sec: fix inline query for descriptors Thread-Index: AQHWU8QtEf/o293d10+6owcDoUw2Kqj7e1mg Date: Tue, 7 Jul 2020 03:48:36 +0000 Message-ID: References: <20200706183500.29862-1-akhil.goyal@nxp.com> In-Reply-To: <20200706183500.29862-1-akhil.goyal@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=none action=none header.from=oss.nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [122.176.13.33] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 6d38508d-d9d2-40d3-6e85-08d82228a0e7 x-ms-traffictypediagnostic: AM5PR0401MB2674: x-ms-exchange-sharedmailbox-routingagent-processed: True x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2733; x-forefront-prvs: 0457F11EAF x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 42hh4UZpTHi7DiRhykmfX6oePsIIoZgpY3mDBdRHFUU4o+2rE3o+saP4AFasUB6rfuI59W66QVSN2cWqSADOulqotyqQ9QOvF2pITR4YgMubjY7yedwYbbwGHbZJ0hRoZ5bqC0ZRj0BVOpZ6JxoEdzQICmr5XppIVe8o3MIgRucBm0GmRIDCC1+OkTxx/uFUOU7FsFlkCaRJ5lzsspZTVBRlBBg9GYl4YcZNm+6aapPw0ubCgHYsQ5xaAxiTGsiQu0Nvi0V2s6Gdi1sJg53t3bUcMd6gFvrkEh2kdUpoImx3RyEssqYopEycex+OrYG20+TV0xKiUgAJuwFCYGfWDg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM6PR04MB4456.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(396003)(366004)(136003)(39860400002)(346002)(376002)(52536014)(76116006)(33656002)(64756008)(66476007)(66946007)(66556008)(66446008)(26005)(4326008)(7696005)(186003)(2906002)(6506007)(53546011)(55236004)(83380400001)(86362001)(478600001)(8676002)(316002)(110136005)(8936002)(71200400001)(55016002)(5660300002)(9686003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: T2Cl8y1dy1ehOOP+/PQOBJB2pyl9enzAAVbEzjkVjQdJWt7pSUWODI+lFhfwNz00NMXMrerO6g1YdDZhRBVdmISUBOlYZ+VtDJOu+3QJ6VRbjMX2troR8a7uWElEXaKb9sxVNmN4L2mPs0aoOzJPuZLynDUw1nZl3oJiLLaVSQ5VufEPTBdVRBsd/JLYt3qIAHstvvlimcOOdwOOcrdob/vx2n7zqUPUsl6eV3T9d98UbfA6FS5wTPXcOnM7Jsx8I15agls16nsfQLnVfRPBW90lsqrBVYqc1k3tPUea7bcl1YGWQS5gPC0mW9ryIjvMqapjWcmcfLyD8U8CIHGj4dPDdmCoHXn/4Uq6VaWS7tDnSlU7XkbDSmPwBBPGmLLB38JnKzzFtSicEzhqIehPbna8fW6SXERg7N81pMAbYfLmpkh8P2vPUABeAo9CbP2S2B/8YA5Henpn95lh2PUyXCIMpZdrgQoZaMuicjwcH/RbAvUTyeweQ2C0cYqf7mjh Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB4456.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6d38508d-d9d2-40d3-6e85-08d82228a0e7 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Jul 2020 03:48:36.5683 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: NhKJhWgDY7CbGHNm+VcEPDWlv6kx0imcv2IQBjSU4k3N06p1HZq9F5FL4CoQZ1Jl8TvbRVzUMaRyieYEGUl6gQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0401MB2674 Subject: Re: [dpdk-dev] [PATCH 1/4] crypto/dpaax_sec: fix inline query for descriptors X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Series- Acked-by: Hemant Agrawal -----Original Message----- From: Akhil Goyal =20 Sent: Tuesday, July 7, 2020 12:05 AM To: dev@dpdk.org; Hemant Agrawal Cc: Akhil Goyal Subject: [PATCH 1/4] crypto/dpaax_sec: fix inline query for descriptors The maximum length of job descriptor which is formed is 13 words and hence = rta_inline_query should take care of the max descriptor(shared + job) lengt= hs and thus find out of the key can be referenced or immediate. Signed-off-by: Akhil Goyal --- drivers/common/dpaax/caamflib/desc.h | 2 +- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 4 ++-- drivers/crypto/dpaa_sec/dpaa_sec.c | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/common/dpaax/caamflib/desc.h b/drivers/common/dpaax/ca= amflib/desc.h index e4139aaa9..635d6bad0 100644 --- a/drivers/common/dpaax/caamflib/desc.h +++ b/drivers/common/dpaax/caamflib/desc.h @@ -26,7 +26,7 @@ extern enum rta_sec_era rta_sec_era; #define CAAM_CMD_SZ= sizeof(uint32_t) #define CAAM_PTR_SZ sizeof(dma_addr_t) #define CAAM_DES= C_BYTES_MAX (CAAM_CMD_SZ * MAX_CAAM_DESCSIZE) -#define DESC_JOB_IO_LEN (CAA= M_CMD_SZ * 5 + CAAM_PTR_SZ * 3) +#define DESC_JOB_IO_LEN (CAAM_CMD_SZ * 7 + CAAM_PTR_SZ * 3) =20 /* Block size of any entity covered/uncovered with a KEK/TKEK */ #define KEK_BLOCKSIZE 16 diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c b/drivers/crypto/d= paa2_sec/dpaa2_sec_dpseci.c index 60fdced78..c56fb2152 100644 --- a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c +++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c @@ -2192,7 +2192,7 @@ dpaa2_sec_aead_init(struct rte_cryptodev *dev, =20 priv->flc_desc[0].desc[0] =3D aeaddata.keylen; err =3D rta_inline_query(IPSEC_AUTH_VAR_AES_DEC_BASE_DESC_LEN, - MIN_JOB_DESC_SIZE, + DESC_JOB_IO_LEN, (unsigned int *)priv->flc_desc[0].desc, &priv->flc_desc[0].desc[1], 1); =20 @@ -2416,7 +2416,7 @@ dpaa2_sec_aead_chain_init(struct rte_cryptodev *dev, priv->flc_desc[0].desc[0] =3D cipherdata.keylen; priv->flc_desc[0].desc[1] =3D authdata.keylen; err =3D rta_inline_query(IPSEC_AUTH_VAR_AES_DEC_BASE_DESC_LEN, - MIN_JOB_DESC_SIZE, + DESC_JOB_IO_LEN, (unsigned int *)priv->flc_desc[0].desc, &priv->flc_desc[0].desc[2], 2); =20 diff --git a/drivers/crypto/dpaa_sec/dpaa_sec.c b/drivers/crypto/dpaa_sec/d= paa_sec.c index 01e79c8ea..5ce7e3582 100644 --- a/drivers/crypto/dpaa_sec/dpaa_sec.c +++ b/drivers/crypto/dpaa_sec/dpaa_sec.c @@ -351,7 +351,7 @@ dpaa_sec_prep_ipsec_cdb(dpaa_sec_session *ses) cdb->sh_desc[0] =3D cipherdata.keylen; cdb->sh_desc[1] =3D authdata.keylen; err =3D rta_inline_query(IPSEC_AUTH_VAR_AES_DEC_BASE_DESC_LEN, - MIN_JOB_DESC_SIZE, + DESC_JOB_IO_LEN, (unsigned int *)cdb->sh_desc, &cdb->sh_desc[2], 2); =20 @@ -537,7 +537,7 @@ dpaa_sec_prep_cdb(dpaa_sec_session *ses) cdb->sh_desc[0] =3D alginfo_c.keylen; cdb->sh_desc[1] =3D alginfo_a.keylen; err =3D rta_inline_query(IPSEC_AUTH_VAR_AES_DEC_BASE_DESC_LEN, - MIN_JOB_DESC_SIZE, + DESC_JOB_IO_LEN, (unsigned int *)cdb->sh_desc, &cdb->sh_desc[2], 2); =20 -- 2.17.1