From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BAE0AA0540; Mon, 13 Jul 2020 05:47:07 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 637CD1C43F; Mon, 13 Jul 2020 05:47:06 +0200 (CEST) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2068.outbound.protection.outlook.com [40.107.22.68]) by dpdk.org (Postfix) with ESMTP id 6543D1C234 for ; Mon, 13 Jul 2020 05:47:04 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gJzpcnlnoekLdi39sNkZvjwk0gAZ98M9gd7/iHjfWSuVN9P2wxANtfGAlc4NPcHbE8wX2VRIy9NGgPFQgTu9u69u6LoploVOrf/D/9E636In4PeNLDC1u+bBkq5YFaKr1IXE/bB7Zp1xRvgv60GkESghxaS7+95lcYwPKGR3pWwlx4mCzifInaLisqP9cEKKr7OGxmN7f/h60PkUGeNmj6jEsTMouLgIAiw72uPa1aEy7mpvobBjxAFd3FmL6gE/6iMaAjw3yaxyDJ4DijX5bVkKBpQw7TeZl1qCt7fwwwKIR9rw9nuw2tjAOp0G6FLh7lzrU6Q+fy2lOlFEGDPN/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qia1l4o+dThMGvOIEno+Rs6NPFx0xjWRjmz/lZEHfMk=; b=S3hApwcBFuGvJ30y6A0sqAb/frNGSvhepesEoQtAknDazcqg/FxO8FWcWrd8IN/dQs4OYtkDJ79yxWqowLDJVq9PxUx5IsTZ8sSHKNihGlkAv9hkKELAxHRaix6LD9YB7N8tNj+rF5u+mmyHnSULPBvqMTVTeexd5h1GV63s00LpBP77oN1wTqo5YTDCs4Lw977bRNDU/weumZtz+fu5zrOXQrHyDjtdB+9G/g1xwwhqbFGhEnztBH7SNQhq6Ht9ZmKjtgBGFprAUSlpjqk30Lf6UZr1gcpOBgwZA6i+b7YaKY1Pdo+cQ+Ay5PlUNsahtIoCDX6/fjU4IgFyvuuHNQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qia1l4o+dThMGvOIEno+Rs6NPFx0xjWRjmz/lZEHfMk=; b=YS+nouxIl8vrKDAXsGWkJCAKwaCl+7a0e/8lyRWAU6tWZXpS6TnW3DR8u9c1X/pxV5VhardGr52alUZ/teLRQMItFdmF84jSrRyHRi0G3t/5cltibtBE4rWYeuBcn1ZXhafZsmueF0oO8fOqpcktXLMM3hbodmp3ELmvaT3xHzk= Received: from AM6PR04MB4456.eurprd04.prod.outlook.com (2603:10a6:20b:22::25) by AM7PR04MB6872.eurprd04.prod.outlook.com (2603:10a6:20b:106::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.23; Mon, 13 Jul 2020 03:47:03 +0000 Received: from AM6PR04MB4456.eurprd04.prod.outlook.com ([fe80::52:2324:96c9:f3ae]) by AM6PR04MB4456.eurprd04.prod.outlook.com ([fe80::52:2324:96c9:f3ae%7]) with mapi id 15.20.3174.025; Mon, 13 Jul 2020 03:47:03 +0000 From: Hemant Agrawal To: Thomas Monjalon , Gagandeep Singh CC: "dev@dpdk.org" , "ferruh.yigit@intel.com" Thread-Topic: [dpdk-dev] [PATCH v2 03/29] net/dpaa2: enable timestamp for Rx offload case as well Thread-Index: AQHWV4mhVrnYAPyCuEOiM/eC79DPHakCbQMQ Date: Mon, 13 Jul 2020 03:47:03 +0000 Message-ID: References: <20200527132326.1382-1-hemant.agrawal@nxp.com> <20200707092244.12791-1-hemant.agrawal@nxp.com> <20200707092244.12791-4-hemant.agrawal@nxp.com> <6088092.f3ReCXcs2Y@thomas> In-Reply-To: <6088092.f3ReCXcs2Y@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=nxp.com; x-originating-ip: [182.69.104.93] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: f433094d-b0c7-4ea3-78d3-08d826df67b6 x-ms-traffictypediagnostic: AM7PR04MB6872: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1468; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: bfTiSAZDQphF/WkdX+WxILHJDFQNE2pDQbOwmfkvsOk/VW5NpajHP1expnhRy/YhB0EfLENfjZx7oE5pM8gqigudcqR6yz2xqbbOKNmyU+yyI5rmZTiMRDDqhvhX5KN+9txeQC4/WCQQq39+jeu58x1Eei31MhvxuD3rfG1svuznepVAi4YEVmPMUMZTbgS7gldhSe3VN6ANhsFKiuCCOmbElrkjZXT5pRHGMnQN7zWr7vKbyFXCVklzbO4GWNnJcqgk7b/5fCvHbENibpbK8MXN0EbsqTeQJEuiZcnPogczpCMA2anx2bs5uzMbyT6N x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM6PR04MB4456.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(366004)(83380400001)(6636002)(498600001)(110136005)(4326008)(26005)(52536014)(186003)(71200400001)(54906003)(5660300002)(55016002)(9686003)(6506007)(53546011)(2906002)(44832011)(86362001)(7696005)(8676002)(33656002)(66476007)(76116006)(66556008)(64756008)(66446008)(66946007)(8936002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: Mc4yajpRKnNrH4H9JfKphn4e3JaklpBfGrYpmfDO/+HRJ21U2u2cZNqf5frzCkAr8Ewz3T1ZnVEgW4SPKHfErR+Jz2Yps5v2o2uSQAkMKxTTWegPVt7ZwgH/iAm9St0COJZcibWXNsfN4Kw7LhGKtrA5qiQEQj7U9zOf+/uMxQYUNChXDqtBbS0+MzIaAzM4pBpRlknaaJLxApFoy7xrkb0WhjpEdL439JxuYjFgaGNRigbvb6WynW90n1SAx97UIRoiCyvkYzHE98x12KUkJYLQMfiHP7op4j7g9BxrVJPkjetbjKDQe3eGAQmzQxSd+TqPAdqWP3ma8BEBs7PTnoTpF54Q8UACJZY9T4+6lSwLo90vUhoUjF1dZN21GSYQTsvsthelWf7Eqye9Ynwy+1kGiaNR1Yov1957HCy+CJ1tIWKkgS0R8rvv+LonLA/M8TqOCPvQ8y4TOnhUPAWjrQ3iOtifgjRhAZIsJM+5z2E= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB4456.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f433094d-b0c7-4ea3-78d3-08d826df67b6 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jul 2020 03:47:03.1300 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: sK5s/qoKvKfad83RdZrIsl9vNgPZx7B1jE+BIf1uwdsI8FvVLHR2Lln5djosK8UZ+aWmuhV96Q+pPeOV+WOQGQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB6872 Subject: Re: [dpdk-dev] [PATCH v2 03/29] net/dpaa2: enable timestamp for Rx offload case as well X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" -----Original Message----- From: Thomas Monjalon =20 Sent: Saturday, July 11, 2020 7:16 PM To: Gagandeep Singh ; Hemant Agrawal Cc: dev@dpdk.org; ferruh.yigit@intel.com Subject: Re: [dpdk-dev] [PATCH v2 03/29] net/dpaa2: enable timestamp for Rx= offload case as well Importance: High 07/07/2020 11:22, Hemant Agrawal: > From: Gagandeep Singh >=20 > This patch enables the packet timestamping conditionally when Rx=20 > offload is enabled for timestamp. >=20 > Signed-off-by: Gagandeep Singh > --- > drivers/net/dpaa2/dpaa2_ethdev.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c=20 > b/drivers/net/dpaa2/dpaa2_ethdev.c > index a1f19194d..8edd4b3cd 100644 > --- a/drivers/net/dpaa2/dpaa2_ethdev.c > +++ b/drivers/net/dpaa2/dpaa2_ethdev.c > @@ -524,8 +524,10 @@ dpaa2_eth_dev_configure(struct rte_eth_dev *dev) > return ret; > } > =20 > +#if !defined(RTE_LIBRTE_IEEE1588) > if (rx_offloads & DEV_RX_OFFLOAD_TIMESTAMP) > - dpaa2_enable_ts =3D true; > +#endif > + dpaa2_enable_ts =3D true; I don't understand this patch at all. There is no comment in the code, and the commit log is not very explanatory= . You are lucky Ferruh is less strict than me. I remember I already said I was bored of the lack of explanations in NXP dr= ivers. [Hemant] We will improve next time.=20 The patch description says: "> This patch enables the packet timestamping = conditionally when Rx=20 > offload is enabled for timestamp." It should be improved with - Enable the timestamping by default when IEEE15= 88 is enabled irrespective of offload flag.