From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0FADFA0093; Tue, 19 May 2020 08:43:51 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 757E51D54F; Tue, 19 May 2020 08:43:50 +0200 (CEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2060.outbound.protection.outlook.com [40.107.20.60]) by dpdk.org (Postfix) with ESMTP id EEDE61D446 for ; Tue, 19 May 2020 08:43:48 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jnJP0xbATtnCfkWnNPMCNHGbVd9SWMQCcPv+KGOwTvZbJx+SZ/JD8m/AnVsYPmcf03XkIpfdm794/oXcXYcRcfQpU2JhbxjAPWSwr5VTM1dGzoyoVl2kalINMmWPaJkrezkt4A4lpqSWim8j4H9CFkS7Gheyhl4FUd+Q6l3GEQZceXwGhLsVtTbtxG5Pw/DCPCryqWMjQ3156viWIshGDMYT3VXiymqutVOHhVC9/1p7Wk5j6xV/Fp/feqQxOzSiLLRju8DeXGjfrwLYJRu3WSUU72eoidMpZt/MY9CO9riZKFAr5D4LE4ht24ShuTyt1aIpmAnjCXkEb7wdBdLdcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=e0zQb9hCITbm+Z/mD1wHQci5FL384HukL46VTJ2954Q=; b=DpFhHlX9qIkCx9VJkIkVuuLFOomijqyhohO50MWZ7FaNPrB/OBA7Tf/qwRKo77QHV7CWCqrLevHNCJvTkQPhJcZ6ujhv6zkiLMsYR2zblDtGYKVw4AuNfAUTrrfbTr/gckvJd9vT0HdcrZtXCyDKWjzCOor8Muf+IVjf2rfuCHM7lhpRHjxeh95Jb+I/RWjSLJs8/Cg5C2EwMFrYjFaVFuFBPQ724/+WhwyYS8cUnch0B8ZpQtpd8wlwJE3+BJOBZU6pqh/muurawl8HLnIxS9dbbCG70bTAdQxEB+tKuRoY1XOIW6keTCxGgzGBigEOkkpMohLC1uvPY5zUoM0OAw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=e0zQb9hCITbm+Z/mD1wHQci5FL384HukL46VTJ2954Q=; b=sZP0Bu78qaidx9Z6BIJRyjvIBupDWhqtOUIqEMHw880raS6fU35h59yla1FUzH232/7CBsCM6MYLL2W6zLcGngsya9Gaez994MYaPfS+6Tpmjl1Nf8baIVo5HUmggNqmJXWUALKXLRn4lL0F5BwHp2m7Z3rDWBYJAmf59e+MSBk= Received: from AM6PR04MB4456.eurprd04.prod.outlook.com (2603:10a6:20b:22::25) by AM6PR04MB4039.eurprd04.prod.outlook.com (2603:10a6:209:4d::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.27; Tue, 19 May 2020 06:43:47 +0000 Received: from AM6PR04MB4456.eurprd04.prod.outlook.com ([fe80::52:2324:96c9:f3ae]) by AM6PR04MB4456.eurprd04.prod.outlook.com ([fe80::52:2324:96c9:f3ae%7]) with mapi id 15.20.3000.022; Tue, 19 May 2020 06:43:47 +0000 From: Hemant Agrawal To: Hemant Agrawal , "dev@dpdk.org" , "david.marchand@redhat.com" , "mdr@ashroe.eu" Thread-Topic: [PATCH v8 01/13] common/dpaax: move internal symbols into INTERNAL section Thread-Index: AQHWKp5AQPmDlwgRZE+I4Uwamih83aiu/E7w Date: Tue, 19 May 2020 06:43:47 +0000 Message-ID: References: <20200514132533.13752-1-hemant.agrawal@nxp.com> <20200515094752.28490-1-hemant.agrawal@nxp.com> <20200515094752.28490-2-hemant.agrawal@nxp.com> In-Reply-To: <20200515094752.28490-2-hemant.agrawal@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=none action=none header.from=nxp.com; x-originating-ip: [182.69.64.223] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 0b19bb9f-955c-44d0-b290-08d7fbbffbbc x-ms-traffictypediagnostic: AM6PR04MB4039: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1303; x-forefront-prvs: 040866B734 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: oRqUGK8GrIVQworjHHQG9QXyjEl3Rp1e6b/mf+pxzpHEpfBkKtCQHq4XdLk9L6qRxj7VoPyf/anLIb8SL2UDr8TnyGPtOH/Mi6goieCv5ASIQ4hyPygdjYge/meZ7qCa1uABoDjoaWCQ9ibrJPZPTpRMQWd+iKYMNCMHC+xM6cUWo0jRpZF54J8gephhihzdBQF+wS7vX3U69te7aBhNZURT3w5gcAHJpn71tudJL5ofk995EoYg75lvnRLKVijYGOr+mEoBjqEUIJpkLtO0js9WVvZY9N0juMRvOpHLbtP9HiRGd8biEwF4fF5Pzg9y5ibR7jTnOwi5g0D65zEzIZnNckieSIaGrOFU0u55PDkCaM2DC6vUptjrwXuRSzlNjvnC9LvSgghFQZm3PvVSZa1VQj1uxaHrcTQopX8TsGJZeJizdoOBV3gxUyLK1HPT x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM6PR04MB4456.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(376002)(346002)(366004)(396003)(136003)(39860400002)(26005)(52536014)(5660300002)(2906002)(186003)(33656002)(71200400001)(8936002)(8676002)(44832011)(478600001)(7696005)(9686003)(53546011)(6506007)(55016002)(110136005)(64756008)(316002)(66446008)(66946007)(66476007)(66556008)(76116006)(86362001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: XpvdXPpQnQi7LUQ3lPgf9CFToG8vbzKX9IShqFQl2Akx9TBRIMOOMXdwZpA0zgSA7Lrplnxuzi6Z76t5ZSyDUxadvd7O4VAM4Vl+xw3j9QHGCBHMpS7Xy5NbWS5zJBOLSfFkO8CvywNszfMORRfGAD/+fYFYGExvdY4QXHRh4iI8i1/M4KRIa9oVXXMf0maOgG+xwlz4BMvGo41pd2A2lnHSuYGKfmfEu5x2FS4ZLttnQkD+kZ329HytCq7EuaAEhswNVGKPoWVszBrN7ZoeDVKAE97DkUqWkk8ATI8SQCyAouZzQc+tr/s6krHzVNJi2SkebQs/m/e5ROVxbqzf7SHB5OUAHNLNJoGo6eV48UcyRfI0N9fe18K5qHROilTihgCmPGC+z27dCwldVovb1wpLB8DBKLBWtWqcvFZ44syHO1bLTvmDRC+pKQTCfiK3bT2bCZZQLMfgWFRoBQeMYLNBHqUNLeBx2Pv2n6yTp1dly5IlpjIHoF9M9aJUruDE Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0b19bb9f-955c-44d0-b290-08d7fbbffbbc X-MS-Exchange-CrossTenant-originalarrivaltime: 19 May 2020 06:43:47.5538 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 1I4R8MDaytkTEcVaViZ198SafGfM0pvPsWGDeuM/x5Twq/d/QH9Srx26do38d6lGVXscI5aUmEeXf+bkvVGBVw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB4039 Subject: Re: [dpdk-dev] [PATCH v8 01/13] common/dpaax: move internal symbols into INTERNAL section X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Ray, Will you please review and ack this series?. Regards, Hemant > -----Original Message----- > From: Hemant Agrawal > Sent: Friday, May 15, 2020 3:18 PM > To: dev@dpdk.org; david.marchand@redhat.com; mdr@ashroe.eu > Cc: Hemant Agrawal > Subject: [PATCH v8 01/13] common/dpaax: move internal symbols into > INTERNAL section > Importance: High >=20 > This patch moves the internal symbols to INTERNAL sections so that any > change in them is not reported as ABI breakage. >=20 > Signed-off-by: Hemant Agrawal > --- > devtools/libabigail.abignore | 3 +++ > drivers/common/dpaax/dpaa_of.h | 15 +++++++++++++++ > drivers/common/dpaax/dpaax_iova_table.h | 4 ++++ > drivers/common/dpaax/rte_common_dpaax_version.map | 6 ++++-- > 4 files changed, 26 insertions(+), 2 deletions(-) >=20 > diff --git a/devtools/libabigail.abignore b/devtools/libabigail.abignore = index > c9ee73cb3c..b1488d5549 100644 > --- a/devtools/libabigail.abignore > +++ b/devtools/libabigail.abignore > @@ -48,3 +48,6 @@ > changed_enumerators =3D RTE_CRYPTO_AEAD_LIST_END > [suppress_variable] > name =3D rte_crypto_aead_algorithm_strings > +; Ignore moving DPAAx stable functions to INTERNAL tag [suppress_file] > + file_name_regexp =3D ^librte_common_dpaax\. > diff --git a/drivers/common/dpaax/dpaa_of.h > b/drivers/common/dpaax/dpaa_of.h index 960b421766..38d91a1afe 100644 > --- a/drivers/common/dpaax/dpaa_of.h > +++ b/drivers/common/dpaax/dpaa_of.h > @@ -24,6 +24,7 @@ > #include > #include > #include > +#include >=20 > #ifndef OF_INIT_DEFAULT_PATH > #define OF_INIT_DEFAULT_PATH "/proc/device-tree" > @@ -102,6 +103,7 @@ struct dt_file { > uint64_t buf[OF_FILE_BUF_MAX >> 3]; > }; >=20 > +__rte_internal > const struct device_node *of_find_compatible_node( > const struct device_node *from, > const char *type __rte_unused, > @@ -113,32 +115,44 @@ const struct device_node > *of_find_compatible_node( > dev_node !=3D NULL; \ > dev_node =3D of_find_compatible_node(dev_node, type, > compatible)) >=20 > +__rte_internal > const void *of_get_property(const struct device_node *from, const char > *name, > size_t *lenp) __attribute__((nonnull(2))); > +__rte_internal > bool of_device_is_available(const struct device_node *dev_node); >=20 > + > +__rte_internal > const struct device_node *of_find_node_by_phandle(uint64_t ph); >=20 > +__rte_internal > const struct device_node *of_get_parent(const struct device_node > *dev_node); >=20 > +__rte_internal > const struct device_node *of_get_next_child(const struct device_node > *dev_node, > const struct device_node *prev); >=20 > +__rte_internal > const void *of_get_mac_address(const struct device_node *np); >=20 > #define for_each_child_node(parent, child) \ > for (child =3D of_get_next_child(parent, NULL); child !=3D NULL; \ > child =3D of_get_next_child(parent, child)) >=20 > + > +__rte_internal > uint32_t of_n_addr_cells(const struct device_node *dev_node); uint32_t > of_n_size_cells(const struct device_node *dev_node); >=20 > +__rte_internal > const uint32_t *of_get_address(const struct device_node *dev_node, size_= t > idx, > uint64_t *size, uint32_t *flags); >=20 > +__rte_internal > uint64_t of_translate_address(const struct device_node *dev_node, > const uint32_t *addr) __attribute__((nonnull)); >=20 > +__rte_internal > bool of_device_is_compatible(const struct device_node *dev_node, > const char *compatible); >=20 > @@ -146,6 +160,7 @@ bool of_device_is_compatible(const struct > device_node *dev_node, > * subsystem that is device-tree-dependent. Eg. Qman/Bman, config layers= , > etc. > * The path should usually be "/proc/device-tree". > */ > +__rte_internal > int of_init_path(const char *dt_path); >=20 > /* of_finish() allows a controlled tear-down of the device-tree layer, e= g. if a > diff --git a/drivers/common/dpaax/dpaax_iova_table.h > b/drivers/common/dpaax/dpaax_iova_table.h > index fc3b9e7a8f..230fba8ba0 100644 > --- a/drivers/common/dpaax/dpaax_iova_table.h > +++ b/drivers/common/dpaax/dpaax_iova_table.h > @@ -61,9 +61,13 @@ extern struct dpaax_iova_table *dpaax_iova_table_p; > #define DPAAX_MEM_SPLIT_MASK_OFF (DPAAX_MEM_SPLIT - 1) /**< Offset */ >=20 > /* APIs exposed */ > +__rte_internal > int dpaax_iova_table_populate(void); > +__rte_internal > void dpaax_iova_table_depopulate(void); > +__rte_internal > int dpaax_iova_table_update(phys_addr_t paddr, void *vaddr, size_t lengt= h); > +__rte_internal > void dpaax_iova_table_dump(void); >=20 > static inline void *dpaax_iova_table_get_va(phys_addr_t paddr) __rte_hot= ; > diff --git a/drivers/common/dpaax/rte_common_dpaax_version.map > b/drivers/common/dpaax/rte_common_dpaax_version.map > index f72eba761d..14b507ad13 100644 > --- a/drivers/common/dpaax/rte_common_dpaax_version.map > +++ b/drivers/common/dpaax/rte_common_dpaax_version.map > @@ -1,4 +1,8 @@ > DPDK_20.0 { > + local: *; > +}; > + > +INTERNAL { > global: >=20 > dpaax_iova_table_depopulate; > @@ -18,6 +22,4 @@ DPDK_20.0 { > of_init_path; > of_n_addr_cells; > of_translate_address; > - > - local: *; > }; > -- > 2.17.1