From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80070.outbound.protection.outlook.com [40.107.8.70]) by dpdk.org (Postfix) with ESMTP id 2A0901B129 for ; Wed, 3 Apr 2019 12:15:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TcK4GiMJ8fqH/l9z3dRASQ/aoegp4wRJv2plE686xLs=; b=chd7o085H/quFgrk2ZzCUhj5jFG8fRoprB/7I2a8rTPrkNFQiBbcL3isp8PE7vL30Z856aOxf4ykz5EPKFzrW5HaxsHxY2hiOSP2g7yLqLnzCFSAjj5rNE9oNH6E9Yh6BBU+Ot7xXl/szgkMCZc2bvXtNEhM9JJTWjNbI2cQT3o= Received: from AM6PR0502MB3797.eurprd05.prod.outlook.com (52.133.22.13) by AM6PR0502MB3958.eurprd05.prod.outlook.com (52.133.29.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1750.17; Wed, 3 Apr 2019 10:15:44 +0000 Received: from AM6PR0502MB3797.eurprd05.prod.outlook.com ([fe80::5db8:12bc:aff3:5048]) by AM6PR0502MB3797.eurprd05.prod.outlook.com ([fe80::5db8:12bc:aff3:5048%6]) with mapi id 15.20.1750.017; Wed, 3 Apr 2019 10:15:44 +0000 From: Shahaf Shuler To: Ori Kam , Matan Azrad , Yongseok Koh CC: "dev@dpdk.org" , Slava Ovsiienko Thread-Topic: [PATCH v2 1/3] net/mlx5: prepare Direct Verbs for Direct Rule Thread-Index: AQHU5YPmzgc93i1VpkyEu5+F+3y86aYqQQ1Q Date: Wed, 3 Apr 2019 10:15:44 +0000 Message-ID: References: <1553096315-91832-1-git-send-email-orika@mellanox.com> <1553790741-69362-1-git-send-email-orika@mellanox.com> <1553790741-69362-2-git-send-email-orika@mellanox.com> In-Reply-To: <1553790741-69362-2-git-send-email-orika@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 70e371c7-eff3-4d23-6819-08d6b81d555d x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600139)(711020)(4605104)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020); SRVR:AM6PR0502MB3958; x-ms-traffictypediagnostic: AM6PR0502MB3958: x-microsoft-antispam-prvs: x-forefront-prvs: 0996D1900D x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(136003)(376002)(346002)(39860400002)(366004)(396003)(189003)(199004)(81156014)(6246003)(11346002)(6116002)(476003)(99286004)(66066001)(9686003)(106356001)(229853002)(25786009)(5660300002)(3846002)(7696005)(52536014)(26005)(54906003)(110136005)(486006)(53936002)(8936002)(446003)(6436002)(6636002)(2906002)(107886003)(256004)(71200400001)(71190400001)(33656002)(68736007)(7736002)(316002)(76176011)(97736004)(4326008)(186003)(14454004)(102836004)(8676002)(105586002)(55016002)(81166006)(305945005)(6506007)(74316002)(86362001)(478600001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM6PR0502MB3958; H:AM6PR0502MB3797.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: QDyB/pWqOGOwsxsr0QAoM6uMEohhihtNEk6y6FmP9panEi6uFSssXeJ6fbDW7zWqtj+fSzrNyr9yCjoVHr0PCKMGoZPND42qgfKI2GA68ZZfTQVB0qv2qezNnZyKa4FoTCgdy4QMAO2V+rhLp+J3rwYwphyAPCT8toPoxh5LCvGZGBXsTWVyb0ass8sCfSdijm7kXgraBGwMqBPeiHwM1l9h/xXkjSCpr79Ac0OnDvfYqGJhQ9Ctsz2dGY2tsj8fGMqYYw6yt/GxI5rUvkRGZp1H48O8uDPakXZnDyaL+9joULMUhhM/R2QriAJvYfMvTOperitcLJ/gDB7899W1GgdfmKzgRrLJjV9ji41MGtD8zk0jsvuazeMySXrqIJAANiU0oFHLq5akaHEFvJr+scTPiirdKIhGxK3Dl2fsqic= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 70e371c7-eff3-4d23-6819-08d6b81d555d X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Apr 2019 10:15:44.4340 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR0502MB3958 Subject: Re: [dpdk-dev] [PATCH v2 1/3] net/mlx5: prepare Direct Verbs for Direct Rule X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Apr 2019 10:15:46 -0000 Thursday, March 28, 2019 6:33 PM, Ori Kam: > Subject: [PATCH v2 1/3] net/mlx5: prepare Direct Verbs for Direct Rule > --- a/drivers/net/mlx5/mlx5_glue.h > +++ b/drivers/net/mlx5/mlx5_glue.h > @@ -55,6 +55,10 @@ [...] > enum mlx5dv_flow_table_type { flow_table_type =3D 0, }; #endif >=20 > +#ifndef HAVE_IBV_FLOW_DEVX_COUNTERS > +#define MLX5DV_FLOW_ACTION_COUNTER_DEVX 0 #endif > + > #ifndef HAVE_IBV_DEVX_OBJ > struct mlx5dv_devx_obj; > #endif > @@ -98,7 +102,7 @@ struct mlx5_glue { > struct ibv_flow *(*create_flow)(struct ibv_qp *qp, > struct ibv_flow_attr *flow); > int (*destroy_flow)(struct ibv_flow *flow_id); > - int (*destroy_flow_action)(struct ibv_flow_action *action); > + int (*destroy_flow_action)(void *action); > struct ibv_qp *(*create_qp)(struct ibv_pd *pd, > struct ibv_qp_init_attr *qp_init_attr); > struct ibv_qp *(*create_qp_ex) > @@ -160,19 +164,17 @@ struct mlx5_glue { > int (*dv_destroy_flow_matcher)(struct mlx5dv_flow_matcher > *matcher); > struct ibv_flow *(*dv_create_flow)(struct mlx5dv_flow_matcher > *matcher, > struct mlx5dv_flow_match_parameters > *match_value, > - size_t num_actions, > - struct mlx5dv_flow_action_attr *actions_attr); > - struct ibv_flow_action *(*dv_create_flow_action_packet_reformat) > - (struct ibv_context *ctx, > - size_t data_sz, > - void *data, > + size_t num_actions, void *actions[]); > + void *(*dv_create_flow_action_counter)(void *obj, uint32_t > offset); > + void *(*dv_create_flow_action_dest_ibv_qp)(void *qp); > + void *(*dv_create_flow_action_modify_header) > + (struct ibv_context *ctx, size_t actions_sz, uint64_t actions[], > + enum mlx5dv_flow_table_type ft_type); > + void *(*dv_create_flow_action_packet_reformat) > + (struct ibv_context *ctx, size_t data_sz, void *data, > enum mlx5dv_flow_action_packet_reformat_type > reformat_type, > enum mlx5dv_flow_table_type ft_type); > - struct ibv_flow_action *(*dv_create_flow_action_modify_header) > - (struct ibv_context *ctx, > - size_t actions_sz, > - uint64_t actions[], > - enum mlx5dv_flow_table_type > ft_type); > + void *(*dv_create_flow_action_tag)(uint32_t tag); > struct ibv_context *(*dv_open_device)(struct ibv_device *device); > struct mlx5dv_devx_obj *(*devx_obj_create) > (struct ibv_context *ctx, Due to those changes you must bump up the LIB_GLUE_VERSION .=20 > -- > 1.8.3.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 4E9F9A0679 for ; Wed, 3 Apr 2019 12:15:49 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3F89F1B12D; Wed, 3 Apr 2019 12:15:48 +0200 (CEST) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80070.outbound.protection.outlook.com [40.107.8.70]) by dpdk.org (Postfix) with ESMTP id 2A0901B129 for ; Wed, 3 Apr 2019 12:15:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TcK4GiMJ8fqH/l9z3dRASQ/aoegp4wRJv2plE686xLs=; b=chd7o085H/quFgrk2ZzCUhj5jFG8fRoprB/7I2a8rTPrkNFQiBbcL3isp8PE7vL30Z856aOxf4ykz5EPKFzrW5HaxsHxY2hiOSP2g7yLqLnzCFSAjj5rNE9oNH6E9Yh6BBU+Ot7xXl/szgkMCZc2bvXtNEhM9JJTWjNbI2cQT3o= Received: from AM6PR0502MB3797.eurprd05.prod.outlook.com (52.133.22.13) by AM6PR0502MB3958.eurprd05.prod.outlook.com (52.133.29.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1750.17; Wed, 3 Apr 2019 10:15:44 +0000 Received: from AM6PR0502MB3797.eurprd05.prod.outlook.com ([fe80::5db8:12bc:aff3:5048]) by AM6PR0502MB3797.eurprd05.prod.outlook.com ([fe80::5db8:12bc:aff3:5048%6]) with mapi id 15.20.1750.017; Wed, 3 Apr 2019 10:15:44 +0000 From: Shahaf Shuler To: Ori Kam , Matan Azrad , Yongseok Koh CC: "dev@dpdk.org" , Slava Ovsiienko Thread-Topic: [PATCH v2 1/3] net/mlx5: prepare Direct Verbs for Direct Rule Thread-Index: AQHU5YPmzgc93i1VpkyEu5+F+3y86aYqQQ1Q Date: Wed, 3 Apr 2019 10:15:44 +0000 Message-ID: References: <1553096315-91832-1-git-send-email-orika@mellanox.com> <1553790741-69362-1-git-send-email-orika@mellanox.com> <1553790741-69362-2-git-send-email-orika@mellanox.com> In-Reply-To: <1553790741-69362-2-git-send-email-orika@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 70e371c7-eff3-4d23-6819-08d6b81d555d x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600139)(711020)(4605104)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020); SRVR:AM6PR0502MB3958; x-ms-traffictypediagnostic: AM6PR0502MB3958: x-microsoft-antispam-prvs: x-forefront-prvs: 0996D1900D x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(136003)(376002)(346002)(39860400002)(366004)(396003)(189003)(199004)(81156014)(6246003)(11346002)(6116002)(476003)(99286004)(66066001)(9686003)(106356001)(229853002)(25786009)(5660300002)(3846002)(7696005)(52536014)(26005)(54906003)(110136005)(486006)(53936002)(8936002)(446003)(6436002)(6636002)(2906002)(107886003)(256004)(71200400001)(71190400001)(33656002)(68736007)(7736002)(316002)(76176011)(97736004)(4326008)(186003)(14454004)(102836004)(8676002)(105586002)(55016002)(81166006)(305945005)(6506007)(74316002)(86362001)(478600001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM6PR0502MB3958; H:AM6PR0502MB3797.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: QDyB/pWqOGOwsxsr0QAoM6uMEohhihtNEk6y6FmP9panEi6uFSssXeJ6fbDW7zWqtj+fSzrNyr9yCjoVHr0PCKMGoZPND42qgfKI2GA68ZZfTQVB0qv2qezNnZyKa4FoTCgdy4QMAO2V+rhLp+J3rwYwphyAPCT8toPoxh5LCvGZGBXsTWVyb0ass8sCfSdijm7kXgraBGwMqBPeiHwM1l9h/xXkjSCpr79Ac0OnDvfYqGJhQ9Ctsz2dGY2tsj8fGMqYYw6yt/GxI5rUvkRGZp1H48O8uDPakXZnDyaL+9joULMUhhM/R2QriAJvYfMvTOperitcLJ/gDB7899W1GgdfmKzgRrLJjV9ji41MGtD8zk0jsvuazeMySXrqIJAANiU0oFHLq5akaHEFvJr+scTPiirdKIhGxK3Dl2fsqic= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 70e371c7-eff3-4d23-6819-08d6b81d555d X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Apr 2019 10:15:44.4340 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR0502MB3958 Subject: Re: [dpdk-dev] [PATCH v2 1/3] net/mlx5: prepare Direct Verbs for Direct Rule X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190403101544.6T8BvHexztIQJJx6XCnCootQ7YfFdwysvv3RfN400is@z> Thursday, March 28, 2019 6:33 PM, Ori Kam: > Subject: [PATCH v2 1/3] net/mlx5: prepare Direct Verbs for Direct Rule > --- a/drivers/net/mlx5/mlx5_glue.h > +++ b/drivers/net/mlx5/mlx5_glue.h > @@ -55,6 +55,10 @@ [...] > enum mlx5dv_flow_table_type { flow_table_type =3D 0, }; #endif >=20 > +#ifndef HAVE_IBV_FLOW_DEVX_COUNTERS > +#define MLX5DV_FLOW_ACTION_COUNTER_DEVX 0 #endif > + > #ifndef HAVE_IBV_DEVX_OBJ > struct mlx5dv_devx_obj; > #endif > @@ -98,7 +102,7 @@ struct mlx5_glue { > struct ibv_flow *(*create_flow)(struct ibv_qp *qp, > struct ibv_flow_attr *flow); > int (*destroy_flow)(struct ibv_flow *flow_id); > - int (*destroy_flow_action)(struct ibv_flow_action *action); > + int (*destroy_flow_action)(void *action); > struct ibv_qp *(*create_qp)(struct ibv_pd *pd, > struct ibv_qp_init_attr *qp_init_attr); > struct ibv_qp *(*create_qp_ex) > @@ -160,19 +164,17 @@ struct mlx5_glue { > int (*dv_destroy_flow_matcher)(struct mlx5dv_flow_matcher > *matcher); > struct ibv_flow *(*dv_create_flow)(struct mlx5dv_flow_matcher > *matcher, > struct mlx5dv_flow_match_parameters > *match_value, > - size_t num_actions, > - struct mlx5dv_flow_action_attr *actions_attr); > - struct ibv_flow_action *(*dv_create_flow_action_packet_reformat) > - (struct ibv_context *ctx, > - size_t data_sz, > - void *data, > + size_t num_actions, void *actions[]); > + void *(*dv_create_flow_action_counter)(void *obj, uint32_t > offset); > + void *(*dv_create_flow_action_dest_ibv_qp)(void *qp); > + void *(*dv_create_flow_action_modify_header) > + (struct ibv_context *ctx, size_t actions_sz, uint64_t actions[], > + enum mlx5dv_flow_table_type ft_type); > + void *(*dv_create_flow_action_packet_reformat) > + (struct ibv_context *ctx, size_t data_sz, void *data, > enum mlx5dv_flow_action_packet_reformat_type > reformat_type, > enum mlx5dv_flow_table_type ft_type); > - struct ibv_flow_action *(*dv_create_flow_action_modify_header) > - (struct ibv_context *ctx, > - size_t actions_sz, > - uint64_t actions[], > - enum mlx5dv_flow_table_type > ft_type); > + void *(*dv_create_flow_action_tag)(uint32_t tag); > struct ibv_context *(*dv_open_device)(struct ibv_device *device); > struct mlx5dv_devx_obj *(*devx_obj_create) > (struct ibv_context *ctx, Due to those changes you must bump up the LIB_GLUE_VERSION .=20 > -- > 1.8.3.1