From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30042.outbound.protection.outlook.com [40.107.3.42]) by dpdk.org (Postfix) with ESMTP id 52E571B373 for ; Mon, 12 Feb 2018 23:34:57 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=z8WOTSn7Cyki9OrmKN1R83lnvMpjdXtoYqDE5hwuNqI=; b=H/RCvtair4unLShcTNwv4CCqFE375T8Cv5uZC2fvvDt9em/BWqZ7UZl/M9cxF6SaFs7noI+L8+Q7A56UJ52O/NQW8f/RWMe2E6nBAF+9oshq3TeQwElhmVOwlnTaYmiTR2R08Tx8eTEPcYc4jeInA+1/kc4VyU9tUu3bbSbQ9Kg= Received: from AM6PR0502MB3877.eurprd05.prod.outlook.com (52.133.21.150) by AM6PR0502MB3752.eurprd05.prod.outlook.com (52.133.21.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.485.10; Mon, 12 Feb 2018 22:34:55 +0000 Received: from AM6PR0502MB3877.eurprd05.prod.outlook.com ([fe80::7575:9817:baa7:6c41]) by AM6PR0502MB3877.eurprd05.prod.outlook.com ([fe80::7575:9817:baa7:6c41%13]) with mapi id 15.20.0485.015; Mon, 12 Feb 2018 22:34:55 +0000 From: Ophir Munk To: Thomas Monjalon CC: "dev@dpdk.org" , Pascal Mazon , "Olga Shern" Thread-Topic: [dpdk-stable] [PATCH v1] net/tap: fix CRC stripping capability report Thread-Index: AQHTpA/cya9eQkC2kkOimJf6vvdEmaOhDS4AgABN/LA= Date: Mon, 12 Feb 2018 22:34:55 +0000 Message-ID: References: <1518446598-24238-1-git-send-email-ophirmu@mellanox.com> <5072632.Aql229SuCI@xps> In-Reply-To: <5072632.Aql229SuCI@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=ophirmu@mellanox.com; x-originating-ip: [89.139.41.242] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM6PR0502MB3752; 7:FP2mPDPbO0zs8W5n2IROmxvOTVdmG9QnQd/yxxZZfoJ3WwuH8+PJywM3PHCO+YT2IQdS+kTj28TgFFbpZCdNjarObh519+sIi4UvF57vPviBKAYUFIr0P1diHkpWMaCP6uSfkTFT7GAOpcb/D1NhTJEIdwyBgEetdFE6jZwUxWhdYXBMxY2vHBglzUhLW/tZM0b6Ccsue+MnVDI7Ts4G5/bw2MNz1GEK7uOAm1ugfXpea5WR6vaIupsw9cjbndvH x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 17bd7de9-f0b3-42f1-f1ce-08d57268d717 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(3008032)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603307)(7153060)(7193020); SRVR:AM6PR0502MB3752; x-ms-traffictypediagnostic: AM6PR0502MB3752: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(20558992708506); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040501)(2401047)(8121501046)(5005006)(3002001)(10201501046)(3231101)(944501161)(93006095)(93001095)(6055026)(6041288)(20161123564045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123562045)(6072148)(201708071742011); SRVR:AM6PR0502MB3752; BCL:0; PCL:0; RULEID:; SRVR:AM6PR0502MB3752; x-forefront-prvs: 0581B5AB35 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(346002)(39860400002)(39380400002)(366004)(376002)(13464003)(189003)(199004)(68736007)(81156014)(316002)(81166006)(305945005)(8936002)(5250100002)(229853002)(14454004)(8676002)(2900100001)(186003)(26005)(6916009)(3660700001)(99286004)(74316002)(4326008)(3846002)(86362001)(3280700002)(6116002)(5660300001)(6436002)(575784001)(7736002)(105586002)(55016002)(106356001)(76176011)(25786009)(53546011)(102836004)(2906002)(6506007)(6246003)(478600001)(107886003)(97736004)(66066001)(2950100002)(54906003)(7696005)(53936002)(9686003)(33656002)(168613001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM6PR0502MB3752; H:AM6PR0502MB3877.eurprd05.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: SqYrL0IRfxxM8nYsML0OQjoTN6oxwTRQVIwh+tfTGHHqIaK7/VPW3H3JfuAEqET6DYf5PwTwJHgBMuEIqeu4Ng== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 17bd7de9-f0b3-42f1-f1ce-08d57268d717 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Feb 2018 22:34:55.2379 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR0502MB3752 Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v1] net/tap: fix CRC stripping capability report X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Feb 2018 22:34:57 -0000 Will issue v2 with commit message updated > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Monday, February 12, 2018 7:55 PM > To: Ophir Munk > Cc: dev@dpdk.org; Pascal Mazon ; Olga Shern > > Subject: Re: [dpdk-stable] [PATCH v1] net/tap: fix CRC stripping capabili= ty > report >=20 > The title should be "add CRC stripping capability". >=20 > 12/02/2018 15:43, Ophir Munk: > > CRC stripping is executed outside of TAP PMD scope. There is no > > prevention that TAP reports on Rx CRC stripping capability. >=20 > We could mention that the CRC stripping is done in the kernel. >=20 > > It is especially required when TAP is operating as failsafe sub-device > > with another PCI sub-device which supports CRC stripping. > > In the corrupted code TAP did not report on this capability which > > caused failsafe to not report on it as well. >=20 > You discover the bug with failsafe but it is not related at all. > I think you squeeze this part of the explanation. >=20 > > The fix is for TAP to report that Rx CRC stripping is supported. > > > > Fixes: 95ae196ae10b ("net/tap: use new Rx offloads API") >=20 > I don't think it is a root cause. > This capability is missing from day one: > Fixes: 02f96a0a82d1 ("net/tap: add TUN/TAP device PMD") >=20 > > Cc: stable@dpdk.org > > > > Signed-off-by: Ophir Munk