From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50075.outbound.protection.outlook.com [40.107.5.75]) by dpdk.org (Postfix) with ESMTP id 8DC935A for ; Tue, 2 Apr 2019 11:03:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KNPr9JJeQAfqOJXCaokH6NKFLlazl8zQisNaFI9wsok=; b=WEqfbt4n0+MtqkendEz5CYahRnDR6mWWQOJ6ckmtZXX4M+InbRv6jM11b9UmFh92FsyWTo1QH0SLnKuVUbr+SxJpoUpVSZnQRWkLNgS+nzGGBbL8Pzq7GEO7H+MklOALDKRf1M64nI5gpVC46zrhllNv/lu/uSYVS3Wq+7BzslY= Received: from AM6PR05MB4405.eurprd05.prod.outlook.com (52.135.163.23) by AM6PR05MB4470.eurprd05.prod.outlook.com (52.135.162.155) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1750.22; Tue, 2 Apr 2019 09:03:16 +0000 Received: from AM6PR05MB4405.eurprd05.prod.outlook.com ([fe80::edb9:6ee3:cd08:b3f2]) by AM6PR05MB4405.eurprd05.prod.outlook.com ([fe80::edb9:6ee3:cd08:b3f2%6]) with mapi id 15.20.1750.017; Tue, 2 Apr 2019 09:03:16 +0000 From: Ali Alnubani To: Pavan Nikhilesh Bhagavatula CC: "dev@dpdk.org" , Jerin Jacob Kollanukkaran , Thomas Monjalon , "arybchenko@solarflare.com" , "ferruh.yigit@intel.com" , "bernard.iremonger@intel.com" Thread-Topic: [dpdk-dev] [PATCH v5 1/2] app/testpmd: optimize testpmd txonly mode Thread-Index: AQHU58OyW3tsNCt3+kWkYjTNS0cbsqYolbTg Date: Tue, 2 Apr 2019 09:03:15 +0000 Message-ID: References: <20190228194128.14236-1-pbhagavatula@marvell.com> <20190331131341.12924-1-pbhagavatula@marvell.com> In-Reply-To: <20190331131341.12924-1-pbhagavatula@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=alialnu@mellanox.com; x-originating-ip: [82.213.2.186] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 92468eb3-3715-48c3-8268-08d6b74a0b08 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600139)(711020)(4605104)(4618075)(2017052603328)(7193020); SRVR:AM6PR05MB4470; x-ms-traffictypediagnostic: AM6PR05MB4470: x-ms-exchange-purlcount: 1 x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-forefront-prvs: 0995196AA2 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(136003)(396003)(346002)(376002)(39860400002)(366004)(199004)(189003)(13464003)(2906002)(97736004)(33656002)(66066001)(256004)(102836004)(76176011)(6506007)(53546011)(68736007)(6916009)(3846002)(6436002)(6116002)(229853002)(14454004)(71190400001)(71200400001)(478600001)(25786009)(9686003)(7696005)(105586002)(106356001)(53936002)(476003)(446003)(74316002)(11346002)(86362001)(486006)(54906003)(26005)(6246003)(186003)(81156014)(316002)(52536014)(55016002)(81166006)(4326008)(8676002)(7736002)(5660300002)(99286004)(305945005)(8936002)(6306002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM6PR05MB4470; H:AM6PR05MB4405.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: s9L07rfPgn1tvoYW6skB7HCfAGQNPfr3PL+VaY0gGTtDyd5U1CyKMgoHEkzCRJ0HuUtwf/naJohSfM7eT0KKXu0nNxmHffm/KizURbZ5gRey3I00rlNdp6A03FFM8qp7CpAnm3egshYk4mXbd6PNVr2bqTVifM14yiH8UUzueZ/DtSVZ3ye4ZMDPy1pF79JKHy5B8S2rqS0NrfB0ih7K2luD28rbOzbzVPziEUFon0ZAbbqfid6IDi8HhBcrw76ELa2qlpwajJmd9R17m886B3jNFA+Ffcqt75sR7LSdSdaghAj0MGG/ce7y3WMQjtghYfvVtv5X7+vvOvP3T1iKvcK/OCj4HBVFtX/nMClVWM1V5v5afbSP0NHMRJasIaTbbBjoLwfYoplD6zTsTlXCmqAdlDS1s12hELRj0Fh/dlE= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 92468eb3-3715-48c3-8268-08d6b74a0b08 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Apr 2019 09:03:15.8332 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR05MB4470 Subject: Re: [dpdk-dev] [PATCH v5 1/2] app/testpmd: optimize testpmd txonly mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Apr 2019 09:03:18 -0000 Hi Pavan, > -----Original Message----- > From: dev On Behalf Of Pavan Nikhilesh > Bhagavatula > Sent: Sunday, March 31, 2019 4:14 PM > To: Jerin Jacob Kollanukkaran ; Thomas Monjalon > ; arybchenko@solarflare.com; > ferruh.yigit@intel.com; bernard.iremonger@intel.com > Cc: dev@dpdk.org; Pavan Nikhilesh Bhagavatula > > Subject: [dpdk-dev] [PATCH v5 1/2] app/testpmd: optimize testpmd txonly > mode >=20 > From: Pavan Nikhilesh >=20 > Optimize testpmd txonly mode by > 1. Moving per packet ethernet header copy above the loop. > 2. Use bulk ops for allocating segments instead of having a inner loop fo= r > every segment. >=20 > Also, move the packet prepare logic into a separate function so that it c= an be > reused later. >=20 > Signed-off-by: Pavan Nikhilesh > --- > v5 Changes > - Remove unnecessary change to struct rte_port *txp (movement). > (Bernard) >=20 > v4 Changes: > - Fix packet len calculation. >=20 > v3 Changes: > - Split the patches for easier review. (Thomas) > - Remove unnecessary assignments to 0. (Bernard) >=20 > v2 Changes: > - Use bulk ops for fetching segments. (Andrew Rybchenko) > - Fallback to rte_mbuf_raw_alloc if bulk get fails. (Andrew Rybchenko) > - Fix mbufs not being freed when there is no more mbufs available for > segments. (Andrew Rybchenko) >=20 > app/test-pmd/txonly.c | 139 +++++++++++++++++++++++------------------- > 1 file changed, 76 insertions(+), 63 deletions(-) >=20 The patch doesn't apply. It conflicts with 82010ef55 app/testpmd: make txon= ly mode generate multiple flows (http://patches.dpdk.org/patch/51869/). Can you please rebase? Thanks, Ali From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id EB224A0679 for ; Tue, 2 Apr 2019 11:03:18 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B282A11A4; Tue, 2 Apr 2019 11:03:18 +0200 (CEST) Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50075.outbound.protection.outlook.com [40.107.5.75]) by dpdk.org (Postfix) with ESMTP id 8DC935A for ; Tue, 2 Apr 2019 11:03:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KNPr9JJeQAfqOJXCaokH6NKFLlazl8zQisNaFI9wsok=; b=WEqfbt4n0+MtqkendEz5CYahRnDR6mWWQOJ6ckmtZXX4M+InbRv6jM11b9UmFh92FsyWTo1QH0SLnKuVUbr+SxJpoUpVSZnQRWkLNgS+nzGGBbL8Pzq7GEO7H+MklOALDKRf1M64nI5gpVC46zrhllNv/lu/uSYVS3Wq+7BzslY= Received: from AM6PR05MB4405.eurprd05.prod.outlook.com (52.135.163.23) by AM6PR05MB4470.eurprd05.prod.outlook.com (52.135.162.155) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1750.22; Tue, 2 Apr 2019 09:03:16 +0000 Received: from AM6PR05MB4405.eurprd05.prod.outlook.com ([fe80::edb9:6ee3:cd08:b3f2]) by AM6PR05MB4405.eurprd05.prod.outlook.com ([fe80::edb9:6ee3:cd08:b3f2%6]) with mapi id 15.20.1750.017; Tue, 2 Apr 2019 09:03:16 +0000 From: Ali Alnubani To: Pavan Nikhilesh Bhagavatula CC: "dev@dpdk.org" , Jerin Jacob Kollanukkaran , Thomas Monjalon , "arybchenko@solarflare.com" , "ferruh.yigit@intel.com" , "bernard.iremonger@intel.com" Thread-Topic: [dpdk-dev] [PATCH v5 1/2] app/testpmd: optimize testpmd txonly mode Thread-Index: AQHU58OyW3tsNCt3+kWkYjTNS0cbsqYolbTg Date: Tue, 2 Apr 2019 09:03:15 +0000 Message-ID: References: <20190228194128.14236-1-pbhagavatula@marvell.com> <20190331131341.12924-1-pbhagavatula@marvell.com> In-Reply-To: <20190331131341.12924-1-pbhagavatula@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=alialnu@mellanox.com; x-originating-ip: [82.213.2.186] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 92468eb3-3715-48c3-8268-08d6b74a0b08 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600139)(711020)(4605104)(4618075)(2017052603328)(7193020); SRVR:AM6PR05MB4470; x-ms-traffictypediagnostic: AM6PR05MB4470: x-ms-exchange-purlcount: 1 x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-forefront-prvs: 0995196AA2 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(136003)(396003)(346002)(376002)(39860400002)(366004)(199004)(189003)(13464003)(2906002)(97736004)(33656002)(66066001)(256004)(102836004)(76176011)(6506007)(53546011)(68736007)(6916009)(3846002)(6436002)(6116002)(229853002)(14454004)(71190400001)(71200400001)(478600001)(25786009)(9686003)(7696005)(105586002)(106356001)(53936002)(476003)(446003)(74316002)(11346002)(86362001)(486006)(54906003)(26005)(6246003)(186003)(81156014)(316002)(52536014)(55016002)(81166006)(4326008)(8676002)(7736002)(5660300002)(99286004)(305945005)(8936002)(6306002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM6PR05MB4470; H:AM6PR05MB4405.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: s9L07rfPgn1tvoYW6skB7HCfAGQNPfr3PL+VaY0gGTtDyd5U1CyKMgoHEkzCRJ0HuUtwf/naJohSfM7eT0KKXu0nNxmHffm/KizURbZ5gRey3I00rlNdp6A03FFM8qp7CpAnm3egshYk4mXbd6PNVr2bqTVifM14yiH8UUzueZ/DtSVZ3ye4ZMDPy1pF79JKHy5B8S2rqS0NrfB0ih7K2luD28rbOzbzVPziEUFon0ZAbbqfid6IDi8HhBcrw76ELa2qlpwajJmd9R17m886B3jNFA+Ffcqt75sR7LSdSdaghAj0MGG/ce7y3WMQjtghYfvVtv5X7+vvOvP3T1iKvcK/OCj4HBVFtX/nMClVWM1V5v5afbSP0NHMRJasIaTbbBjoLwfYoplD6zTsTlXCmqAdlDS1s12hELRj0Fh/dlE= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 92468eb3-3715-48c3-8268-08d6b74a0b08 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Apr 2019 09:03:15.8332 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR05MB4470 Subject: Re: [dpdk-dev] [PATCH v5 1/2] app/testpmd: optimize testpmd txonly mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190402090315.My7jgpwXz9NUJQj-rcAuOQUcsZn1R2GGOPteKGvg7Tc@z> Hi Pavan, > -----Original Message----- > From: dev On Behalf Of Pavan Nikhilesh > Bhagavatula > Sent: Sunday, March 31, 2019 4:14 PM > To: Jerin Jacob Kollanukkaran ; Thomas Monjalon > ; arybchenko@solarflare.com; > ferruh.yigit@intel.com; bernard.iremonger@intel.com > Cc: dev@dpdk.org; Pavan Nikhilesh Bhagavatula > > Subject: [dpdk-dev] [PATCH v5 1/2] app/testpmd: optimize testpmd txonly > mode >=20 > From: Pavan Nikhilesh >=20 > Optimize testpmd txonly mode by > 1. Moving per packet ethernet header copy above the loop. > 2. Use bulk ops for allocating segments instead of having a inner loop fo= r > every segment. >=20 > Also, move the packet prepare logic into a separate function so that it c= an be > reused later. >=20 > Signed-off-by: Pavan Nikhilesh > --- > v5 Changes > - Remove unnecessary change to struct rte_port *txp (movement). > (Bernard) >=20 > v4 Changes: > - Fix packet len calculation. >=20 > v3 Changes: > - Split the patches for easier review. (Thomas) > - Remove unnecessary assignments to 0. (Bernard) >=20 > v2 Changes: > - Use bulk ops for fetching segments. (Andrew Rybchenko) > - Fallback to rte_mbuf_raw_alloc if bulk get fails. (Andrew Rybchenko) > - Fix mbufs not being freed when there is no more mbufs available for > segments. (Andrew Rybchenko) >=20 > app/test-pmd/txonly.c | 139 +++++++++++++++++++++++------------------- > 1 file changed, 76 insertions(+), 63 deletions(-) >=20 The patch doesn't apply. It conflicts with 82010ef55 app/testpmd: make txon= ly mode generate multiple flows (http://patches.dpdk.org/patch/51869/). Can you please rebase? Thanks, Ali