From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5491CA00C2; Wed, 22 Apr 2020 23:36:24 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 325861C24B; Wed, 22 Apr 2020 23:36:23 +0200 (CEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2051.outbound.protection.outlook.com [40.107.20.51]) by dpdk.org (Postfix) with ESMTP id B43181C13B for ; Wed, 22 Apr 2020 23:36:21 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=USUkjYo+bpcdiyGDCgw805Cn1qWjxlLFvAa4GmcjuHsby1GJn4/YNvw2Ugo58E6Enmw1zAJ/GgAjtRRffFm//eeZIng2fM8agT531ScHqFJz4G8Am+VySV8/qHCve3u0wp+a/Erht8qzjKnmQ9+Px+KuVb9gEK1o0uH39ZqJoMyuE5MQhEKu9moF9cg/q7W4DIX1V8wW6wppBohk1OSbHIq789VgrIB5p3yorYEQAVsC5ouJrBrV5/d9tBFE7H0hdIIwZuVdmk5RqT+6rqQHJCgwCe+cXFvtmj1LUDhN2HDGuV1R2b31EhuHkUaavHALm8rwyMegLOlxFUg3EZnfKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LOsgwqcbBsTTkgVDObPYDTl0eIQ1RP4/EnzlWw6Zh0Y=; b=cfSmvTcDaASNbEER20MxVWezsR3yVOA9UQdRRx+rVl0tIrNP/SEpZBSPq5iQ4a4nIfaHbsdpgeDJtiEQmBDctzMiDW4x72Tv3HRLCJ4f69b9i2TgPIsN490kxd5HifnOxCmfJkwtKJ6OUZ2aF8TvezM8yteMSz2FL8KpUqdIZdSXxIxFB7fxLmE0LvqfQrpJZaTPSAjl7wPua8lPmnKnaF1jCJemv+JVo08HfUPbdE4MdoJjt6q1luLCBDGSjwk/YyAdMNWLKLx2cX5Zc+TJL/CFFNDvm840qA2dtxRcFxrFQXNJkbXpYLNuOSJAqQlocMvHfo1P7lhkVR80O6l+UQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LOsgwqcbBsTTkgVDObPYDTl0eIQ1RP4/EnzlWw6Zh0Y=; b=b4KFU7LXw3n82MS/brzya6NWlvuxmjz+ZFL6FMBlKpHxvsRRjNNiwUr411RcMBe9ikrdKKFKVw9meKh4m8SffKqBHzxR9d3iks2coKDATrTpqnxzr5qGY0Ktmsl0ggQQQV43RP1A1adjVWwo4o1PaHeJmlV99wg+q2DzuydDbbc= Received: from AM6PR05MB5176.eurprd05.prod.outlook.com (2603:10a6:20b:63::30) by AM6PR05MB6328.eurprd05.prod.outlook.com (2603:10a6:20b:b6::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2921.29; Wed, 22 Apr 2020 21:36:20 +0000 Received: from AM6PR05MB5176.eurprd05.prod.outlook.com ([fe80::f5cd:b10f:5f1b:4b22]) by AM6PR05MB5176.eurprd05.prod.outlook.com ([fe80::f5cd:b10f:5f1b:4b22%7]) with mapi id 15.20.2937.012; Wed, 22 Apr 2020 21:36:20 +0000 From: Ori Kam To: Guy Kaneti , Thomas Monjalon , Jerin Jacob Kollanukkaran , "xiang.w.wang@intel.com" , Pavan Nikhilesh Bhagavatula CC: "dev@dpdk.org" , Shahaf Shuler , "hemant.agrawal@nxp.com" , Opher Reviv , Alex Rosenbaum , Dovrat Zifroni , Prasun Kapoor , "nipun.gupta@nxp.com" , "bruce.richardson@intel.com" , "yang.a.hong@intel.com" , "harry.chang@intel.com" , "gu.jian1@zte.com.cn" , "shanjiangh@chinatelecom.cn" , "zhangy.yun@chinatelecom.cn" , "lixingfu@huachentel.com" , "wushuai@inspur.com" , "yuyingxia@yxlink.com" , "fanchenggang@sunyainfo.com" , "davidfgao@tencent.com" , "liuzhong1@chinaunicom.cn" , "zhaoyong11@huawei.com" , "oc@yunify.com" , "jim@netgate.com" , "hongjun.ni@intel.com" , "j.bromhead@titan-ic.com" , "deri@ntop.org" , "fc@napatech.com" , "arthur.su@lionic.com" , Parav Pandit Thread-Topic: [dpdk-dev] [EXT] [PATCH v1 3/4] regexdev: add regexdev core functions Thread-Index: AQHWFjbgxS5vKKLgw0emBJMEx66G/qiFnyAQ Date: Wed, 22 Apr 2020 21:36:19 +0000 Message-ID: References: <1585464438-111285-1-git-send-email-orika@mellanox.com> <2061995.157zFVKu8G@xps> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=orika@mellanox.com; x-originating-ip: [89.208.130.33] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: e41c0b08-1e0d-486d-fbcd-08d7e7053244 x-ms-traffictypediagnostic: AM6PR05MB6328:|AM6PR05MB6328: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6108; x-forefront-prvs: 03818C953D x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM6PR05MB5176.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10009020)(4636009)(376002)(366004)(136003)(346002)(396003)(39860400002)(186003)(52536014)(478600001)(5660300002)(33656002)(316002)(26005)(53546011)(107886003)(2906002)(6506007)(110136005)(54906003)(7416002)(7406005)(7696005)(86362001)(8936002)(71200400001)(76116006)(66556008)(66476007)(66946007)(64756008)(66446008)(81156014)(9686003)(55016002)(4326008); DIR:OUT; SFP:1101; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: MHLEr1xqFRHXX3sv+KOd6+YEdmORIR/mPn+Y/mOl0wK1YoudWQtZLfr9gTBHivZ9opguMt8NtTnvipEMFNyUS4njGNU6owcGRY3OpCfut4+Drcajw4x68V/U1uwNVrTYcfPwMyZM/kYxLDVhId2A3ZKcBEV3GkxNCvzZo4jKSI5X+KZGOKvC6iGQ4PNeBTALuVvKh75K1UVKJ1OECuY4xug9vQ/L/PxS/lS0aBvjpNGELXi8hdGuLd58bm/41F6iXbYQBwFEjYtDfKWbY/UFWyTEXy4hpJmY/AIxMYHgHhgqdVXmjmf3mnsDp8hHn1Gay3lUCgITAc20iGDlCtorRJDzBu4QuwmM8VJDxuSc3D0zwpsVM8ONcvIWlDUnQ6OZMl5JL6V5RlUCveI4le0C7IAyEQlmnNVPGM3EOe9KgI58pqMr6RiBKRBrMn/JjmVT x-ms-exchange-antispam-messagedata: 6/OAXMoP04KvGee4gTtfug0+O63Dqz78+Q2m5sOldVO0Y+OyoypVU8Sdw4NBOH3bWpXs84Uh4rcAOjfSSjNI6m4wr76QO2Yz4cFwCMrASTtgMO83k8yjMDw3d51fsecUBMcVl0sthXUwsTZ9jMYICQ== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: e41c0b08-1e0d-486d-fbcd-08d7e7053244 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Apr 2020 21:36:19.8570 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: OknKAA6yF1oQ4ncQcQkP07+LkPbBEzlXuwjdsMNUcWBZRagSkIkbirVWL4EmclXsIuC8TQjjielbr2fbFDWx8w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR05MB6328 Subject: Re: [dpdk-dev] [EXT] [PATCH v1 3/4] regexdev: add regexdev core functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Guy, > -----Original Message----- > From: dev On Behalf Of Guy Kaneti > Sent: Sunday, April 19, 2020 1:39 PM > To: Ori Kam ; Thomas Monjalon > ; Jerin Jacob Kollanukkaran ; > xiang.w.wang@intel.com; Pavan Nikhilesh Bhagavatula > > Cc: dev@dpdk.org; Shahaf Shuler ; > hemant.agrawal@nxp.com; Opher Reviv ; Alex > Rosenbaum ; Dovrat Zifroni ; > Prasun Kapoor ; nipun.gupta@nxp.com; > bruce.richardson@intel.com; yang.a.hong@intel.com; harry.chang@intel.com; > gu.jian1@zte.com.cn; shanjiangh@chinatelecom.cn; > zhangy.yun@chinatelecom.cn; lixingfu@huachentel.com; wushuai@inspur.com; > yuyingxia@yxlink.com; fanchenggang@sunyainfo.com; > davidfgao@tencent.com; liuzhong1@chinaunicom.cn; > zhaoyong11@huawei.com; oc@yunify.com; jim@netgate.com; > hongjun.ni@intel.com; j.bromhead@titan-ic.com; deri@ntop.org; > fc@napatech.com; arthur.su@lionic.com; Parav Pandit > Subject: Re: [dpdk-dev] [EXT] [PATCH v1 3/4] regexdev: add regexdev core > functions >=20 >=20 >=20 > > -----Original Message----- > > From: dev On Behalf Of Ori Kam > > Sent: Wednesday, April 08, 2020 11:40 AM > > To: Thomas Monjalon ; Jerin Jacob Kollanukkaran > > ; xiang.w.wang@intel.com; Pavan Nikhilesh > > Bhagavatula > > Cc: dev@dpdk.org; Shahaf Shuler ; > > hemant.agrawal@nxp.com; Opher Reviv ; Alex > > Rosenbaum ; Dovrat Zifroni ; > > Prasun Kapoor ; nipun.gupta@nxp.com; > > bruce.richardson@intel.com; yang.a.hong@intel.com; > > harry.chang@intel.com; gu.jian1@zte.com.cn; shanjiangh@chinatelecom.cn; > > zhangy.yun@chinatelecom.cn; lixingfu@huachentel.com; > > wushuai@inspur.com; yuyingxia@yxlink.com; > > fanchenggang@sunyainfo.com; davidfgao@tencent.com; > > liuzhong1@chinaunicom.cn; zhaoyong11@huawei.com; oc@yunify.com; > > jim@netgate.com; hongjun.ni@intel.com; j.bromhead@titan-ic.com; > > deri@ntop.org; fc@napatech.com; arthur.su@lionic.com; Parav Pandit > > > > Subject: Re: [dpdk-dev] [EXT] [PATCH v1 3/4] regexdev: add regexdev cor= e > > functions > > > > > > > > > -----Original Message----- > > > From: dev On Behalf Of Thomas Monjalon > > > Sent: Monday, April 6, 2020 4:30 PM > > > To: Ori Kam ; Jerin Jacob Kollanukkaran > > > ; xiang.w.wang@intel.com; Pavan Nikhilesh > > > Bhagavatula > > > Cc: dev@dpdk.org; Shahaf Shuler ; > > > hemant.agrawal@nxp.com; Opher Reviv ; Alex > > > Rosenbaum ; Dovrat Zifroni > > ; > > > Prasun Kapoor ; nipun.gupta@nxp.com; > > > bruce.richardson@intel.com; yang.a.hong@intel.com; > > > harry.chang@intel.com; gu.jian1@zte.com.cn; > > > shanjiangh@chinatelecom.cn; zhangy.yun@chinatelecom.cn; > > > lixingfu@huachentel.com; wushuai@inspur.com; yuyingxia@yxlink.com; > > > fanchenggang@sunyainfo.com; davidfgao@tencent.com; > > > liuzhong1@chinaunicom.cn; zhaoyong11@huawei.com; oc@yunify.com; > > > jim@netgate.com; hongjun.ni@intel.com; j.bromhead@titan-ic.com; > > > deri@ntop.org; fc@napatech.com; arthur.su@lionic.com; Parav Pandit > > > > > > Subject: Re: [dpdk-dev] [EXT] [PATCH v1 3/4] regexdev: add regexdev > > > core functions > > > > > > 06/04/2020 14:48, Pavan Nikhilesh Bhagavatula: > > > > > From: Pavan Nikhilesh Bhagavatula > > > > >> >> From: Pavan Nikhilesh Bhagavatula > > > > >> >> > > > > >> >> Looks like this implementation is incomplete? > > > > >> >> I don't see any pmd specific helper functions for @see > > > > >> >rte_cryptodev_pmd.c, > > > > >> >> rte_eventdev_pmd* > > > > >> >> > > > > >> >I think the current implementation includes all needed > > > > >> >functions, at least for the first stage. > > > > >> >You can find in rte_regexdev_driver.h the functions that should > > > > >> >be called by the PMD. We have the register / unregister which > > > > >> >acts the same > > > > >as > > > > >> >create > > > > >> >and destroy. For parsing argument the PMD may call > > > > >rte_kvargs_parse. > > > > >> > > > > > >> > > > > >> _driver.h should atleast include > > > > >> rte_regex_dev_pci_generic_probe/rte_regex_pmd_vdev_init > > > > >> else there would be a lot of code repetition and possibly > > > > >> udefined > > > > >behavior > > > > >> at the driver layer. > > > > >> > > > > >Why should they be included? At least in this stage, there is no > > > > >code to share ethdev why should we add code for the vdev? > > > > > > > > Ok I think I failed to communicate my concerns across. > > > > Let me retry > > > > > > > > 1. SW based regex devices such as PCRE/Hyperscan rely on vdev > > > > framework i.e. user needs to pass an EAL argument > > > > --vdev=3D"regex_pcre" for the driver to initialize all the other EA= L > > > > subsystems (ethdev, eventdev, cryptodev, > > > etc..)support this. > > > > > > vdev helpers do not have to be part of the first patches which define= API. > > > It should be added when adding the first vdev driver. > > > > > > > 2. HW based independent regex devices that are exposed as PCI > > > > devices > > > would need > > > > pci probe helpers. > > > > > > Same, PCI helpers can be added while adding the first PCI driver. > > > > > > We can synchronize about how to split the work, avoiding two > > > developers doing the same thing. But let's not mandate this work to b= e > > > done as part of this first series. > > > > > > > > I agree with Thomas, let's discuss this when adding the PMDs. >=20 > I am writing a now the Marvell OcteonTx2 PMD and I think that a PCI helpe= r is > missing. > When registering a PCI device, a .remove function is registered of type > pci_remove_t *remove; >=20 > typedef int (pci_remove_t)(struct rte_pci_device *); > because this function receives struct rte_pci_device * as an argument > It is required to have a helper function to retrieve struct rte_regexdev = *dev > based on the device name (or another way). > similar to rte_cryptodev_pmd_get_named_dev(const char *name)i Will add. Thanks, Ori