From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6D7E7A0540; Mon, 20 Jul 2020 06:50:59 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 487AB2B9A; Mon, 20 Jul 2020 06:50:59 +0200 (CEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70084.outbound.protection.outlook.com [40.107.7.84]) by dpdk.org (Postfix) with ESMTP id 47D401023 for ; Mon, 20 Jul 2020 06:50:58 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SuOAKYjUOsaFkjy6sDZHg/NJyryi4DRKXGsKYOZLWTsEGeAaZiIcI+f/4sfDanT5HJk/m/Zfw+a6pXw4Otj+QJGsacogkfI1rFGQzKXZ6EjtBd/k8IoZiJKrLocOlRi+wPQv8v+YeL/hivTB7NJlr5rHT5o/fHvuRs6KIyg5vl5JXPTZAbwofSNLyikFRAX4j/10XfBewewyOdBeMCdNmgyHjtIv3PH2UtxeMTnCSCHrrSmg0u5Ahnu3JwqLKbRgzyLtslQKaWx7f07qi7MWBP5iog8HiXAl93XhFeuc1p36fXlQK35M6b3VOUqjuoQE5icmWDX9OZ4EMBCgFhmJgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=R1VByeLv3aADq5CmsRVKmrj8/WwjDpvLSE62lRvW/Qg=; b=KCjv0a+3VnaCa8g4ovU6UxH4R3QD4essZ5qIbui/8ly2xUKQ/bNDuLxXZAMO8Vl7TmU0BWZdiAGnFkJHntMpFB/iEUhdRaAwALsLfC+8mPZfnugNCdc8v1mm6GcQA9iEpdRKqgBgONJNlEwJ2rGHDxDaNZwa7cN1Y55Ex9mqyHSPlbI4HnyqaKUw1M9EhIb0n2t7mzAqaInFVXB6O1IgGF2K4JolqC/cuH9052qMq2Y18qHAzNs3sjI/Sl5SISb11cQMQ+l3buopBE1yUSYGBiHbvoSbFg2ElbLZrXE4DEHOC20sf2RqDwA92l5XcqIdoSHePdQ9TeTTBLazmArY5Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=R1VByeLv3aADq5CmsRVKmrj8/WwjDpvLSE62lRvW/Qg=; b=oPLiHgtRpQuqsUmMm4as5NIw917MRsFnBs+F6yifX16fJEBs3XmHQ1t27dC2dYsPqumtacyP2SoNit5bO1mr7ifIk9henAZsyfNZjhynubIinYqLRRPYhb0ULfl/8827Ic2Un0wwxJqKwwPRC3Xylhm/sFPtMslhn4+26Y5ULK4= Received: from AM6PR05MB5176.eurprd05.prod.outlook.com (2603:10a6:20b:63::30) by AM7PR05MB6946.eurprd05.prod.outlook.com (2603:10a6:20b:1a3::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.23; Mon, 20 Jul 2020 04:50:56 +0000 Received: from AM6PR05MB5176.eurprd05.prod.outlook.com ([fe80::9024:accb:4d6b:805f]) by AM6PR05MB5176.eurprd05.prod.outlook.com ([fe80::9024:accb:4d6b:805f%3]) with mapi id 15.20.3195.025; Mon, 20 Jul 2020 04:50:56 +0000 From: Ori Kam To: Thomas Monjalon CC: "jerinj@marvell.com" , "xiang.w.wang@intel.com" , Matan Azrad , Slava Ovsiienko , John McNamara , Marko Kovacevic , Parav Pandit , Shahaf Shuler , Ray Kinsella , Neil Horman , "guyk@marvell.com" , "dev@dpdk.org" , "pbhagavatula@marvell.com" , "hemant.agrawal@nxp.com" , Opher Reviv , Alex Rosenbaum , "dovrat@marvell.com" , "pkapoor@marvell.com" , "nipun.gupta@nxp.com" , "bruce.richardson@intel.com" , "yang.a.hong@intel.com" , "harry.chang@intel.com" , "gu.jian1@zte.com.cn" , "shanjiangh@chinatelecom.cn" , "zhangy.yun@chinatelecom.cn" , "lixingfu@huachentel.com" , "wushuai@inspur.com" , "yuyingxia@yxlink.com" , "fanchenggang@sunyainfo.com" , "davidfgao@tencent.com" , "liuzhong1@chinaunicom.cn" , "zhaoyong11@huawei.com" , "oc@yunify.com" , "jim@netgate.com" , "hongjun.ni@intel.com" , "deri@ntop.org" , "fc@napatech.com" , "arthur.su@lionic.com" , Raslan Darawsheh , Yuval Avnery Thread-Topic: [PATCH v5 01/13] regex/mlx5: add RegEx PMD layer and mlx5 driver Thread-Index: AQHWXffEpkLK/Dr6WEajWEM6t4jo0akPeGeAgABo4yA= Date: Mon, 20 Jul 2020 04:50:56 +0000 Message-ID: References: <1593941027-86651-1-git-send-email-orika@mellanox.com> <1595182154-36508-1-git-send-email-orika@mellanox.com> <1595182154-36508-2-git-send-email-orika@mellanox.com> <3058241.yiR4NS12MS@thomas> In-Reply-To: <3058241.yiR4NS12MS@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=mellanox.com; x-originating-ip: [147.236.152.129] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 2aeb9b9f-e01d-4ab2-e792-08d82c687d8a x-ms-traffictypediagnostic: AM7PR05MB6946: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtFwd,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: BWxZyPEyqcelzs3tSpzTuh2r7vsYkldr76cdIrgp5yocbfwhmd0BHdlRBL+hR7aY94zKoQ/foiWQ6/i1ZrAJOIUZLx+eW1wvh3QuK+wsD8uPJenf/bQ1RKolwNAetla1SpLH4EqdXEfUtz+mQbDABZDNfP4y2t2xoPHVAdX3jihVjFO5r1jZxwdGfhCqSSQg8uzSIohAIL+RUUZeNLlJ/mxe2HoEDF+B+cSeWUk4PI8V4dJwjW2NQMZcsINLVurXbLE+tjKXN+uDp/7bmCdlM9HMA5TDQQWLULFUiuJP+SR1SSQsZ5sQrhZKeo5HZU4+7xPUZMIaLeYnyKfMAvSpzg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM6PR05MB5176.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(39860400002)(346002)(136003)(376002)(396003)(366004)(107886003)(8676002)(6916009)(7696005)(83380400001)(71200400001)(66946007)(66476007)(478600001)(2906002)(7406005)(7416002)(8936002)(316002)(55016002)(6506007)(186003)(86362001)(5660300002)(52536014)(66446008)(64756008)(66556008)(4326008)(26005)(9686003)(33656002)(76116006)(54906003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: sYQ3VDL8Es+xPOvwkrBo+cwOhddLMKlgvjWRs9JI95s2iSRpHhy1qHm9nkRDsncq/o8pFMEqJ9j8CQf6uZAEs+yeoe4AElyXX7IOiFtkX4NT77KJyeQ2Ntks2TkW4pHsgNK5Ne4sbXoVFa6hU8/L0LvsXwLfHED4xuIrRITxoFuU2g79WvPlUy8QIbUZCkpRzGKO7295zUFQl6vRvALhrgwdDleOQIyW7OjjYaRZHDTiJtCbfW1rJK0oPULPeXVd0vgrJ0gXoyLOBUv9z79wR6WE5CSmElBJjA0oh4nVaQ3OBkT8O0VhpMjLVyyBi6Qcqk4t9hFktqP5/pkb8jnT7OeQMTbd1ZKNmeBZ9vudlZu8WjdORlkovyU8o9+YE8Cp0VaOuIi+rymGjTXwib0Ng06DmFpvIpTvI6Kp9l+IP4o2Ok0MmC9hMqCXyUtEQv02HME9nYw9pcCQ5/+h/bgIXKxu2rbdtIB1Kcr0848w6dlc2oBjLbzF8ie9TFRMYA5p Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM6PR05MB5176.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2aeb9b9f-e01d-4ab2-e792-08d82c687d8a X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Jul 2020 04:50:56.4483 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: g9RBXy3LofzxhqDiCA2mfWx7VdddDXnZD1M6CT7hZULlIc2dhOR/MeT51vrERJIMfTilnHOIa/K5fuOfRcZDOQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR05MB6946 Subject: Re: [dpdk-dev] [PATCH v5 01/13] regex/mlx5: add RegEx PMD layer and mlx5 driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Thomas, Thanks for the review. > -----Original Message----- > From: Thomas Monjalon >=20 > 19/07/2020 20:09, Ori Kam: > > From: Yuval Avnery > > > > This commit introduce the RegEx pull mode drivers class, and > > adds Mellanox RegEx PMD. > [...] > > --- /dev/null > > +++ b/doc/guides/regexdevs/features_overview.rst > > @@ -0,0 +1,100 @@ > > +.. SPDX-License-Identifier: BSD-3-Clause > > + Copyright 2020 Mellanox Technologies, Ltd >=20 > SPDX is not aligned with the Copyright. > You should not have a double space before SPDX. >=20 O.K. > [...] > > --- /dev/null > > +++ b/doc/guides/regexdevs/index.rst > > @@ -0,0 +1,15 @@ > > +.. SPDX-License-Identifier: BSD-3-Clause > > + Copyright 2020 Mellanox Technologies, Ltd >=20 > Same here. RST annotations start at the third column. >=20 O.K > > + > > +REGEX Device Drivers > > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > + > > +The following are a list of RegEx (Regular Expression) device drivers, > > +which can be used from an application through RegEx API. > > + > > +.. toctree:: > > + :maxdepth: 2 > > + :numbered: >=20 > same here >=20 O.K. > [...] > > + Due to external dependencies, this driver is disabled in default > > + configuration of the "make" build. It can be enabled with > > + ``CONFIG_RTE_LIBRTE_MLX5_REGEX_PMD=3Dy`` or by using "meson" build > system which > > + will detect dependencies. >=20 > I would drop this part. I don't think it is an useful info, > especially because make is going to be removed. >=20 I think it is a good comment at least for now, since the RegEx is going to = be used by costumers that are not used to Mellanox devices. But if you wish I will remove. > > +Mellanox mlx5 PCI device can be probed by number of different pci devi= ces, > for example >=20 > Inconsistency on the same line: "pci" vs "PCI". > Will fix. =20 > Better to break line after the comma and after a dot. >=20 Will fix > > +net / vDPA / RegEx. To select the RegEx PMD ``class=3Dregex`` should b= e > specified > > +as device parameter. >=20 > This does not explain if RegEx is exclusive with other classes. >=20 Will clarify. > [...] > > +- BlueField 2 running Mellonx supported kernel. >=20 > typo: Mellonx >=20 Will fix. > > +- Enable the RegEx caps using system call from the BlueField 2. >=20 > This is a doc. Please write full words: "capabilities". > Will fix. =20 > [...] > > +These options can be modified in the ``.config`` file. > > + > > +- ``CONFIG_RTE_LIBRTE_MLX5_REGEX_PMD`` (default **n**) > > + > > + Toggle compilation of librte_pmd_mlx5 itself. >=20 > Better to drop this "make" part. > [...] O.K. but Make is still a build system, that is used, but I will remove. > > enum mlx5_class { > > MLX5_CLASS_INVALID, > > MLX5_CLASS_NET =3D RTE_BIT64(0), > > + MLX5_CLASS_REGEX =3D RTE_BIT64(2), > > MLX5_CLASS_VDPA =3D RTE_BIT64(1), >=20 > I think regex would be better sorted after vDPA. >=20 I did this to have alphabetic ordering. > [...] > > +++ b/drivers/regex/meson.build > > @@ -0,0 +1,9 @@ > > +# SPDX-License-Identifier: BSD-3-Clause > > +# Copyright 2020 Mellanox Technologies, Ltd > > + > > +drivers =3D ['mlx5'] > > +std_deps =3D ['ethdev', 'kvargs'] # 'ethdev' also pulls in mbuf, net, = eal etc > > +std_deps +=3D ['bus_pci'] # very many PMDs depend on PCI, so m= ake std > > +std_deps +=3D ['bus_vdev'] # same with vdev bus >=20 > I disagree about making bus some standard deps. O.K will remove >=20 >=20