From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A4372A0577; Sun, 5 Apr 2020 17:13:02 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9CE432C5E; Sun, 5 Apr 2020 17:13:01 +0200 (CEST) Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50047.outbound.protection.outlook.com [40.107.5.47]) by dpdk.org (Postfix) with ESMTP id A09F4276C; Sun, 5 Apr 2020 17:13:00 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Fz46XDCNaOjjfU2eEUsj59/Onvx7Bv4KVQieqFvBlRu9vcYakEcfs4aMBQxyWFQPtaqezlpbt3DSsz2MpPffwB5KoZZaIBB/gh4s3CfuaNKUahS8kOrF/RtBxW1jNQAZXVsNORZwvDRI96GPJ08IPB3ejr2BjliVwx0lotV8WTQCM83JN9+5yb501m8gX2lPn7hmg1J/UuSAxqExsOX8z9bhHrfno3rJ9PdMpm3KbFfkAZel0uAkuRxVMvwBVXd3irVUSKuDa12gFbhXJzd50K90POPXWfb0MQKVqS1R+qSFu4FybFGkPw88wQwJLSk8MR44smYiUn3ierELfm84Vg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ed6w3F9zwLPLaRhZTxV1cUfsw6B6EsrCM2cjsr4KlhI=; b=c0NG0ucRCPsg1GdJhKr0RhicL4f3ek6qcEnh0GfRNg4CDMgecW5pdnQoVQfBxDEgzIbRWcG22oQ4Y1H24oLlt/6OHI+nNFWeSHvOI//2YWN2/3tCzW3tc0c9BywH5S1qe4Zx++is1/NiPVWxO+F4ylI/PZjlw0R1XK8Xik3EgJzHlvF8KPgj1STQGp+L+e28cNjigr7FYqOqgzx+PilvFFZVzlrfZUZ0DuRTwH1woNd44SK6s7dckVO7eqaMEStq7+WhU7/DhI15reHaprCSblrt3+yjHdiXL5lLgCcmBD+ijvJsXKVsYZ2EYq8989D9Fsq1GFdEx/Q9icGNqzQlSA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ed6w3F9zwLPLaRhZTxV1cUfsw6B6EsrCM2cjsr4KlhI=; b=QXMiWd/F6uEMCCetBbGTVypeJiGruc3rnkArcOVGQjB1zxPCD4t8aO6t+2saT2YfPpRfeHimi+zQMcPGUC1G/gE9c0we6ynl2Ba5SiHkRHv58Q7ysEBm5gCqn7fmMFxMUHolyndQlv2gLnHTOdUe6hFefcNjuksH1vER7oLDluY= Received: from AM6PR05MB5176.eurprd05.prod.outlook.com (2603:10a6:20b:63::30) by AM6PR05MB4357.eurprd05.prod.outlook.com (2603:10a6:209:48::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2878.19; Sun, 5 Apr 2020 15:12:59 +0000 Received: from AM6PR05MB5176.eurprd05.prod.outlook.com ([fe80::f5cd:b10f:5f1b:4b22]) by AM6PR05MB5176.eurprd05.prod.outlook.com ([fe80::f5cd:b10f:5f1b:4b22%7]) with mapi id 15.20.2878.018; Sun, 5 Apr 2020 15:12:59 +0000 From: Ori Kam To: Xiao Zhang , "dev@dpdk.org" CC: "qi.z.zhang@intel.com" , "wei.zhao1@intel.com" , "stable@dpdk.org" Thread-Topic: [v2] app/testpmd: fix PPPOES flow API Thread-Index: AQHWBBGaeM8mPPPhN06u+6qAGH787KhiuLkAgAf3v+A= Date: Sun, 5 Apr 2020 15:12:59 +0000 Message-ID: References: <20200327081926.6154-1-xiao.zhang@intel.com> <20200331132940.4960-1-xiao.zhang@intel.com> In-Reply-To: <20200331132940.4960-1-xiao.zhang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=orika@mellanox.com; x-originating-ip: [185.175.32.251] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: eec1f8b4-a51f-489c-c2b1-08d7d973d3b0 x-ms-traffictypediagnostic: AM6PR05MB4357: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-forefront-prvs: 03648EFF89 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM6PR05MB5176.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10009020)(4636009)(136003)(376002)(396003)(39860400002)(366004)(346002)(478600001)(71200400001)(86362001)(26005)(6506007)(53546011)(4326008)(55016002)(9686003)(186003)(110136005)(316002)(33656002)(81166006)(76116006)(2906002)(5660300002)(66446008)(54906003)(7696005)(66476007)(8936002)(8676002)(64756008)(66556008)(81156014)(66946007)(52536014); DIR:OUT; SFP:1101; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: e4YboQ1KXznuquC4Pz+0geCheW94VduHjylohApMKEt9TgyRA/4NF5Iv9y2YybKxASqHcyVZgrKTqzQ9GA0Xd8K3M9yBE1yw5lkfyUIrcIBpd/ng2PvwfgZFliz1G3n1qc9w+2W7kqQJCgEgKTX8mu4p2aYYEqEel6quHUJ2kzatf98L7TRBrZluqhw1gnkwi2iZoS3QJ2FfUwn3rqkPvrMfPrY6AijfrZwuPTNyagkW+yngP6ET2mNtvb4mpgwKnYfMA644zBIE9PZXD0gzvPoV9ZCloqu2XYYYdLe+UXlSQMg/jKd63yYNC+YDIQwr3Uhi1VKszp4cALBoxvTTO4yMFp3uwfHUrBKp5fRT/dXUbXLwxgIj5V/i3/Hr8Ws/g7xaJqOJoTSGZMNNWYVoZJT8Q6X3hJsRC0n9ztpPmLrZGsyYsExxniUdQfXO/oGi x-ms-exchange-antispam-messagedata: k2mDdxXUEsbrwnZLN4z0U6gII+NiF/zswamdngXciRSic/vkg8kBfgrPukRBCwkj/P6ZdA83dP+EUdVF1An6axHEB9nzhI8e5y+kLF/vU1Gq8L991KavSUJbFVhQiGHhBDZJpaEQNFGdNvVGxUnB4g== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: eec1f8b4-a51f-489c-c2b1-08d7d973d3b0 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Apr 2020 15:12:59.0968 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: hYesNvqhm1lnIsZSWDSZSqhh231JpU0j+UklEGBtCx86atpK3MWGtrt9rRqMND0cIO68YlWnl3Xb6HX1uZon0A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR05MB4357 Subject: Re: [dpdk-dev] [v2] app/testpmd: fix PPPOES flow API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Xiao, > -----Original Message----- > From: Xiao Zhang > Sent: Tuesday, March 31, 2020 4:30 PM > To: dev@dpdk.org > Cc: Ori Kam ; qi.z.zhang@intel.com; > wei.zhao1@intel.com; Xiao Zhang ; stable@dpdk.org > Subject: [v2] app/testpmd: fix PPPOES flow API >=20 > The command line to create RTE flow for specific proto_id of PPPOES can > not work. >=20 > It was: > testpmd> flow create 0 ingress pattern proto_id > proto_id [TOKEN]: match PPPoE session protocol identifier > testpmd> flow create 0 ingress pattern proto_id proto_id > proto_id [TOKEN]: match PPPoE session protocol identifier > testpmd> flow create 0 ingress pattern proto_id proto_id proto_id > proto_id [TOKEN]: match PPPoE session protocol identifier >=20 > The proto_id can not be set with previous implementation. >=20 > This patch is to fix this issue, and change the command line to: > testpmd> flow create 0 pattern pppoe_proto_id is xxxx >=20 > Fixes: 226c6e60c35b ("ethdev: add PPPoE to flow API") > Cc: stable@dpdk.org >=20 > Signed-off-by: Xiao Zhang > --- > v2 change the command line according to review comments. > --- Acked-by: Ori Kam Thanks, Ori > app/test-pmd/cmdline_flow.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) >=20 > diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c > index a78154502..7ac01562e 100644 > --- a/app/test-pmd/cmdline_flow.c > +++ b/app/test-pmd/cmdline_flow.c > @@ -1035,7 +1035,6 @@ static const enum index item_pppoes[] =3D { > }; >=20 > static const enum index item_pppoe_proto_id[] =3D { > - ITEM_PPPOE_PROTO_ID, > ITEM_NEXT, > ZERO, > }; > @@ -2641,11 +2640,14 @@ static const struct token token_list[] =3D { > session_id)), > }, > [ITEM_PPPOE_PROTO_ID] =3D { > - .name =3D "proto_id", > + .name =3D "pppoe_proto_id", > .help =3D "match PPPoE session protocol identifier", > .priv =3D PRIV_ITEM(PPPOE_PROTO_ID, > sizeof(struct rte_flow_item_pppoe_proto_id)), > - .next =3D NEXT(item_pppoe_proto_id), > + .next =3D NEXT(item_pppoe_proto_id, NEXT_ENTRY(UNSIGNED), > + item_param), > + .args =3D ARGS(ARGS_ENTRY_HTON > + (struct rte_flow_item_pppoe_proto_id, proto_id)), > .call =3D parse_vc, > }, > [ITEM_HIGIG2] =3D { > -- > 2.17.1