From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6B930A00C5; Sun, 5 Jul 2020 13:58:30 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 17F171DBE2; Sun, 5 Jul 2020 13:58:30 +0200 (CEST) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80052.outbound.protection.outlook.com [40.107.8.52]) by dpdk.org (Postfix) with ESMTP id 3C9EB1DB47; Sun, 5 Jul 2020 13:58:29 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bUu0g1X3GJGRMGWIJXSpmFxXSD4PffpjDOSgFZ76D2HjSQLF3F3ByvXC6MFE34zhR2+DuEcaoSeZSVdKsUaKt54/72mG7fNi4qBvC7LnEpg+Cfz1s/wGjlf1fJlIYuBMd5NIXK9MDp86TZb9ng/3UgwlOmDvHmfia2da67mDAYpaFFterw9+lvjgEv2DnJ1zudaUKLM7FaIWTTZ/8ggda2ZdiVUp3Ftb9g4s6gskxEzpBOpYwhxxBz4zZhGL+1+OgZbY64jVGHBSOYvKxQ0VkW/QE+AObGgRq550+TvLEAHoptG7aJ59KxOEsO2+H30Coym9cV29fVh2dkuYkjbk0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3698Cm3UNO6gTy0UtnJXgKejaiWNZzl3EDn1VqJzhjM=; b=PyPkhPy8NauLfcLRCUNx2no3/dfko/VviWKID9fNtB092y1X1tWCU8BD/bUR7mhLn1KhkcUh3gD/nvnLMii+IrgJ19yofKoWFQpG9Jt5ehLOF9QvrydhxE3i3HUCOGa17cevhX+Lcx+G0kJLZ1k9MG+NPd1oq8CDfflV/medAA4c3KKS0saVVg0HKNoF0TZrZTbssnPLbHetTRNGjsT9icI/j4xjC5mkgGpfEMmCrNuh3tzpmBwzo8vOa7hWIgGloXeWJ/nwjA7k6A5AvCszCOD1YDQBR3gG6QPrkvybSDsJR5LHx1C0juVi+nAW/epqXIeNfj2dkFclOwFUXd9B4A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3698Cm3UNO6gTy0UtnJXgKejaiWNZzl3EDn1VqJzhjM=; b=JY/Zxm1/iDK3lHaKsou8vnS/Q895hnS0IPyVPaOT3O69rkea1xzgS383F+aSgOxyeSORxaCXZQchjRSUCkuGCy2bwxuapwZWsi7Y91A3WD8/+AIr7m5L5yS/tldHkremDAzqwGNFRC2Ypel033RskXCpAHeGTmgfw4L2emwm9h4= Received: from AM6PR05MB5176.eurprd05.prod.outlook.com (2603:10a6:20b:63::30) by AM5PR0501MB2530.eurprd05.prod.outlook.com (2603:10a6:203:6::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3153.28; Sun, 5 Jul 2020 11:58:28 +0000 Received: from AM6PR05MB5176.eurprd05.prod.outlook.com ([fe80::9024:accb:4d6b:805f]) by AM6PR05MB5176.eurprd05.prod.outlook.com ([fe80::9024:accb:4d6b:805f%3]) with mapi id 15.20.3153.029; Sun, 5 Jul 2020 11:58:28 +0000 From: Ori Kam To: oulijun , "ferruh.yigit@intel.com" CC: "dev@dpdk.org" , "users@dpdk.org" Thread-Topic: Questions about rte_flow_create APIs Thread-Index: AdZRBWe3ASkCL0NzTXWobHNvBKxWkABvK3ag Date: Sun, 5 Jul 2020 11:58:28 +0000 Message-ID: References: <13c6e9a563824423a653bdb64d72d54e@huawei.com> In-Reply-To: <13c6e9a563824423a653bdb64d72d54e@huawei.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: huawei.com; dkim=none (message not signed) header.d=none;huawei.com; dmarc=none action=none header.from=mellanox.com; x-originating-ip: [147.236.152.129] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: da5b2a44-31ba-4b7c-419b-08d820dabaea x-ms-traffictypediagnostic: AM5PR0501MB2530: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 045584D28C x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: TgozPHxtW8F2LeAshW/fY9rKt6qWHKqCcIwdbVp0JJhpmkuowKwEd2pT2nz/L25/2T9LFvND+/Ql2rmNifEjkjcVSbSpslT5iTBFd+tX3GhxQktBduCOdyXT/AwqR3UMZQZlt0e5y6GJq3K7IVSQ/Ic7lkBNs0bah33iGd3Ldli44E9mSjb/8BvWu26dDomh6CtDc1XtbUR1zwhEyfCkFYZsKPpfdHKCIybGmC6XmtJ7zdnh0tfT8qJyNpOxipTqO/3RJdly+KTRJQKz6B7wDc/kwGQ3idY+zYaJlFScIAEsiIt4QEKS6dOehNP5w3itMbSwFzB6a1V3BSGw813cpg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM6PR05MB5176.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(136003)(376002)(39860400002)(396003)(366004)(346002)(186003)(66946007)(9686003)(4326008)(26005)(76116006)(2906002)(110136005)(86362001)(33656002)(53546011)(8936002)(8676002)(316002)(71200400001)(7696005)(6506007)(5660300002)(64756008)(66446008)(66476007)(9326002)(54906003)(55016002)(478600001)(66556008)(52536014); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: YqUlmxPvGswQKH6qMTOVRf462yp7HgeNLcpuXf2wXB06TY6o1zskSx6Ytno2SAw0yQRv3yOl2ZVjWoaackoUfokpJRUxxfRLPeHZMUi8YSq6Iop/DKAIrTje7Clw5xGVYVWV32SozxmIlVo0icat43/spJChGWy4MTQHXlV1ofb/Fy7QadkurvZSxP6nGmzoQOLr13l869ixNlDDG6Dpj+LmlwlwJ3QpPmevOGQzOOxyGcNVaMQRMB5pf6ozKQSOUQ/k7xADF0ZyermsaW1AJzVWwhQw71vs4sgtITl3DAYFGLd49qqoEJyY2KSNcUmV4QVmBiCwRfAwMp9TdlxSbWya3GijD7FASZw6sgvFsiOb62oRyF2xivG9vNMylJaHhYpGk1vPCsXKmrNHJVkezQqtM+1oQQDDQYl/nR6JU4xMFfksKiKNUCd4nttv/6meC/eTDsuR84L7QPbNVPq++ia4LJDNZlakORny4CJwEMCkpYFyz0drThTdFPaFfbSv x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM6PR05MB5176.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: da5b2a44-31ba-4b7c-419b-08d820dabaea X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Jul 2020 11:58:28.2829 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: cfR8tPdUKRJF2rMXYVo8i2RS0HXOHf6BLSVtKYJK4NhIabmDgdieJ+26zjqfJsWXwemmNPCE+9eB0H4NXi9oiw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0501MB2530 Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] Questions about rte_flow_create APIs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Oulijun, First small comment, I think you sent the mail in HTML format, please next time send it as plain text. From: oulijun Sent: Friday, July 3, 2020 9:45 AM To: Ori Kam ; ferruh.yigit@intel.com Cc: dev@dpdk.org; users@dpdk.org Subject: Questions about rte_flow_create APIs Hi, Guys I am analyzing rte_flow_create API and test and is testing server paramet= ric scenario. When use testpmd and the following flow creat cmd: testpmd> flow create 0 ingress pattern end actions rss func simple_xor /= end why the contents of rte_flow_action_rss is not same acquisition method afte= r run the flowing codes. struct rte_flow_action_rss conf; rss_conf =3D action->conf; the Value of unspecified parameter is not same acquisition method. The rss_conf.type is default; The rss_conf.key_len is deault; The rss_conf.queue_num is deault; However, the rss_conf.key is random and unpredictable The result is that when the user does not specify the rss key, the driver w= ill fill a random value into the hardware=1B$B!#=1B(B The rss key value found by the user is different from the first value, whic= h results in the user not being able to use it correctly. I think the reasonable behavior is that either the rss rule was not success= fully created or the content of the rss key that was queried has not change= d testpmd> show port 0 rss-hash key RSS functions: all ipv4-frag ipv4-other ipv6-frag ipv6-other ip RSS key: 4439796BB54C5023B675EA5B124F9F30B8A2C03DDFDC4D02A08C9B334AF64A4C05C6FA34395= 8D8557D99583AE138C92E81150366 testpmd> flow create 0 ingress pattern eth / ipv4 / udp / end actions rss t= ypes ipv4-udp end queues end / end Flow rule #0 created testpmd> show port 0 rss-hash key RSS functions: all ipv4-udp udp RSS key: 74657374706D6427732064656661756C74205253532068617368206B65792C206F766572726= 9646520697420666F722062657474 What do you think? [Ori] I think this is a testpmd only issue, since it uses the same structur= e when it pass it to the pmd. you can look at it in also in a different way. 1. the application create first flow using empty rss action, this mean tha= t the flow gets the default RSS functions, 2. the application insert the flow you gave with different RSS function tha= n the original one. 3. the application create a new flow with empty RSS, no the flow is created= using the new RSS function and not the old one. So I don=1B$B!G=1B(Bt think this is a true issue. Best, Ori Thanks Lijun Ou