From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D018FA0564; Tue, 24 Mar 2020 10:58:51 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A30791C0C3; Tue, 24 Mar 2020 10:58:50 +0100 (CET) Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10056.outbound.protection.outlook.com [40.107.1.56]) by dpdk.org (Postfix) with ESMTP id 4F99D1C0C2 for ; Tue, 24 Mar 2020 10:58:49 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SN4TLMTtq/cmbM5O1R2z67COfJndeyp9V2gImr32R06tLifWE7dQ/Tis8xdCPtGpIKKNOTgPC0DKuKorGZUzYfa5rXmCKt8P0wiej/Y9tl71XxvsI2ffErOvBR9D963AQ4OsTh82q91LcMuMZM9rHzsbz9qityGtxz2rdxTzOi82/vN3afn3B9IOEHJKoVHnzJC4ShegyK90+MMYtg4oxFWXhugi6PfINYDnXVlKDcqnHN/J0KCVRlDQ9Nvc/61XubS8hZhuHsQ8JTt9U6MwyZucGgyg3BJKEJCzbCEL9nnXWDj2jcdvqa6QNoZB0UswhlKM+9GVXRIv5xkkAxTvpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=43Jp7mu/o95En+aIKBG3+0EEcZ84l7rDHwMJGeP/3Kc=; b=Zc1omyl1S10KrV6rl+EFNRSb4KFLZiNhxIdHmgS11Cy7ZK7qfKJKELQjTDWZWRN0YWRXaLjkqmjWA1t9R+jrc4VIwTTLep+E26q2v0hzXz58agEJfWmwpljLKnAQy2IXyPiq/030XH1CaFIgPcFXp2PiEUrmkPQanbCa0jAEZLkEVgm3QlpKnvLX17xDufsi/4+lRhEVMc+mnnWx5k7Pwz2wrZSISPKFkDZGkzfWK7j0fNQ/Gb1/LWm/4V6HiyGtpHML93P8oRODbndZELstnDveLh8H/KcBjEdKSDMMSxRkqbanD77NFjoqQv5sTKTS/Kp9/zpmbBQH3w/5cCLgfw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=43Jp7mu/o95En+aIKBG3+0EEcZ84l7rDHwMJGeP/3Kc=; b=Cv2VYc9GnRVTc+8K3pYZkV99TsR0HgKEQ/8Usz5FbShlC9WW9WjQOmhaE4ZL++1tg4JDeNhOrofOylc4Pfb03kJIMiVQ8AV4PIAzLx0vg7UlGxP+f7vB5ZWbOCBn95jvF5hfbogpRp5LqQv+RzE/7yEi5es8gdgUZdVfp895kjA= Received: from AM6PR05MB5176.eurprd05.prod.outlook.com (20.177.196.158) by AM6PR05MB5286.eurprd05.prod.outlook.com (20.177.197.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2835.22; Tue, 24 Mar 2020 09:58:48 +0000 Received: from AM6PR05MB5176.eurprd05.prod.outlook.com ([fe80::80e9:7eb9:e770:941d]) by AM6PR05MB5176.eurprd05.prod.outlook.com ([fe80::80e9:7eb9:e770:941d%7]) with mapi id 15.20.2835.023; Tue, 24 Mar 2020 09:58:48 +0000 From: Ori Kam To: Dekel Peled , "wenzhuo.lu@intel.com" , "jingjing.wu@intel.com" , "bernard.iremonger@intel.com" CC: Matan Azrad , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] app/testpmd: enhance GTP support Thread-Index: AQHV+2sDS3lRIQWjrka9c8J9AGxPpKhXjY2w Date: Tue, 24 Mar 2020 09:58:48 +0000 Message-ID: References: <239bc0ae9191ddc12fec65742949710d13185b85.1584346077.git.dekelp@mellanox.com> In-Reply-To: <239bc0ae9191ddc12fec65742949710d13185b85.1584346077.git.dekelp@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=orika@mellanox.com; x-originating-ip: [185.175.35.255] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 89a89819-2f1b-4508-3e98-08d7cfd9f2b2 x-ms-traffictypediagnostic: AM6PR05MB5286:|AM6PR05MB5286: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2449; x-forefront-prvs: 03524FBD26 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(39850400004)(376002)(396003)(346002)(366004)(136003)(8936002)(316002)(8676002)(186003)(76116006)(6506007)(54906003)(66556008)(64756008)(66476007)(66946007)(26005)(110136005)(66446008)(52536014)(71200400001)(4326008)(81156014)(81166006)(478600001)(86362001)(5660300002)(33656002)(2906002)(7696005)(9686003)(55016002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM6PR05MB5286; H:AM6PR05MB5176.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: xbXxjRVqOvq9fOFTUVWXnPwxes0BVOCj10HFwH6TGd+bc6CmCilCqbSLCyPj6gqt3iL8zq61LZObNKufKAd/vBaAxlcjL0VUcgkgLKyCA54LW9ozBYeffYxWwewIKPu0D/5P90fdE+e1ACJTf5GEyAXgl2GCB8NowEjrxGY+1knSN8foco8MDWjLQz+C/oVn9UKUiATXSCvx0k8prjrMH/3GAckbjNqL1hQrvc/Jb789Mz+Ql+0XRnvt+laj551OsVsfU24Yo1wyq6y5ExFx/zmbstInW69GfAZ1vemTV4jfIryBuZ0eLqClT3u0M05uwJUjRwnEoj1j8LKKKKGDgmRSxn3ULNnqvq3wg8qU2OqRFyaxZUbRSD4Smci06nTUNYZ9MSBX642yFgipVHlAmxWFiUwtD3b5i36uzdCSnUzr4uE96j+HHee6Z0ok08Ao x-ms-exchange-antispam-messagedata: 5ft4EvNWvehsWCxzismcQmr9TIQpcfBOtD/g4Dp23SmIT0O50l3wY2IvB1Oqv8qnZh/mzYV8cTCr2/xCT2a5YsTummpFfvUPP2uIoGjvBEiYQEuFFKm6BbbrfBgxe4ivYf981QTdIc7NNeYFDB5eLQ== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 89a89819-2f1b-4508-3e98-08d7cfd9f2b2 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Mar 2020 09:58:48.1196 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: OOeAHrLCRqr1tOoac/IVLHavXWQX3SBYvIL8hZbOrOlzXxnWW9KuTY6ZzkgZvfIOAoV3eqpipipcQO2jSUvMeA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR05MB5286 Subject: Re: [dpdk-dev] [PATCH] app/testpmd: enhance GTP support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Dekel, > -----Original Message----- > Subject: [dpdk-dev] [PATCH] app/testpmd: enhance GTP support >=20 > This patch adds CLI option to enter the v_pt_rsv_flags value for GTP > flow pattern item. > It also adds GTP as valid item in raw_encap nad raw_decap setting. >=20 > Signed-off-by: Dekel Peled > --- > app/test-pmd/cmdline_flow.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) >=20 > diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c > index a781545..cc1bd19 100644 > --- a/app/test-pmd/cmdline_flow.c > +++ b/app/test-pmd/cmdline_flow.c > @@ -170,6 +170,7 @@ enum index { > ITEM_FUZZY, > ITEM_FUZZY_THRESH, > ITEM_GTP, > + ITEM_GTP_FLAGS, > ITEM_GTP_MSG_TYPE, > ITEM_GTP_TEID, > ITEM_GTPC, > @@ -938,6 +939,7 @@ struct parse_action_priv { > }; >=20 > static const enum index item_gtp[] =3D { > + ITEM_GTP_FLAGS, > ITEM_GTP_MSG_TYPE, > ITEM_GTP_TEID, > ITEM_NEXT, > @@ -2347,6 +2349,13 @@ static int comp_set_raw_index(struct context *, > const struct token *, > .next =3D NEXT(item_gtp), > .call =3D parse_vc, > }, > + [ITEM_GTP_FLAGS] =3D { > + .name =3D "v_pt_rsv_flags", > + .help =3D "GTP flags", > + .next =3D NEXT(item_gtp, NEXT_ENTRY(UNSIGNED), > item_param), > + .args =3D ARGS(ARGS_ENTRY_HTON(struct rte_flow_item_gtp, > + v_pt_rsv_flags)), V_pt_rsv_flags is 8 bits right? So why HTON? > + }, > [ITEM_GTP_MSG_TYPE] =3D { > .name =3D "msg_type", > .help =3D "GTP message type", > @@ -6604,6 +6613,9 @@ static int comp_set_raw_index(struct context *, > const struct token *, > size =3D sizeof(struct rte_flow_item_ah); > proto =3D 0x33; > break; > + case RTE_FLOW_ITEM_TYPE_GTP: > + size =3D sizeof(struct rte_flow_item_gtp); > + break; > case RTE_FLOW_ITEM_TYPE_PFCP: > size =3D sizeof(struct rte_flow_item_pfcp); > break; > -- > 1.8.3.1 Best, Ori