From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BA752A0561; Mon, 20 Apr 2020 12:09:37 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7CCCD1C240; Mon, 20 Apr 2020 12:09:36 +0200 (CEST) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2073.outbound.protection.outlook.com [40.107.21.73]) by dpdk.org (Postfix) with ESMTP id 39CC41C23E for ; Mon, 20 Apr 2020 12:09:34 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lmNLB6xUsuFI8PStoBCzu5DUJp3WVANU0ulzVeHpMuk2BgL7xqbWgOm+XpRSF9N0pBRgFl3dVrPnUWZ7LEgHiafICK5Do4a2ZTinBLoKaGYBxacJVNkglifkyOEeiaHYJtZXHtZ0lIXb/QvOGq6mG7s6+/BVgoVeAougvQ5/Evhy2jA/R/uNpwu08CHh4vchYhh5xGGAwtE3gDWUKt2VLA5NLvrL46UoApXzcGUjp4bBJ5knZcQ8U70IfhBw8kgWV3lXoKQ238GJyOnoA+hAeUCr6jr8y6R7Zx5718GS8sKtGR6TezhXTwG8yXp+gv+aVCKWB4yblvGzQpwmXXqcww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=muwrTJCOzS5+9URTfkqEAaswWdZt4g46eumPozVuSzM=; b=Tpe78uqaiYkVN3myfm8v2gjLWjBhzZ03BKCiTMRBh4Do+juBbQUDtqQPEMHCcczJE76xQzClPrTB3yEzoV3blX28E/ezj2cGQRwifUugnNLnB3CFrQFIAWSUxSYPSl6yc88e88T8gMmdU8KMcBFc1GwE/yoeBJ6S8PAm+8bs3waLq9Sen/inJ7EDDEqBqTq+XltbPRxeVaLFKNXgqYovhcFTZZm/ySAGILlHFZ5N5bT/IF40Sc13kQf51wOPK61A/sgbvHoq1AV4Yu9uKGaR5pkyeFoiLP1l4Fp+ZrqVOuQmsId3lisN9MClkYFmLtThuFwJZd6GafheMIyWZpZm7w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=muwrTJCOzS5+9URTfkqEAaswWdZt4g46eumPozVuSzM=; b=Q0t1G5n2f7waqzHVZC0KEVt9gGJ4LbN6LjIguQgNImOdcs7gZFwWi3H1epaQRfqw7sYeT9Lc5UN31TOKIxzhsc5qigN3wAcwMbRmSxwbKjolbwLfiDik+t1iZ7o1hDrVHDSyPLLfa9WrsGSzBDedyqvpMd4Z0AONdV2efcHrBkI= Received: from AM6PR05MB5176.eurprd05.prod.outlook.com (2603:10a6:20b:63::30) by AM6PR05MB5878.eurprd05.prod.outlook.com (2603:10a6:20b:a6::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2921.25; Mon, 20 Apr 2020 10:09:32 +0000 Received: from AM6PR05MB5176.eurprd05.prod.outlook.com ([fe80::f5cd:b10f:5f1b:4b22]) by AM6PR05MB5176.eurprd05.prod.outlook.com ([fe80::f5cd:b10f:5f1b:4b22%7]) with mapi id 15.20.2921.030; Mon, 20 Apr 2020 10:09:32 +0000 From: Ori Kam To: Bing Zhao , "john.mcnamara@intel.com" , "marko.kovacevic@intel.com" , Slava Ovsiienko , Matan Azrad CC: Shahaf Shuler , Raslan Darawsheh , "dev@dpdk.org" , Thomas Monjalon Thread-Topic: [PATCH v2] doc: update flow non-cached mode notes Thread-Index: AQHWEaOnCLuqf5VoM0aFRtIpb60VkKiB0WjQ Date: Mon, 20 Apr 2020 10:09:32 +0000 Message-ID: References: <1586789756-227464-1-git-send-email-bingz@mellanox.com> In-Reply-To: <1586789756-227464-1-git-send-email-bingz@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=orika@mellanox.com; x-originating-ip: [185.149.253.12] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 3781272f-058e-4f52-e7d3-08d7e512ebe1 x-ms-traffictypediagnostic: AM6PR05MB5878:|AM6PR05MB5878: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr,ExtFwd x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-forefront-prvs: 03793408BA x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM6PR05MB5176.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10009020)(4636009)(396003)(366004)(136003)(346002)(376002)(39860400002)(186003)(76116006)(7696005)(6636002)(55016002)(9686003)(478600001)(5660300002)(33656002)(52536014)(86362001)(54906003)(4326008)(8936002)(2906002)(53546011)(6506007)(66946007)(64756008)(66556008)(66476007)(66446008)(81156014)(71200400001)(8676002)(110136005)(316002)(15650500001)(26005); DIR:OUT; SFP:1101; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Yw0kD6cPlzmI/SqnfsL5PgGQsWwHEx+Iy8C1JPa2iHFC1jH3WW2WALvBpyBQXL1tyK2nd6qAYVfLE9nZnbK6X/lrSYOMj+QrVbMwAS7W/VSJHQ4ImLo58TkgapFYT4oHjagnsAWREIv9LJ6P4bEtxmdCxXRlJsjnAk5G/Im2E1y/q+9mf77R042jtNsLbbcLZUq+jBtx0BbegOLaGKpr8+Rss4II4ELaEGtRf5jDsoD/xPWvAfKqHSPpSVBe2GLf5QlzPenA4ixRfNE+CFSN1EmeMvv31UIL7zjU/hc2Ho6Byr37pRNIMvKWZ5PFzHBk9VOwNS/nQ+4pMZTYhBCb3ONKHSaqgB2geaMIFbjlwXeWs1WMolhKqwG2vqUkWcSAymvtfOzfH3EEaMUF8yAgHXnQq4KfAGJ+FyUK04rutu/KB3+d0TSNtNvcMHgdOpUG x-ms-exchange-antispam-messagedata: cg94V05rndfGouim/v8/dLY3IZMqGf8b/wBoopHlhuIVaigcQwq7KwM8E1AA9+YYqN77IyNjirne8oiLlqsRFqEu8+FRkPTSeLz5fdFxEZlBM3764sxANN0YZJQIZ+3PFRdUoiTWziUMvkJa00Jpdw== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3781272f-058e-4f52-e7d3-08d7e512ebe1 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Apr 2020 10:09:32.5087 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: xLBlS7Jn3oJUVHFvEQnZSQzGYdEQMYD726T9RheOKMDVE+CNEZLxsAYVuZiPQRVPMWFP8NWdXQNGWY/nTYUL1Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR05MB5878 Subject: Re: [dpdk-dev] [PATCH v2] doc: update flow non-cached mode notes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Bing, > -----Original Message----- > From: Bing Zhao > Sent: Monday, April 13, 2020 5:56 PM > To: john.mcnamara@intel.com; marko.kovacevic@intel.com; Slava Ovsiienko > ; Matan Azrad > Cc: Shahaf Shuler ; Raslan Darawsheh > ; Ori Kam ; dev@dpdk.org; > Thomas Monjalon > Subject: [PATCH v2] doc: update flow non-cached mode notes >=20 > This patch updates the MLX5 PMD and release notes documentations. > Adding the notes of the behavior change that rte flows organization > is switched into non-cached mode for applications. >=20 > Signed-off-by: Bing Zhao > --- > v2: update the description in release notes. > --- > doc/guides/nics/mlx5.rst | 10 ++++++++++ > doc/guides/rel_notes/release_20_05.rst | 1 + > 2 files changed, 11 insertions(+) >=20 > diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst > index e13c07d..63138c4 100644 > --- a/doc/guides/nics/mlx5.rst > +++ b/doc/guides/nics/mlx5.rst > @@ -1287,6 +1287,16 @@ set, and we should allow to specify zero values as > rte_flow parameters for the > META and MARK items and actions. In the same time zero mask has no > meaning and > should be rejected on validation stage. >=20 > +Notes for rte_flow > +------------------ > +Implementation of flows organization is in non-cached mode. When stoppin= g a > +device, all the flows inserted from application will be considered inval= id and > +flushed automatically in the background. After restarting of the device,= no > +application's flow exists in the system. > + I think that it should be stated that all flows are destroyed, and the refe= rence to those flows are not valid any more. It is important to tell that the pointers tha= t the application is holding is not valid anymore, and should be discarded by the application= . > +The application should re-insert the flows as required after device rest= arting, > +and must not try to destroy or flush the invalid flows before stopping. > + Here I think it should say: The application should recreate the flows. Again it to make sure that the application flow pointers are not valid anym= ore. Also I don't understand the last line, The application should destroy all f= lows=20 before stopping the device. > Notes for testpmd > ----------------- >=20 > diff --git a/doc/guides/rel_notes/release_20_05.rst > b/doc/guides/rel_notes/release_20_05.rst > index 4b81893..b951745 100644 > --- a/doc/guides/rel_notes/release_20_05.rst > +++ b/doc/guides/rel_notes/release_20_05.rst > @@ -62,6 +62,7 @@ New Features >=20 > * Added support for matching on IPv4 Time To Live and IPv6 Hop Limit. > * Added support for creating Relaxed Ordering Memory Regions. > + * Flow rules caching removed from the driver for memory saving. >=20 And correctness according to RTE flow. Thanks, Ori > * **Updated the Intel ice driver.** >=20 > -- > 1.8.3.1