From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 27D95A00C5; Mon, 6 Jul 2020 09:02:10 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 717D71D525; Mon, 6 Jul 2020 09:02:09 +0200 (CEST) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60047.outbound.protection.outlook.com [40.107.6.47]) by dpdk.org (Postfix) with ESMTP id DB9F01D163 for ; Mon, 6 Jul 2020 09:02:07 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Spxx38fo8iUlItPW0tdJpZ8hJtS1W3RZatmrxWpkqOQGgawUDmifFbTXrxI+4d8niMQasd5PIfVIdLoqdCtHXuUNGSXcInm0m+zucdAUSOfefd6zl6s/SjoyBISSurOIwg8WyFXUrw7DMFZVOx5blZRWjsly3JlDpxEsxvZGxh1qYVk0geAJdq7nyGnnLLXpEqksN58TXd92GMTzTxVwzLJGi7NrprIITXioU1dRwfvUytjvfU6FC9FwkJXdIR5CMad8Qn4rFJmcvXOg8lB5toOl7ijshM5yoWeEey9kDzvsvvtzdV5z7hFhR3IIeKmxGHn44vTXrDwiGtNmp4KRng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=q7hAqZsDIuENZamlVuJOuLE9M2SAViHfax2ik8oecTU=; b=LRS+ZHJVEbM4ERrhqxmu7+hGW2Vfb6R7BHwaTudNEpNdxAg/7X3a6riNF0c7Wt22XnpcfHIFBS8jSLz93gIs5A3f6ID2xA81HrcqX9rwlIYpvWaG86qmNlL/v2eyWQA/Wx9OkB55w+Md5qxJ8D4nkysHqlLr4wp4hhVA6wUgKzjSctlXLVsAUaKQBo8BcgsPLJieIF8JqBRZM1WH9BjP8xZjIOFErpTBN5Z8SPREPQk/2f1YgcWJn8fOUvB5fg3ApR9DHorFKcbym4v1sH304H/7l/vwjz/KXMXrNAQkwXT+7+POPCfoLyLGsDKuBUuf6YfGCELg8yE82T0lhJhE+Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=q7hAqZsDIuENZamlVuJOuLE9M2SAViHfax2ik8oecTU=; b=obAOiemEYr8aqii5hMIFGhFMFt1C7v4oIiExbwlJKCVh1oFQUO1t0MD4Xqzexrs7R6rFSRMTYMjh7yWvpgfv+h6uCBeU46oJ3uq2Pw+wR3bjkZBeLJP/SkWq+6zBrkqCv/898jnqTh2L53nnwJcaZZP+YDOWhuaD0PC/OrcVCVM= Received: from AM6PR05MB5176.eurprd05.prod.outlook.com (2603:10a6:20b:63::30) by AM6PR05MB6310.eurprd05.prod.outlook.com (2603:10a6:20b:b5::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3153.27; Mon, 6 Jul 2020 07:02:06 +0000 Received: from AM6PR05MB5176.eurprd05.prod.outlook.com ([fe80::9024:accb:4d6b:805f]) by AM6PR05MB5176.eurprd05.prod.outlook.com ([fe80::9024:accb:4d6b:805f%3]) with mapi id 15.20.3153.029; Mon, 6 Jul 2020 07:02:06 +0000 From: Ori Kam To: Thomas Monjalon , "jerinj@marvell.com" CC: "xiang.w.wang@intel.com" , "dev@dpdk.org" , "guyk@marvell.com" , "pbhagavatula@marvell.com" , Shahaf Shuler , "hemant.agrawal@nxp.com" , Opher Reviv , Alex Rosenbaum , "dovrat@marvell.com" , "pkapoor@marvell.com" , "nipun.gupta@nxp.com" , "bruce.richardson@intel.com" , "yang.a.hong@intel.com" , "harry.chang@intel.com" , "gu.jian1@zte.com.cn" , "shanjiangh@chinatelecom.cn" , "zhangy.yun@chinatelecom.cn" , "lixingfu@huachentel.com" , "wushuai@inspur.com" , "yuyingxia@yxlink.com" , "fanchenggang@sunyainfo.com" , "davidfgao@tencent.com" , "liuzhong1@chinaunicom.cn" , "zhaoyong11@huawei.com" , "oc@yunify.com" , "jim@netgate.com" , "hongjun.ni@intel.com" , "deri@ntop.org" , "fc@napatech.com" , "arthur.su@lionic.com" Thread-Topic: [dpdk-dev] [PATCH v4 1/4] regexdev: introduce regexdev subsystem Thread-Index: AQHWUETzf1LlsbP1xkag8xRbJsjy8aj5gyeAgACeHOA= Date: Mon, 6 Jul 2020 07:02:06 +0000 Message-ID: References: <1585464438-111285-1-git-send-email-orika@mellanox.com> <1593675963-13317-1-git-send-email-orika@mellanox.com> <1593675963-13317-2-git-send-email-orika@mellanox.com> <3275376.WQDlNZRKe8@thomas> In-Reply-To: <3275376.WQDlNZRKe8@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=mellanox.com; x-originating-ip: [147.236.152.129] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 65b180c6-f784-4e04-ce36-08d8217a7e82 x-ms-traffictypediagnostic: AM6PR05MB6310: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-forefront-prvs: 04569283F9 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 7qoN1zZ9o/zSkmGjQKFunVNf3pYMYIxus5Bh0I5PMclxKxmcXMnUA7edrBULd9Hj4nFipVAuBEbWfiakZ0qMfcM7soyX3u0NMKVJRNhcNl6knZ/V9h3N/sMKqFxf9Eglv6LK4SYo0jke7LF8q5BIxZHkhR8MMrDB9g2aJakI9Y2r1EVpOw4FQ/Kzhaps/iam6icoCNX6UA7fBg23b0jdrthmCSboCeZWgLzLPpDmbys39ZVenjTCEkX4j/SIZ2iRLeaggSmxAhjwfkveLdBrO2GZMQ9LHaA1xGQyqsgpLjiKxd3mcY9otl2wU2SVK4lp0i2/IYwEHiwemYmnvFx5JUKhpOmwBPtYfjjOBCXQ1XhYilRNR/Hjde+wnrD3Gi7P x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM6PR05MB5176.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(39860400002)(136003)(346002)(366004)(376002)(396003)(8676002)(4326008)(33656002)(66946007)(76116006)(66476007)(55016002)(66556008)(64756008)(66446008)(83380400001)(7416002)(71200400001)(478600001)(86362001)(8936002)(110136005)(316002)(7696005)(5660300002)(54906003)(2906002)(53546011)(6506007)(26005)(186003)(52536014)(9686003)(87944003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: Jlt5u+z5c2Ljeu756tA7Jz0BcwW7NxWLde1LFW1ScBB5Rjq/7dM2Y50g6I07KsTWulhlaU6jOaieQ8o9yqklCQWTC+YwohGV7q5inklSNCVF11cekeP0UFI2zoA+S4vHyFenNkwoTUS7Bg0Lk94vkWd5tbCptAVFTI/wLPN6LLaVtvSVy+LG5byvHo1/qVtH8q2Nvr2kxkHIE/xaBdG+d5UmcZERsO3k+J54iivIUAhvPFDj1omJXh79hhxksf9+1Bd253VYYQ+CjN5NmK2tqB8xjp/fhloP5NjrVvJZ1wuQDQDOsULs3qUKh7FFaVwlXRDnoL3XN6SsQNo6wBI5mZKwYue1lQGVpFRIc/ahK6I5cYIbVJ/8LSOWXpBgV7EBTdE00o7o0gxdmAqF/gPkNxu+6mMf7zeCVABRXGoS54s0VUFhOH7qpWCVlqQcj0245tD/KgPyA0bLpsiqX/D0RgzfF2igktlRj1GJxzX44+o+dUBqaiwVQBLTUJ5O16GX Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM6PR05MB5176.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 65b180c6-f784-4e04-ce36-08d8217a7e82 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Jul 2020 07:02:06.3314 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: f3aw2+I4BXtuyqc2SZ8rjWzEapVeKHHSidAV4O8B+x1G0rwcfOl+nM2NSs3+OyhCKfde5iPCjtcskkf4kRX8Dg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR05MB6310 Subject: Re: [dpdk-dev] [PATCH v4 1/4] regexdev: introduce regexdev subsystem X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Thomas, > -----Original Message----- > From: Thomas Monjalon > Sent: Monday, July 6, 2020 12:19 AM > To: jerinj@marvell.com; Ori Kam > Cc: xiang.w.wang@intel.com; dev@dpdk.org; guyk@marvell.com; > pbhagavatula@marvell.com; Shahaf Shuler ; > hemant.agrawal@nxp.com; Opher Reviv ; Alex > Rosenbaum ; dovrat@marvell.com; > pkapoor@marvell.com; nipun.gupta@nxp.com; bruce.richardson@intel.com; > yang.a.hong@intel.com; harry.chang@intel.com; gu.jian1@zte.com.cn; > shanjiangh@chinatelecom.cn; zhangy.yun@chinatelecom.cn; > lixingfu@huachentel.com; wushuai@inspur.com; yuyingxia@yxlink.com; > fanchenggang@sunyainfo.com; davidfgao@tencent.com; > liuzhong1@chinaunicom.cn; zhaoyong11@huawei.com; oc@yunify.com; > jim@netgate.com; hongjun.ni@intel.com; deri@ntop.org; fc@napatech.com; > arthur.su@lionic.com > Subject: Re: [dpdk-dev] [PATCH v4 1/4] regexdev: introduce regexdev > subsystem >=20 > 02/07/2020 09:46, Ori Kam: > > From: Jerin Jacob > > --- a/config/common_base > > +++ b/config/common_base > > # > > +# Compile regex device support > > +# > > +CONFIG_RTE_LIBRTE_REGEXDEV=3Dy > > + > > +# > > # Compile librte_ring > > # > > CONFIG_RTE_LIBRTE_RING=3Dy > > @@ -1141,3 +1146,4 @@ CONFIG_RTE_APP_CRYPTO_PERF=3Dy > > # Compile the eventdev application > > # > > CONFIG_RTE_APP_EVENTDEV=3Dy > > + >=20 > Why this empty line? >=20 Sure. > > --- a/doc/api/doxy-api-index.md > > +++ b/doc/api/doxy-api-index.md > > @@ -26,6 +26,7 @@ The public API headers are grouped by topics: > > [event_timer_adapter] (@ref rte_event_timer_adapter.h), > > [event_crypto_adapter] (@ref rte_event_crypto_adapter.h), > > [rawdev] (@ref rte_rawdev.h), > > + [regexdev] (@ref rte_regexdev.h), > > [metrics] (@ref rte_metrics.h), >=20 > Please move regexdev after [compress]. >=20 Sure. > > --- a/doc/api/doxy-api.conf.in > > +++ b/doc/api/doxy-api.conf.in > > @@ -61,6 +61,7 @@ INPUT =3D @TOPDIR@/doc/api/doxy-api= - > index.md \ > > @TOPDIR@/lib/librte_rcu \ > > @TOPDIR@/lib/librte_reorder \ > > @TOPDIR@/lib/librte_rib \ > > + @TOPDIR@/lib/librte_regexdev \ > > @TOPDIR@/lib/librte_ring \ >=20 > What is the ordering here? >=20 Will move it above rib. > > --- a/doc/guides/prog_guide/index.rst > > +++ b/doc/guides/prog_guide/index.rst > > @@ -72,3 +72,4 @@ Programmer's Guide > > lto > > profile_app > > glossary > > + regexdev_lib >=20 > Why adding it at the end? > I would suggest adding regexdev after compressdev. >=20 Sure. > > --- /dev/null > > +++ b/doc/guides/prog_guide/regexdev_lib.rst >=20 > Please remove the _lib suffix in this filename. >=20 Sure. > [...] > > +The dequeue API uses the same format as the enqueue API of processed b= ut > > +the ``nb_ops`` and ``ops`` parameters are now used to specify the max > processed > > +operations the user wishes to retrieve and the location in which to st= ore > them. > > +The API call returns the actual number of processed operations returne= d, > this > > +can never be larger than ``nb_ops``. > > + >=20 > Please avoid empty line at end of files. >=20 Sure. > > --- /dev/null > > +++ b/lib/librte_regexdev/Makefile > > @@ -0,0 +1,31 @@ > > +# SPDX-License-Identifier: BSD-3-Clause > > +# Copyright(C) 2019 Marvell International Ltd. > > +# Copyright(C) 2020 Mellanox International Ltd. >=20 > Mellanox copyright is wrong. It should be: > Copyright 2020 Mellanox Technologies, Ltd > Will fix. =20 > > --- /dev/null > > +++ b/lib/librte_regexdev/meson.build > > @@ -0,0 +1,7 @@ > > +# SPDX-License-Identifier: BSD-3-Clause > > +# Copyright(c) 2020 Mellanox Corporation >=20 > Wrong copyright. Please check them all. >=20 Will fix. > > + > > +allow_experimental_apis =3D true >=20 > Internal libraries do not need such flag anymore. >=20 Will remove. > > +sources =3D files('rte_regexdev.c') > > +headers =3D files('rte_regexdev.h') > > +deps +=3D ['mbuf'] > [...] > > --- a/lib/meson.build > > +++ b/lib/meson.build > > @@ -25,7 +25,7 @@ libraries =3D [ > > 'gro', 'gso', 'ip_frag', 'jobstats', > > 'kni', 'latencystats', 'lpm', 'member', > > 'power', 'pdump', 'rawdev', > > - 'rib', 'reorder', 'sched', 'security', 'stack', 'vhost', > > + 'regexdev', 'rib', 'reorder', 'sched', 'security', 'stack', 'vhost', >=20 > strange choice :) > I would have added regex at the end of the previous line which is shorter= . >=20 Will change. >=20