From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 93225A0523; Thu, 2 Jul 2020 09:20:29 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 706581D619; Thu, 2 Jul 2020 09:20:29 +0200 (CEST) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60054.outbound.protection.outlook.com [40.107.6.54]) by dpdk.org (Postfix) with ESMTP id 9D53E1D5FB for ; Thu, 2 Jul 2020 09:20:28 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CThzKF3Tmt1Mo2gKyN2TcFQ6swXmpmdMEBB6loQ/cI0333RERY0c2dAlTDdT4Ap8zgKLkYlz5wzpjcI0U035erKeLDe9SX7KbzXOUsXDvM1LP1HSXPbAXwRnyxPgO5IXQ7oI1Ji0nps4GjWvfT924/EA/UIdbr65ZyVw74y88kDMqr6BDrRRB44TOorxb9CGatBmK22KmWzCbwDeuxsBVf7UAl/p6ny6K/BBAYo6UZLHaFAl0kUux4FoMhoWod0qMu+8Aw+P8OsPDioNPPyKrJZHg6/52qjlSUQSaU5O7DOzYv79NH3aYTsZW7vqFadhtKHweSVJ/IZaIvBZCcUyKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zy4YlDfuqzOC7Cy9KC/ZSvh28WA5ee8pN7KtZWnYq3U=; b=H9YKJ9AwwwBcLlVFYhdXTy+FsAp6S/OHdT9+KXnvfjYjB3rjcu82MXquacGdXk46qzNLsH/KIeb6IxM1A56cxhYCKjPEYgeoT4aQ4y0dH1lF+hVXl6pWaviWuRH999pX8aoeaULExgjxa4wNll076/yzA2R3nW6xudKaBsiAFyl575wv+4flo5ZFEfT39goWx66JJeVjJPxAdasgCfXmQOM+sgOTUhGPpTDRIugxdrgTxvqzKMMHnmgrWGBTcs+1sZG1uQBh8gG8VSMPRmYASLP+0AgieL5Zu0aM5LQH4J9Ut6oSOy9s7VEFd0mmaEZFq1rDE7f9BqlKKMopMJcEyQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zy4YlDfuqzOC7Cy9KC/ZSvh28WA5ee8pN7KtZWnYq3U=; b=LDX07QFzW8ZydanvZXsHp1chYt3ba8AqmWXwHDbDZNTx52LKf1LPOlIXTrJc5r45QD0Iwcjqfg12WrWIrU/3ijqgGGebF6TSAWdUETE/dwzxcQvdYK4Fj6d1NJalkFxUfrIvvI/pKWiEOt7Stm2zVjU66KDivHgYIQQR8zMZBlI= Received: from AM6PR05MB5176.eurprd05.prod.outlook.com (2603:10a6:20b:63::30) by AM6PR05MB6310.eurprd05.prod.outlook.com (2603:10a6:20b:b5::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3131.21; Thu, 2 Jul 2020 07:20:28 +0000 Received: from AM6PR05MB5176.eurprd05.prod.outlook.com ([fe80::9024:accb:4d6b:805f]) by AM6PR05MB5176.eurprd05.prod.outlook.com ([fe80::9024:accb:4d6b:805f%3]) with mapi id 15.20.3131.030; Thu, 2 Jul 2020 07:20:27 +0000 From: Ori Kam To: Stephen Hemminger , Andrey Vesnovaty CC: Thomas Monjalon , Ferruh Yigit , Andrew Rybchenko , "dev@dpdk.org" , Andrey Vesnovaty Thread-Topic: [dpdk-dev] [RFC v2 1/1] add flow shared action API Thread-Index: AQHWRwdTAy746UnaSkKPuA+5UKonB6jzgCWAgABzvjA= Date: Thu, 2 Jul 2020 07:20:27 +0000 Message-ID: References: <20200620133257.12441-1-andrey.vesnovaty@gmail.com> <20200701172409.6b82bd6e@hermes.lan> In-Reply-To: <20200701172409.6b82bd6e@hermes.lan> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: networkplumber.org; dkim=none (message not signed) header.d=none;networkplumber.org; dmarc=none action=none header.from=mellanox.com; x-originating-ip: [147.236.152.129] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: f755d1a3-07cc-40f1-289f-08d81e586557 x-ms-traffictypediagnostic: AM6PR05MB6310: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3276; x-forefront-prvs: 0452022BE1 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: AXB8VL18oEhEOMzK6xrTFs2fyGzWNPJKxfR3m6e+Z+p6oDRVd6aZo5YNya09kFW9j7Roi3iFGqbrz6OnmJbeYe9M8LXA0rQCJ/IzUwpoc6FwflOTMdJmhElcTWUwTyDgAVfhdSulRcHn3rpNwoaT+KIRP7+JsEIvTA+Fs+hapJ1RT6jBzEuA37wSRtXwoxlIvv/yvb3/hbC1YDQBefWyjiTWxyviN+FktwQRM+ICx0m2epyrdr6M25MMxvXqNKNpJgLCpXNCK7ylsqcSXA3Bpj8lh5LO2GVho76BjFnqHJWvb8sI6NOqH42kHlW8YRPQ x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM6PR05MB5176.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(136003)(39850400004)(366004)(396003)(376002)(346002)(478600001)(52536014)(5660300002)(66556008)(7696005)(186003)(66476007)(83380400001)(33656002)(66946007)(4744005)(76116006)(316002)(8676002)(8936002)(55016002)(86362001)(4326008)(6506007)(9686003)(53546011)(71200400001)(2906002)(110136005)(54906003)(66446008)(64756008)(107886003)(26005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: UrzpHuuuAljM+l6uNZ3f/aW2mFDuGmtQ1+sZ34MbPiGOBKa6VdEzDj0nyK5LcWkAGSyFzW0sW5D/aKskJlPyrrP3Hudvo8tOROV5InAuYkhXPMRU0TiEo8cId02/TTTmaNV6P0/xZ/VgCXq038aGneBNbWLnPuBo112on9zGTRPrAozEPO4qfnUZ0DID3rlTqpZTpeILH7fdFiK0UNLhHbUq07f5wAT7ulQFcHkrWVPL0Z6aUCGPsWTsTtZs9D3AM9oI/PZHrLIM54a+Sfu4GTvSvn1Y/jJAJqkso+0qyUPkFtjVt9AKONzVfJ7z1/6/LVNG7gZE5deiLX6AVCRgWtK5PBTI5F77Q+gd/KE5JckuJLfkOkRegXqDJBGBFLlnkgDWkjJJEtNxDcDmE2q8t72l+f38uPCvHiHmP3dnOX984n9UHmqpGbJ+HBrRZ42awSqbERebWy3cbCSoZqaSpBPAxGpiQwNiW8CmeFNeww4z7zXni7DbRlDA/o2XwGDa Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM6PR05MB5176.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f755d1a3-07cc-40f1-289f-08d81e586557 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Jul 2020 07:20:27.7732 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ueFZTiZElpS4n1qZEgsRQ6ztFh4Ftf2C86l014OkZdUEIUrTrVbFwhB0aNezrZOaNEdFR75YspG2mEbBDXAoaw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR05MB6310 Subject: Re: [dpdk-dev] [RFC v2 1/1] add flow shared action API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Stephen, > -----Original Message----- > From: Stephen Hemminger > Sent: Thursday, July 2, 2020 3:24 AM > To: Andrey Vesnovaty > Cc: Thomas Monjalon ; Ferruh Yigit > ; Andrew Rybchenko ; > Ori Kam ; dev@dpdk.org; Andrey Vesnovaty > > Subject: Re: [dpdk-dev] [RFC v2 1/1] add flow shared action API >=20 > On Sat, 20 Jun 2020 16:32:57 +0300 > Andrey Vesnovaty wrote: >=20 > > + > > +void * > > +rte_flow_shared_action_create(uint16_t port_id, > > + const struct rte_flow_action *action, > > + struct rte_flow_error *error) > > +{ >=20 > NAK >=20 > API's that return void * (opaque pointer) are dangerous and should > not be added to DPDK. >=20 > To do data hiding. Define a structure but don't expose the internals > of what that structure are. I agree with you it is better not to use void * So I suggest to use new struct rte_action_ctx or something like this. That= =20 will be implemented differently for each driver just like rte_flow. What do you think? Best, Ori