From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0067.outbound.protection.outlook.com [104.47.2.67]) by dpdk.org (Postfix) with ESMTP id CE4DF5B26 for ; Mon, 1 Oct 2018 22:28:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fmhRxHj5ox5aoSv6VUEI1WOCCtZ1FINZ3mXPynPJPHA=; b=ZzuER3ngWHY23tu5OT7NkA850Vk9P+iv6lpsAf88Gz0P9s8gI1l3LXCZ6IfJ6rxpy79kT2YUfqWia34m2juvdmrsRrxXHytaB0y6o+7gfE5PwAbOqy/pO/Eyk8hPSvy9ZnSM1OVRtSzoC1QUyRecvg/cLyJCGr+CrGoQVbYYRYo= Received: from AM6PR08MB3672.eurprd08.prod.outlook.com (20.177.115.29) by AM6PR08MB3271.eurprd08.prod.outlook.com (52.135.164.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1185.22; Mon, 1 Oct 2018 20:28:28 +0000 Received: from AM6PR08MB3672.eurprd08.prod.outlook.com ([fe80::f423:e46a:a03c:e928]) by AM6PR08MB3672.eurprd08.prod.outlook.com ([fe80::f423:e46a:a03c:e928%2]) with mapi id 15.20.1185.024; Mon, 1 Oct 2018 20:28:28 +0000 From: Honnappa Nagarahalli To: Yipeng Wang , "bruce.richardson@intel.com" CC: "dev@dpdk.org" , "sameh.gobriel@intel.com" , nd , Honnappa Nagarahalli Thread-Topic: [PATCH v4 1/5] test/hash: fix bucket size in hash perf test Thread-Index: AQHUV3C6vYc6ieEypEWJYcqrvbF57aUK239g Date: Mon, 1 Oct 2018 20:28:28 +0000 Message-ID: References: <1537966465-248530-1-git-send-email-yipeng1.wang@intel.com> <1538143869-152808-1-git-send-email-yipeng1.wang@intel.com> <1538143869-152808-2-git-send-email-yipeng1.wang@intel.com> In-Reply-To: <1538143869-152808-2-git-send-email-yipeng1.wang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Honnappa.Nagarahalli@arm.com; x-originating-ip: [217.140.111.135] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM6PR08MB3271; 6:GnFpLz8MEzwlCsgdmo7wQYKntv3vWD5CrX79HC/AMqWHhXi5wUEkfuF/nUXkPzqTX/qAByk21YoFKizji0HC2WySl3ryhZ4ApECCuR282bFb6YX/C5nquyioGWQnMQ9DFbY05RRagebditD0dB8vzqUzHYWwYTbcY20y9mqkrBYhFJA33SoAGeUsbt0Aj6e9oPAx7McuU/ALVlhg2YZVcFCuhO0voInOlUlDxZMwJCDk+gVWUYrztiZuOSfUXaRuAiYmzccSQ4M63c9Hgz/lGPDZ3yl7Uf8+d1kn1f9OFVTkoEEmk3QaVl+aMnaCfnD/suuhNPc6seAlR1CIz8RScNhI2Re58POWw5NbBi2FkLz/xBrROfTnKFQGsd8BTcxh9RNPFSQUSVWUkQlzTDpyVIfNJbAQU/9nRi96hrr85X8DflIA0ddRh5qa8pGu89M3QOGE6zOwQQk5EHbZl8hlBw==; 5:hkITulfOHvJ+hz8m2rS55qGbDNuuiJ7BWcMynIn11Oj1KL5A7+kp7WaxEWuq6DhgpmqQwHt6bCH1tvSUHOJGjkUEM7/Yfgase5Rl8ZggJDFb5ilomfS1y262ZwFVygcgkhYwxFMZYlh2AD7kSu4oq4J3/E1MPq4PGmYn9kDYDds=; 7:j0YkwgssJ+pBKC+sk786mv8UjJDFs21pt2wFOIDIlqpjoRJmLNjcahpDeLDSqtqsDIc05Zv9xt9pseL0hX9nKlSoOXMZAvEdzGY8yR5LZaY7Ozmh8SvggCFD4yd45eoAwcsi2962oE80mBw/tuws5rMN/tP32Brj0YVewbMcXyQcmtm9bsjH+c36n+PaTgryJBo5d7Rp866VIrO107Gh5DlOmN6TWvRW4GJd8iPg/b7WrTgVC5tgiy82Sp7Wsyle x-ms-exchange-antispam-srfa-diagnostics: SOS;SOR; x-ms-office365-filtering-correlation-id: 8b3eb5dd-0871-4f7d-d368-08d627dc7282 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534165)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:AM6PR08MB3271; x-ms-traffictypediagnostic: AM6PR08MB3271: nodisclaimer: True x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(228905959029699)(180628864354917); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(10201501046)(3002001)(93006095)(93001095)(3231355)(944501410)(52105095)(6055026)(149066)(150057)(6041310)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123564045)(20161123560045)(201708071742011)(7699051); SRVR:AM6PR08MB3271; BCL:0; PCL:0; RULEID:; SRVR:AM6PR08MB3271; x-forefront-prvs: 0812095267 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(39860400002)(136003)(396003)(376002)(366004)(189003)(199004)(81156014)(68736007)(97736004)(2501003)(71200400001)(8936002)(72206003)(5250100002)(106356001)(71190400001)(2906002)(105586002)(4326008)(256004)(14454004)(6506007)(14444005)(2900100001)(6116002)(6246003)(316002)(478600001)(3846002)(66066001)(110136005)(33656002)(54906003)(11346002)(446003)(76176011)(26005)(186003)(7696005)(99286004)(102836004)(8676002)(486006)(6436002)(476003)(5660300001)(7736002)(74316002)(305945005)(229853002)(53936002)(81166006)(25786009)(55016002)(86362001)(9686003); DIR:OUT; SFP:1101; SCL:1; SRVR:AM6PR08MB3271; H:AM6PR08MB3672.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: 8i74qhMD3BZGYphBFLBArbUe/tH7+OD7f5zftjm7ayWcprs1OXApjy8HR21ohpJG8zUDm+7cXd6Id5HJimX2nbNzuhCIQDqfo4fQcd7AHcFPgoxR8w1AD2HknFrqb2qgfY0KXJp3KjVJopsrp0Z1pC8b2Y8n35QKMfbhdaXtkEC2UWbaTdw6lHyzmOEL3OuuMcYE6Yh0o38jLfIku6ylP5llQlya5CWHxBglTd3SOJyNve9upt15qHhqOmRhwpV8+HDZKRvDC/Vr0QLoqiaNFFbMbu3FSNsoHjT3Gge4F4EjkXRQ+Sqkefv4UgvVrn60S3niXUrWoPQ2J8GOHalWJT+h3i3O/hD/u01gCQ6t0Fk= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8b3eb5dd-0871-4f7d-d368-08d627dc7282 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Oct 2018 20:28:28.6031 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3271 Subject: Re: [dpdk-dev] [PATCH v4 1/5] test/hash: fix bucket size in hash perf test X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Oct 2018 20:28:30 -0000 >=20 > The bucket size was changed from 4 to 8 but the corresponding perf test w= as > not changed accordingly. >=20 > In the test, the bucket size and number of buckets are used to map to the > underneath rte_hash structure. They are used to test performance of two > conditions: keys in primary buckets only and keys in both primary and > secondary buckets. >=20 > Although there is no functional issue with bucket size set to 4, it misma= tches > the underneath rte_hash structure, which may affect code readability and > future extension. >=20 > Fixes: 58017c98ed53 ("hash: add vectorized comparison") > Cc: stable@dpdk.org >=20 > Signed-off-by: Yipeng Wang > Acked-by: Bruce Richardson > --- > test/test/test_hash_perf.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/test/test/test_hash_perf.c b/test/test/test_hash_perf.c inde= x > 33dcb9f..fe11632 100644 > --- a/test/test/test_hash_perf.c > +++ b/test/test/test_hash_perf.c > @@ -20,7 +20,8 @@ > #define MAX_ENTRIES (1 << 19) > #define KEYS_TO_ADD (MAX_ENTRIES * 3 / 4) /* 75% table utilization */ > #define NUM_LOOKUPS (KEYS_TO_ADD * 5) /* Loop among keys added, > several times */ -#define BUCKET_SIZE 4 > +/* BUCKET_SIZE should be same as RTE_HASH_BUCKET_ENTRIES in rte_hash > +library */ #define BUCKET_SIZE 8 > #define NUM_BUCKETS (MAX_ENTRIES / BUCKET_SIZE) #define > MAX_KEYSIZE 64 #define NUM_KEYSIZES 10 > -- > 2.7.4 Reviewed-by: Honnappa Nagarahalli