From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130055.outbound.protection.outlook.com [40.107.13.55]) by dpdk.org (Postfix) with ESMTP id 32012288C for ; Fri, 25 Jan 2019 06:21:00 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5SQeBSYAnb/HJA7oaYJRqARj7IDho6Y/yezCcBj6Lbw=; b=eo/uUaaSMN6H7QzGitLz8vvC0DTB2EpjTU3mwkZ7Xfi1gWBG7I6IjsEnBLE/1DimI2CDExn6jQkYfgzfTmjpMumWAaHAmsK+B04mo/jLh2F/IUfXYNfd9limxxdw0zID56U469IxTwjF7A1BJNGCEeIXwf2BuPKw+Vgtqb9yVb0= Received: from AM6PR08MB3672.eurprd08.prod.outlook.com (20.177.115.76) by AM6PR08MB3814.eurprd08.prod.outlook.com (20.178.89.211) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1558.16; Fri, 25 Jan 2019 05:20:58 +0000 Received: from AM6PR08MB3672.eurprd08.prod.outlook.com ([fe80::9120:87d6:b17c:fadd]) by AM6PR08MB3672.eurprd08.prod.outlook.com ([fe80::9120:87d6:b17c:fadd%3]) with mapi id 15.20.1558.016; Fri, 25 Jan 2019 05:20:58 +0000 From: Honnappa Nagarahalli To: Gage Eads , "dev@dpdk.org" CC: "olivier.matz@6wind.com" , "arybchenko@solarflare.com" , "bruce.richardson@intel.com" , "konstantin.ananyev@intel.com" , "stephen@networkplumber.org" , nd , "thomas@monjalon.net" , Ola Liljedahl , "Gavin Hu (Arm Technology China)" , "Song Zhu (Arm Technology China)" , nd Thread-Topic: [dpdk-dev] [PATCH v3 0/5] Add non-blocking ring Thread-Index: AQHUr0Httc0m4RqMZ0ywUdJApYhE2aW/dt8Q Date: Fri, 25 Jan 2019 05:20:58 +0000 Message-ID: References: <20190115235227.14013-1-gage.eads@intel.com> <20190118152326.22686-1-gage.eads@intel.com> In-Reply-To: <20190118152326.22686-1-gage.eads@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Honnappa.Nagarahalli@arm.com; x-originating-ip: [217.140.111.135] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM6PR08MB3814; 6:XlxTvhTTL8cFo3WqFX1ZteAF9y3Gozhw6TlyySJK15w4NRCREJ3c0j6XErupy5N4UssZGNAwtRPLRTMKIOQnNUnCexVHalfuLuraOPnnyrg5e3CpVKN4KveTCvbTMbRfOBOLaNK7fp4G0ke5bMwPDd4cSoPugdy/13Br0wXnbCFytHslMy7u7Ksn0Kb4z0myqwUnMf379Att+HWaUBf/DnbI2m8EVIROFKoxch4YFXFtOaVi7FcCNLjogcwQOVYewg4a+LPzSTCt6VnDAnv5+3jOVsZtCkHedpKErwu8RrwAHP2TmcZn03jBrXGg0xw5eda+NYuzPlpotfKlvUjsqWwCZrxbM9j96dc/Qi/ChtyyFLq056/gV+VuciWSKWpPjMHmB5qkapYaGPZOgy4w0kO3hiTi1FNM5SwiPJr1Yt6Dgb4xZE4JknPgvBWXVtF6Cy6TdPs0ibQ7fOsjhiOWDw==; 5:lFHiH/yJbMSHk4YDePCGokpQepvBgVoOcbqxGVxX1xxeDn7t9AWLEmkvUkidmSDmiMb7uQ0ahqjzfMb22p5l9nOcnrS2bF6AQ6TrWI9fRkBTu/EziVlxDtAlv7DBwMCqOPwsZS00sGn0dHbZM7iuTI+gGqSgy7bzLcFjY7SkctMv/EgiviVivhDYv5R+fV3rYaBWKINjYXM3RzriiQRz8g==; 7:Kz1Lytk+ITDbbG4GDw31Tz/6M8s4yLBkE2Ink+L1NAD/6e0J0Ry8UYZHTQ/DXkIFeZ/ZBlp95uP+fo2zh/laLYm7qqCYfZ9ochQofaHMPW87are33yiP5sVsOi3a7ZSUenzilWU7WgY59d/kklFtCw== x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 9a19c5a1-5ca3-4bac-0117-08d68284e382 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600110)(711020)(4605077)(4618075)(2017052603328)(7153060)(7193020); SRVR:AM6PR08MB3814; x-ms-traffictypediagnostic: AM6PR08MB3814: x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr nodisclaimer: True x-microsoft-antispam-prvs: x-forefront-prvs: 0928072091 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(136003)(39860400002)(396003)(346002)(376002)(366004)(13464003)(189003)(199004)(68736007)(7736002)(14454004)(966005)(72206003)(9686003)(8936002)(55016002)(2906002)(6306002)(106356001)(81166006)(345774005)(81156014)(8676002)(105586002)(478600001)(71190400001)(71200400001)(33656002)(486006)(476003)(4326008)(11346002)(446003)(2501003)(99286004)(6246003)(110136005)(7696005)(54906003)(316002)(76176011)(186003)(66066001)(26005)(102836004)(53546011)(6506007)(256004)(25786009)(14444005)(6436002)(74316002)(3846002)(97736004)(6116002)(53936002)(229853002)(305945005)(86362001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM6PR08MB3814; H:AM6PR08MB3672.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: VhDkYdUsF3jT6ILYefXvnpRnEok7GvOU1hi2dBnx7E+mVyZMVgcwxD9uuNvDdQoWEBx8cT+lrYaEsnrZs8EKnPulcWjQGA5phzY37qlyn+GMDiNzh3xE7hM5AAvkyOMA8wIWZ3Shj3QQeybBN9rm4CXWq5GKtXp14YhsZjUj9JQ/OImx1B3bismLnDK6ATPBHQCLpaR31b27ng68jK26PDlVjaHxsNzzCCN0ywqDJw1zgIi3v7rLJwC5XXBc0pS/4dbwHUhkGcIvB9YygSbaH1MS+LH/k4VYlCQCWtmSuv4oJanNgTFl+zNizIA5nTevpfzBrouzUF30LL/CDuwGvbHrLWblgJ036wFctudTCsUc8TqCPfexTY3ezlLFRl9gWEbhdHSxnKqT42C+/6dPT1AADvulxsKZdeVMUox6SQA= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9a19c5a1-5ca3-4bac-0117-08d68284e382 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Jan 2019 05:20:58.3120 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3814 Subject: Re: [dpdk-dev] [PATCH v3 0/5] Add non-blocking ring X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jan 2019 05:21:00 -0000 Hi Gage, Thank you for this patch. Arm (Ola Liljedahl) had worked on a non-blocking= ring algorithm. We were planning to add it to DPDK at some point this year= . I am wondering if you would be open to take a look at the algorithm and c= ollaborate? I am yet to fully understand both the algorithms. But, Ola has reviewed you= r patch and can provide a quick overview of the differences here. If you agree, we can send a RFC patch. You can review that and do performan= ce benchmarking on your platforms. I can also benchmark your patch (may be = once you fix the issue identified in __rte_ring_do_nb_enqueue_mp function?= ) on Arm platforms. May be we can end up with a better combined algorithm. Hi Thomas/Bruce, Please let me know if this is ok and if there is a better way to do this. Thank you, Honnappa > -----Original Message----- > From: dev On Behalf Of Gage Eads > Sent: Friday, January 18, 2019 9:23 AM > To: dev@dpdk.org > Cc: olivier.matz@6wind.com; arybchenko@solarflare.com; > bruce.richardson@intel.com; konstantin.ananyev@intel.com; > stephen@networkplumber.org > Subject: [dpdk-dev] [PATCH v3 0/5] Add non-blocking ring >=20 > For some users, the rte ring's "non-preemptive" constraint is not accepta= ble; > for example, if the application uses a mixture of pinned high-priority th= reads > and multiplexed low-priority threads that share a mempool. >=20 > This patchset introduces a non-blocking ring, on top of which a mempool c= an > run. > Crucially, the non-blocking algorithm relies on a 128-bit compare-and-swa= p, > so it is currently limited to x86_64 machines. This is also an experiment= al API, > so RING_F_NB users must build with the ALLOW_EXPERIMENTAL_API flag. >=20 > The ring uses more compare-and-swap atomic operations than the regular rt= e > ring: > With no contention, an enqueue of n pointers uses (1 + 2n) CAS operations > and a dequeue of n pointers uses 2. This algorithm has worse average-case > performance than the regular rte ring (particularly a highly-contended ri= ng > with large bulk accesses), however: > - For applications with preemptible pthreads, the regular rte ring's wors= t-case > performance (i.e. one thread being preempted in the update_tail() criti= cal > section) is much worse than the non-blocking ring's. > - Software caching can mitigate the average case performance for ring-bas= ed > algorithms. For example, a non-blocking ring based mempool (a likely us= e > case > for this ring) with per-thread caching. >=20 > The non-blocking ring is enabled via a new flag, RING_F_NB. For ease-of-u= se, > existing ring enqueue/dequeue functions work with both "regular" and non- > blocking rings. >=20 > This patchset also adds non-blocking versions of ring_autotest and > ring_perf_autotest, and a non-blocking ring based mempool. >=20 > This patchset makes one API change; a deprecation notice will be posted i= n a > separate commit. >=20 > This patchset depends on the non-blocking stack patchset[1]. >=20 > [1] http://mails.dpdk.org/archives/dev/2019-January/123653.html >=20 > v3: > - Avoid the ABI break by putting 64-bit head and tail values in the same > cacheline as struct rte_ring's prod and cons members. > - Don't attempt to compile rte_atomic128_cmpset without > ALLOW_EXPERIMENTAL_API, as this would break a large number of librarie= s. > - Add a helpful warning to __rte_ring_do_nb_enqueue_mp() in case someone > tries > to use RING_F_NB without the ALLOW_EXPERIMENTAL_API flag. > - Update the ring mempool to use experimental APIs > - Clarify that RINB_F_NB is only limited to x86_64 currently; ARMv8.1-A > builds > can eventually support it with the CASP instruction. >=20 > v2: > - Merge separate docs commit into patch #5 > - Convert uintptr_t to size_t > - Add a compile-time check for the size of size_t > - Fix a space-after-typecast issue > - Fix an unnecessary-parentheses checkpatch warning > - Bump librte_ring's library version >=20 > Gage Eads (5): > ring: add 64-bit headtail structure > ring: add a non-blocking implementation > test_ring: add non-blocking ring autotest > test_ring_perf: add non-blocking ring perf test > mempool/ring: add non-blocking ring handlers >=20 > doc/guides/prog_guide/env_abstraction_layer.rst | 2 +- > drivers/mempool/ring/Makefile | 1 + > drivers/mempool/ring/meson.build | 2 + > drivers/mempool/ring/rte_mempool_ring.c | 58 ++- > lib/librte_eventdev/rte_event_ring.h | 2 +- > lib/librte_ring/Makefile | 3 +- > lib/librte_ring/rte_ring.c | 72 ++- > lib/librte_ring/rte_ring.h | 574 ++++++++++++++++++= ++++-- > lib/librte_ring/rte_ring_generic_64.h | 152 +++++++ > lib/librte_ring/rte_ring_version.map | 7 + > test/test/test_ring.c | 57 ++- > test/test/test_ring_perf.c | 19 +- > 12 files changed, 874 insertions(+), 75 deletions(-) create mode 100644 > lib/librte_ring/rte_ring_generic_64.h >=20 > -- > 2.13.6