From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60042.outbound.protection.outlook.com [40.107.6.42]) by dpdk.org (Postfix) with ESMTP id CCB971B4F5 for ; Tue, 23 Oct 2018 16:15:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uLos5zMPilWR/fJKFGde8FQNUTcx9/10AeqhSnFFEiU=; b=EC6QI2t/nPneuO7uZaxWt7cvi5UU3fOKCbwXB4qgv7V7LyqwgqnNPe7zS3sUgJC40p9bHvyUFsJrO9PH1+j4xSyAbP7a7R8peS2Ntkw97AhCaxWVLqbEf0rYgElqywnKV33qRsTr8fwFDqbl5YhH+ceC70lEU0zwtDLr2QvL1yE= Received: from AM6PR08MB3672.eurprd08.prod.outlook.com (20.177.115.29) by AM6PR08MB3637.eurprd08.prod.outlook.com (20.177.115.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1250.30; Tue, 23 Oct 2018 14:15:30 +0000 Received: from AM6PR08MB3672.eurprd08.prod.outlook.com ([fe80::c1a0:51bf:cd33:2b27]) by AM6PR08MB3672.eurprd08.prod.outlook.com ([fe80::c1a0:51bf:cd33:2b27%5]) with mapi id 15.20.1250.028; Tue, 23 Oct 2018 14:15:30 +0000 From: Honnappa Nagarahalli To: Bruce Richardson CC: "pablo.de.lara.guarch@intel.com" , "dev@dpdk.org" , "yipeng1.wang@intel.com" , "Gavin Hu (Arm Technology China)" , Dharmik Thakkar , nd Thread-Topic: [PATCH v5 5/5] test/hash: read-write lock-free concurrency test Thread-Index: AQHUascct1CfoycaAkGoyrbHgxXo+qUs1TMQ Date: Tue, 23 Oct 2018 14:15:30 +0000 Message-ID: References: <1540268524-126673-1-git-send-email-honnappa.nagarahalli@arm.com> <1540268524-126673-6-git-send-email-honnappa.nagarahalli@arm.com> <20181023115403.GE18800@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20181023115403.GE18800@bricha3-MOBL.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Honnappa.Nagarahalli@arm.com; x-originating-ip: [217.140.111.135] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM6PR08MB3637; 6:JnU8xWIWHd3yPPhwxmGTl8S/7bjXPigeFE0LOmsQ2WeAsldrnDcrlLimSHNNmdYk00ZTQc/An2+TFlnHwUe4IUAafhsngpgzstNOWDzxzXKhhXmZpnyakbmM1yVlm84pc9mM+9234oVU10kwnmLOhbakQ652iBSivv3/tYCidk6ZMiX/AljuldJcPQAcuRQqePgeNihmDW7PMLadjzc0E0aZ46HO0Qnq/mEjIqpPvTZc3mGm2jsyFlOrzxT9z+N81wmzwXKQ7r4V2j76TRx8E3S/5jJqky4TnpBVVX5mGqFe4+9YZaguymCLL6aISW7EwTigHIROQVXed52SYUMYPxjIulRKHfsClIhAl8vyGF0BJpl0INBxFGG19KdlyiVVthaYEGGd3VEOHxeKiDVHZbxxUw+9ry/CTFR0+DpdYz/V77zNTvTgFpp/mVCmIOuGOSen9VNIMuA8F3ltLqfyjQ==; 5:am1yrsK9/IbB/PUlR7DKqnFAHjvscn6daPEooZ4HzLbZdjF6ZjMXabDP6x65aa/E8rH41JpmBeGZWMeYjPV3BV1MvsvRPOSapo1EkJLKHo1Au5pTCqdw2Wow00XMIfUuNhmQOTHdJl/6+aqDi2QtiVRN2Cv8/dQmONVxmJMe3BE=; 7:bDUmFzN0fihUO6QS/4TwRI/Y75lmr5dgC0nWPYeCfNsOzf8zDQhYALotRAP9L2XG2HjJ84vAKoxYLe9WhlHcPf92F2f8y57ZdDxbx8K0GyLUZSdxWAXTe7Rn6te6E+8JgzBPb19gkZrQc2AtLyUy532mwHL79Zw0pDpK6/vVYTTXmjGgR71mV1/mFnE6BCCKy0w5ifiPdIvhUzcTBYVpSL66v3JQyiuqVaXsC32muqlN8d3Vw0YWmRzLRFqPhMxc x-ms-exchange-antispam-srfa-diagnostics: SOS;SOR; x-ms-office365-filtering-correlation-id: fb4f5d45-bf85-4227-497d-08d638f1fd49 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(5600074)(711020)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020); SRVR:AM6PR08MB3637; x-ms-traffictypediagnostic: AM6PR08MB3637: nodisclaimer: True x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(180628864354917)(228905959029699); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(93006095)(93001095)(3002001)(3231355)(944501410)(52105095)(6055026)(148016)(149066)(150057)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123564045)(20161123560045)(20161123562045)(201708071742011)(7699051)(76991095); SRVR:AM6PR08MB3637; BCL:0; PCL:0; RULEID:; SRVR:AM6PR08MB3637; x-forefront-prvs: 0834BAF534 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(366004)(39860400002)(136003)(346002)(376002)(199004)(189003)(5660300001)(5250100002)(102836004)(2906002)(11346002)(6116002)(6506007)(106356001)(476003)(76176011)(3846002)(446003)(6916009)(186003)(68736007)(8676002)(99286004)(8936002)(81166006)(71190400001)(2900100001)(81156014)(71200400001)(9686003)(4326008)(6436002)(256004)(54906003)(74316002)(7736002)(14454004)(305945005)(7696005)(86362001)(55016002)(6246003)(97736004)(229853002)(66066001)(105586002)(486006)(345774005)(33656002)(316002)(72206003)(53936002)(26005)(478600001)(25786009)(20703003); DIR:OUT; SFP:1101; SCL:1; SRVR:AM6PR08MB3637; H:AM6PR08MB3672.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: M5ehLGWgq122OvkVoXsgy11XNqjRr/90jc+8TtQQbsqAOqDPk+1qsJYhC+ApO8HmpqBvSq9PLFdaqAeVVkBM8737vfRqdriytmUq+arMLbi5JV/Pd3fuGr3u0ta6loGM8PyicMTbaGfPYvvj0urxme9twYj8GZJFlEE1MWrG9ncEzCp/dcQepkncLgZ2B3sG6EgPw4cKR8I2nCKCm1ecamUE9eKUum3rKPXsTLoC3iCYxjcTp8RvtpElWxBeUL2u+OTW1F09CiwZyk0aMjJ6JNN8zRJ/BTjtWVexXeXx/lA5TLTj6RWrSUFwEWcO+qgECImmiVloCJI1TidSBgKapWV0cEGTP91ZAQbRh3Zu88U= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: fb4f5d45-bf85-4227-497d-08d638f1fd49 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Oct 2018 14:15:30.6278 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3637 Subject: Re: [dpdk-dev] [PATCH v5 5/5] test/hash: read-write lock-free concurrency test X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Oct 2018 14:15:32 -0000 Hi Bruce, Thank you for the review. > > - hash lookup on existing keys NOT likely to be on shift-path with: > > - hash add causing key-shifts of existing keys in the table > > > > - hash lookup on non-existing keys with: > > - hash add causing NO key-shifts of existing keys in the table > > - hash add causing key-shifts of existing keys in the table > > > > - hash lookup on keys likely to be on shift-path with: > > - multiple writers causing key-shifts of existing keys in the table > > > > Signed-off-by: Dharmik Thakkar > > Reviewed-by: Honnappa Nagarahalli > > Reviewed-by: Gavin Hu > > Reviewed-by: Yipeng Wang > > --- >=20 > Does this need to be done via a completely new test case? Given the numbe= r > of unit tests for the hash table structure, I'm wondering if we can conso= lidate > things a bit. Any thoughts? >=20 Are you concerned about new test case or new test case file? >>From a new test case perspective, we are testing a new use case, hence we n= eed it. May be few parts can be combined such as generating the keys. >>From a new test case file perspective, combining this use case with existin= g files was making the code difficult to manage. Hence we decided to add a = new file. There are more test cases because of multiple configuration options present= in hash table. > /Bruce