From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30064.outbound.protection.outlook.com [40.107.3.64]) by dpdk.org (Postfix) with ESMTP id D37D62B8C for ; Fri, 26 Oct 2018 02:23:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IjmVDKbAYSVlDumntf3HwMF7NR1t3SdlwAAwJx1/dqQ=; b=YT7Va864r2tvnVXOcJubZRGv6Lz5sqNiTC5v6JqjKcoixkSA0jrgCVN7CQafW3mAPCnOSH1C7xP+r5cmqvYyTMomJiMwybYcHoPgw/3uxzJwJ8LnGho0+ZhLA+7WuZkQp1aZAYZkjYe5k5IedT6QyOR3obwrVYsABzc7jrm2XIo= Received: from AM6PR08MB3672.eurprd08.prod.outlook.com (20.177.115.29) by AM6PR08MB3879.eurprd08.prod.outlook.com (20.178.90.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1273.19; Fri, 26 Oct 2018 00:23:56 +0000 Received: from AM6PR08MB3672.eurprd08.prod.outlook.com ([fe80::c1a0:51bf:cd33:2b27]) by AM6PR08MB3672.eurprd08.prod.outlook.com ([fe80::c1a0:51bf:cd33:2b27%5]) with mapi id 15.20.1250.032; Fri, 26 Oct 2018 00:23:56 +0000 From: Honnappa Nagarahalli To: Bruce Richardson , Yipeng Wang CC: "stephen@networkplumber.org" , "dev@dpdk.org" , "sameh.gobriel@intel.com" , nd Thread-Topic: [PATCH v1 3/3] test/hash: add readwrite test for ext table Thread-Index: AQHUYR5KsslQmPs/p0iw68s850xkr6Uu8FuAgAFOSJA= Date: Fri, 26 Oct 2018 00:23:56 +0000 Message-ID: References: <1539208085-30756-1-git-send-email-yipeng1.wang@intel.com> <1539208085-30756-4-git-send-email-yipeng1.wang@intel.com> <20181024203653.GA16476@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20181024203653.GA16476@bricha3-MOBL.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Honnappa.Nagarahalli@arm.com; x-originating-ip: [217.140.111.135] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM6PR08MB3879; 6:0gJzrIs0gW/YzUw1DdY+68qcqP+K3/tP6WAocjykz+dpKGF9LnrjJoklpsJJcYu5iZPgtvqWijUdxeYUawR/WJzS6UJjWEOcPHkj3hcSAHaWSYTUKsKNuJKrWk8LdIoVGNSpU/6AbXJHr4zqjUhMClRcEfAkHITueFoaLOG38/GKxuVF8x6LHUq02xq0p7iKCqUAXfImANdlqQGIHxHSbIy3UWSG2VPp5Xi52D0bXIT+4qdFHJupwC6fFAWHYT5NYTZ7yPGKl4/119q/aJuP43F2CNaHJqFxbDc8YiGyiiWy2i5ohmpKErHUw9OCPHSFxv95mcN80hxUUTvEqU3ZP/0+IJnrZ3WQRi2/LyelROq2TfRyOcQ/JavghcRzoW9nWPkProcPu9CrJ50aSnAO8+HbzhplYVMsU9A+xfyHTCRTVOxAfHrzmjhcKGPyFmPFHebGrYF99XMFcJ8bFtWIcA==; 5:+lfrlWx/89j/dLHoVBIMS17oj/kU4uGKn0NjsPQxNiWC+4pm1xdewFogeB0iIXv6b37eaZK5lpsuy7aQuYGWTTWL9FGgY87elqyoNaPbFgu850Af7I6P3lhUvwHwcgMgzeFOSiTZYylLyP9nSQhViVd/BA3KqNGS2fkleLbINJA=; 7:Lpq7CnJJ2DvfAIiZNdP5ZSf5Zk2dI61VGyA7TJAOfbptjDJL4Ifp1NqKEm5pdL+9rVY0UKjAbV182XfVnp9OiRA17gEzKRX3+aQlAkFgPWrqS8WUffcWwtcg5PeDIH3WdHf6jOq3pR2+JiC7/7Ydvg== x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: c96e0f2b-f995-47ed-7bda-08d63ad95144 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(5600074)(711020)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020); SRVR:AM6PR08MB3879; x-ms-traffictypediagnostic: AM6PR08MB3879: nodisclaimer: True x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(228905959029699); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(3231355)(944501410)(52105095)(3002001)(6055026)(148016)(149066)(150057)(6041310)(20161123560045)(20161123564045)(20161123562045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(201708071742011)(7699051)(76991095); SRVR:AM6PR08MB3879; BCL:0; PCL:0; RULEID:; SRVR:AM6PR08MB3879; x-forefront-prvs: 083751FCA6 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(39850400004)(376002)(396003)(366004)(136003)(199004)(51444003)(189003)(14454004)(25786009)(54906003)(74316002)(76176011)(316002)(68736007)(7696005)(305945005)(478600001)(256004)(8936002)(11346002)(97736004)(446003)(7736002)(53936002)(99286004)(110136005)(486006)(229853002)(2900100001)(2906002)(86362001)(8676002)(9686003)(14444005)(81166006)(81156014)(72206003)(6116002)(66066001)(3846002)(5660300001)(71190400001)(5250100002)(6246003)(33656002)(6506007)(6436002)(186003)(26005)(71200400001)(4326008)(55016002)(476003)(102836004)(106356001)(105586002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM6PR08MB3879; H:AM6PR08MB3672.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: eHXtv1rKlTrPF3twFkuyvxfYs4LX5dd5jDCDuB7enrQeT2sxiyAaFZTsm+6i6JnLKGyCxBO6Tt/3DKaXAhTgpokJJztdSkOkQ8BH7Ve30VPudrpDbcQnVN/P+MAUttzFJl1wOMgt3yUdrFTbs7nJEyKngFyA+v3SaOxfEA1dsOxlkLXtuCK8ectx0DTSEERWeIMFgBXmrd5ETsy+vP5I3SyZS+SaLmYNk7S7WXr/kLLEawi5FE0gX7IEcIIijYGZy75skhDgSgk7Uk5tVDORnhV8p7+pxxF3EUeXfLbzy2fgunZG8zh3Ad1rqDvslsSrTwahLrQfgTAO8Zjkk28ZNp4ltjj6PW4uMeqn58nUuU4= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: c96e0f2b-f995-47ed-7bda-08d63ad95144 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Oct 2018 00:23:56.4791 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3879 Subject: Re: [dpdk-dev] [PATCH v1 3/3] test/hash: add readwrite test for ext table X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Oct 2018 00:23:59 -0000 >=20 > On Wed, Oct 10, 2018 at 02:48:05PM -0700, Yipeng Wang wrote: > > This commit improves the readwrite test to consider extendable table > > feature and add more functional tests to cover more corner cases. > > > > Signed-off-by: Yipeng Wang --- > > test/test/test_hash_readwrite.c | 70 > > ++++++++++++++++++++++++++++++++++------- 1 file changed, 58 > > insertions(+), 12 deletions(-) > > > With the extension of this test case, and the addition of other test case= s by > Honnappa in the other patch sets in this release, we are building up quit= e a > large set of hash table autotests, some of whose meaning and use is a bit > obscure. Are there any hash tests that you feel could be removed at this = point, > to simplify things? >=20 (this comment does not apply to this patch) Looks like your concern is about maintenance of the test code.=20 IMO, we need to reduce the number of configuration flags in this library wh= ich should reduce the number of test cases. The flags I think that are not necessary are: RTE_HASH_EXTRA_FLAGS_TRANS_MEM_SUPPORT - The tests prove that this gives si= gnificant performance boost. IMO, if the platform supports it, it should be= enabled without user consent (I am not an expert on TSX). RTE_HASH_EXTRA_FLAGS_RW_CONCURRENCY - Most use cases require this support. = Only use case where this is not required is a single thread doing both inse= rts and lookups. Even if such a use case is valid, the lock over head shoul= d be small. > /Bruce