From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60064.outbound.protection.outlook.com [40.107.6.64]) by dpdk.org (Postfix) with ESMTP id CE2D3DED for ; Fri, 2 Nov 2018 18:38:27 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wGnBjCYhDyJfsfcaGZ12VIrjXi8xh2HgZcI+qyG79b8=; b=SelWDU97XYyuSIAgq1DOJC1jqfXL/V9iHyI7R81fwujKhRiwTFiOgL9MPNllbpRhxVeEk/9VIIupQbqWgQw3l4mYD+Abw6GgiiIaZxEjh+dI6VW3KvkCtjiJ9d3xai3Pdaf8mKKX3zn/Xk9jtAznjG5ZGee1TZxK08xb5cE/w0s= Received: from AM6PR08MB3672.eurprd08.prod.outlook.com (20.177.115.29) by AM6PR08MB2982.eurprd08.prod.outlook.com (52.135.163.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1294.24; Fri, 2 Nov 2018 17:38:26 +0000 Received: from AM6PR08MB3672.eurprd08.prod.outlook.com ([fe80::c1a0:51bf:cd33:2b27]) by AM6PR08MB3672.eurprd08.prod.outlook.com ([fe80::c1a0:51bf:cd33:2b27%6]) with mapi id 15.20.1273.030; Fri, 2 Nov 2018 17:38:26 +0000 From: Honnappa Nagarahalli To: Bruce Richardson CC: "pablo.de.lara.guarch@intel.com" , "dev@dpdk.org" , "Gavin Hu (Arm Technology China)" , Dharmik Thakkar , nd , "yipeng1.wang@intel.com" , "sameh.gobriel@intel.com" , nd Thread-Topic: [PATCH v2 0/4] hash: deprecate lock ellision and read/write concurreny flags Thread-Index: AQHUcp67IbPo9+9SOUqur29Z82WqQ6U8nyBQ Date: Fri, 2 Nov 2018 17:38:26 +0000 Message-ID: References: <20181101045454.632-2-honnappa.nagarahalli@arm.com> <20181101232522.702-1-honnappa.nagarahalli@arm.com> <20181102112507.GE26868@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20181102112507.GE26868@bricha3-MOBL.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Honnappa.Nagarahalli@arm.com; x-originating-ip: [217.140.111.135] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM6PR08MB2982; 6:g4BagTLzmWvRTn9sZY3TVZl7LA1u/O0djHEtnZh/yZOSvyJnKFxf4Mav1qr7+Q02E8MJwRJtLuqyGB8zdRRLKGYCVR8vEI3QOinkgQiFxzYLaFRP6K4KEmsis2xCGeTIOIaMb1gQWUbHvLPjMHoL+HVB0fI3isjN0l3aqofrwyXPpVC75DPnMM6BNQsvu3valRx8KkH5XVM32Z9NnD7ugb51mF7GwQMqDuDTuc4DM1XZgDkm5S+/6SEpvUYx+KtZZJtppmHNVic6D2Da56jFHHPLyvCjFAA/P/OfHOhG3k4FBjALRCKebgDleLEN+vhDjYbHWDyeCveWqwJ2+SqEXdbDKQPMtG/4Hv6JGoYBFaDyequlAP8wMZ+/EQIO6LhThhUXo5jhk4Xr0Blh3eqUsYuFZLb+DtlH7KcFyqGGyyDwaoxxwwaYpIv8Tmmk0eQMr56Rwtj2N1DLgLXYnlPeLg==; 5:zJaC+OnTQNInlraaLk/Wa3E8kwG/6l9vaUXdxxy61cAoB9N00qifSfG/66ZhKWndRAawOuR3jMdHGiIPh5juNf5Otn+aS2HWGDUjqftpnvdw1/ZVM4tIMTDxOqPCbWiHzylpM5ZGbtYpzx3e4/+QjDjNfZ+MZ8JRs4NhFugLwWM=; 7:YgRrbcsWc8wbGdR1cBqtmSaqgWRhASI85oCaBMQ7XxNgkgIhgbiyWHNdSKOG4ow1H+BodIcoslSQ0Zh72fiFTcRp2+1j2Q6M2o7Z4K8ZQYKP8w3JC0Dn3Y4vEH68rr6RDf1eeDcQEmWPh+MJFdRbbA== x-ms-exchange-antispam-srfa-diagnostics: SOS;SOR; x-ms-office365-filtering-correlation-id: d8792dcc-17ac-4a7a-84c9-08d640e9fe99 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:AM6PR08MB2982; x-ms-traffictypediagnostic: AM6PR08MB2982: nodisclaimer: True x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231382)(944501410)(4982022)(52105095)(93006095)(93001095)(10201501046)(3002001)(6055026)(148016)(149066)(150057)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123562045)(20161123564045)(20161123560045)(201708071742011)(7699051)(76991095); SRVR:AM6PR08MB2982; BCL:0; PCL:0; RULEID:; SRVR:AM6PR08MB2982; x-forefront-prvs: 08444C7C87 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(136003)(39860400002)(396003)(376002)(346002)(366004)(199004)(54094003)(189003)(6116002)(966005)(99286004)(6916009)(5660300001)(8936002)(14454004)(8676002)(4326008)(53936002)(81166006)(81156014)(486006)(33656002)(3846002)(316002)(7696005)(54906003)(6506007)(102836004)(6246003)(229853002)(186003)(74316002)(72206003)(25786009)(26005)(2906002)(105586002)(76176011)(68736007)(66066001)(446003)(55016002)(11346002)(106356001)(71200400001)(9686003)(478600001)(6306002)(71190400001)(14444005)(305945005)(6436002)(256004)(97736004)(2900100001)(7736002)(86362001)(476003); DIR:OUT; SFP:1101; SCL:1; SRVR:AM6PR08MB2982; H:AM6PR08MB3672.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: 152FBs44nHjdP0SaA55lr2hX0E1C1hbKWKk7KJ5llCChiN7EeZXDsObS49xuws3oBt+e36uawzs35QouJwpPZxmtj08PChJwOUVG6mP/90RoaKeEfsCpi5dLIQ1U3NRppUAhyf7GO1jVweajwBpNLadIjkT6BfyRsklIt2zCn7tO0EKNVO6YbXkTRnhz//N4hvzuPQXe49sCj0IQRPK07nHaD+qxv07ul21MC1FKXiM8HSOpgnD5LB3yKa46uyzWtic+0a/tzEjNKXVYTBoTzh5/Bezst6Hsxs64HuVHy16YcGTu2rPOwjHMPKNDirJcviLXoBoCP9WcVF2znPeXH6CDlqUvORydHB2ifQrzIrw= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: d8792dcc-17ac-4a7a-84c9-08d640e9fe99 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Nov 2018 17:38:26.2004 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB2982 Subject: Re: [dpdk-dev] [PATCH v2 0/4] hash: deprecate lock ellision and read/write concurreny flags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Nov 2018 17:38:28 -0000 >=20 > On Thu, Nov 01, 2018 at 06:25:18PM -0500, Honnappa Nagarahalli wrote: > > Various configuration flags in rte_hash library result in increase of > > number of test cases. Configuration flags for enabling transactional > > memory use and read/write concurrency are not required. These features > > should be supported by default. Please refer to [1] for more context. > > > > This patch marks these flags for deprecation in 19.02 release and > > cleans up the test cases. > > > > [1] http://mails.dpdk.org/archives/dev/2018-October/117268.html > > > > Honnappa Nagarahalli (4): hash: prepare for deprecation of flags hash: > > deprecate lock ellision and read/write concurreny flags test/hash: > > stop using lock ellision and read/write concurreny flags doc/hash: > > deprecate lock ellision and read/write concurreny flags > > > While I'd like to reduce the flags and do cleanup, I'm a little concerned= about > putting this scope of changes in so late in the release. I wonder if less= drastic > changes could work as well for this release, and do the cleanup later. Thank you Bruce for the review. This patch series is not fixing any user re= lated problems, let us skip this for 18.11. It will give us time as well to= think through and get this right. > For example, rather than deprecating the flags now, how about just change > the default for when no flags are set? If user has set flags, follow the = existing > path - if flags is set to zero, then have the defaults be to use RW concu= rrency > or TSX. This changes the behavior of the library and what the flags mean, still req= uires ABI change, but does not need deprecation of flags (I guess this is w= hat you meant). However, it will not solve the problem of losing the capabi= lity to disable TSX. >=20 > /Bruce