From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0068.outbound.protection.outlook.com [104.47.2.68]) by dpdk.org (Postfix) with ESMTP id D05881B137 for ; Tue, 23 Oct 2018 17:52:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=h7INf+/VnimJMJRDc6VUNUUGaupHDzUBtjXOb2U6A+Q=; b=pFejW96Agkrd/ufBEx17CuKJxd4H+lNJx/b17FbGG104OK5bdPi2AIo9Xb4S8PTsgkaKBLyTErCUTbaRW0yugDEvVDuIpKD23QoxOW+nEz4o3hyuQqhnh8m3Afuv4bTDXrBnx0G2O1K4vdxdZB6okzcHT78sT8khn6LuHEgn5ss= Received: from AM6PR08MB3672.eurprd08.prod.outlook.com (20.177.115.29) by AM6PR08MB3429.eurprd08.prod.outlook.com (20.177.113.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1250.29; Tue, 23 Oct 2018 15:52:49 +0000 Received: from AM6PR08MB3672.eurprd08.prod.outlook.com ([fe80::c1a0:51bf:cd33:2b27]) by AM6PR08MB3672.eurprd08.prod.outlook.com ([fe80::c1a0:51bf:cd33:2b27%5]) with mapi id 15.20.1250.028; Tue, 23 Oct 2018 15:52:49 +0000 From: Honnappa Nagarahalli To: Bruce Richardson CC: "pablo.de.lara.guarch@intel.com" , "dev@dpdk.org" , "yipeng1.wang@intel.com" , "Gavin Hu (Arm Technology China)" , Dharmik Thakkar , nd Thread-Topic: [PATCH v5 5/5] test/hash: read-write lock-free concurrency test Thread-Index: AQHUascct1CfoycaAkGoyrbHgxXo+qUs1TMQgAAMegCAABliQA== Date: Tue, 23 Oct 2018 15:52:48 +0000 Message-ID: References: <1540268524-126673-1-git-send-email-honnappa.nagarahalli@arm.com> <1540268524-126673-6-git-send-email-honnappa.nagarahalli@arm.com> <20181023115403.GE18800@bricha3-MOBL.ger.corp.intel.com> <20181023142058.GA4496@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20181023142058.GA4496@bricha3-MOBL.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Honnappa.Nagarahalli@arm.com; x-originating-ip: [217.140.111.135] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM6PR08MB3429; 6:V3o/SdUeu7HG0rvl6dj3l2FKCbzCtcjf4J2WOHhUV0bfio0Q4Jlqj0daAmBjQ7641RfFLMBGrWEzXxun/KbfAxWy0HdJdJusPVjmjNwZEjWPZGH9LFFGooacCLwLVBQ7jtywaiOOP5hYSuHQMd/HWnWoV2LDdGCLnPcuRiWIyA6o+1gYqbNAkuEWzP8zkb84wuI23jxjvCnoM2NQqUDenXc6XdeHaTdOxjNoWhgOuxNMYaB6q+lJuec1VrRXEoqPbuP8jTrkvryfP4IVxTA6Rb4/4fii8/0G4DahFNQo9N5vZYvt2twA7sTeG2pSuBnNSzwNg2JssQpJCt2pIH5Pz7pMCFIzkfR5SZlA8nqndDUVU3JIkN5hi+lNDNwPdoTxuK3wv5RyS7ejiyN4SX+T1MZGlxXBJr1gzMv1NxXtr7M7M/qTlDJJ+pXmcPqcEPIbt22yobZM+lO1u6h15ROyVQ==; 5:Qg3h+pgNLYiOANf2Jl9lei7ZmImHA6yNu28TG7T0Gqq1HwpmPdlopWRkKcUOcgj8qHuwqXMgmxbd4JzZgUfA3k1+Q+y3E7+80dkVmDyqnu0CY+KVe1OEJ5AylBzDxn3fM+vy9TumG5fSvU8Ti83lyUxBagZc3axzufFv0tw/SPs=; 7:n5oh8DxWPdiyz2Ga0POgTwHaVj9f+0OJl3+7h6FzrnjxWW7tKlcIxPELNkGFG9xcCMTR8wAdxf2AjLu8aT3LAaZ07ssqbI9oE+8mq7POUc4WcNRIH1tPGwKcT/mkvcZLW5B/naBndxeuJncR70Lc/k77yi+v7vBPYJC36trqjnDUOL7p20vUkehBTMTeO8bNr9U44T8wMooI0o6oRoQS7HLnJiEc4nUySIb+FZANYnoVUglbeuMt1h5MGu+G353E x-ms-exchange-antispam-srfa-diagnostics: SOS;SOR; x-ms-office365-filtering-correlation-id: 76c79e38-d0a0-400d-a2e1-08d638ff952d x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:AM6PR08MB3429; x-ms-traffictypediagnostic: AM6PR08MB3429: nodisclaimer: True x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(228905959029699); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231355)(944501410)(52105095)(3002001)(10201501046)(93006095)(93001095)(6055026)(148016)(149066)(150057)(6041310)(20161123560045)(20161123564045)(20161123562045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(201708071742011)(7699051)(76991095); SRVR:AM6PR08MB3429; BCL:0; PCL:0; RULEID:; SRVR:AM6PR08MB3429; x-forefront-prvs: 0834BAF534 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(346002)(396003)(136003)(366004)(39860400002)(199004)(189003)(54906003)(99286004)(53936002)(14454004)(93886005)(478600001)(72206003)(26005)(74316002)(81156014)(55016002)(6436002)(9686003)(486006)(76176011)(102836004)(2900100001)(105586002)(446003)(316002)(7696005)(8936002)(476003)(106356001)(8676002)(11346002)(5250100002)(6916009)(5660300001)(86362001)(6246003)(256004)(186003)(229853002)(25786009)(3846002)(6116002)(4326008)(305945005)(81166006)(68736007)(7736002)(66066001)(97736004)(33656002)(6506007)(71190400001)(71200400001)(2906002)(20703003); DIR:OUT; SFP:1101; SCL:1; SRVR:AM6PR08MB3429; H:AM6PR08MB3672.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: cCYACOAXfRHtbivypaaJy2qWYz8W1Pgff0wydpWNe0sdubazxJv6vjpt4YrSIrRwNTrR/jo0QN7EJfqWkT0Xnm+YC/+Njr+1/nT4JP+wjytvF1Yol0b5W06rPQUgmI1pbr+DMucyebLGtr2O0hYJJ+3b5cYHF2Q12ogtnZSC29m8voEWXITlzC6ttoXsVoWgXIE8mOVQj1QUeCTU3YjYx23LuCjgXVhiYItquskHYs9RV8lm3zloZ8ABs9NgtuWM1at1w7mzcnHl0O4CYQGT99so48CwWwIqoQ85+Iu2NomxFAjk3toyWXFZJTPbJMVU4DmwGVnP8+bq+7Ecrm7EHcgmeAz76rqB4TJQyOLwSgM= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: 76c79e38-d0a0-400d-a2e1-08d638ff952d X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Oct 2018 15:52:48.9647 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3429 Subject: Re: [dpdk-dev] [PATCH v5 5/5] test/hash: read-write lock-free concurrency test X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Oct 2018 15:52:50 -0000 > > > > --- > > > > > > Does this need to be done via a completely new test case? Given the > > > number of unit tests for the hash table structure, I'm wondering if > > > we can consolidate things a bit. Any thoughts? > > > > > Are you concerned about new test case or new test case file? > > From a new test case perspective, we are testing a new use case, hence = we > need it. May be few parts can be combined such as generating the keys. > > From a new test case file perspective, combining this use case with > existing files was making the code difficult to manage. Hence we decided = to > add a new file. > > > > There are more test cases because of multiple configuration options > present in hash table. > > > Ok. That makes sense. Can you fix the couple of missing items for > make/meson in this patch, then you can add my ack. Yes, I will add that and send out v6, I will add your acked-by. >=20 > Acked-by: Bruce Richardson