DPDK patches and discussions
 help / color / mirror / Atom feed
From: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"bruce.richardson@intel.com" <bruce.richardson@intel.com>,
	"pablo.de.lara.guarch@intel.com" <pablo.de.lara.guarch@intel.com>,
	"yipeng1.wang@intel.com" <yipeng1.wang@intel.com>,
	Dharmik Thakkar <Dharmik.Thakkar@arm.com>,
	"Gavin Hu (Arm Technology China)" <Gavin.Hu@arm.com>,
	nd <nd@arm.com>
Subject: Re: [dpdk-dev] [PATCH v6 2/5] hash: support do not free on delete
Date: Fri, 26 Oct 2018 01:20:53 +0000	[thread overview]
Message-ID: <AM6PR08MB3672BB49FBD93D42A46E2C5A98F00@AM6PR08MB3672.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <2691977.lcrpPM4Irn@xps>

> 24/10/2018 03:32, Honnappa Nagarahalli:
> >  /**
> > + * @warning
> > + * @b EXPERIMENTAL: this API may change without prior notice
> > + *
> > + * Free a hash key in the hash table given the position
> > + * of the key. This operation is not multi-thread safe and should
> > + * only be called from one thread by default. Thread safety
> > + * can be enabled by setting flag during table creation.
> > + * If RTE_HASH_EXTRA_FLAGS_NO_FREE_ON_DEL is enabled,
> > + * this API must be called, with the key index returned by
> > +rte_hash_add_key_xxx
> > + * APIs, after the key is deleted using rte_hash_del_key_xxx APIs.
> > + * This API does not validate if the key is already freed.
> > + *
> > + * @param h
> > + *   Hash table to free the key from.
> > + * @param position
> > + *   Position returned when the key was deleted.
> > + * @return
> > + *   - 0 if freed successfully
> > + *   - -EINVAL if the parameters are invalid.
> > + */
> > +int __rte_experimental
> > +rte_hash_free_key_with_position(const struct rte_hash *h,
> > +                               const int32_t position);
> 
> You need to add this new function to the map file, otherwise linking of shared
> library will fail.
> 
It is messed up. The map file change is in 4/5. I will correct that and submit another version.

> 

  reply	other threads:[~2018-10-26  1:20 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-24  1:32 [dpdk-dev] [PATCH v6 0/5] Address reader-writer concurrency in rte_hash Honnappa Nagarahalli
2018-10-24  1:32 ` [dpdk-dev] [PATCH v6 1/5] hash: separate multi-writer from rw-concurrency Honnappa Nagarahalli
2018-10-24  1:32 ` [dpdk-dev] [PATCH v6 2/5] hash: support do not free on delete Honnappa Nagarahalli
2018-10-25 22:55   ` Thomas Monjalon
2018-10-26  1:20     ` Honnappa Nagarahalli [this message]
2018-10-24  1:32 ` [dpdk-dev] [PATCH v6 3/5] hash: fix key store element alignment Honnappa Nagarahalli
2018-10-24  1:32 ` [dpdk-dev] [PATCH v6 4/5] hash: add lock-free read-write concurrency Honnappa Nagarahalli
2018-10-24  1:32 ` [dpdk-dev] [PATCH v6 5/5] test/hash: read-write lock-free concurrency test Honnappa Nagarahalli
2018-10-25 22:56 ` [dpdk-dev] [PATCH v6 0/5] Address reader-writer concurrency in rte_hash Thomas Monjalon
2018-10-26  0:48   ` Honnappa Nagarahalli
2018-10-26  8:38     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AM6PR08MB3672BB49FBD93D42A46E2C5A98F00@AM6PR08MB3672.eurprd08.prod.outlook.com \
    --to=honnappa.nagarahalli@arm.com \
    --cc=Dharmik.Thakkar@arm.com \
    --cc=Gavin.Hu@arm.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=nd@arm.com \
    --cc=pablo.de.lara.guarch@intel.com \
    --cc=thomas@monjalon.net \
    --cc=yipeng1.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).