From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80049.outbound.protection.outlook.com [40.107.8.49]) by dpdk.org (Postfix) with ESMTP id 66AC4548B for ; Fri, 26 Oct 2018 03:20:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5PL7p3jlD9WubMLCpt5AN0VcZXy9OBENpsUKX7BSDvE=; b=Bg+fB/ZpDKVsJSJM86mSdsKg2z6nNt01RBf+DESTlAxcJPbmdzTX3zdlQTlJpp6+cV8TjMTn7zfSe/wm3ALtneJkmvLIg51hJDpDl71z37J7FIspGemnfmMyMK9VEfGQ1TjsEz+2JgxTW4FHBOSfl4fYc9kgKQuU0UMJx23vpRk= Received: from AM6PR08MB3672.eurprd08.prod.outlook.com (20.177.115.29) by AM6PR08MB3896.eurprd08.prod.outlook.com (20.178.91.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1207.18; Fri, 26 Oct 2018 01:20:54 +0000 Received: from AM6PR08MB3672.eurprd08.prod.outlook.com ([fe80::c1a0:51bf:cd33:2b27]) by AM6PR08MB3672.eurprd08.prod.outlook.com ([fe80::c1a0:51bf:cd33:2b27%5]) with mapi id 15.20.1250.032; Fri, 26 Oct 2018 01:20:53 +0000 From: Honnappa Nagarahalli To: Thomas Monjalon CC: "dev@dpdk.org" , "bruce.richardson@intel.com" , "pablo.de.lara.guarch@intel.com" , "yipeng1.wang@intel.com" , Dharmik Thakkar , "Gavin Hu (Arm Technology China)" , nd Thread-Topic: [dpdk-dev] [PATCH v6 2/5] hash: support do not free on delete Thread-Index: AQHUbLXF/CqfCST3lEaQxYqbKZ1pjqUwuWiw Date: Fri, 26 Oct 2018 01:20:53 +0000 Message-ID: References: <1540344746-29045-1-git-send-email-honnappa.nagarahalli@arm.com> <1540344746-29045-3-git-send-email-honnappa.nagarahalli@arm.com> <2691977.lcrpPM4Irn@xps> In-Reply-To: <2691977.lcrpPM4Irn@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [217.140.111.135] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM6PR08MB3896; 6:OEU+7O7OlAC4KgHlzvyr9nGvRi1ISbJdlPkGiqzLng4EI7lg1Um5EeiRC9NxtPPg4sFmbsDJTPgH9+QAUwb2/2buK+II80uYlKZu/kLfWB8BjBLqTVhVCbXQicd9/GgD/CNLeBtkOuwU9RtlmlG26OAREQ4RNdrb6bk9KhC1jVsfTJzfZMv+ofHWrtzzY0jQgl2MTV7ue+0EMyZlmvrW4m9RlEmppezQjCgBtDU2WScyPhM4bu82tKk4qp2/HNP0e/NYNAKh5/BVtaNSFeoaFYbR+BP2rk3FABuBIo07LneqoqEwSaR+nuIvshFVBPkNu+J2V0gYBxb3P3rFjq3syBnDaNc/oNU5LNEW3jbfgrXb6kRdInn+DBpq2A5DW2olxySo29pgMTxK4lefCm/5GvYd3NrZXW3/bz0wPta7TP/gi/BGQNj//mknDuQEluG7ZJds7vAEUf4UHctl2+jQzA==; 5:m17LfE8zfudP4pBrBoKY8Uu1EI8ys7S1pxfU/cayJcrTeSF4PLFuH5V9bOLIJWhfa1Y9DcV1PGsOvNXrW3t2thHxggA9Qhu740Y0gmUDLqeDewRLl4e72bJWZQqAmbPU487r8/3HArmcx/QWfJjtVOlVUD1KdfANA3iJrV+b+nE=; 7:S9RPNIhtECbe0lXSKP5LNw9z0ha3KQFOmwWW11EfPEEjIcaBvhxT/zV48BVfFgBiE3c1z6+hKyjdDKJM7eYuvghlDGaF/lj8BybkcDqsj8F0pIUGnqv0cdCj5Dt60UU5hE1CzZBBDE7jeipslTgLWkZIaNvf5RNwdVSSVtgnbCaNrj1VXdeUiU1TEpnAUnp3VM6HVXoSMjnL6FdGovvOpQH60m1WSJ5LX0gJ+OXSW9XNqTtJFTgnbJOBqhXarkGM x-ms-exchange-antispam-srfa-diagnostics: SOS;SOR; x-ms-office365-filtering-correlation-id: e81b1ec6-8fe5-404a-1de7-08d63ae1463a x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(5600074)(711020)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020); SRVR:AM6PR08MB3896; x-ms-traffictypediagnostic: AM6PR08MB3896: nodisclaimer: True x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231355)(944501410)(52105095)(3002001)(93006095)(93001095)(10201501046)(6055026)(148016)(149066)(150057)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123558120)(20161123560045)(20161123564045)(201708071742011)(7699051)(76991095); SRVR:AM6PR08MB3896; BCL:0; PCL:0; RULEID:; SRVR:AM6PR08MB3896; x-forefront-prvs: 083751FCA6 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(396003)(39850400004)(376002)(136003)(366004)(189003)(199004)(25786009)(6506007)(8936002)(71190400001)(105586002)(6116002)(2906002)(478600001)(3846002)(6246003)(71200400001)(106356001)(76176011)(229853002)(66066001)(5250100002)(14454004)(33656002)(316002)(9686003)(55016002)(97736004)(446003)(486006)(11346002)(6346003)(102836004)(6436002)(476003)(99286004)(26005)(186003)(7696005)(2900100001)(81166006)(54906003)(305945005)(74316002)(81156014)(7736002)(5660300001)(8676002)(6916009)(53936002)(256004)(68736007)(14444005)(86362001)(4326008)(72206003)(21314003); DIR:OUT; SFP:1101; SCL:1; SRVR:AM6PR08MB3896; H:AM6PR08MB3672.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Honnappa.Nagarahalli@arm.com; x-microsoft-antispam-message-info: KE8fxfeA5Ga0lXWsDPvKS5/9KVOUbkmDJK9T3Ig0sL9kxUiwdPifEAi94FuDswch3GW5dJEOUs3yDeYojQu747av1lDwcGNzwOV6cPU9y9K03wftRu+kvWuC6iHrE3to+ES3EFv4nPGkyopefMG9ATrxOT6c7Aeu9S2AbYwz74gGbANYS0sTKoSRp9kOqAvioYFKNi0Pe1puDKztntfpU5xemmpDIvWKskEVdWnM3sOkGme3HXz9mWpyiXgUZb0/MRxr8wM6k6t13riShVJ5J/B4L1T8+wkOntSUwyBmvrWYkWqSgCTP1o3hMTcDHF5TD/GL1DA62c0VtsgVq44hxvYVcKZQY0UCJLuZbkKnUKs= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: e81b1ec6-8fe5-404a-1de7-08d63ae1463a X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Oct 2018 01:20:53.9145 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3896 Subject: Re: [dpdk-dev] [PATCH v6 2/5] hash: support do not free on delete X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Oct 2018 01:20:55 -0000 > 24/10/2018 03:32, Honnappa Nagarahalli: > > /** > > + * @warning > > + * @b EXPERIMENTAL: this API may change without prior notice > > + * > > + * Free a hash key in the hash table given the position > > + * of the key. This operation is not multi-thread safe and should > > + * only be called from one thread by default. Thread safety > > + * can be enabled by setting flag during table creation. > > + * If RTE_HASH_EXTRA_FLAGS_NO_FREE_ON_DEL is enabled, > > + * this API must be called, with the key index returned by > > +rte_hash_add_key_xxx > > + * APIs, after the key is deleted using rte_hash_del_key_xxx APIs. > > + * This API does not validate if the key is already freed. > > + * > > + * @param h > > + * Hash table to free the key from. > > + * @param position > > + * Position returned when the key was deleted. > > + * @return > > + * - 0 if freed successfully > > + * - -EINVAL if the parameters are invalid. > > + */ > > +int __rte_experimental > > +rte_hash_free_key_with_position(const struct rte_hash *h, > > + const int32_t position); >=20 > You need to add this new function to the map file, otherwise linking of s= hared > library will fail. >=20 It is messed up. The map file change is in 4/5. I will correct that and sub= mit another version. >=20