From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40049.outbound.protection.outlook.com [40.107.4.49]) by dpdk.org (Postfix) with ESMTP id 73C0E23D for ; Wed, 31 Oct 2018 05:21:45 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=X9RFLY8T4FLVVigt6yWuIls/JGO72CfWmFmd3D3/Y8Y=; b=cke05ONrrBx5Mga4cr0KhrVwiWye3jD10coCvjAY9FMtSN3gxpmrKg0pCgYBakIHsu6c3QNk7eou6kcDKdcw01BpZ3EqZefmR+GKxOUJ+4/0hiUuD5KCITC9lwhjMOWLCzD4h497eWtPMJIKSDsQLIkpUHMKemzoVC/E+I4no6Y= Received: from AM6PR08MB3672.eurprd08.prod.outlook.com (20.177.115.29) by AM6PR08MB3173.eurprd08.prod.outlook.com (52.135.164.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1273.26; Wed, 31 Oct 2018 04:21:44 +0000 Received: from AM6PR08MB3672.eurprd08.prod.outlook.com ([fe80::c1a0:51bf:cd33:2b27]) by AM6PR08MB3672.eurprd08.prod.outlook.com ([fe80::c1a0:51bf:cd33:2b27%6]) with mapi id 15.20.1273.025; Wed, 31 Oct 2018 04:21:44 +0000 From: Honnappa Nagarahalli To: Bruce Richardson CC: Yipeng Wang , "stephen@networkplumber.org" , "dev@dpdk.org" , "sameh.gobriel@intel.com" , nd , nd Thread-Topic: [PATCH v1 3/3] test/hash: add readwrite test for ext table Thread-Index: AQHUYR5KsslQmPs/p0iw68s850xkr6Uu8FuAgAFOSJCAASfeAIAHdL8A Date: Wed, 31 Oct 2018 04:21:44 +0000 Message-ID: References: <1539208085-30756-1-git-send-email-yipeng1.wang@intel.com> <1539208085-30756-4-git-send-email-yipeng1.wang@intel.com> <20181024203653.GA16476@bricha3-MOBL.ger.corp.intel.com> <20181026101216.GA14620@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20181026101216.GA14620@bricha3-MOBL.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Honnappa.Nagarahalli@arm.com; x-originating-ip: [217.140.111.135] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM6PR08MB3173; 6:H/NrNBnfzJBpsQ6LTo0UKnp01Hj0vvnvW/qk0geGGz9g1nr5AAWWOJhEwGCbqdkEX/243THvzhEl4bn0WZ1QpBRZVqgBhOeuQQq9V8pw8CC/BjU2bYnK3DqRFiCXPn54b4/nbOQjCvTWNrjRu2u7mB0AESmqs4xUefeuB67yED4+8Pkh60/VBMH/Z6/iWt2Edx1jSa+aGlwv4DOk1B73PfMSbByGH0qTWFAPMIhDnmW092QHm/luicSn1E3ynLh0936lJfPis+CTbewDTbtSM6AuNN+R9LKt2CTVXAA64jP5ZZwv2vFCC2DBUpr2yfhPOVJKjlWk0sssc3c8bb2u/U0+o/HysDuARJcuDRaLpq7Gb5fU4Dvm5SJYNGUicy9h6EGJC0a+lRnLe2XpPIQClN2OkD2Td0092I+yv3JJkY0BJpQdks+TKp7r2oUK/ltrvIicSBJWXKqYukLjkv3p+Q==; 5:W55W24S+a01kIgWHz5Xu+IVHTI6bS66G8PrtEDnQK2ZTsWsrh5n4diRQieTx0bCpknCs2H38haDdnjpuU8VuCueydb3KUPOkgNeTiysb1CgTHmZFWxrBE7vAccaVfFqdsXfa6g61BhoZW+xSuMZ5Wr5MhCtf58tTeaRfA14sG+c=; 7:q8RGaU8gs+HAJhR9GOxEq8AgsxjxWAEdLtGtecQ0YjCsbq8DluD3O0OIjB50n9SoaHYyk4uoRS6T4WjbHNDq23BYnr9irPKRg/J010pCOF7oXUcfBE8UPqSEpaE+eU7XWxeZEiOpgvcNWSM0fzyzzA== x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 070673ed-e44a-4b74-4580-08d63ee85d98 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:AM6PR08MB3173; x-ms-traffictypediagnostic: AM6PR08MB3173: nodisclaimer: True x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(228905959029699); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3002001)(10201501046)(93006095)(93001095)(3231382)(944501410)(52105095)(6055026)(148016)(149066)(150057)(6041310)(20161123558120)(20161123560045)(20161123562045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(201708071742011)(7699051)(76991095); SRVR:AM6PR08MB3173; BCL:0; PCL:0; RULEID:; SRVR:AM6PR08MB3173; x-forefront-prvs: 084285FC5C x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(136003)(366004)(39860400002)(396003)(376002)(346002)(189003)(51444003)(199004)(26005)(68736007)(55016002)(6246003)(9686003)(74316002)(6436002)(6916009)(33656002)(105586002)(53936002)(106356001)(81166006)(478600001)(81156014)(186003)(8676002)(8936002)(66066001)(305945005)(5250100002)(54906003)(25786009)(2906002)(4326008)(14444005)(256004)(6116002)(446003)(3846002)(7696005)(71190400001)(71200400001)(76176011)(229853002)(99286004)(72206003)(97736004)(86362001)(316002)(14454004)(2900100001)(476003)(102836004)(7736002)(6506007)(5660300001)(11346002)(93886005)(486006); DIR:OUT; SFP:1101; SCL:1; SRVR:AM6PR08MB3173; H:AM6PR08MB3672.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: 65+I9cN7MM0jHJjF69BDEoY9e9bs7XR9r7w0vE0hzzlZjLMKEtIgQOnVhzhoKhFZotLTQghTJv34017XvDmGHnFf9iy7IQmZZisoJgckLVkmvE+ACSoaGsx9X9M6H/Ea9KCl0qydr7XQBmSS2XIwp/DtFTejejZbXrprHWZt/Bp+5BeZKJl4rm3axMM7eBirQa+LeiOdOHsM4oTiv77lxPdLh+ojJXHWFuNx2iK/89JoPvXOBuOF+U+sRkWpv66jZTq7DQVUGwP0Hu+w7fmQ1U2gVIFa4yiT0JMPceMMNE5WD7b8T5S9Egh8shEt7nC7Yu51wJmCfqHhtJkj7bp0pnBA7aeBgV03oKgW+USuJF4= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: 070673ed-e44a-4b74-4580-08d63ee85d98 X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Oct 2018 04:21:44.1868 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3173 Subject: Re: [dpdk-dev] [PATCH v1 3/3] test/hash: add readwrite test for ext table X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 Oct 2018 04:21:45 -0000 > On Fri, Oct 26, 2018 at 12:23:56AM +0000, Honnappa Nagarahalli wrote: > > > > > > On Wed, Oct 10, 2018 at 02:48:05PM -0700, Yipeng Wang wrote: > > > > This commit improves the readwrite test to consider extendable > > > > table feature and add more functional tests to cover more corner ca= ses. > > > > > > > > Signed-off-by: Yipeng Wang --- > > > > test/test/test_hash_readwrite.c | 70 > > > > ++++++++++++++++++++++++++++++++++------- 1 file changed, 58 > > > > insertions(+), 12 deletions(-) > > > > > > > With the extension of this test case, and the addition of other test > > > cases by Honnappa in the other patch sets in this release, we are > > > building up quite a large set of hash table autotests, some of whose > > > meaning and use is a bit obscure. Are there any hash tests that you > > > feel could be removed at this point, to simplify things? > > > > > (this comment does not apply to this patch) Looks like your concern is > > about maintenance of the test code. > > IMO, we need to reduce the number of configuration flags in this librar= y > which should reduce the number of test cases. > > The flags I think that are not necessary are: > > RTE_HASH_EXTRA_FLAGS_TRANS_MEM_SUPPORT - The tests prove that > this gives significant performance boost. IMO, if the platform supports i= t, it > should be enabled without user consent (I am not an expert on TSX). > > RTE_HASH_EXTRA_FLAGS_RW_CONCURRENCY - Most use cases require this > support. Only use case where this is not required is a single thread doin= g both > inserts and lookups. Even if such a use case is valid, the lock over head= should > be small. > > > I agree with the idea. What I suggest is that only a single flag should b= e > needed, and that only for the uncommon case, i.e. where we do not need an= y > locking of the hash-table. Otherwise the hash should be thread safe by de= fault > and using the most effective locking mechanism for the platform. >=20 > Unfortunately, doing this requires an ABI change, but since it only shoul= d > affect the create function, it should be doable with function versioning = to > keep backward compatibility. >=20 I have made the changes. It seems to be working fine. I will post it once i= nternal review completes. We made this change (SHA: 9d033dac7d7cacca9559e0381f99b4c730e80979) to supp= ort 'no free on delete'. This was done by introducing another configuration= flag 'RTE_HASH_EXTRA_FLAGS_NO_FREE_ON_DEL'. IMO, it makes sense to keep de= lete and free as two different operations always and deprecate 'free during= delete' support. We can provide backward compatibility by making ABI chang= e instead of introducing another configuration flag. > /Bruce