From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70058.outbound.protection.outlook.com [40.107.7.58]) by dpdk.org (Postfix) with ESMTP id EE17CFEB for ; Mon, 29 Oct 2018 06:54:23 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=k5qYT65+RYpCAyifytiId5SyhSF66MQEpw1VcYNaVCQ=; b=InbjcLJR0uY+RKDzw4QXQ5O2honZw2P/IudZtUw/u/PWWGl8HumySHetANl0cHV+apyjVaBDgLZ8cvzcY62OdkvYg0ojJs4/UbgMj2wzcQchVc0VNLU0l5g4woVJWYG2PcK7xBbHMMIz8C5Z/DMpBm4sGSSpMozGhprvGlK8uzg= Received: from AM6PR08MB3672.eurprd08.prod.outlook.com (20.177.115.29) by AM6PR08MB3077.eurprd08.prod.outlook.com (52.135.163.150) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1273.25; Mon, 29 Oct 2018 05:54:22 +0000 Received: from AM6PR08MB3672.eurprd08.prod.outlook.com ([fe80::c1a0:51bf:cd33:2b27]) by AM6PR08MB3672.eurprd08.prod.outlook.com ([fe80::c1a0:51bf:cd33:2b27%6]) with mapi id 15.20.1273.025; Mon, 29 Oct 2018 05:54:22 +0000 From: Honnappa Nagarahalli To: Bruce Richardson CC: Yipeng Wang , "stephen@networkplumber.org" , "dev@dpdk.org" , "sameh.gobriel@intel.com" , nd Thread-Topic: [PATCH v1 3/3] test/hash: add readwrite test for ext table Thread-Index: AQHUYR5KsslQmPs/p0iw68s850xkr6Uu8FuAgAFOSJCAASfeAIAEaJ2Q Date: Mon, 29 Oct 2018 05:54:22 +0000 Message-ID: References: <1539208085-30756-1-git-send-email-yipeng1.wang@intel.com> <1539208085-30756-4-git-send-email-yipeng1.wang@intel.com> <20181024203653.GA16476@bricha3-MOBL.ger.corp.intel.com> <20181026101216.GA14620@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20181026101216.GA14620@bricha3-MOBL.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Honnappa.Nagarahalli@arm.com; x-originating-ip: [217.140.111.135] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM6PR08MB3077; 6:fRWUklxCFZDivuMdNXqYil2NFXvJrX6h2n5zlm6pQJl2LXsO7/RcL1nVh1ZpWOm5GYidN/DV3ROdS7WDKvWhXC2FWlieyD4iTNWu8yWCIhbbJtb+6xbotCJTRK8oe344C4XlhniAFFj84mCwdd7Mj6gtAj12/tLsHHw7+kHQMHQmCnrbXK2LumH42YD6X6qu1BqGN95IkM178ekL/BBI2s4pq8h9Tq3uf3kdJOxVgxK1dRoscDdDTKYSWsOcYXboBDOpTy4h2SPQgO6GWdH4bN91cq75OOQiON0MIuT6TCIPpZeLM0Tl8/U81FxpwYFuS7AQ5BGJ+roJ1+OACwJBZ7wHoGelfvjY9MdK1/yvJsEzT3ugjEaaNTIZhcPbekrDiwqD0AbusxiiSr4R24zxj83y8JZuLk1Xq7ADUaTPz8vYECO5nRYUeVt9f8UyGITbLhSavzB3vV496ypqtV6blg==; 5:U5aAmDdlNRFnLESmfnJPpe035P869qP/eFwjGkbtgFuHblOHhYSGgBYAVcsr3qMTVgiXTaxOBOunSdlgdAdTQOVbeztli9nNgDDx3C32GFVtprqqVOaJihl7uY1QEsCIqmCLuTDyBbFFbaa7mnT1qHW3zLLV3aL2yUEdXOXAy1g=; 7:0d1VudtFPcKfm2mPuZliN9PGEIZN/6QyAGeyqcLK2g3J/KMNgZ0ktwsW+MoTM29vlmqVAR4XAql1S/YMvsFx48NJ6Jiwyh1mSSqzmRH1aknpJY0nGEZVuVLyzH1rJKDjxyiwZzxHtM3NVQ4+DDsl4w== x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 448b3294-1aa5-41e8-7a8a-08d63d62f9eb x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:AM6PR08MB3077; x-ms-traffictypediagnostic: AM6PR08MB3077: nodisclaimer: True x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(228905959029699); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231382)(944501410)(52105095)(3002001)(10201501046)(93006095)(93001095)(6055026)(148016)(149066)(150057)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123560045)(20161123564045)(20161123558120)(201708071742011)(7699051)(76991095); SRVR:AM6PR08MB3077; BCL:0; PCL:0; RULEID:; SRVR:AM6PR08MB3077; x-forefront-prvs: 084080FC15 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(39850400004)(136003)(346002)(376002)(366004)(43544003)(51444003)(189003)(199004)(446003)(11346002)(71190400001)(2900100001)(71200400001)(6246003)(486006)(102836004)(33656002)(66066001)(74316002)(476003)(229853002)(25786009)(14444005)(256004)(26005)(99286004)(68736007)(186003)(2906002)(72206003)(8676002)(478600001)(76176011)(316002)(106356001)(7696005)(8936002)(53936002)(6436002)(54906003)(81156014)(105586002)(93886005)(6506007)(81166006)(4326008)(6916009)(7736002)(14454004)(305945005)(55016002)(9686003)(6116002)(3846002)(86362001)(5250100002)(97736004)(5660300001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM6PR08MB3077; H:AM6PR08MB3672.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: V69pLHSOXqj4LY8HqEvxhYm64xMDDBf+fGJeNwUuYDNt2bnLJ2b/IFg2swqQmNItPJxKp6WJReODRkIGMua3TZpt6kUtR3SxltDQZQngothAgtqSTKsh8EtVVoeSU65TC4Ivisj9iY61mmZlAWdZ1F2T0HUfGCHT/Meat/VF0Ok1A6ldmCsnxxrT5XuLdTHuRVydp66r2f3efSp3oaFHu1B7UuMSvPXYhiykPy/GK2/mB2KOB/hElFyTeLg/Gs4AoTVaL15KqtX0shduO6RLjmnV5zoTbF0lbmvhaTq/0jL2UzlA9OS7J+smdOA9UV+aiJ45QmYOCLS+Xv0kwyWcRhCKm6LujZ5sNAtloZDtteg= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: 448b3294-1aa5-41e8-7a8a-08d63d62f9eb X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Oct 2018 05:54:22.7241 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3077 Subject: Re: [dpdk-dev] [PATCH v1 3/3] test/hash: add readwrite test for ext table X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Oct 2018 05:54:24 -0000 > > > On Wed, Oct 10, 2018 at 02:48:05PM -0700, Yipeng Wang wrote: > > > > This commit improves the readwrite test to consider extendable > > > > table feature and add more functional tests to cover more corner ca= ses. > > > > > > > > Signed-off-by: Yipeng Wang --- > > > > test/test/test_hash_readwrite.c | 70 > > > > ++++++++++++++++++++++++++++++++++------- 1 file changed, 58 > > > > insertions(+), 12 deletions(-) > > > > > > > With the extension of this test case, and the addition of other test > > > cases by Honnappa in the other patch sets in this release, we are > > > building up quite a large set of hash table autotests, some of whose > > > meaning and use is a bit obscure. Are there any hash tests that you > > > feel could be removed at this point, to simplify things? > > > > > (this comment does not apply to this patch) Looks like your concern is > > about maintenance of the test code. > > IMO, we need to reduce the number of configuration flags in this librar= y > which should reduce the number of test cases. > > The flags I think that are not necessary are: > > RTE_HASH_EXTRA_FLAGS_TRANS_MEM_SUPPORT - The tests prove that > this gives significant performance boost. IMO, if the platform supports i= t, it > should be enabled without user consent (I am not an expert on TSX). > > RTE_HASH_EXTRA_FLAGS_RW_CONCURRENCY - Most use cases require this > support. Only use case where this is not required is a single thread doin= g both > inserts and lookups. Even if such a use case is valid, the lock over head= should > be small. > > > I agree with the idea. What I suggest is that only a single flag should b= e > needed, and that only for the uncommon case, i.e. where we do not need an= y > locking of the hash-table. Otherwise the hash should be thread safe by de= fault > and using the most effective locking mechanism for the platform. >=20 RTE_HASH_EXTRA_FLAGS_RW_CONCURRENCY_LF - should take care of this. > Unfortunately, doing this requires an ABI change, but since it only shoul= d > affect the create function, it should be doable with function versioning = to > keep backward compatibility. >=20 Looks simple enough. Version the rte_hash_create function and map the exist= ing function to 18.08. The new version of the function will always enable h= w_trans_mem_support and rw_concurrency. Should we check to see if these fla= gs are set by the user and print a warning message about deprecation of the= se flags in the newer version of the function? > /Bruce