From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70049.outbound.protection.outlook.com [40.107.7.49]) by dpdk.org (Postfix) with ESMTP id 1583A5F25; Fri, 2 Nov 2018 05:30:38 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uoyx8t7V0tcJDevDkCPFtpyjeRlDuCsrN5SQ1MCFxKs=; b=qhH+f/CW/+UR4hC7vyaNPE9PXZAfpawlCS9e/0qwkcspJLkAq1D7p5CLQPcZ6bmYnXukBfsgIaULlwCPCWp6f14CK9bAHBW9+CKSC07DjP5UC+udnHhjv83YzK97ZmTrHlr+G9wVrugrIp6jqvGHKBhOZIpQ0Qs905vW22+RuxI= Received: from AM6PR08MB3672.eurprd08.prod.outlook.com (20.177.115.29) by AM6PR08MB2951.eurprd08.prod.outlook.com (52.135.163.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1273.25; Fri, 2 Nov 2018 04:30:36 +0000 Received: from AM6PR08MB3672.eurprd08.prod.outlook.com ([fe80::c1a0:51bf:cd33:2b27]) by AM6PR08MB3672.eurprd08.prod.outlook.com ([fe80::c1a0:51bf:cd33:2b27%6]) with mapi id 15.20.1273.025; Fri, 2 Nov 2018 04:30:36 +0000 From: Honnappa Nagarahalli To: "Gavin Hu (Arm Technology China)" , Stephen Hemminger CC: "dev@dpdk.org" , "thomas@monjalon.net" , "olivier.matz@6wind.com" , "chaozhu@linux.vnet.ibm.com" , "bruce.richardson@intel.com" , "konstantin.ananyev@intel.com" , "jerin.jacob@caviumnetworks.com" , "stable@dpdk.org" , nd Thread-Topic: [PATCH v4 2/2] ring: move the atomic load of head above the loop Thread-Index: AQHUccjZCIJwxa2i/k+ilpsv5CToGqU7LFmAgAB01bWAAEANEA== Date: Fri, 2 Nov 2018 04:30:36 +0000 Message-ID: References: <1541066031-29125-1-git-send-email-gavin.hu@arm.com> <1541066031-29125-3-git-send-email-gavin.hu@arm.com>, <20181101102601.7933b8d1@xeon-e3> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Honnappa.Nagarahalli@arm.com; x-originating-ip: [217.140.103.75] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM6PR08MB2951; 6:ny2A7OudZ6cMwfQaxrykRg7Tj6XBW8pYDRLrlp8GYehbHabsv1HwCjWjv4+lPQ5d2+IpJCiBtiyNFAU1jJpMSNVJvdaFrez/S45G0IE2saedDcOXjhSXrYKsn16saCIX8lHWm55s84WE7wCIC42W1X/FkA8wvvCy2B7NBEI+kLjnSkQz7ac9+zTiQgzgml5mw2Kw0pHL0sIyoBo9cCU4PFGkFnuCZA7BsaLV44Vd70k0OxEIMsQXF4ZKtuTTlQeUVDWEPVibDlnp+03abmCLmqul50knhOpCnft9ONlD7H/lSIJ/a0r5hTC5jF6wVR40sUNL+hMEIqmkf8r/Nl2r7U80BTZ7lchwKJBeSenMooAHVAGHU2HbOz+cxjfB9kVA+utWS7bs3kSLPhzgy8STdftobKbHoUr6L80v/VpNzjihTwTrXK6FoPV6QNCeiDiwtmw4OOSBOZnM0wqu7uP4SA==; 5:rTrtpAeLYDB4FZH/YPnPj0vLW16O8M6nz1hULiwOipxJcPy/Q4NAFVhCHJFRwDpCC3QQ+5XXodigkXf/7k7EwHcRPApqyfz+NjlnPSK2dkXbcCSnDdXHMoD/nzDAj9yFvlLDJWxr7rtCHnzNdlioXsrwKn4rkGXt1JliY1uK+wQ=; 7:1LIPOflapXGP3sQ5ZDZGu5r4tuLG8NmSXHNBQ05Y5+wkkPryS5UQtzM/zATg0SaSoYbul7ysSGr88U9yj0O0veGi4cSsFVhqanOoWoGmqgGrhXI7wAdcgS1KRm93t5NEz9chVX3NwpFwCR0q9HuHFw== x-ms-exchange-antispam-srfa-diagnostics: SOS;SOR; x-ms-office365-filtering-correlation-id: 9c0dfb05-2bb6-42c2-edfb-08d6407befd2 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:AM6PR08MB2951; x-ms-traffictypediagnostic: AM6PR08MB2951: nodisclaimer: True x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(180628864354917); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231382)(944501410)(52105095)(93006095)(93001095)(10201501046)(3002001)(6055026)(148016)(149066)(150057)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123564045)(20161123560045)(20161123558120)(201708071742011)(7699051)(76991095); SRVR:AM6PR08MB2951; BCL:0; PCL:0; RULEID:; SRVR:AM6PR08MB2951; x-forefront-prvs: 08444C7C87 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(396003)(39860400002)(376002)(366004)(136003)(189003)(199004)(14454004)(6436002)(478600001)(66066001)(5660300001)(6246003)(8936002)(74316002)(3846002)(316002)(7696005)(6116002)(110136005)(54906003)(33656002)(486006)(2906002)(55016002)(11346002)(476003)(446003)(256004)(72206003)(229853002)(97736004)(2900100001)(71200400001)(26005)(186003)(71190400001)(53936002)(105586002)(9686003)(102836004)(305945005)(68736007)(7736002)(76176011)(81166006)(25786009)(86362001)(99286004)(81156014)(8676002)(4326008)(93886005)(106356001)(6506007); DIR:OUT; SFP:1101; SCL:1; SRVR:AM6PR08MB2951; H:AM6PR08MB3672.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: BBYWAb4ohG6mFITDUcQip8UmxAr9nPxGhWzNhwrxQ0uUHUfR90N+Toz18y9ZG9LDhqKZfdS9VtSq3ePSyn97aXmlPya6+z5q91aL4J0ZP9NSIO6xmtz69fSIulohGeT8XfE+R9SWwLruYHS/CHIx+6rlNFdI+kVfrVuS+vvaUTCRDjyuFGk8i1kg37opwX/cTsJ051w6JjZL6OvhJe8Rjt6Ld749+RYmmSf1fDteS6/UWI3jwTFLkIGLCFMbnGt2Wfjxq2xTcQ+7sTWugLyQNUwXlahV3nrfvYHHL9QxE38XExCPNZ4pCD2h/MqRwh+Oa/BZSsgFBA2qjnUhzyMBqaBcFUH7rhds8L7C9QNVabY= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9c0dfb05-2bb6-42c2-edfb-08d6407befd2 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Nov 2018 04:30:36.7346 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB2951 Subject: Re: [dpdk-dev] [PATCH v4 2/2] ring: move the atomic load of head above the loop X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Nov 2018 04:30:39 -0000 =A0 On Thu, 1 Nov 2018 17:53:51 +0800=20 Gavin Hu wrote:=20 > +* **Updated the ring library with C11 memory model.**=20 > +=20 > + Updated the ring library with C11 memory model including the following = changes:=20 > +=20 > + * Synchronize the load and store of the tail=20 > + * Move the atomic load of head above the loop=20 > +=20 Does this really need to be in the release notes? Is it a user visible chan= ge=20 or just an internal/optimization and fix.=20 [Gavin] There is no api changes, but this is a significant change as ring i= s fundamental and widely used, it decreases latency by 25% in our tests, it= may do even better for cases with more contending producers/consumers or d= eeper depth of rings. [Honnappa] I agree with Stephen. Release notes should be written from DPDK = user perspective. In the rte_ring case, the user has the option of choosing= between c11 and non-c11 algorithms. Performance would be one of the criter= ia to choose between these 2 algorithms. IMO, it probably makes sense to in= dicate that the performance of c11 based algorithm has been improved. Howev= er, I do not know what DPDK has followed historically regarding performance= optimizations. I would prefer to follow whatever has been followed so far. I do not think that we need to document the details of the internal changes= since it does not help the user make a decision.