From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20050.outbound.protection.outlook.com [40.107.2.50]) by dpdk.org (Postfix) with ESMTP id 4F15A1B144 for ; Thu, 3 Jan 2019 02:14:05 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fbqHt1o2nVOS38zI1WWTflhpgZex5vNwb17SRdkYcV8=; b=FMF6Kb8wdyKAFy3ez+0uLftzYnloe33rW0A8VKjITf3IlK++jzqnf7W6ZNdVypKRit5tBuPhHFQWAgre3AijI/9X9rTj59s8wz9bhElcaLMPymhEdZ00ZPNvqK1tAGMBJTpLqXZkMyCouTgG8jjjnSu7C35CQ8720mRrb+ae8gg= Received: from AM6PR08MB3782.eurprd08.prod.outlook.com (20.178.89.23) by AM6PR08MB3781.eurprd08.prod.outlook.com (20.178.89.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1495.6; Thu, 3 Jan 2019 01:14:04 +0000 Received: from AM6PR08MB3782.eurprd08.prod.outlook.com ([fe80::ec42:3d22:9741:b870]) by AM6PR08MB3782.eurprd08.prod.outlook.com ([fe80::ec42:3d22:9741:b870%5]) with mapi id 15.20.1495.005; Thu, 3 Jan 2019 01:14:03 +0000 From: "Ruifeng Wang (Arm Technology China)" To: Honnappa Nagarahalli , "dev@dpdk.org" CC: "thomas@monjalon.net" , "jerinj@marvell.com" , "hemant.agrawal@nxp.com" , "bruce.richardson@intel.com" , "chaozhu@linux.vnet.ibm.com" , nd , "tomaszx.kulasek@intel.com" , nd , nd Thread-Topic: [PATCH v1] examples/l3fwd: enable hash multi lookup for ARM Thread-Index: AQHUolwbqhZ+V9+Lr0+VKeL7TUPADaWcS7aAgABwhgA= Date: Thu, 3 Jan 2019 01:14:03 +0000 Message-ID: References: <20190102052826.156605-1-ruifeng.wang@arm.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Ruifeng.Wang@arm.com; x-originating-ip: [113.29.88.7] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM6PR08MB3781; 6:akH4idhdeIuLJiaMgrwNlcI5KOVUlog8vhBDBXtEPTnbnr2YnFD9HfDKADzeP+QyujrxSZNCGMkFK2LM7dhaJb0XxdhMmvxH1XtQL0Zm24AOmjhSOed7ivJfWd9oRzzc2ffonEO3f5cPPhnx+1lq82atvwUn7ShqLLrTJOM0rqxgS5BurzDXM1MDRODgMnyBpQgLCNJjN7iYAsbQ0bOZECUpVxOxSAnz1GLcE7S0qbotLTXqpnwsfP1yuZuWdzQwdiOm5MtlLCdqQQ/5XQ03H8hXJPK9gvIvmO1UNyRI4brNYaqLwvp6Lpqmz3bkae2MFY0JJeLY+hZDAtrNv8h1xIHKzQ47wZ9ASfDVjfHV7kB576ADqqMMUBdbN3A6V+QCUYpHKC6uU19jLF5X76FDAZcZg9KHW6kSxEHkVDPlhdlRIInup3Jm4NJfAcAFsp4D4WgCrJUdDjmVBZTFzYsg9g==; 5:WRP7yV522YbCUfThaPHCm9NuU9nBsHQ560YwxxAbKwv0uy1ceLlkOMVYCakZr03I5IbwYoQrKHTjRUPvoksVI2k8XIlUK24/dsfT3qEnz1lM2tpWj8T++TAb8xu3j8gea7YwWphMDEKl0kWXEE/fvJeVZjTGzh/Qbq5qpO4VxWpVWKOThgmShhDaAPlkivI4FtRn7B6YbarsDPXrMXta/Q==; 7:wADeEXjb6Dqc3SsS+YK7twI8NZVeFycVXBMVdkpIc1BTcIbm84lNFKJOGNqmAVTTGgfBSb+6Llg/BSQoU/v3EtnvassMdABZpzGVABCzcYJRlyIHxKvR+G1VcEs/INn2rWl1kbXiYPZquoMTcI0NvQ== x-ms-exchange-antispam-srfa-diagnostics: SOS;SOR; x-ms-office365-filtering-correlation-id: c05b6dd3-a7b8-48cd-cf53-08d67118c03e x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600109)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:AM6PR08MB3781; x-ms-traffictypediagnostic: AM6PR08MB3781: nodisclaimer: True x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(3230021)(908002)(999002)(5005026)(6040522)(8220060)(2401047)(8121501046)(3002001)(93006095)(93001095)(3231475)(944501520)(52105112)(10201501046)(6055026)(6041310)(20161123558120)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123560045)(201708071742011)(7699051)(76991095); SRVR:AM6PR08MB3781; BCL:0; PCL:0; RULEID:; SRVR:AM6PR08MB3781; x-forefront-prvs: 0906E83A25 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(39860400002)(376002)(136003)(396003)(346002)(189003)(199004)(13464003)(106356001)(76176011)(81156014)(81166006)(55236004)(102836004)(478600001)(74316002)(186003)(6246003)(8676002)(26005)(229853002)(53546011)(105586002)(72206003)(66066001)(3846002)(6506007)(2906002)(6116002)(33656002)(97736004)(14454004)(4326008)(7736002)(256004)(316002)(99286004)(476003)(25786009)(575784001)(8936002)(5660300001)(11346002)(86362001)(68736007)(54906003)(55016002)(446003)(7696005)(305945005)(71190400001)(53936002)(2501003)(6436002)(71200400001)(9686003)(110136005)(486006); DIR:OUT; SFP:1101; SCL:1; SRVR:AM6PR08MB3781; H:AM6PR08MB3782.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: tFbIBTZYD9Lr4i7Ds0wD0lRJ5FNzJfLjh4cqoMQAoQgIwAfVgYPJi+yYcIJ/3MxyCyVnpIiJ1v9tSCUCGbk9jGuKx4PJYVXC3qYiAk5l2Rhevj7jnS7exxXZ1/AtnG21sHkRbcQaLTWsyEg68yrQ+gMJe8PfJhNu/9OrOePV9qRB4DJ/nzRb8OCr8/V+8NMjJJtMvymI555JNL9igfP3BZA8shcH/adygJc3dTSRq5KudW8sqztjqpnzdW46oi3WSuMEYFJDgHxJg+YlDSh+RqRu1uGOyFgxl0t87sqae7WDcS+M04fVOZtyD6cLH2fS spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: c05b6dd3-a7b8-48cd-cf53-08d67118c03e X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Jan 2019 01:14:03.6978 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3781 Subject: Re: [dpdk-dev] [PATCH v1] examples/l3fwd: enable hash multi lookup for ARM X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Jan 2019 01:14:05 -0000 Hi Honnappa, > -----Original Message----- > From: Honnappa Nagarahalli > Sent: Thursday, January 3, 2019 2:23 > To: Ruifeng Wang (Arm Technology China) ; > dev@dpdk.org > Cc: thomas@monjalon.net; jerinj@marvell.com; hemant.agrawal@nxp.com; > bruce.richardson@intel.com; chaozhu@linux.vnet.ibm.com; nd > ; Ruifeng Wang (Arm Technology China) > ; tomaszx.kulasek@intel.com; nd > Subject: RE: [PATCH v1] examples/l3fwd: enable hash multi lookup for ARM >=20 > Thanks Ruifeng for the patch. I have one question inline. >=20 > Jerin/Hemant, > It would be good if you could test this on your platforms, since this is > being made default. >=20 > Thanks, > Honnappa >=20 > > -----Original Message----- > > From: Ruifeng Wang > > Sent: Tuesday, January 1, 2019 11:28 PM > > To: dev@dpdk.org > > Cc: thomas@monjalon.net; jerinj@marvell.com; > hemant.agrawal@nxp.com; > > bruce.richardson@intel.com; chaozhu@linux.vnet.ibm.com; Honnappa > > Nagarahalli ; nd ; > Ruifeng > > Wang (Arm Technology China) ; > > tomaszx.kulasek@intel.com > > Subject: [PATCH v1] examples/l3fwd: enable hash multi lookup for ARM > > > > Compile option for hash_multi_lookup was broken, and caused feature > > cannot be enabled on Arm. > > This patch sets hash_multi_lookup method as default, and sequential > > lookup becomes optional. > > > > In test of 8192 flows with 128-byte packets, throughput increased by > > 25.6% after enabling hash_multi_lookup. > > > I assume these are lookup-hit numbers. Do you have look-up miss numbers? >=20 Yes, lookup-hit had 25.6% gain. In lookup-miss tests, throughput had over 33% gain. > > Fixes: 52c97adc1f0f ("examples/l3fwd: fix exact match performance") > > Cc: tomaszx.kulasek@intel.com > > > > Signed-off-by: Ruifeng Wang > > Reviewed-by: Gavin Hu > > Reviewed-by: Phil Yang > > Tested-by: Ruifeng Wang > > --- > > examples/l3fwd/l3fwd.h | 4 ---- > > 1 file changed, 4 deletions(-) > > > > diff --git a/examples/l3fwd/l3fwd.h b/examples/l3fwd/l3fwd.h index > > c962deac3..063b80018 100644 > > --- a/examples/l3fwd/l3fwd.h > > +++ b/examples/l3fwd/l3fwd.h > > @@ -11,10 +11,6 @@ > > > > #define RTE_LOGTYPE_L3FWD RTE_LOGTYPE_USER1 > > > > -#if !defined(NO_HASH_MULTI_LOOKUP) && > > defined(RTE_MACHINE_CPUFLAG_NEON) -#define > NO_HASH_MULTI_LOOKUP 1 > > -#endif > > - > > #define MAX_PKT_BURST 32 > > #define BURST_TX_DRAIN_US 100 /* TX drain every ~100us */ > > > > -- > > 2.17.1