From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20088.outbound.protection.outlook.com [40.107.2.88]) by dpdk.org (Postfix) with ESMTP id ADE401B1F0 for ; Thu, 14 Feb 2019 03:40:57 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BmNoqAu53S5DFwptRBPYNkB+Dqf/xbYiiFjl3o1AmeI=; b=PTSGhz/KUs5hZVFxUkjHRxB7XFgNIaC0ii6NC/CiziUOIhPpSblubmTmFfSNCwdaARih4btLBlnFvVE7+TW0NVWckH1cMcYRPU28ZxkA/2EoMGczpBM1kkc70l+YWvgzf3VkWQ3EBK6yqd4qMOvo4DkTWdwlUFOWhLG9dcD/Y7s= Received: from AM6PR08MB3782.eurprd08.prod.outlook.com (20.178.89.23) by AM6PR08MB3221.eurprd08.prod.outlook.com (52.135.165.161) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1601.19; Thu, 14 Feb 2019 02:40:56 +0000 Received: from AM6PR08MB3782.eurprd08.prod.outlook.com ([fe80::4961:be49:af6d:4e50]) by AM6PR08MB3782.eurprd08.prod.outlook.com ([fe80::4961:be49:af6d:4e50%5]) with mapi id 15.20.1601.023; Thu, 14 Feb 2019 02:40:56 +0000 From: "Ruifeng Wang (Arm Technology China)" To: "Wang, Yipeng1" , "jerinj@marvell.com" CC: "dev@dpdk.org" , Honnappa Nagarahalli , "Gavin Hu (Arm Technology China)" , nd , nd Thread-Topic: [PATCH v2] hash: optimize signature compare by using neon intrinsic Thread-Index: AQHUwqDpQUOcXvB6GkiKCT95gdbggaXeMQ4AgABiPoA= Date: Thu, 14 Feb 2019 02:40:55 +0000 Message-ID: References: <20190212070104.33830-1-ruifeng.wang@arm.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Ruifeng.Wang@arm.com; x-originating-ip: [113.29.88.7] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3c976a9e-c4c7-4b23-8e77-08d69225d860 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600110)(711020)(4605077)(4618075)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020); SRVR:AM6PR08MB3221; x-ms-traffictypediagnostic: AM6PR08MB3221: x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr nodisclaimer: True x-microsoft-exchange-diagnostics: 1; AM6PR08MB3221; 20:TlpbzD6z/PNSZmniK3zLIt+BQP5gYw7m37xJyfHZoMespWwJHFMNNNv3DjX/0n1kg6SDpTVigjiguE+f1NNegCImuMSvZTuokOKhXXwjd8Y5ffpolhiReXultB7xtokN+F8BMP9e+YzW37sWgfqRCBDFX2nwMvbjmzTcdGo9H+w= x-microsoft-antispam-prvs: x-forefront-prvs: 09480768F8 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(376002)(396003)(136003)(39860400002)(366004)(199004)(189003)(13464003)(2501003)(14454004)(68736007)(256004)(446003)(478600001)(2906002)(3846002)(486006)(6116002)(86362001)(72206003)(74316002)(305945005)(229853002)(476003)(66066001)(81166006)(81156014)(8676002)(8936002)(7736002)(55016002)(33656002)(9686003)(11346002)(6436002)(7696005)(55236004)(99286004)(71190400001)(71200400001)(53936002)(186003)(102836004)(53546011)(76176011)(97736004)(6246003)(25786009)(54906003)(316002)(4326008)(110136005)(105586002)(26005)(106356001)(6506007); DIR:OUT; SFP:1101; SCL:1; SRVR:AM6PR08MB3221; H:AM6PR08MB3782.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: ZCyshW2s3ISq9Jhyka4XfftVvkUdbV+RtTA4rwZNhDab+JPjTdZwVl5J2ZwVKX9tu2ERwQNn/SfNOVjp8pA+3QbkFPviid9y3IuLyBkNd2CSWeIj26igVZzAve4oBbWLryOAKTzJ62m9YBOAohusvq5dACoDOGZolmCZxtNav84ngf6pShV0rTnHEwCa8r66x6XJFctb4V8o5PGeA6FA1JRpOzb+Abe1/ssdLZazbQHgHClQWKwQeEz6p3ZNt68nx+DZ/jADMdf2aeEzhq8m8u4wMjbVJlPrviE8/AmslduzcCmE+9IaAJlyR4qvCYRjNEf3IETxQak5PSJRhAbA8DVcJscYLlXhgyYFeFbtBowfk8ZVfYNZJylvLE6HivRIYdYCCh5oJUapyEe+oOHSfvZHwD3ntEzM/8aIyeUo3IU= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3c976a9e-c4c7-4b23-8e77-08d69225d860 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Feb 2019 02:40:55.9774 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3221 Subject: Re: [dpdk-dev] [PATCH v2] hash: optimize signature compare by using neon intrinsic X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Feb 2019 02:40:57 -0000 Hi Yipeng, Thanks for your review and acknowledgement. I did think about braces on separate lines. One concern is, in this way, ex= tra indent will be needed and=20 make it hard to keep code lines within 80 characters. So I made the style c= ompromise.=20 Regards, /Ruifeng > -----Original Message----- > From: Wang, Yipeng1 > Sent: Thursday, February 14, 2019 4:32 > To: Ruifeng Wang (Arm Technology China) ; > jerinj@marvell.com > Cc: dev@dpdk.org; Honnappa Nagarahalli > ; Gavin Hu (Arm Technology China) > ; nd > Subject: RE: [PATCH v2] hash: optimize signature compare by using neon > intrinsic >=20 > Hi, Ruifeng, >=20 > I don't have an ARM Platform at hand to test but I gone through the code > against a NEON instruction manual, and the logic looks good to me. One sm= all > comment is the coding style for switch case, I think it is more common to > leave the braces on their own lines. >=20 > Otherwise: > Acked-by: Yipeng Wang >=20 >=20 > >-----Original Message----- > >From: Ruifeng Wang [mailto:ruifeng.wang@arm.com] > >Sent: Monday, February 11, 2019 11:01 PM > >To: Wang, Yipeng1 ; jerinj@marvell.com > >Cc: dev@dpdk.org; honnappa.nagarahalli@arm.com; gavin.hu@arm.com; > >nd@arm.com; Ruifeng Wang > >Subject: [PATCH v2] hash: optimize signature compare by using neon > >intrinsic > > > >Implemented signature compare function based on neon intrinsic. > >Hash bulk lookup had 3% - 6% performance gain after optimization. > > > >Signed-off-by: Ruifeng Wang > >Reviewed-by: Gavin Hu