From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 2E036A2EEB
	for <public@inbox.dpdk.org>; Fri, 13 Sep 2019 06:17:36 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id A24FD1F03A;
	Fri, 13 Sep 2019 06:17:34 +0200 (CEST)
Received: from EUR03-AM5-obe.outbound.protection.outlook.com
 (mail-eopbgr30040.outbound.protection.outlook.com [40.107.3.40])
 by dpdk.org (Postfix) with ESMTP id 25D111F024;
 Fri, 13 Sep 2019 06:17:31 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; 
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=awBF/RRumHo523OLdVr3xMQZiZtp68hWAzAeGhsGksc=;
 b=2OYIVcyJAl6ovMZefyfQA1fjsxrXmD3kOlYGmKBQBXD6H1HkQy/TrlUmDCixNbJZMxifJD1k6qffGXL6YkV5bZwdI6KEQRtnjNYkJtZJ08qrfY285p5t7brE3KoKQwewWu4CEsH3IhsQTniiZ2/ScC2K2UboX/vjMjGC/9CGxb0=
Received: from DB7PR08CA0005.eurprd08.prod.outlook.com (2603:10a6:5:16::18) by
 DBBPR08MB4393.eurprd08.prod.outlook.com (2603:10a6:10:c7::17) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.2263.14; Fri, 13 Sep 2019 04:17:29 +0000
Received: from AM5EUR03FT060.eop-EUR03.prod.protection.outlook.com
 (2a01:111:f400:7e08::201) by DB7PR08CA0005.outlook.office365.com
 (2603:10a6:5:16::18) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2263.15 via Frontend
 Transport; Fri, 13 Sep 2019 04:17:29 +0000
Authentication-Results: spf=temperror (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dpdk.org; dmarc=none action=none
 header.from=arm.com;
Received-SPF: TempError (protection.outlook.com: error in processing during
 lookup of arm.com: DNS Timeout)
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT060.mail.protection.outlook.com (10.152.16.160) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id
 15.20.2263.14 via Frontend Transport; Fri, 13 Sep 2019 04:17:28 +0000
Received: ("Tessian outbound 55d20e99e8e2:v31");
 Fri, 13 Sep 2019 04:17:26 +0000
X-CR-MTA-TID: 64aa7808
Received: from b27ba88d39a1.3 (ip-172-16-0-2.eu-west-1.compute.internal
 [104.47.8.53]) by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 09ED230D-1FFC-42C2-AFFC-571BDA7B4918.1; 
 Fri, 13 Sep 2019 04:17:20 +0000
Received: from EUR03-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur03lp2053.outbound.protection.outlook.com [104.47.8.53])
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b27ba88d39a1.3
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 13 Sep 2019 04:17:20 +0000
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=npLM9Xk2/TWcRnJ4p/7yzUrdb8CyMIvcN/+14sCz0KxeDaNcJOJoOU9gJGnC2Bg1iyZkPiGX1XRdGC0b3dE7CdXHu/HlUkOcBEZ9hr6mRu+lNDSulSB29MgC6vkr0h+9CP+vhF9V4SdQrbsugRKTzSPoCES63y8IAYncCn0QkpgtsbHlCnufyTjzxrRXxOj1pxWhygjRtIIRc8wFa7KrioIfjVlv3emuT/mdnVZBsXgtd6SNVomDPFpZ6NWzajtJRxMmgvHGEDLO8QTJS2AvFME/CXWzO/0oYTECODMl2GESDXO2d397mrvzvvckkzz9KDHur9fTPluCgGTt8FVD0A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; 
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=awBF/RRumHo523OLdVr3xMQZiZtp68hWAzAeGhsGksc=;
 b=jisk3fJJ5+7HrK2UhczfLcNollJoyYL9lZI8KVNfo00+gQCOve9Uj67hxtwR1W68sEDBGikc5VcvvjxouKZ5L+d3WcOFRnbhzkI7vtuakdlzsFfIPDms1qaHDlAZAAWcwrV/nmOjkN+3oGvzCLaMqS6eyZwMR41g4REw8a+wq2D1G31wooWnN86ypMS6201z25PEZe1B8HCL3CbwxLX69jnkoYDGLdMSIx2pqxw3c8Y1nt+YVjAtacy81VREPTdAYaoELQBDDJNiYjmriIolPMB+RVMjp6hwh6uyvww93Hee1IyCfAmmiWJpq6ZNdAawHAeIWCRBHGAmG/hqordFyw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; 
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=awBF/RRumHo523OLdVr3xMQZiZtp68hWAzAeGhsGksc=;
 b=2OYIVcyJAl6ovMZefyfQA1fjsxrXmD3kOlYGmKBQBXD6H1HkQy/TrlUmDCixNbJZMxifJD1k6qffGXL6YkV5bZwdI6KEQRtnjNYkJtZJ08qrfY285p5t7brE3KoKQwewWu4CEsH3IhsQTniiZ2/ScC2K2UboX/vjMjGC/9CGxb0=
Received: from AM6PR08MB5144.eurprd08.prod.outlook.com (10.255.122.221) by
 AM6PR08MB3414.eurprd08.prod.outlook.com (20.177.114.74) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.2263.17; Fri, 13 Sep 2019 04:17:20 +0000
Received: from AM6PR08MB5144.eurprd08.prod.outlook.com
 ([fe80::add1:41d3:6c9:ba55]) by AM6PR08MB5144.eurprd08.prod.outlook.com
 ([fe80::add1:41d3:6c9:ba55%6]) with mapi id 15.20.2263.016; Fri, 13 Sep 2019
 04:17:19 +0000
From: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
To: "Ruifeng Wang (Arm Technology China)" <Ruifeng.Wang@arm.com>
CC: "dev@dpdk.org" <dev@dpdk.org>, "Gavin Hu (Arm Technology China)"
 <Gavin.Hu@arm.com>, nd <nd@arm.com>, "Ruifeng Wang (Arm Technology China)"
 <Ruifeng.Wang@arm.com>, "stable@dpdk.org" <stable@dpdk.org>, nd <nd@arm.com>
Thread-Topic: [PATCH] lib/rcu: fix possible spurious thread unregister
Thread-Index: AQHVZxXGWrmq4Nw06kyMQ8Drk7xPD6cpBdjQ
Date: Fri, 13 Sep 2019 04:17:19 +0000
Message-ID: <AM6PR08MB51443F0FA5C3351C5193133498B30@AM6PR08MB5144.eurprd08.prod.outlook.com>
References: <20190909135142.3510-1-ruifeng.wang@arm.com>
In-Reply-To: <20190909135142.3510-1-ruifeng.wang@arm.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ts-tracking-id: 386a403d-5437-4d21-9394-7eeb4c86775e.0
x-checkrecipientchecked: true
Authentication-Results-Original: spf=none (sender IP is )
 smtp.mailfrom=Honnappa.Nagarahalli@arm.com; 
x-originating-ip: [217.140.111.135]
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: 2d3ad9b4-91f8-48ce-4dbd-08d7380149d3
X-MS-Office365-Filtering-HT: Tenant
X-Microsoft-Antispam-Untrusted: BCL:0; PCL:0;
 RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600166)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020);
 SRVR:AM6PR08MB3414; 
X-MS-TrafficTypeDiagnostic: AM6PR08MB3414:|AM6PR08MB3414:|DBBPR08MB4393:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS: <DBBPR08MB439346BF87573BD91B9F722C98B30@DBBPR08MB4393.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
x-ms-oob-tlc-oobclassifiers: OLM:843;OLM:843;
x-forefront-prvs: 0159AC2B97
X-Forefront-Antispam-Report-Untrusted: SFV:NSPM;
 SFS:(10009020)(4636009)(376002)(366004)(136003)(346002)(396003)(39860400002)(189003)(199004)(13464003)(4326008)(25786009)(6436002)(81156014)(81166006)(450100002)(8676002)(305945005)(71200400001)(256004)(9686003)(66066001)(5660300002)(99286004)(55016002)(3846002)(486006)(229853002)(7736002)(71190400001)(54906003)(6116002)(74316002)(476003)(316002)(6636002)(86362001)(11346002)(76116006)(66556008)(66476007)(6506007)(26005)(53546011)(52536014)(6246003)(14454004)(446003)(186003)(64756008)(6862004)(66446008)(2906002)(508600001)(7696005)(53936002)(102836004)(66946007)(33656002)(8936002)(76176011);
 DIR:OUT; SFP:1101; SCL:1; SRVR:AM6PR08MB3414;
 H:AM6PR08MB5144.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en;
 PTR:InfoNoRecords; MX:1; A:1; 
received-spf: None (protection.outlook.com: arm.com does not designate
 permitted sender hosts)
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam-Message-Info-Original: sKZ0LCrkNeEYBMpKZa98vEEpgW/0/jSjGhlMCWrzz/tJSYSs1lXVGKM1czFqz9ZNpwOJIZ5BTkAUpyQeW17xJ5ogKWNhrlRxYXoVvL0Nj3ZIbUwSzy2OTpV6D6PJnB16UjUBues0Xozc7Gx5g10gVINaTBqlrAjJOslDnLb83vpRBSShUmvd47kkqJlyZvZoDie6XwRaIUASLXCKLPKv66A/m+uTfBLhNnFe5UmI+KhY7MZqWw3j4EoPw7QTrjhE6b4/rbikfRFXiGcR7GT4LZ/OG82A7n2P1wtmj6PDntlhVHFE2Xzwsn4us9nvC4JDr7cXRYsuGywgznTKaonNJsUD0k95odNwjodLJg2PsiWOM0ygnlvjb4EkFbvTq2idS4JdqLLsrRdm2hDYViGmflanX6g1KeszBMKm/4IJOa4=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3414
Original-Authentication-Results: spf=none (sender IP is )
 smtp.mailfrom=Honnappa.Nagarahalli@arm.com; 
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT060.eop-EUR03.prod.protection.outlook.com
X-Forefront-Antispam-Report: CIP:63.35.35.123; IPV:CAL; SCL:-1; CTRY:IE;
 EFV:NLI; SFV:NSPM;
 SFS:(10009020)(4636009)(346002)(136003)(376002)(39860400002)(396003)(13464003)(199004)(189003)(486006)(25786009)(336012)(50466002)(508600001)(126002)(7736002)(26826003)(33656002)(356004)(46406003)(66066001)(74316002)(476003)(305945005)(47776003)(102836004)(316002)(26005)(81166006)(22756006)(14454004)(5660300002)(52536014)(7696005)(229853002)(63350400001)(186003)(99286004)(6116002)(3846002)(54906003)(23726003)(53546011)(6506007)(6246003)(4326008)(446003)(55016002)(36906005)(76130400001)(6636002)(8676002)(11346002)(450100002)(81156014)(6862004)(76176011)(86362001)(97756001)(70586007)(8936002)(9686003)(8746002)(2906002)(70206006);
 DIR:OUT; SFP:1101; SCL:1; SRVR:DBBPR08MB4393;
 H:64aa7808-outbound-1.mta.getcheckrecipient.com; FPR:; SPF:TempError; LANG:en;
 PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; A:1; MX:1; 
X-MS-Office365-Filtering-Correlation-Id-Prvs: adc207c5-04d2-4585-33b0-08d7380144e8
X-Microsoft-Antispam: BCL:0; PCL:0;
 RULEID:(2390118)(7020095)(4652040)(8989299)(5600166)(710020)(711020)(4605104)(1401327)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020);
 SRVR:DBBPR08MB4393; 
NoDisclaimer: True
X-Forefront-PRVS: 0159AC2B97
X-Microsoft-Antispam-Message-Info: SNQnBs4AAyIRJGu4594nNmAQBtRPVdXylomUY8fxOmFiPe2ycsaxuDGzwbRNmhYh4yupKaIcpbApfoRm5O3LGTkjXrXalh3hBAaxl3UwlD+VE5a+06ENUMYvZSxRyiKvUq4T+lgO7+kQ4l6eTFgXVMXAVPK/sTt6jRkrj7Ux0vQcgtCzDLUhJ8kt/bh+/mP17tYUPEbRUOT5vRIMzHnKdbu90heI5xY3IT20YDrjhybDGYNfblMH9/eUVTYDHfa+t0IsaeFaQdm5vjltWAqEIyH01qfgNAfeSKuOsymjKxslDNB1P1sqDr0MtMAGPEQTz70fXQ7If+evOQAm0x2Piz6cxdJYBc/g087vL4AOOSvORG5bzzGZU/VopjfZR7WBpk99SMHm8YfVpRCFc3bLh/w4Dpn+LXl/iEnMMtSJRXc=
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Sep 2019 04:17:28.0041 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 2d3ad9b4-91f8-48ce-4dbd-08d7380149d3
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123];
 Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB4393
Subject: Re: [dpdk-dev] [PATCH] lib/rcu: fix possible spurious thread
	unregister
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Thanks Ruifeng, looks good.

> -----Original Message-----
> From: Ruifeng Wang <ruifeng.wang@arm.com>
> Sent: Monday, September 9, 2019 8:52 AM
> To: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
> Cc: dev@dpdk.org; Gavin Hu (Arm Technology China) <Gavin.Hu@arm.com>;
> nd <nd@arm.com>; Ruifeng Wang (Arm Technology China)
> <Ruifeng.Wang@arm.com>; stable@dpdk.org
> Subject: [PATCH] lib/rcu: fix possible spurious thread unregister
>=20
> Thread unregister returns success while unregister not been performed.
> This is due to incorrect thread registration status check.
> Fix this issue by correcting bitmap check.
>=20
> Fixes: 64994b56cfd7 ("rcu: add RCU library supporting QSBR mechanism")
> Cc: stable@dpdk.org
>=20
> Signed-off-by: Ruifeng Wang <ruifeng.wang@arm.com>
> Reviewed-by: Gavin Hu <gavin.hu@arm.com>
> ---
>  lib/librte_rcu/rte_rcu_qsbr.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/lib/librte_rcu/rte_rcu_qsbr.c b/lib/librte_rcu/rte_rcu_qsbr.=
c index
> ce7f93dd3..8c37c88cd 100644
> --- a/lib/librte_rcu/rte_rcu_qsbr.c
> +++ b/lib/librte_rcu/rte_rcu_qsbr.c
> @@ -158,7 +158,7 @@ rte_rcu_qsbr_thread_unregister(struct rte_rcu_qsbr
> *v, unsigned int thread_id)
>  	/* Check if the thread is already unregistered */
>  	old_bmap =3D __atomic_load_n(__RTE_QSBR_THRID_ARRAY_ELM(v, i),
>  					__ATOMIC_RELAXED);
> -	if (old_bmap & ~(1UL << id))
> +	if (!(old_bmap & (1UL << id)))
>  		return 0;
>=20
>  	do {
> @@ -175,7 +175,7 @@ rte_rcu_qsbr_thread_unregister(struct rte_rcu_qsbr
> *v, unsigned int thread_id)
>  		if (success)
>  			__atomic_fetch_sub(&v->num_threads,
>  						1, __ATOMIC_RELAXED);
> -		else if (old_bmap & ~(1UL << id))
> +		else if (!(old_bmap & (1UL << id)))
>  			/* Someone else unregistered this thread.
>  			 * Counter should not be incremented.
>  			 */
> --
Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>

> 2.17.1