From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 26300A034C; Mon, 8 Aug 2022 12:40:17 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DDC664067B; Mon, 8 Aug 2022 12:40:16 +0200 (CEST) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60042.outbound.protection.outlook.com [40.107.6.42]) by mails.dpdk.org (Postfix) with ESMTP id 2D4F84014F for ; Mon, 8 Aug 2022 12:40:15 +0200 (CEST) ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=O+r/O5xHymII8KDRBs3yDciiAYB9IMfWbgm+3DzPerF8H68AbxPcLtiBzWxl24eB0eLTPHiqhxBSivUFjfM3ki27Q1oMIRXK4jiPjzv7jN/5gpmnb89dgwf01HSE14EW/oisFa1uveOZ9JhDv5u8aLp5U+tIEkkpOTE+cIR2/+eeRY9NfZISSYIlLBpDuRv/1tapW6MrmjUa0BnEnGdbXJFB98UgES4EJf/ZLgnNPviJG9LNUvhq8/JNfHhNQfobszCBlM0zoaRkEN36gb+GIX7j1MYLKrZj73orX/Q05BCfub8HX+Kbn0J9eY2VtsE/aYaacH5Q/82HbzT12lYagg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5d6sJsEL5XYBkZigLmFGkUIhU9x1oVsFCD1EwXs/cWg=; b=JxgoM64Y+Y0eVekpYUA6X5Edt/RUqqPn2I43z0KF/3Kpdm4mc95bwg6+C3nk7xTeeY96G7ulWO8RMmRdCt3QjFT3vhMnUcVonXMmpmrub/4Y3x49rqfTj4UFwauIAwvKxPUtsJHJG9X6uyumuONfY5YTFc/SikHMzQA8SmceOBkW2IAdx+2Cvc9tZDo1EC630HWWCOz6RHQsJIcjEi+RxarX1O+wbNhw+dP2cPYFfpnjU9imWs6RMvlevIq4t2mFmt15dDDJtxYeVnsSBeULmx0OZPUMY8j8PGJDTnoUtJdmkDr0aU5xPB3GRuzq7QQoE24ZWxmyXjHMi4nUgIf8KQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=dpdk.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5d6sJsEL5XYBkZigLmFGkUIhU9x1oVsFCD1EwXs/cWg=; b=PtIfiPkJKrWyZh7KUbnjpVdL3W6f2KTFKk77FlG8sfPpJIj41jd/P/hTeNdKyp6TOAUHB9pmI3C2DdlnjjZ8GCp8vxkolHz9YOC7lzqzj18nTQLcpOhAEC8sTXml96fmps7HLrJz0zqDzubnzmn00BBMhAo+/dT5Wq00oI2c5lw= Received: from AS9PR05CA0023.eurprd05.prod.outlook.com (2603:10a6:20b:488::13) by AS8PR08MB7323.eurprd08.prod.outlook.com (2603:10a6:20b:442::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5504.14; Mon, 8 Aug 2022 10:40:06 +0000 Received: from AM5EUR03FT003.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:488:cafe::b1) by AS9PR05CA0023.outlook.office365.com (2603:10a6:20b:488::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5504.16 via Frontend Transport; Mon, 8 Aug 2022 10:40:06 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT003.mail.protection.outlook.com (10.152.16.149) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5504.16 via Frontend Transport; Mon, 8 Aug 2022 10:40:05 +0000 Received: ("Tessian outbound cc6a8ab50b6b:v123"); Mon, 08 Aug 2022 10:40:05 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 5719e72646323792 X-CR-MTA-TID: 64aa7808 Received: from 017a25b4bf5e.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id D64E86DD-FD79-45B6-B221-BCCA328FB113.1; Mon, 08 Aug 2022 10:39:58 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 017a25b4bf5e.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 08 Aug 2022 10:39:58 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jQRIoTWrnWXHWaFOUSWuCQmsWV7cxjJKa7WC/9ONPzqzsiVMP7Zqb9IRQcJl5yh+49ApsW+qAoNIyMg9KUa21UMSWGzxHd0R2pChy7yIuFNj9/o6LwPhc8VNwEQnjKeHI88omGmDrJ1tvPoNuGZHz/5jsPSLD0j1tpQWg+pCWD0PY9mwXrZvkISuhtZOkMLGHxFCglbKbG8Ybdcfh3kRGiERmAGYrJdmubjcogNpv+CIWTOi9Z0Pq3aRcSld8zCm1/H90gTdz+T8udq/NCHOZnv0RQaQMJ7SXCjHBGYwkKac7Qu3srGoaq5Z21Of8dkGU1Y6z2qtbsSveLSw/t6Tzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5d6sJsEL5XYBkZigLmFGkUIhU9x1oVsFCD1EwXs/cWg=; b=emQKtj8KnSGi+BMmsIwZHh7mgbeFN2maC+ci8Wf3Mj3lxv+n8P9wyzmQxUXkKfYaglLB29iF5fXrbSf1eNwRqRK38He1Nnz7+LbpiP7OZ4SfQXd/SwX/0K5VMj7cLaWgnz7JEvDra8hI77GVn/mXQzw45ApzEV6zynT/pwadbmWs12wNOK6BwO/TxfYeFmiml/DgcxtCJWuenew8ZLJtlbh1XWC8j4ODWR5/5do2QDhEl4RFMEx+Q+pFyX43HudAtWcj4efLms6wI5sFrRyg7D2K9w6h1S4I2as94O406xE0SB3D6DMbxEU/jZV9jUF3+rz3kfMYeSSR+43u0FM8lw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5d6sJsEL5XYBkZigLmFGkUIhU9x1oVsFCD1EwXs/cWg=; b=PtIfiPkJKrWyZh7KUbnjpVdL3W6f2KTFKk77FlG8sfPpJIj41jd/P/hTeNdKyp6TOAUHB9pmI3C2DdlnjjZ8GCp8vxkolHz9YOC7lzqzj18nTQLcpOhAEC8sTXml96fmps7HLrJz0zqDzubnzmn00BBMhAo+/dT5Wq00oI2c5lw= Received: from AS4PR08MB7712.eurprd08.prod.outlook.com (2603:10a6:20b:513::6) by AS8PR08MB7224.eurprd08.prod.outlook.com (2603:10a6:20b:347::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5504.14; Mon, 8 Aug 2022 10:39:57 +0000 Received: from AS4PR08MB7712.eurprd08.prod.outlook.com ([fe80::84ce:1b39:1ce7:8d59]) by AS4PR08MB7712.eurprd08.prod.outlook.com ([fe80::84ce:1b39:1ce7:8d59%3]) with mapi id 15.20.5504.019; Mon, 8 Aug 2022 10:39:56 +0000 From: Joyce Kong To: huzaifa.rahman , "jgrajcia@cisco.com" CC: "dev@dpdk.org" Subject: RE: [PATCH] memif: memif driver does not crashes when there's different N of TX and RX queues Thread-Topic: [PATCH] memif: memif driver does not crashes when there's different N of TX and RX queues Thread-Index: AQHYoNjRNoM+5DLB0kSKiHXGPioBZq2k1zyQ Date: Mon, 8 Aug 2022 10:39:56 +0000 Message-ID: References: <20220726101628.2118564-1-huzaifa.rahman@emumba.com> In-Reply-To: <20220726101628.2118564-1-huzaifa.rahman@emumba.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 197889c4-48e7-4eb1-76b4-08da792a5b90 x-ms-traffictypediagnostic: AS8PR08MB7224:EE_|AM5EUR03FT003:EE_|AS8PR08MB7323:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: RhSmeCJFYQDJvSjelookLH5TYnBlIeW3amHi3uapTl+XGKZc69v2MVFx+BYDMktIfZ41fAOWldCA8xok8GhA9VzbzK6ou0hw8fPuMso3Ms3/Mx7PIkE0HtWHoTEtxInN7RftJPUMXHTIIYnQbA99ErmFEA7+eZg7hfWTmv7uvIujD6Qfy0zXTztO8Xuwu4lSSBby+psNh3d1sz6+DHuNx+vXrhWydbnJGP556aM6DVrnQGN+9zpzrEC3zrLUuXGHPBRfw57ARJFj8O8VjCNTZRwXKir6V8mmTQ0sUmmnE1B9PiUhpqR1Z165hwzy9OzGGGcMyX45SlNnY+aCqWj1+7dzThLQEveQI4w+J23uFFjHKeC/E5kweQHHMK6KZ+E4GJT7EVyn3UfPZVXih5jV7aaJZziFnGUOHGFnxYdy2yGSVJid2R3RPax3oPna1BO81dCRM2TQmYAiCW8VXd/AYRaZZSLYZVVyu+/eGRhFwxwTEY25/Kf8HYtPuuou4iX4up1lfviifpogfX/Qwilqy/BfcDIA7LSTcN5CAvkRtsYC6V08HT2dcY22fSY+WqdI6a3cfPYh+NmDN/1Puw7aruR51wbqjykG+yzJibWytandqeg5dCcpsAuynSu2HsEkac2wtg0gzDwefEhV8Je0BkacRYfd35TtsAi5rIOSVcEb3kSmKc1V9GfSs8Q8kayjzN+VrD1IYBGfc0g5ciRfuMIT0vC1HuctiTtQIRTLFG+VdWS+da+f+YwkCX4gAVJ1DSc5T1RlnOkRE14MKzHT1nbvGKJ6XMjHzsZ89XrbbCGChTnkpG4+GmBkqNKOo0SyJhTbB2Qji9zGldEEZ9Lefw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AS4PR08MB7712.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(136003)(376002)(346002)(396003)(366004)(39860400002)(2906002)(38070700005)(9686003)(26005)(41300700001)(7696005)(53546011)(6506007)(83380400001)(55016003)(38100700002)(122000001)(186003)(966005)(478600001)(52536014)(33656002)(71200400001)(4326008)(8676002)(64756008)(66446008)(66476007)(66556008)(76116006)(8936002)(66946007)(110136005)(316002)(5660300002)(86362001); DIR:OUT; SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB7224 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT003.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 8e493094-8afa-4bac-da4b-08da792a5641 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: b6LVYI1PJHD0gSG8z29kUGwhRlVoz3GZt8F5qKzcx/oZ6l3pHgghTS+RTtRqfvSBwHfhyliGRE1wwbn0+5gmmw0P+FIOyH2/6LegMwOclRVzs9P4dQOezBI57QtRxHbCeXCTHfkBl882umkLW4RGVlHjhVDKvqSIV80Jk1sFIwjXCWvKRnWVdXlhzTb3ATKodf4pifFwgdCmPAcsmEslNdl7X1wMLyqFY7IBoibLlwhsb81kIBxK9rnwKoQgKlJfB3NGRb/zJggMAR9RjxipXw6PiT7zabw/A8zQBlO66cCM976x/Aoldf3ApfQ9adBQWnzKfVx/nMd88qDpWl5gOTwm9anMVcYDNS6nC2ajs1hM+YMFqXjvAyqczt4YO53W9j30UeG0nQn7gEL0IP0+PJfkksMHhZFx1IpSr80bF5V6jpBvbIKA2v3bDRF5O6NCnd1+R+gUoYhK8L+Ia65Sit7hjkP2NJSny18RR7rFh0mLLyYDYbubi9/uaIc5QVIqd+6XrJjbC6BWzMz6iLPOrdo3epmwR4yyOcsurD89MhA4lrevwu6JZpn8JXRCnK/D8KOEH/mefQiHhF6bCOm/rpMYSX6nlfniXDAfUuJAmQQ4YmNSJNwDf4V/U0bOBOSe8s5jlSdvkUK9FmD2uN+VASavEI7TYMA6YdQPeYIBa6rg/3WTrBbDj4AEwhBF8z5do7DaXAOUeKTNDpVsuw9Z1DV8qMXPAabww/SXfeM3VD+WmVlz/mhsoM0+teKtF971epdcxKlo2G98ZNGUBsCZQQWtBnSAST5PDBL0JbT+HlfmMyxWPD15+C3jsE0aNyuY6I9/uU0Xl07/nketgF+MKA== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230016)(4636009)(376002)(396003)(39860400002)(346002)(136003)(40470700004)(36840700001)(46966006)(83380400001)(41300700001)(26005)(9686003)(6506007)(53546011)(7696005)(4326008)(70586007)(70206006)(186003)(356005)(8676002)(81166007)(86362001)(966005)(82740400003)(336012)(47076005)(316002)(40460700003)(110136005)(82310400005)(478600001)(33656002)(2906002)(55016003)(36860700001)(52536014)(40480700001)(5660300002)(8936002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Aug 2022 10:40:05.7659 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 197889c4-48e7-4eb1-76b4-08da792a5b90 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT003.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB7323 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Huzaifa, This patch looks good to me. And would you please help review my memif patches? https://patches.dpdk.org/project/dpdk/cover/20220701102815.1444223-1-joyce.= kong@arm.com/ Thanks, Joyce > -----Original Message----- > From: huzaifa.rahman > Sent: Tuesday, July 26, 2022 6:16 PM > To: jgrajcia@cisco.com > Cc: dev@dpdk.org; huzaifa.rahman > Subject: [PATCH] memif: memif driver does not crashes when there's > different N of TX and RX queues net/memif: fix memif crash with different Tx Rx queues > > Bugzilla ID: 734 > > there's a bug in memif_stats_get() function due to confusion between C2S > (client->server) and S2C (server->client) rings, causing a crash if there= 's a > different number of RX and TX queues. > > this is fixed by selectiing the correct rings for RX and TX i.e for RX, S= 2C rings > are selected and for TX, C2S rings are selected. > Fixes: 09c7e63a71f9 ("net/memif: introduce memory interface PMD") Cc: stable@dpdk.org > Signed-off-by: huzaifa.rahman Reviewed-by: Joyce Kong > --- > drivers/net/memif/rte_eth_memif.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/memif/rte_eth_memif.c > b/drivers/net/memif/rte_eth_memif.c > index dd951b8296..e56df84e10 100644 > --- a/drivers/net/memif/rte_eth_memif.c > +++ b/drivers/net/memif/rte_eth_memif.c > @@ -1444,8 +1444,8 @@ memif_stats_get(struct rte_eth_dev *dev, struct > rte_eth_stats *stats) > stats->opackets =3D 0; > stats->obytes =3D 0; > > - tmp =3D (pmd->role =3D=3D MEMIF_ROLE_CLIENT) ? pmd- > >run.num_c2s_rings : > - pmd->run.num_s2c_rings; > + tmp =3D (pmd->role =3D=3D MEMIF_ROLE_CLIENT) ? pmd- > >run.num_s2c_rings : > + pmd->run.num_c2s_rings; > nq =3D (tmp < RTE_ETHDEV_QUEUE_STAT_CNTRS) ? tmp : > RTE_ETHDEV_QUEUE_STAT_CNTRS; > > @@ -1458,8 +1458,8 @@ memif_stats_get(struct rte_eth_dev *dev, struct > rte_eth_stats *stats) > stats->ibytes +=3D mq->n_bytes; > } > > - tmp =3D (pmd->role =3D=3D MEMIF_ROLE_CLIENT) ? pmd- > >run.num_s2c_rings : > - pmd->run.num_c2s_rings; > + tmp =3D (pmd->role =3D=3D MEMIF_ROLE_CLIENT) ? pmd- > >run.num_c2s_rings : > + pmd->run.num_s2c_rings; > nq =3D (tmp < RTE_ETHDEV_QUEUE_STAT_CNTRS) ? tmp : > RTE_ETHDEV_QUEUE_STAT_CNTRS; > > -- > 2.25.1 IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.