RE: [PATCH v3 1/2] net/memif: add a Rx fast path

[Joyce Kong <Joyce.Kong@arm.com>]

Hi Stephen,

> -----Original Message-----
> From: Stephen Hemminger <stephen@networkplumber.org>
> Sent: Thursday, September 1, 2022 12:26 AM
> To: Joyce Kong <Joyce.Kong@arm.com>
> Cc: jgrajcia@cisco.com; huzaifa.rahman@emumba.com; dev@dpdk.org; nd
> <nd@arm.com>; mb@smartsharesystems.com; Ruifeng Wang
> <Ruifeng.Wang@arm.com>
> Subject: Re: [PATCH v3 1/2] net/memif: add a Rx fast path
> 
> On Mon, 22 Aug 2022 03:47:30 +0000
> Joyce Kong <joyce.kong@arm.com> wrote:
> 
> > +	if (likely(mbuf_size >= pmd->cfg.pkt_buffer_size)) {
> > +		struct rte_mbuf *mbufs[nb_pkts];
> > +		ret = rte_pktmbuf_alloc_bulk(mq->mempool, mbufs,
> nb_pkts);
> > +			if (unlikely(ret < 0))
> > +				goto no_free_bufs;
> > +
> 
> The indentation looks off here, is this because of diff?
> Also, my preference is to use blank line after declaration.
Will modify the format in next version.

> 
> One more thing, the use of variable length array on stack will cause the
> function to get additional overhead if stack-protector strong is enabled.
Will fix the array length in next version.