From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 86E52431DE; Mon, 23 Oct 2023 09:09:15 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6C9AE4027E; Mon, 23 Oct 2023 09:09:15 +0200 (CEST) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2059.outbound.protection.outlook.com [40.107.21.59]) by mails.dpdk.org (Postfix) with ESMTP id 71E9240270; Mon, 23 Oct 2023 09:09:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WrcdSkMjWDijLWQyzOnhT2cDB5YCvjXu7jWteEOI2dM=; b=Zh+mclqIguBeixBCq5pwHhffRFeSFkalG8skyriaT7yIARA77WQ0iOdYZgbzef9tqNyWJsWIbPr5+Wxo/p/m5IcYFb+oWNrVavWiYQDWrwP/6qrNUquZdPGW3YNN6heXlxFG2rt1AXUReDWxZuakv9Fl8ggsjIC7OgtSgYljq1g= Received: from DU7PR01CA0005.eurprd01.prod.exchangelabs.com (2603:10a6:10:50f::28) by PAVPR08MB9553.eurprd08.prod.outlook.com (2603:10a6:102:314::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.29; Mon, 23 Oct 2023 07:09:11 +0000 Received: from DU6PEPF0000A7E3.eurprd02.prod.outlook.com (2603:10a6:10:50f:cafe::4f) by DU7PR01CA0005.outlook.office365.com (2603:10a6:10:50f::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.33 via Frontend Transport; Mon, 23 Oct 2023 07:09:11 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DU6PEPF0000A7E3.mail.protection.outlook.com (10.167.8.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.15 via Frontend Transport; Mon, 23 Oct 2023 07:09:11 +0000 Received: ("Tessian outbound d9a8e74be042:v215"); Mon, 23 Oct 2023 07:09:10 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 4c87deaf4b626088 X-CR-MTA-TID: 64aa7808 Received: from 891b8f12c74a.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id AD89F876-9AFB-4700-AFD5-C599C7B0B188.1; Mon, 23 Oct 2023 07:09:03 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 891b8f12c74a.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 23 Oct 2023 07:09:03 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nNfKdcueNWeVs4RAl67LrAQhqZKtHTHr4Y3Z9HlQcswSs/4jTWltNygprdiGRvJEEWEK2mChoFgGbgwjcHyPCVipf35htpZIhmDz85SSEEwrOHrhOafVqI5LkVfh32dzcLMph2AmeY6tWeFtjrm1ksi85oOmUYkdu3uCCx87+dF9kTUJYfxeaB7mMald+R7EU/JNSbi9b/fAbWeUSKQc0JVbd0+KobFcRevddzGrOgn1OSuei0gBbWKGhXrZU815hEVvMvfqWvzt0IOFFY0ZvG4Ic0DDALbVPNiIWulEB0krGCKLiw4RjGBv/4flZSZcBx0ZArEjNRmg2+chB4opYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WrcdSkMjWDijLWQyzOnhT2cDB5YCvjXu7jWteEOI2dM=; b=G6o0vzoqXcWmcjZZ7357HgTW/vkJwwoy9oQRm0yPBXCbsFoSrktIxsRfWi9v7AfxdzmiS7J16xkUHcqfBe6UPt1WISWAn2XwpJnu3Avv43C+95QbjB/MK+HqKPy1uMI/yLLGLuKBUcUSjNanqvAZ9DhQq7XuLZf9qXqx3BWpVSxv90xQcnFfZ5erXTkKb8VI4yGtPBGtZ+kvurneolycnlEwO89auyyVXakVYTHivbjE0UeqTkUbTQ93eX6G74fDjwFXR+sugLTCaDJkbCf16kJILhbBi7F0t/xRWmsagF7lebhbz8BMfcrx6Vr/bQLQg5xZQtrWrOrfXuhqh2WsTQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WrcdSkMjWDijLWQyzOnhT2cDB5YCvjXu7jWteEOI2dM=; b=Zh+mclqIguBeixBCq5pwHhffRFeSFkalG8skyriaT7yIARA77WQ0iOdYZgbzef9tqNyWJsWIbPr5+Wxo/p/m5IcYFb+oWNrVavWiYQDWrwP/6qrNUquZdPGW3YNN6heXlxFG2rt1AXUReDWxZuakv9Fl8ggsjIC7OgtSgYljq1g= Received: from AS4PR08MB7712.eurprd08.prod.outlook.com (2603:10a6:20b:513::6) by AS8PR08MB6438.eurprd08.prod.outlook.com (2603:10a6:20b:33e::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.26; Mon, 23 Oct 2023 07:09:01 +0000 Received: from AS4PR08MB7712.eurprd08.prod.outlook.com ([fe80::ccaa:c22:3e53:26fe]) by AS4PR08MB7712.eurprd08.prod.outlook.com ([fe80::ccaa:c22:3e53:26fe%4]) with mapi id 15.20.6907.028; Mon, 23 Oct 2023 07:09:01 +0000 From: Joyce Kong To: David Marchand , "dev@dpdk.org" CC: "thomas@monjalon.net" , "techboard@dpdk.org" , Tyler Retzlaff Subject: RE: [PATCH] bitops: mark new symbols as stable Thread-Topic: [PATCH] bitops: mark new symbols as stable Thread-Index: AQHaAaMdr53BYgysy0qnhM73lBIvvLBWrthQ Date: Mon, 23 Oct 2023 07:09:01 +0000 Message-ID: References: <20231018091123.1594324-1-david.marchand@redhat.com> In-Reply-To: <20231018091123.1594324-1-david.marchand@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS4PR08MB7712:EE_|AS8PR08MB6438:EE_|DU6PEPF0000A7E3:EE_|PAVPR08MB9553:EE_ X-MS-Office365-Filtering-Correlation-Id: 6bbc6f78-c917-408d-4a18-08dbd396f4ee x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: JqPQlawn9uxcX1a/1j7uM4Qdub7AgSRHMs3YvQq4DsYr0Ix/kefI9Zuu8bo9T8HNqjnLLDNgE8lbWTBfLAdbJ1NdqI5Lo81XUs6AWeX1vwFHnrvBUaa7k8yny8RwwXSIPsSXSLXB8h792svLCz+R/9o3wL+yTRnfojEUkVUjutsVfn1SZe+g2ImjzNT1ZHeJsRhM0CfODLcckLUc5ss3UhsWi5SqrRSTEgX5K1hA/IqoDemohpaMgzvyaWbLmvkMoCCChNfKedhBmF1QayML1yw5GI/xcCVTuczSclYrMm32s0MFCvkGHm8rtND4Ia3zLCu7TPrQjyLvYhYiP3Ah6XhD5Zv5kJfWz1JOUuoBCtiMF6ebHCEPI/mcWksiNWvtuF5tm//0cEklBDbHwe/lkVDLd2DK+atApXUwe9VDnF9feTmQJIT0Ygk0H/BTGSFml8xoTt2iTHm/eoGW/WzkkfsnPDC6jzJcFR67vhaHCy1ePPtWCBXiUhdGwwD5vxhNjlST0Xj28IE8OGD82YQpEQkuJjv8rKD7zDvOEtHIdDRfa4ckcerHM7UPhwYmIr33BMtBrfXLJe39Wl3B6vHI2iGB8j1mRAHq505FDoLIKy0= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AS4PR08MB7712.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376002)(366004)(39860400002)(346002)(136003)(396003)(230922051799003)(451199024)(1800799009)(64100799003)(186009)(55016003)(26005)(6506007)(7696005)(71200400001)(9686003)(53546011)(83380400001)(8676002)(52536014)(41300700001)(5660300002)(4326008)(8936002)(2906002)(478600001)(76116006)(66556008)(110136005)(316002)(54906003)(64756008)(66446008)(66476007)(66946007)(122000001)(86362001)(38100700002)(33656002)(38070700009); DIR:OUT; SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6438 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DU6PEPF0000A7E3.eurprd02.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: f6398aa8-d680-42d6-f866-08dbd396eefe X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PeB/b0EQr9RJsgEv1+7rXbLvsyRjWeQO60cRqs6+fAir3taUIWaCles4ztUkSPxvIWEaffS2oGAMYWQNf0OTd3hxOA6Vsggb0HQ+T1UmRqmt99ce2ODhPXQWjmfgj7/yajysCMMyDmfXSk4AOT10cTviQZJwdDPiJQ8PqDJYjTdEqeYO0tMGyP2K+FIqAqRDBijqdSrevIbl9IN6H7MSHWqJt3iC16oCBZDwdkS+l+eYTSU6GkW3QuPZuJgxSfjo2rD/Lh65MufX/eYd0FOOg6nsdt6E9nbVhMWYftEkjUeHdD1A9pXXePTd5MTteNoGCgqEuN8UN9OgeRFYM7fGvQ6lwiiW5Yb3KsneoRbHAVyGaZAb3pxOpJaxlTCDJVK1IoAHQ86SFy7GJdgQzKx+o+m/rKQKIk1V7iyW8pZjS0CjWf4Sd7gjET3fyHL4xra1sRBlEsv/q7K35JqK2stdxhQ1v1B6K4ISr9FNVla8MgCA1XuEbFjzNiAU7d7731XaCVw56wz6ixTfHMtN8SsQoZMVkYyqSSPSlL9xANp3ucR/RZsW6wSD/DasrVPn//A6ZFSzBPH1NDuZXRTn4BwvWHcR/8EMvZQif5EGolXld+UDOJ+YmUaGSJ8fWDAgUcNdiNt1yNVaQcyP6A+0gW6bXXcXMVGAj0viy1RLu8lEheTq23UulNMRaG/XZS+IiZZOY408NFeLaWgdYQvo5gUd4/0oV7r8j7JaS0oiq/44vt/KELycj0yrmVm9HjeGIwbq X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230031)(4636009)(346002)(39860400002)(376002)(396003)(136003)(230922051799003)(64100799003)(1800799009)(186009)(82310400011)(451199024)(46966006)(40470700004)(36840700001)(55016003)(2906002)(36860700001)(70206006)(316002)(70586007)(54906003)(82740400003)(356005)(110136005)(81166007)(107886003)(478600001)(6506007)(7696005)(9686003)(53546011)(40480700001)(47076005)(336012)(83380400001)(41300700001)(40460700003)(52536014)(86362001)(450100002)(5660300002)(33656002)(8936002)(8676002)(4326008)(26005); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Oct 2023 07:09:11.0400 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6bbc6f78-c917-408d-4a18-08dbd396f4ee X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DU6PEPF0000A7E3.eurprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR08MB9553 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: David Marchand > Sent: Wednesday, October 18, 2023 5:11 PM > To: dev@dpdk.org > Cc: thomas@monjalon.net; techboard@dpdk.org; Joyce Kong > ; Tyler Retzlaff > Subject: [PATCH] bitops: mark new symbols as stable > > Calling an experimental symbol from an inline helper triggers a warning w= hen > such code is not compiled with experimental API. > This can be seen when rte_bitops.h gets (indirectly) included in OVS buil= ds. > > On the other hand, rte_clz32, rte_clz64, rte_ctz32, rte_ctz64, rte_popcou= nt32, > rte_popcount64 are inline helpers for abstracting common bit counting > functions. This part of the API is unlikely to change. > > Mark those symbols as stable. > > Fixes: 18898c4d06f9 ("eal: use abstracted bit count functions") > > Signed-off-by: David Marchand Reviewed-by: Joyce Kong > --- > Copying Techboard for info, as this goes against the usual policy of mark= ing > new API as experimental. > > --- > lib/eal/include/rte_bitops.h | 48 ------------------------------------ > 1 file changed, 48 deletions(-) > > diff --git a/lib/eal/include/rte_bitops.h b/lib/eal/include/rte_bitops.h = index > 6b8ae8d3ac..174d25216d 100644 > --- a/lib/eal/include/rte_bitops.h > +++ b/lib/eal/include/rte_bitops.h > @@ -280,9 +280,6 @@ rte_bit_relaxed_test_and_clear64(unsigned int nr, > volatile uint64_t *addr) #ifdef RTE_TOOLCHAIN_MSVC > > /** > - * @warning > - * @b EXPERIMENTAL: this API may change, or be removed, without prior > notice > - * > * Get the count of leading 0-bits in v. > * > * @param v > @@ -290,7 +287,6 @@ rte_bit_relaxed_test_and_clear64(unsigned int nr, > volatile uint64_t *addr) > * @return > * The count of leading zero bits. > */ > -__rte_experimental > static inline unsigned int > rte_clz32(uint32_t v) > { > @@ -302,9 +298,6 @@ rte_clz32(uint32_t v) } > > /** > - * @warning > - * @b EXPERIMENTAL: this API may change, or be removed, without prior > notice > - * > * Get the count of leading 0-bits in v. > * > * @param v > @@ -312,7 +305,6 @@ rte_clz32(uint32_t v) > * @return > * The count of leading zero bits. > */ > -__rte_experimental > static inline unsigned int > rte_clz64(uint64_t v) > { > @@ -324,9 +316,6 @@ rte_clz64(uint64_t v) } > > /** > - * @warning > - * @b EXPERIMENTAL: this API may change, or be removed, without prior > notice > - * > * Get the count of trailing 0-bits in v. > * > * @param v > @@ -334,7 +323,6 @@ rte_clz64(uint64_t v) > * @return > * The count of trailing zero bits. > */ > -__rte_experimental > static inline unsigned int > rte_ctz32(uint32_t v) > { > @@ -346,9 +334,6 @@ rte_ctz32(uint32_t v) } > > /** > - * @warning > - * @b EXPERIMENTAL: this API may change, or be removed, without prior > notice > - * > * Get the count of trailing 0-bits in v. > * > * @param v > @@ -356,7 +341,6 @@ rte_ctz32(uint32_t v) > * @return > * The count of trailing zero bits. > */ > -__rte_experimental > static inline unsigned int > rte_ctz64(uint64_t v) > { > @@ -368,9 +352,6 @@ rte_ctz64(uint64_t v) } > > /** > - * @warning > - * @b EXPERIMENTAL: this API may change, or be removed, without prior > notice > - * > * Get the count of 1-bits in v. > * > * @param v > @@ -378,7 +359,6 @@ rte_ctz64(uint64_t v) > * @return > * The count of 1-bits. > */ > -__rte_experimental > static inline unsigned int > rte_popcount32(uint32_t v) > { > @@ -386,9 +366,6 @@ rte_popcount32(uint32_t v) } > > /** > - * @warning > - * @b EXPERIMENTAL: this API may change, or be removed, without prior > notice > - * > * Get the count of 1-bits in v. > * > * @param v > @@ -396,7 +373,6 @@ rte_popcount32(uint32_t v) > * @return > * The count of 1-bits. > */ > -__rte_experimental > static inline unsigned int > rte_popcount64(uint64_t v) > { > @@ -406,9 +382,6 @@ rte_popcount64(uint64_t v) #else > > /** > - * @warning > - * @b EXPERIMENTAL: this API may change, or be removed, without prior > notice > - * > * Get the count of leading 0-bits in v. > * > * @param v > @@ -416,7 +389,6 @@ rte_popcount64(uint64_t v) > * @return > * The count of leading zero bits. > */ > -__rte_experimental > static inline unsigned int > rte_clz32(uint32_t v) > { > @@ -424,9 +396,6 @@ rte_clz32(uint32_t v) } > > /** > - * @warning > - * @b EXPERIMENTAL: this API may change, or be removed, without prior > notice > - * > * Get the count of leading 0-bits in v. > * > * @param v > @@ -434,7 +403,6 @@ rte_clz32(uint32_t v) > * @return > * The count of leading zero bits. > */ > -__rte_experimental > static inline unsigned int > rte_clz64(uint64_t v) > { > @@ -442,9 +410,6 @@ rte_clz64(uint64_t v) } > > /** > - * @warning > - * @b EXPERIMENTAL: this API may change, or be removed, without prior > notice > - * > * Get the count of trailing 0-bits in v. > * > * @param v > @@ -452,7 +417,6 @@ rte_clz64(uint64_t v) > * @return > * The count of trailing zero bits. > */ > -__rte_experimental > static inline unsigned int > rte_ctz32(uint32_t v) > { > @@ -460,9 +424,6 @@ rte_ctz32(uint32_t v) } > > /** > - * @warning > - * @b EXPERIMENTAL: this API may change, or be removed, without prior > notice > - * > * Get the count of trailing 0-bits in v. > * > * @param v > @@ -470,7 +431,6 @@ rte_ctz32(uint32_t v) > * @return > * The count of trailing zero bits. > */ > -__rte_experimental > static inline unsigned int > rte_ctz64(uint64_t v) > { > @@ -478,9 +438,6 @@ rte_ctz64(uint64_t v) } > > /** > - * @warning > - * @b EXPERIMENTAL: this API may change, or be removed, without prior > notice > - * > * Get the count of 1-bits in v. > * > * @param v > @@ -488,7 +445,6 @@ rte_ctz64(uint64_t v) > * @return > * The count of 1-bits. > */ > -__rte_experimental > static inline unsigned int > rte_popcount32(uint32_t v) > { > @@ -496,9 +452,6 @@ rte_popcount32(uint32_t v) } > > /** > - * @warning > - * @b EXPERIMENTAL: this API may change, or be removed, without prior > notice > - * > * Get the count of 1-bits in v. > * > * @param v > @@ -506,7 +459,6 @@ rte_popcount32(uint32_t v) > * @return > * The count of 1-bits. > */ > -__rte_experimental > static inline unsigned int > rte_popcount64(uint64_t v) > { > -- > 2.41.0 IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.