From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 76744A034F; Wed, 10 Nov 2021 06:17:47 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 442D04014D; Wed, 10 Nov 2021 06:17:47 +0100 (CET) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60080.outbound.protection.outlook.com [40.107.6.80]) by mails.dpdk.org (Postfix) with ESMTP id 48A0940142 for ; Wed, 10 Nov 2021 06:17:45 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Pf7SE6YRW/llK5Gz40oIx6Wam/zTy643EgQGPndEcn2n0zeeb0+8TXsdbAxo92rNUsN2e0DGINIarEMjyUQs6a5uYdvkKZXVSRxVMVi4MvogJOD8CahsoZa5bE3q99GoXJv9kkWAl/VmMLo0KLV2UTaTMCUGRQ1CsjOrXT10mGWUPEWvFUGQRcRgcGJ0y97fIOAQ67t6YlD0vLrOey/0joVCS4avgjJXiROU9sCA+GIVOPD5HbLDSRbRxVvduwJoVnpUCG5WsthDNtKxEDZU/+BjNfUcHmTfmaCBar2W24Tlg2iSf/CaI4Ad2lgfoIuxB5Tg8fYPWK2b9AV++Ko/dw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XHq+aWmNB7zl/RWXkRgVATZIG5GF1zPQcdcfIsxAtaA=; b=PYHtC2LBPfFy+UZSd0HvknpWkvbk+SCpDv7C6/1YLM5U936VU8yBMxxrjmcUpO8liCioY3isAtuh5vGqjzN2CNDx4qgIIGU4Q6vvTsVMkCjvao9scg0q7QK7P6Mj/aCqJBf7T7aj6MGximSSoMYnMw7R6zMX9Cb+AUw0yHNuUAtOv8B/6oIHUQIK0Ipme+flSt710p8tN7//z183fYFbPkS1siKbVOp47m4zqMo/1sm8ibdJWDJ3m1fy+oBNVJT2A6utEDJBHNQ4W5/792+pwyCmDUVmEuN856OTGKmNb2fjiBZ/i7cKDwYwS0cpYf3knmd/bphqsi4Pq6w/uxBwrw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XHq+aWmNB7zl/RWXkRgVATZIG5GF1zPQcdcfIsxAtaA=; b=HMvEh/Gs9cTXwDYgbxEs4XUs2xen40fuVZ+gU75x2PtVhwIVsGnY0qFcU65j94gljpTDyyPPsBThti89zgDeIUphA9SkpWVrRs317gLo3FiDzQ2q7LyXeKsOfbKBMP0iOqu5wD7n5Iq+Wy6JKY7aoUbpf0Yi9/MZ65QKOOyTETI= Received: from AS8PR04MB8198.eurprd04.prod.outlook.com (2603:10a6:20b:3b0::14) by AM6PR04MB5128.eurprd04.prod.outlook.com (2603:10a6:20b:5::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.11; Wed, 10 Nov 2021 05:17:43 +0000 Received: from AS8PR04MB8198.eurprd04.prod.outlook.com ([fe80::9895:b941:f782:6999]) by AS8PR04MB8198.eurprd04.prod.outlook.com ([fe80::9895:b941:f782:6999%9]) with mapi id 15.20.4649.017; Wed, 10 Nov 2021 05:17:43 +0000 From: Gagandeep Singh To: Thomas Monjalon CC: "dev@dpdk.org" , Nipun Gupta , "david.marchand@redhat.com" , "ferruh.yigit@intel.com" , "gakhil@marvell.com" , Hemant Agrawal Thread-Topic: [dpdk-dev] [PATCH v4 1/5] dma/dpaa: introduce DPAA DMA driver Thread-Index: AQHX1SPPN7ZBF4zxt0i1kgwhEJC6X6v7RnEAgADu+CA= Date: Wed, 10 Nov 2021 05:17:43 +0000 Message-ID: References: <20211108090704.3585175-2-g.singh@nxp.com> <20211109043910.4016824-1-g.singh@nxp.com> <20211109043910.4016824-2-g.singh@nxp.com> <2155251.kCPDGmGbOk@thomas> In-Reply-To: <2155251.kCPDGmGbOk@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a7444e36-5ed6-4e2a-a300-08d9a4096cbd x-ms-traffictypediagnostic: AM6PR04MB5128: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: mgfy9ZF6nPBzHncEO9Rnzo4wGA2PdpJ1Y480m5vhL9sHKOQqYHbonMFOf5fXCDLOZAYyIGQSudGLDUHJwvFXwhhYfA6vUu8dxmfnR7EUCPVWzWPCGLpTIomPpKAIDg48qnyaHlPmGyEZwPj/dcAb1w626qa0d9vE2HaIP7DGPJJ5/fmDSR4n1+1HWJQa9dStkYo0Mg/aZ/aPpNNegLmvT3NXRpELsM52nEVXWVjkE5gPv39iBthqh2zJ2WYt6zdqXSRpkLaEeINSRBTJKBhw1EdrDUien+eVpOZkGsMrAwCPSUbtFp8ETX5u7x1iBesT0G53JRs/QHh6AiawG/3hjAgK3CC6w5PJa9iavMzuTapxWBZ+TwpOdtBk165WDjn3pYZ38pl/RGEiZiwudVpRUi+eMZxcD8mYxY0LlAQjiKJNc1+J0ApCc4S+65w1zMBslIs+l0EnXcSKDGGetFRAf0XlgoJR5GUKlGtU1ac9430UvvQpPaKHv2/tvWs0W5RNu0ZH2Zk0R+eds27PCz0lwFHd8SsVDQtfFunJtfJEMmRVOQSE3Vf2xrBxoHL7+jz3FFdFXW0yhaJFFVfOYTOkRBXLZmxnjPZCofgo/743VQXq0M6NVFIYyzcHZKF+5//lkLZsBfoLzFz+5biFOg4L91dwCB2Yxo7URG0gKcrHEc730eBBW3Ippzs+K99dnIxlZxC8EqXcACkgmVr8KLyhnw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AS8PR04MB8198.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(86362001)(8676002)(38070700005)(83380400001)(52536014)(38100700002)(2906002)(5660300002)(55016002)(122000001)(508600001)(4326008)(7696005)(71200400001)(186003)(8936002)(64756008)(6916009)(6506007)(316002)(53546011)(9686003)(66476007)(54906003)(66446008)(66556008)(26005)(66946007)(76116006)(33656002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?X6K0ROoj4E3aow+17YKWE8UU+W4ovqbHgzOcpc32+tCBQ+ZAkFqcD7DJRCMz?= =?us-ascii?Q?8Hd3/UAku+9e0q3uMae3yVgauFdYUCgpmJk0JEAqsrrNkcXaA+io9p/ndtjL?= =?us-ascii?Q?ZITJm0BmjBdLF3ACi75ZJURGUtC8W1SWrzhbrkrsbFyAayaTiGr9EoFN98Ub?= =?us-ascii?Q?4Uw/IKBOG1UOusyXwN+xhVRIYkUk2hRXjsxfLqpNWuOR3FUTYX9Va7c/W3K1?= =?us-ascii?Q?jq1M+D5FG4mk6fk/6MzQhm+hgNCLQ0ytskPu2nnP68fLHHYX098yU+OlC3O/?= =?us-ascii?Q?guAXdoDr/hxQb9UYuScjAtZqUMCACoGE4ypsEUztVqll55HIV4QLj0c0MM2A?= =?us-ascii?Q?+g1xDQuj7DDBaF2VAneUY/csbVmvGKzf1dY34BT5H9kIVHmvnHIWqcG/Ivrv?= =?us-ascii?Q?wV4xKlanotwXvbCLobvFH+6hbsdmMWXiTgh0HjAwKlNyhALN4V/6tE01aiKL?= =?us-ascii?Q?+6XeqfkC5QaicRIJvxmNPbqK2hoN2LyOWmdB93DaefiSgmgRCzFGTXMvjKiL?= =?us-ascii?Q?YqtXvbdJ9kxzvSPE4r/Ze3Jh9WdJFdo0PPMWJxL1dLMRE2Hrr1YMOVy0+AQP?= =?us-ascii?Q?3x3uR3Z1nsjDd7NRyrx7MsjreX/7wRBYq3if/1+VvaIAPx2LBXdqfm0T+tf3?= =?us-ascii?Q?nmjJXfniHGxMVnOFN6hHjjpPehEKLvvaydPjl4AWLdozAJdYVFeNA0SshiWe?= =?us-ascii?Q?+MTHGyUKFM1og//6Q3UBifcp0oDy1kVj54iEXvueHI/ysuM0ilPa8y3WNVrV?= =?us-ascii?Q?mvsGt7+Hv1b6Ca7SxWuJt7ZcWLAq3k9ggDUGGRHMAmZCPT0B4JR2oLxzEt2Z?= =?us-ascii?Q?hfNMzeIAkN9Ln0c4VQHF5GNnKYfsZ16nRud3si+VDoi/kqt/F7hO55JOtJgs?= =?us-ascii?Q?kkrPehWnAodfF1kSDiGUEZF8VsOFH0RZb99VPXu1hrK7ZLoGzAStXZw1OnsF?= =?us-ascii?Q?9Bz/UutS/ioobLReKFgNF85xnSw4l8Z4YFGwcTqpZx4EI33o5omxsinls5gp?= =?us-ascii?Q?jMsYL+9KQQI922paV2BB0l5wiVit/WV/c2RT4g48awm7yZevKM4ogXs9KIzA?= =?us-ascii?Q?cE9EqpR2eXaGf/qHcB8PxTXfOzwevX3BY58OFi7nRaJditZuiQzBrayxtuyy?= =?us-ascii?Q?6d7Tfqi4MlvI1QZBPa0WXi/2UzUmM3K6DUbcY8AN+yiCQoqXSxSwELfCaSNC?= =?us-ascii?Q?nXms3d3XZob9cXVImLIsFsa9k/c4qSHtt60Ni03XaWIET627iV+2xp1UMn8x?= =?us-ascii?Q?ba1uXuMOLyC9i063uUc4h1Aq1eKFLfAO3taL8z6sVi/ihH3IKuBsAENW+dIE?= =?us-ascii?Q?JwTuQ0RFOIcoisv5WLTwcJCBbk8AwQHuXhdPinxg3+uVkTUnUXHS7tDrvYkM?= =?us-ascii?Q?m+O0O3bVT6eZ9aB8cGTo7fjuzHLvUZYHWpMBKDsumd5g7LVdktTj74OfLZtq?= =?us-ascii?Q?+o8v/297AIY8cfmq58JZCRY7b9FPzWwKhXgJhvZJM6BMlnxtXI9qPo6mWsze?= =?us-ascii?Q?1sFlM6ToAduBBEzcrrusG3tT+LwPJ7UiM+mpjoFBVRIvqLDnYxUWuEXmcw?= =?us-ascii?Q?=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8198.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a7444e36-5ed6-4e2a-a300-08d9a4096cbd X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Nov 2021 05:17:43.3832 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: aH1JaKC+AGP5nL+EspZpgyqx0S9CLhzZqw+Y8mSqKAtG5C90knpMtFz4rZ1rPbQP X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB5128 Subject: Re: [dpdk-dev] [PATCH v4 1/5] dma/dpaa: introduce DPAA DMA driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Thomas Monjalon > Sent: Tuesday, November 9, 2021 8:15 PM > To: Gagandeep Singh > Cc: dev@dpdk.org; Nipun Gupta ; > david.marchand@redhat.com; ferruh.yigit@intel.com; gakhil@marvell.com; > Hemant Agrawal > Subject: Re: [dpdk-dev] [PATCH v4 1/5] dma/dpaa: introduce DPAA DMA drive= r >=20 > 09/11/2021 05:39, Gagandeep Singh: > > The DPAA DMA driver is an implementation of the dmadev APIs, > > that provide means to initiate a DMA transaction from CPU. > > The initiated DMA is performed without CPU being involved > > in the actual DMA transaction. This is achieved via using > > the QDMA controller of DPAA SoC. > > > > Signed-off-by: Gagandeep Singh > > --- > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -1377,6 +1377,17 @@ F: drivers/raw/dpaa2_qdma/ > > F: doc/guides/rawdevs/dpaa2_qdma.rst > > > > > > + > > +Dmadev Drivers > > +-------------- > > + > > +NXP DPAA DMA > > +M: Gagandeep Singh > > +M: Nipun Gupta > > +F: drivers/dma/dpaa/ > > +F: doc/guides/dmadevs/dpaa.rst > > + > > + >=20 > There is already a section for DMA drivers. >=20 > > Packet processing > > ----------------- > > > [...] > > --- /dev/null > > +++ b/doc/guides/dmadevs/dpaa.rst > > @@ -0,0 +1,54 @@ > > +.. SPDX-License-Identifier: BSD-3-Clause > > + Copyright 2021 NXP > > + > > +NXP DPAA DMA Driver > > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >=20 > There are other occurences in this patch of a lack of attention. > Doing underlining of correct length is a minimum when starting a doc. >=20 > > --- a/doc/guides/rel_notes/release_21_11.rst > > +++ b/doc/guides/rel_notes/release_21_11.rst > > @@ -20,6 +20,9 @@ DPDK Release 21.11 > > ninja -C build doc > > xdg-open build/doc/guides/html/rel_notes/release_21_11.html > > > > +* **Added NXP DPAA DMA driver.** > > + > > + * Added a new dmadev driver for NXP DPAA platform. > > > > New Features > > ------------ >=20 > The new features should be inside this section and well sorted. >=20 > There are a lot of other details that I won't report. > All of this look to be on purpose, or a big negligence. > In any case, it looks to me as sending some junk work to my face. >=20 > I am too kind, so I will fix all, and will merge after the deadline passe= d. > But please remember that I don't forget such attitude, > and I think other maintainers won't forget as well. >=20 I accept my mistakes. This happens while rebasing the patches in very last moment. There was no such intention to send junk work to the maintainer. I sent the= first Version of the series when the DMA APIs were still in review and at that ti= me There was no section " Dmadev Drivers" in the maintainers so I added it and also release notes were at the right place. But while rebasing at the very last moment, I forgot to pay attention to details. Thank you for being so kind. I will take care of all these details next tim= e.