From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3AA9FA0352; Tue, 8 Feb 2022 15:15:37 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B7A13410FD; Tue, 8 Feb 2022 15:15:36 +0100 (CET) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150085.outbound.protection.outlook.com [40.107.15.85]) by mails.dpdk.org (Postfix) with ESMTP id B9E23410FC for ; Tue, 8 Feb 2022 15:15:34 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZQsu1WlQ50qdrXngy0Z0b0dv4rbVR9gT59H0JTEsS8isOgGjriXGSYdi7X/iTC9uEWw1ElJwbpp5pdIU8nji/yMy1ydpD7vMqnzTEvLUr2Xu/qSGpMsy53G83G5IxZNSix/ggAAHflA68DCizJNgTQTn/gq2ceyt/42XNBrzAAIb/L3Fl9br0mbpQfwNxVm6G0QbvgwniHv9o3sm3p3Y6AzovtLzTYK0Pk0qFPJ9HcjgVmc4hEMZhxb/6gXfoHn2C1fK6o6FLULLlKxWsKZ9x3s0FDjXT8fvjatBB/9IEK9npjZH+ZjEe1lu9TVxTxlzH9qmlYg+pyuXoYWIESbVpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SEYuQ/jSrYaGAshB8y6wEHBq8XFRQdo+brUsSoHBMnA=; b=HTWPW4X24WgAWowrGzHoeeyChM6jjXq7OUMROCIyB9LQKZpdbIh+7RngtQaPCJI8GoYHE5O1CTD2DvbKysYAFvDfM2UhcWV3diTYJGzzTw5IfopMzL2xZIKIIYFn4ttMLS0D0V7zDCl9xE0RPjloT8bkup/uzgYwKqZ0SCQr6ttuBG+wOfk4cLeWu4zheA48e2QnRFt2IX24CbOAYOcCZyAf58P5G7P3kr0kvwW91iQalaExYGH6hEeTdm1bePXD4aO7/MxX1+69U/PHsbh4UPDqa+Hg5mDRPTIQge9k6ohTkW4EOEM2cp898XUnG6VhJOwfi3zQm2udWrxTbryIPw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SEYuQ/jSrYaGAshB8y6wEHBq8XFRQdo+brUsSoHBMnA=; b=lJNgnMfBJ/1J8PCEnKuXVfAfBEQ8dHaP+Fytn6dr82iVliKcljCk9h1oD36vMc0sQxaMCgcs5HrOizO4FeNNBy5kobZfeq/L/IGi1Pn+WNEP9bH5ljnfrskajqucuZDZzwZmrntHlS7Kh7HxGccMKr7pXb8xJ35NcLzPp901tbI= Received: from AS8PR04MB8198.eurprd04.prod.outlook.com (2603:10a6:20b:3b0::14) by DB3PR0402MB3897.eurprd04.prod.outlook.com (2603:10a6:8:12::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.18; Tue, 8 Feb 2022 14:15:32 +0000 Received: from AS8PR04MB8198.eurprd04.prod.outlook.com ([fe80::4146:965b:5645:9269]) by AS8PR04MB8198.eurprd04.prod.outlook.com ([fe80::4146:965b:5645:9269%4]) with mapi id 15.20.4951.018; Tue, 8 Feb 2022 14:15:32 +0000 From: Gagandeep Singh To: Akhil Goyal , "dev@dpdk.org" CC: Akhil Goyal Subject: RE: [EXT] [PATCH v2 4/8] crypto/dpaa2_sec: support AES-GMAC Thread-Topic: [EXT] [PATCH v2 4/8] crypto/dpaa2_sec: support AES-GMAC Thread-Index: AQHX+8rn+TOPd7vybEOvWp3vJM0wnKxtfJeAgBx3YkA= Date: Tue, 8 Feb 2022 14:15:32 +0000 Message-ID: References: <20211220102710.3083370-1-g.singh@nxp.com> <20211228091058.3620177-1-g.singh@nxp.com> <20211228091058.3620177-5-g.singh@nxp.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 535769d1-3a85-480c-149d-08d9eb0d77c5 x-ms-traffictypediagnostic: DB3PR0402MB3897:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Ivqfw1V18okmz9rAWeX50rCom0MskwX4dxTcD07kW2EN8hfKkLWI71KI0DHcTbopT9gqnnAlEhp7XiVgckHvVZwA0bXQ0Jy2ir8z78Xs7X2MMQlJAF1ObUjjnI1YAaizd+HzO7wmfzS/y5GxYMgQ2f9UVx1HVEoTTowgZFaNZQ9qBWa3d6HILs01X9dQPChS0BSm0W9KxZYuDkkNVV1tkH3E8XXVezTatTH1elX1qDFobU8j2GG3kPnZ4wNfCC6DksCJKmaY/5dIUHidF3rOVLvq8h7xtjr1t5GyDyVaAACqaA17c/bgoTQexPCzA4g92OPAjzvY8YPWhM5lsJga3b+1Sp6a5Fk8wC+sFbvxmjjkIUFzJQ2smMTHC+CY9nK1ThMcqS++KIDtTCdZByZescaPPZOaw1l4GLwPPQtRSw34h2suLlZqoWMww5OLYjtHdMCDzuMWf/8EO9Icn5YpOy/ofOgWHZN0bY4kOo11p4OPY7IOH4gXr8fdTbuVEVxBognj10Pp9L20c8AKqdXuCM9RJdhGPiY9nLMQuzOsoMDOL4UM2SihEIMFaxK5dZhejiRBDjcIGFYrbOuYa/dhd2KLFLkV0lPJxDP6NDyXCIsz/oRp0aYy/caPtxOs8353gb1bTKXFwUrZqpchx2TqoeS/WMygGfM7uukID3DVUrYpE0wQYjEW3ACJBWvhKM+h9pWzbQROQ8f7iz6De7BsGw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AS8PR04MB8198.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(26005)(53546011)(186003)(38100700002)(71200400001)(55016003)(66556008)(55236004)(66476007)(7696005)(83380400001)(66446008)(6506007)(64756008)(8936002)(76116006)(4326008)(8676002)(122000001)(66946007)(52536014)(508600001)(86362001)(33656002)(316002)(2906002)(110136005)(5660300002)(9686003)(38070700005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?UOHGzjj66nDet3SJGzG8/zhyVkXTNosXeTbmPdOiqqjvGsO6yomyh3JrIgS1?= =?us-ascii?Q?o8Hst90eG+zT74O8tmW9Yb5tSN9y0jS14+qLbsiS0IRBS02P6t1voS3mWdcD?= =?us-ascii?Q?h8+TOTKogE5fc3i0QJBDZtL3HusXFfMwHkwn+fVNsJJWdsrHiKKMHIM4depd?= =?us-ascii?Q?7uF6i+Mlp2WMXef2nelmgqcObyEiRg4DCsXiBpWxRra0rdnQ4fRxrIDhncLg?= =?us-ascii?Q?UnokOwTGepKGf1dzF0xJJ1Aql7KbaQv8m6I27ZaRGhrM6vKzeBuWAA+FamPs?= =?us-ascii?Q?AUV+SV7ZWi8mDxXYlWbDKYGnb8jKFnme/GWyROhItKTNUotGHuY55d23tAkN?= =?us-ascii?Q?zre7PGC6eq4nG5ttIRpLaGWaVnon7ZENXuE3odOzJKPZxJWYwQZO8OvOLpo8?= =?us-ascii?Q?xUSvFzgNgeH0ppKiEPsrdiy5+XJPU0EByf7O5te+YWT2AydQCrtZ2oU/pIdM?= =?us-ascii?Q?hri0d0T4a3sq7TQ5f5KFXVV6FcqaaFBx9Z/LTzy93IRiVxm9RJBJj3X2iS3B?= =?us-ascii?Q?U1/kDX9FQMEiRnYKNzYvRLSyLKzN7V3IU6B26WrlK+LqlcG9WBom1tFGAQLX?= =?us-ascii?Q?8ExjGBQvMQV735mXZKlbJ29HeiSwRkSjt/XSTIL6m26a0gBo+kdgeViw29Qn?= =?us-ascii?Q?qvuz5gAAHM6mN/bOX4Zhxtoj+WzCkwIc36GR2vq9ORaHNUJSYUZLcu/z7wAj?= =?us-ascii?Q?JF7Uqv+2XK43wBJAJc9tA4dcwnL8i+dDzRh2TwVR/ay/jJlJxe6bbaWcurAb?= =?us-ascii?Q?xS6+Ip6K/wsGbrSrk0I5dLckHc8RYSu1BVwzsF6HJrZom03crKa5Pv2xLbWs?= =?us-ascii?Q?31ayoh1fS4pkbNuU4+nwM3ZcQrgdPx1VydbiAONRCLXLcgaK3vbCFscO7yWg?= =?us-ascii?Q?eD6lq9bkEEtLo7sncxCMkj8P5ZwBfJyU0aAKIOqcP3J85RqwgW4i9rshGoqq?= =?us-ascii?Q?5f6gaUGNHsbFZUBOqPzLW9Hzz0BaliMHnDZaPxApQjcywQ48w61xUX0yJz1U?= =?us-ascii?Q?y+v1T2JKzuJEEwr4y7gVoLhrCrTSjaB17pdYNKZjGLdBbgbVtWg9HbSXIBPO?= =?us-ascii?Q?xysQYmzHiOiIVbbYH8LSjrKdwx0eDrMnDq7fzDdsOoJZQUQCmCmdyahWveKg?= =?us-ascii?Q?99Mj2wi2PGYaQmU0AS3OGSsEw0qpGKbQTewRBqANWWBjUA6Q9j+bGGOSckYr?= =?us-ascii?Q?4bNOilRq8Kq3T5HkbDXC45WD6xO9DZxHAWL8OWuIepdBFieVqnyoibOKCgzk?= =?us-ascii?Q?MMRX+gWx2RN9QK603GYFsSZRkdFXC4xEguMF0EX0WViN691ISPi5OublAVqZ?= =?us-ascii?Q?ZmzRX+YqTEYxGoujqFzcr1zZLbDyXG8I25sr38hjM0/cfbvyzL+0aQoWgJUY?= =?us-ascii?Q?FXb+Qh2cG2Cr86ggjDurVrK0P3CbeR6Uh7edqssEPPMO06pjZeN3oS24OfXo?= =?us-ascii?Q?xsRKJ9A9enJRZo56me0lgfgxRXuMHaeiq131/rqYNXtSCBWzjhhMEIXJ3KA5?= =?us-ascii?Q?twys73zBCwJRktEnq8a+eXuA1JlacNWI90vUpOdBZU764ciIFsssbMB+ajRq?= =?us-ascii?Q?HVhsBAdG8eHYN+PJtAY=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8198.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 535769d1-3a85-480c-149d-08d9eb0d77c5 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Feb 2022 14:15:32.5830 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: d0oSc/2Um8Thl+G12nBcVl8FHd/Y1XhkE3Z6E6gN5PCvBK5P8Y8Px2VCLSkC1Wvj X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0402MB3897 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Akhil Goyal > Sent: Friday, January 21, 2022 4:59 PM > To: Gagandeep Singh ; dev@dpdk.org > Cc: Akhil Goyal > Subject: RE: [EXT] [PATCH v2 4/8] crypto/dpaa2_sec: support AES-GMAC >=20 > > From: Akhil Goyal > > > > This patch supports AES_GMAC algorithm for DPAA2 > > driver. > > > > Signed-off-by: Akhil Goyal > > Signed-off-by: Gagandeep Singh > > --- > > doc/guides/cryptodevs/features/dpaa2_sec.ini | 1 + > > drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 14 ++++++++- > > drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h | 30 ++++++++++++++++++++ > > lib/cryptodev/rte_crypto_sym.h | 4 ++- > > 4 files changed, 47 insertions(+), 2 deletions(-) >=20 > This patch should be split in two - cryptodev change should be separate p= atch. >=20 > > diff --git a/lib/cryptodev/rte_crypto_sym.h b/lib/cryptodev/rte_crypto_= sym.h > > index daa090b978..4644fa3e25 100644 > > --- a/lib/cryptodev/rte_crypto_sym.h > > +++ b/lib/cryptodev/rte_crypto_sym.h > > @@ -467,8 +467,10 @@ enum rte_crypto_aead_algorithm { > > /**< AES algorithm in CCM mode. */ > > RTE_CRYPTO_AEAD_AES_GCM, > > /**< AES algorithm in GCM mode. */ > > - RTE_CRYPTO_AEAD_CHACHA20_POLY1305 > > + RTE_CRYPTO_AEAD_CHACHA20_POLY1305, > > /**< Chacha20 cipher with poly1305 authenticator */ > > + RTE_CRYPTO_AEAD_AES_GMAC > > + /**< AES algorithm in GMAC mode. */ > > }; > AES-GMAC is also defined as AUTH algo. It may be removed but that would b= e > ABI break. > Is it not possible to use AES-GMAC as auth algo? There are some issues in this patch. I will send it later.