From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3FDC8A00C2; Wed, 28 Sep 2022 08:25:57 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D66864113C; Wed, 28 Sep 2022 08:25:56 +0200 (CEST) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130044.outbound.protection.outlook.com [40.107.13.44]) by mails.dpdk.org (Postfix) with ESMTP id DF42341133 for ; Wed, 28 Sep 2022 08:25:54 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=obcG2z8GqWiTqlcN8HS1ipeo+sCkZT5yj2YKa5X6KGPv2tjM8L08vl7ujsHE0rSD0yIJ7wMMNR0JVT884u7u+LfSz0Zk9Qsv8cEFZHkN4azGAv+eMc0E//5QTfT/9i7vYPHW7p02MWeK2Uw1D+pX99jPAngUoVw1zLP01d/HPfFJDtp1dNFYk4aJ062hL/MjpgJUbiHOEmyFNWF5J36MESiUO9QH3CrxMKGYFBgUBtfQrHap99ovaR7owPz+OEuxVzgJwgBmwqrq6Jt/ELjtsPJDVlLhz0vHiK8jWE2e2vveZcPQx7C+J455iTRTDLd+qMsoMYJGhOwcVNuwsmIZWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=36+31vL992hP7OzuAr4NRXkLIbQphHjdHF5gYHmowzQ=; b=LLEJEu4mmvaCmLlEpoTv3HUkpcN4hVHXZoTR8wZk3lzWa85iQDrYOyoc8E2Uh5Xre0Ay4t4zWDszaj+OVb3MD5kliCm5GXdzkZpu+F56zGlmcb+mTPrl/KFlm8ZLm3sPVjvB8jOIhQRiwDJGjfihhG0T/a+tsOelRsrhPNfvCWLRHrvz7gwaFmqdWzbZifPKLig8awNRNRE2t/NyZOwLSvQbsXkMMUOSp9BXGcNcdcQkE4MJjBRUTYz97kNHDwGMrLM6tldUTTFPv8pPDh1gvXX8+EcnrPYempUGhFIfEFdeLTUiRGziQtEsK5xNcSGocEu8vnlcO66c8rQdHywcmQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=36+31vL992hP7OzuAr4NRXkLIbQphHjdHF5gYHmowzQ=; b=bmi89nh763LsNl01yB0iUpxX86vrCI5ID80G9U++CCUUeje1UoTzAPw6tLvjqSpJDvhsPDvKgzBat5FTJAnWBGij9evpA6ZO50jWawfjXxkQ+TTTZg67yPC8T3fqmw4uEEEUU5Ychay7+C1hHjGCNuj2jCNKYrq11hGtUDk7/7A= Received: from AS8PR04MB8198.eurprd04.prod.outlook.com (2603:10a6:20b:3b0::14) by DB9PR04MB8348.eurprd04.prod.outlook.com (2603:10a6:10:25c::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.26; Wed, 28 Sep 2022 06:25:52 +0000 Received: from AS8PR04MB8198.eurprd04.prod.outlook.com ([fe80::14d0:4458:d6ec:b8b1]) by AS8PR04MB8198.eurprd04.prod.outlook.com ([fe80::14d0:4458:d6ec:b8b1%7]) with mapi id 15.20.5676.017; Wed, 28 Sep 2022 06:25:52 +0000 From: Gagandeep Singh To: "thomas@monjalon.net" , "dev@dpdk.org" , Hemant Agrawal Subject: RE: [PATCH] raw/dpaa2_cmdif: remove driver Thread-Topic: [PATCH] raw/dpaa2_cmdif: remove driver Thread-Index: AQHY0YO13zQb746/YUi+TvzNCn62L630Yp9w Date: Wed, 28 Sep 2022 06:25:52 +0000 Message-ID: References: <20220926084045.2290498-1-g.singh@nxp.com> In-Reply-To: <20220926084045.2290498-1-g.singh@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: AS8PR04MB8198:EE_|DB9PR04MB8348:EE_ x-ms-office365-filtering-correlation-id: 8613f116-fd9c-4019-a8a9-08daa11a4af5 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: N13RGsL4sSNiZ2aWLJDXzmFo81b4AuaCmYnRuBo911wJmN2ocWhL6w6EUevyTae3JsISNL4DZ/6WZScFwrkAW4j+QrI2DRAFIiHQcpFSrQQpU8Pnzw6jWOyjqlDX2FS0eEVmmFayS86VpF78CbTVjR2aYo03giFY3PBg60YMRedOcocuQ4mnldxthqYbbP1cXBgXlDtn3RCHjm0GDXaIz0L4Qf5Y2YDWxim6A60EFNW97woRLqiMGKhcAPdd2fFHzaGywaB/kQ+TpWykshsHcmaSUtqWvit/24C7Jq8ZLlLr1wxSq3flRI1SdJ/ibd3dYEoM2vuJM0R+V1V75y0JdGa8bkm6C45kxHmoD/vvdG70tXUj/MpTOGWzMuzswZqNkP8s58AYtp4ggX3g9djJ/g4oOCedRQYkELzKFpCeGedpTzGi0SgGpcrLqzVg/La06iGFtb1SLhoPZjfRJp4ZFTKPRTpw0f1zRrnLI8sJcd65ZJdSjTHbg0XIXqdE+cg0bR4FEMUmlIskDUQ7rtem6r4VyhitvVMePk+Y7E300HLFHxwxqcAjbJH/BDpQlKsXiRT4x0Tcm0BVKngsjX7iN6dUa3iceOSHHrRYMJtMtE7oG7+ZZ87QL7m/yNT56mJQD6N04IqMotgyHLsL8NS1Y4+oQ6Xzv9jYpZzUKYeyfcvOdAQ/j6OjyKHKk0dsbHaZmlrGcxghkdsKVdEHUMRgExYd9gIXYHRMKW5DCuM0UpxsBf/Mn53teucFOpjy7Ia/CcIvriOaJobqeA3fHM7whZLwBj/qx0cWI1evoq+7q1s= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AS8PR04MB8198.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(396003)(39860400002)(366004)(346002)(376002)(136003)(451199015)(86362001)(66446008)(66476007)(66556008)(76116006)(8936002)(52536014)(8676002)(5660300002)(33656002)(41300700001)(2906002)(66946007)(110136005)(64756008)(316002)(6636002)(55016003)(122000001)(38100700002)(186003)(30864003)(83380400001)(38070700005)(71200400001)(7696005)(9686003)(26005)(53546011)(6506007)(478600001)(579004); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Vg8D37nmfliZI16vl4N2gbROKUg0RS/jGurd+dB91KnroR9qIkByn1H4mXNV?= =?us-ascii?Q?4ANwq1fKUkfIOQB4dwdPi1wy1hzFGTf8T2GwvwjDwwKgAIIlUGKH7o0M3xqN?= =?us-ascii?Q?hPrAstBes09MCHbM5xurD+NqxrtB+9xSxi+trwnyZmNNYHYbwKqrIa0mpzks?= =?us-ascii?Q?GClNrkck6KCKEd7Gbwdw+HeC4VAjHmAw2sudwIF5B0eobz+RGzjSJJ1+4xNv?= =?us-ascii?Q?lUzK+G6Hc43GH3WAwt3wwcepwPZWxkFlBy86vox09aQndDAtDnS80Du6XqJm?= =?us-ascii?Q?GlhrUAf7dg/RGVqruhrojryx5EROcUcM6+JBIPRGgpTHPruOol29hLsJ7jZQ?= =?us-ascii?Q?coHKxct85rxWChsfpZs3QM03boAhSXcUQTni5dI35p5WRVSYeGxc1ASJ/RtL?= =?us-ascii?Q?i5ZoM4C+4Dvp2rHhZT7oD2zDfnwssVuOkz1VtAdgnufICbHz4N5WuEMG/KvN?= =?us-ascii?Q?cGPmF/F/uO+jMvX/puCH+CF9LjCDKma3xDCxkpUG48Jx+x3B9FDF05gSpGFX?= =?us-ascii?Q?oLcBqmPkB4tV4hRaQeOHp8Sn4fzZgrg1yR8ns2gpMyWn1/shGqvB86dAzR3d?= =?us-ascii?Q?hmGrwYSG85EYX8edmTQVFbsDJHgz5tDMiKSJOZ3eW9jzfta+zwHFZxEvSaya?= =?us-ascii?Q?/yiQUy/+2amOFJiGFT9qxhacBc45K9C4J3DGno5AXFce4g1R7xTRCvW6OeL3?= =?us-ascii?Q?KQfVM7aF5LBOKXTaKv7DBmIaoCt3ZwXjClxE4aus6xrv3U7TGmgAUWbTbJ9g?= =?us-ascii?Q?hJhcWBZ+neCdwf9xu04qtVdm3bsdyEMFVhhmF5r+qqrTfzKfBULMpl8ZjAqF?= =?us-ascii?Q?XSO0ijJc8vv8Yc7YANqg9F1PcbCTXL/hzcKYRlaVef2CGPn3b8RmHSV+luBA?= =?us-ascii?Q?FQ3l0No2qh1aqNKZ62u+fDMD2Z2QS5/e0Pd8tuREa7HUl/+TInjrfKWSDSsQ?= =?us-ascii?Q?ZR+AUd/dAu3uqBRoIF6+0o0tn1R30RW6h1avVubOMPFxfWHhLtJYRPTrvgW7?= =?us-ascii?Q?l109RWL+C4QFeTb5FSTIx+rPNRPA+wn31DarI1kOKyRbKT0VK7rtLBpAbSMf?= =?us-ascii?Q?AwYV6y/l5KWMdTJkVMQpnm0NS9VUb/SyL3wxxIDcHpNPl5bZCy9XpKejVFi7?= =?us-ascii?Q?HzLXWG5KmTDA9I9KEga+AkyNuAlzz7RJEl0R7aoyZeCQhcq3pmuaZr8nlPDL?= =?us-ascii?Q?h5QtJwHt6VfUc5GJbV+/uteBdSPHtdgUay7M2evC4mPWrTqFZCPciIJtEw8N?= =?us-ascii?Q?jhBMrlpepDX3+4a0eAiL8ieN4GLRcgQ/IjOfyUjoyxcCqB7cN7nOtj2bhWy1?= =?us-ascii?Q?8FKwtiFoqT+83/wNPCt01skh4W7xnFY2Uoa2Kwx31OBYDwPsZMyVCBufaGLn?= =?us-ascii?Q?n33vnBvFeajfjQJcBTZUqZmgWIINbVkeE8tamBKFdx8ozJh3EIVd0jiAe/0q?= =?us-ascii?Q?0O8SiP+QadISDVBIFiS55NlyktgxeTCVHOAIFkWWkaTwF0Uzy3jwNPbNPc3F?= =?us-ascii?Q?77hI39ze0gdFHXr7OoARSTFyW569V81Hc9Rperq3FzeOVW9QE1QJelRVwp53?= =?us-ascii?Q?aPQzeBwkMCRD5f8tT2M=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8198.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8613f116-fd9c-4019-a8a9-08daa11a4af5 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Sep 2022 06:25:52.4869 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: NpbQSwxYEQM9gObizFA2/d7mRgW1NOaO5XTxwpd7nFtDMkOru3yMJYCZoT8PZUhP X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8348 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Thomas, One of the customer has objected this patch as they are going to use it in = future so please discard it. Regards, Gagan > -----Original Message----- > From: Gagandeep Singh > Sent: Monday, September 26, 2022 2:11 PM > To: thomas@monjalon.net; dev@dpdk.org; Hemant Agrawal > > Cc: Gagandeep Singh > Subject: [PATCH] raw/dpaa2_cmdif: remove driver >=20 > dpaa2_cmdif raw driver is no longer in use and has no known activer user. >=20 > So this patch removes dpaa2_cmdif raw driver. >=20 > Signed-off-by: Gagandeep Singh > --- > MAINTAINERS | 5 - > doc/api/doxy-api-index.md | 1 - > doc/api/doxy-api.conf.in | 1 - > doc/guides/platform/dpaa2.rst | 6 +- > doc/guides/rawdevs/dpaa2_cmdif.rst | 77 ----- > doc/guides/rawdevs/index.rst | 1 - > doc/guides/rel_notes/deprecation.rst | 3 - > drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c | 291 ------------------ > drivers/raw/dpaa2_cmdif/dpaa2_cmdif_logs.h | 46 --- > drivers/raw/dpaa2_cmdif/meson.build | 7 - > drivers/raw/dpaa2_cmdif/rte_pmd_dpaa2_cmdif.h | 35 --- > drivers/raw/dpaa2_cmdif/version.map | 3 - > drivers/raw/meson.build | 1 - > 13 files changed, 1 insertion(+), 476 deletions(-) delete mode 100644 > doc/guides/rawdevs/dpaa2_cmdif.rst > delete mode 100644 drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c > delete mode 100644 drivers/raw/dpaa2_cmdif/dpaa2_cmdif_logs.h > delete mode 100644 drivers/raw/dpaa2_cmdif/meson.build > delete mode 100644 drivers/raw/dpaa2_cmdif/rte_pmd_dpaa2_cmdif.h > delete mode 100644 drivers/raw/dpaa2_cmdif/version.map >=20 > diff --git a/MAINTAINERS b/MAINTAINERS > index 08e575faac..5180adbefd 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -1401,11 +1401,6 @@ F: doc/guides/rawdevs/ntb.rst > F: examples/ntb/ > F: doc/guides/sample_app_ug/ntb.rst >=20 > -NXP DPAA2 CMDIF > -M: Gagandeep Singh > -F: drivers/raw/dpaa2_cmdif/ > -F: doc/guides/rawdevs/dpaa2_cmdif.rst > - >=20 > Packet processing > ----------------- > diff --git a/doc/api/doxy-api-index.md b/doc/api/doxy-api-index.md index > 186a258be4..1984761498 100644 > --- a/doc/api/doxy-api-index.md > +++ b/doc/api/doxy-api-index.md > @@ -53,7 +53,6 @@ The public API headers are grouped by topics: > [dpaa2](@ref rte_pmd_dpaa2.h), > [mlx5](@ref rte_pmd_mlx5.h), > [dpaa2_mempool](@ref rte_dpaa2_mempool.h), > - [dpaa2_cmdif](@ref rte_pmd_dpaa2_cmdif.h), > [dpaa2_qdma](@ref rte_pmd_dpaa2_qdma.h), > [crypto_scheduler](@ref rte_cryptodev_scheduler.h), > [dlb2](@ref rte_pmd_dlb2.h), > diff --git a/doc/api/doxy-api.conf.in b/doc/api/doxy-api.conf.in index > 608494a7c0..c4a39a02cb 100644 > --- a/doc/api/doxy-api.conf.in > +++ b/doc/api/doxy-api.conf.in > @@ -22,7 +22,6 @@ INPUT =3D @TOPDIR@/doc/api/doxy-api- > index.md \ > @TOPDIR@/drivers/net/ixgbe \ > @TOPDIR@/drivers/net/mlx5 \ > @TOPDIR@/drivers/net/softnic \ > - @TOPDIR@/drivers/raw/dpaa2_cmdif \ > @TOPDIR@/drivers/raw/ifpga \ > @TOPDIR@/drivers/raw/ioat \ > @TOPDIR@/lib/eal/include \ diff --git > a/doc/guides/platform/dpaa2.rst b/doc/guides/platform/dpaa2.rst index > a9fcad6ca2..28cb1be690 100644 > --- a/doc/guides/platform/dpaa2.rst > +++ b/doc/guides/platform/dpaa2.rst > @@ -36,11 +36,7 @@ Common Offload HW Block Drivers >=20 > See :doc:`../eventdevs/dpaa2` for NXP dpaa2 eventdev driver informati= on. >=20 > -4. **Rawdev AIOP CMDIF Driver** > - > - See :doc:`../rawdevs/dpaa2_cmdif` for NXP dpaa2 AIOP command > interface driver information. > - > -5. **DMA Driver** > +4. **DMA Driver** >=20 > See :doc:`../dmadevs/dpaa2` for NXP dpaa2 QDMA driver information. >=20 > diff --git a/doc/guides/rawdevs/dpaa2_cmdif.rst > b/doc/guides/rawdevs/dpaa2_cmdif.rst > deleted file mode 100644 > index 4eed661c8e..0000000000 > --- a/doc/guides/rawdevs/dpaa2_cmdif.rst > +++ /dev/null > @@ -1,77 +0,0 @@ > -.. SPDX-License-Identifier: BSD-3-Clause > - Copyright 2018 NXP > - > -NXP DPAA2 CMDIF Driver > -=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > - > -The DPAA2 CMDIF is an implementation of the rawdev API, that provides - > communication between the GPP and AIOP (Firmware). This is achieved -via > using the DPCI devices exposed by MC for GPP <--> AIOP interaction. > - > -More information can be found at `NXP Official Website - > processors/qoriq-arm-processors:QORIQ-ARM>`_. > - > -Features > --------- > - > -The DPAA2 CMDIF implements following features in the rawdev API; > - > -- Getting the object ID of the device (DPCI) using attributes > -- I/O to and from the AIOP device using DPCI > - > -Supported DPAA2 SoCs > --------------------- > - > -- LS2084A/LS2044A > -- LS2088A/LS2048A > -- LS1088A/LS1048A > - > -Prerequisites > -------------- > - > -See :doc:`../platform/dpaa2` for setup information > - > -- Follow the DPDK :ref:`Getting Started Guide for Linux ` to = setup > the basic DPDK environment. > - > -.. note:: > - > - Some part of fslmc bus code (mc flib - object library) routines are > - dual licensed (BSD & GPLv2). > - > - > -Enabling logs > -------------- > - > -For enabling logs, use the following EAL parameter: > - > -.. code-block:: console > - > - ./your_cmdif_application --log- > level=3Dpmd.raw.dpaa2.cmdif, > - > -Using ``pmd.raw.dpaa2.cmdif`` as log matching criteria, all Event PMD lo= gs > can be -enabled which are lower than logging ``level``. > - > - > -Initialization > --------------- > - > -The DPAA2 CMDIF is exposed as a vdev device which consists of dpci devic= es. > -On EAL initialization, dpci devices will be probed and then vdev device = -can > be created from the application code by > - > -* Invoking ``rte_vdev_init("dpaa2_dpci")`` from the application > - > -* Using ``--vdev=3D"dpaa2_dpci"`` in the EAL options, which will call > - rte_vdev_init() internally > - > -Example: > - > -.. code-block:: console > - > - ./your_cmdif_application --vdev=3D"dpaa2_dpci" > - > -Platform Requirement > -~~~~~~~~~~~~~~~~~~~~ > - > -DPAA2 drivers for DPDK can only work on NXP SoCs as listed in the - > ``Supported DPAA2 SoCs``. > diff --git a/doc/guides/rawdevs/index.rst b/doc/guides/rawdevs/index.rst > index cf69633064..5e5421028c 100644 > --- a/doc/guides/rawdevs/index.rst > +++ b/doc/guides/rawdevs/index.rst > @@ -13,7 +13,6 @@ application through rawdev API. >=20 > cnxk_bphy > cnxk_gpio > - dpaa2_cmdif > ifpga > ioat > ntb > diff --git a/doc/guides/rel_notes/deprecation.rst > b/doc/guides/rel_notes/deprecation.rst > index 985ef89877..bf98bf1c09 100644 > --- a/doc/guides/rel_notes/deprecation.rst > +++ b/doc/guides/rel_notes/deprecation.rst > @@ -207,9 +207,6 @@ Deprecation Notices > Names for the telemetry commands will be similarly limited. > The parameters for telemetry commands are unaffected by this change. >=20 > -* raw/dpaa2_cmdif: The ``dpaa2_cmdif`` rawdev driver will be deprecated > - in DPDK 22.11, as it is no longer in use, no active user known. > - > * raw/ioat: The ``ioat`` rawdev driver has been deprecated, since it's > functionality is provided through the new ``dmadev`` infrastructure. > To continue to use hardware previously supported by the ``ioat`` rawde= v > driver, diff --git a/drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c > b/drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c > deleted file mode 100644 > index aeee4ac289..0000000000 > --- a/drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c > +++ /dev/null > @@ -1,291 +0,0 @@ > -/* SPDX-License-Identifier: BSD-3-Clause > - * Copyright 2018-2019 NXP > - */ > - > -#include > -#include > -#include > - > -#include > -#include > -#include > -#include > -#include > - > -#include > -#include > - > -#include > -#include > -#include "dpaa2_cmdif_logs.h" > -#include "rte_pmd_dpaa2_cmdif.h" > - > -/* CMDIF driver name */ > -#define DPAA2_CMDIF_PMD_NAME dpaa2_dpci > - > -/* > - * This API provides the DPCI device ID in 'attr_value'. > - * The device ID shall be passed by GPP to the AIOP using CMDIF commands= . > - */ > -static int > -dpaa2_cmdif_get_attr(struct rte_rawdev *dev, > - const char *attr_name, > - uint64_t *attr_value) > -{ > - struct dpaa2_dpci_dev *cidev =3D dev->dev_private; > - > - DPAA2_CMDIF_FUNC_TRACE(); > - > - RTE_SET_USED(attr_name); > - > - if (!attr_value) { > - DPAA2_CMDIF_ERR("Invalid arguments for getting > attributes"); > - return -EINVAL; > - } > - *attr_value =3D cidev->dpci_id; > - > - return 0; > -} > - > -static int > -dpaa2_cmdif_enqueue_bufs(struct rte_rawdev *dev, > - struct rte_rawdev_buf **buffers, > - unsigned int count, > - rte_rawdev_obj_t context) > -{ > - struct dpaa2_dpci_dev *cidev =3D dev->dev_private; > - struct rte_dpaa2_cmdif_context *cmdif_send_cnxt; > - struct dpaa2_queue *txq; > - struct qbman_fd fd; > - struct qbman_eq_desc eqdesc; > - struct qbman_swp *swp; > - uint32_t retry_count =3D 0; > - int ret; > - > - RTE_SET_USED(count); > - > - if (unlikely(!DPAA2_PER_LCORE_DPIO)) { > - ret =3D dpaa2_affine_qbman_swp(); > - if (ret) { > - DPAA2_CMDIF_ERR( > - "Failed to allocate IO portal, tid: %d\n", > - rte_gettid()); > - return 0; > - } > - } > - swp =3D DPAA2_PER_LCORE_PORTAL; > - > - cmdif_send_cnxt =3D (struct rte_dpaa2_cmdif_context *)(context); > - txq =3D &(cidev->tx_queue[cmdif_send_cnxt->priority]); > - > - /* Prepare enqueue descriptor */ > - qbman_eq_desc_clear(&eqdesc); > - qbman_eq_desc_set_fq(&eqdesc, txq->fqid); > - qbman_eq_desc_set_no_orp(&eqdesc, 0); > - qbman_eq_desc_set_response(&eqdesc, 0, 0); > - > - /* Set some of the FD parameters to i. > - * For performance reasons do not memset > - */ > - fd.simple.bpid_offset =3D 0; > - fd.simple.ctrl =3D 0; > - > - DPAA2_SET_FD_ADDR(&fd, DPAA2_VADDR_TO_IOVA(buffers[0]- > >buf_addr)); > - DPAA2_SET_FD_LEN(&fd, cmdif_send_cnxt->size); > - DPAA2_SET_FD_FRC(&fd, cmdif_send_cnxt->frc); > - DPAA2_SET_FD_FLC(&fd, cmdif_send_cnxt->flc); > - > - /* Enqueue a packet to the QBMAN */ > - do { > - ret =3D qbman_swp_enqueue_multiple(swp, &eqdesc, &fd, > NULL, 1); > - if (ret < 0 && ret !=3D -EBUSY) > - DPAA2_CMDIF_ERR("Transmit failure with err: %d\n", > ret); > - retry_count++; > - } while ((ret =3D=3D -EBUSY) && (retry_count < > DPAA2_MAX_TX_RETRY_COUNT)); > - > - if (ret < 0) > - return ret; > - > - DPAA2_CMDIF_DP_DEBUG("Successfully transmitted a packet\n"); > - > - return 1; > -} > - > -static int > -dpaa2_cmdif_dequeue_bufs(struct rte_rawdev *dev, > - struct rte_rawdev_buf **buffers, > - unsigned int count, > - rte_rawdev_obj_t context) > -{ > - struct dpaa2_dpci_dev *cidev =3D dev->dev_private; > - struct rte_dpaa2_cmdif_context *cmdif_rcv_cnxt; > - struct dpaa2_queue *rxq; > - struct qbman_swp *swp; > - struct qbman_result *dq_storage; > - const struct qbman_fd *fd; > - struct qbman_pull_desc pulldesc; > - uint8_t status; > - int ret; > - > - RTE_SET_USED(count); > - > - if (unlikely(!DPAA2_PER_LCORE_DPIO)) { > - ret =3D dpaa2_affine_qbman_swp(); > - if (ret) { > - DPAA2_CMDIF_ERR( > - "Failed to allocate IO portal, tid: %d\n", > - rte_gettid()); > - return 0; > - } > - } > - swp =3D DPAA2_PER_LCORE_PORTAL; > - > - cmdif_rcv_cnxt =3D (struct rte_dpaa2_cmdif_context *)(context); > - rxq =3D &(cidev->rx_queue[cmdif_rcv_cnxt->priority]); > - dq_storage =3D rxq->q_storage->dq_storage[0]; > - > - qbman_pull_desc_clear(&pulldesc); > - qbman_pull_desc_set_fq(&pulldesc, rxq->fqid); > - qbman_pull_desc_set_numframes(&pulldesc, 1); > - qbman_pull_desc_set_storage(&pulldesc, dq_storage, > - (uint64_t)(DPAA2_VADDR_TO_IOVA(dq_storage)), 1); > - > - while (1) { > - if (qbman_swp_pull(swp, &pulldesc)) { > - DPAA2_CMDIF_DP_WARN("VDQ cmd not issued. > QBMAN is busy\n"); > - /* Portal was busy, try again */ > - continue; > - } > - break; > - } > - > - /* Check if previous issued command is completed. */ > - while (!qbman_check_command_complete(dq_storage)) > - ; > - /* Loop until the dq_storage is updated with new token by QBMAN > */ > - while (!qbman_result_has_new_result(swp, dq_storage)) > - ; > - > - /* Check for valid frame. */ > - status =3D (uint8_t)qbman_result_DQ_flags(dq_storage); > - if (unlikely((status & QBMAN_DQ_STAT_VALIDFRAME) =3D=3D 0)) { > - DPAA2_CMDIF_DP_DEBUG("No frame is delivered\n"); > - return 0; > - } > - > - fd =3D qbman_result_DQ_fd(dq_storage); > - > - buffers[0]->buf_addr =3D (void *)DPAA2_IOVA_TO_VADDR( > - DPAA2_GET_FD_ADDR(fd) + > DPAA2_GET_FD_OFFSET(fd)); > - cmdif_rcv_cnxt->size =3D DPAA2_GET_FD_LEN(fd); > - cmdif_rcv_cnxt->flc =3D DPAA2_GET_FD_FLC(fd); > - cmdif_rcv_cnxt->frc =3D DPAA2_GET_FD_FRC(fd); > - > - DPAA2_CMDIF_DP_DEBUG("packet received\n"); > - > - return 1; > -} > - > -static const struct rte_rawdev_ops dpaa2_cmdif_ops =3D { > - .attr_get =3D dpaa2_cmdif_get_attr, > - .enqueue_bufs =3D dpaa2_cmdif_enqueue_bufs, > - .dequeue_bufs =3D dpaa2_cmdif_dequeue_bufs, > -}; > - > -static int > -dpaa2_cmdif_create(const char *name, > - struct rte_vdev_device *vdev, > - int socket_id) > -{ > - struct rte_rawdev *rawdev; > - struct dpaa2_dpci_dev *cidev; > - > - /* Allocate device structure */ > - rawdev =3D rte_rawdev_pmd_allocate(name, sizeof(struct > dpaa2_dpci_dev), > - socket_id); > - if (!rawdev) { > - DPAA2_CMDIF_ERR("Unable to allocate rawdevice"); > - return -EINVAL; > - } > - > - rawdev->dev_ops =3D &dpaa2_cmdif_ops; > - rawdev->device =3D &vdev->device; > - > - /* For secondary processes, the primary has done all the work */ > - if (rte_eal_process_type() !=3D RTE_PROC_PRIMARY) > - return 0; > - > - cidev =3D rte_dpaa2_alloc_dpci_dev(); > - if (!cidev) { > - DPAA2_CMDIF_ERR("Unable to allocate CI device"); > - rte_rawdev_pmd_release(rawdev); > - return -ENODEV; > - } > - > - rawdev->dev_private =3D cidev; > - > - return 0; > -} > - > -static int > -dpaa2_cmdif_destroy(const char *name) > -{ > - int ret; > - struct rte_rawdev *rdev; > - > - rdev =3D rte_rawdev_pmd_get_named_dev(name); > - if (!rdev) { > - DPAA2_CMDIF_ERR("Invalid device name (%s)", name); > - return -EINVAL; > - } > - > - /* The primary process will only free the DPCI device */ > - if (rte_eal_process_type() =3D=3D RTE_PROC_PRIMARY) > - rte_dpaa2_free_dpci_dev(rdev->dev_private); > - > - ret =3D rte_rawdev_pmd_release(rdev); > - if (ret) > - DPAA2_CMDIF_DEBUG("Device cleanup failed"); > - > - return 0; > -} > - > -static int > -dpaa2_cmdif_probe(struct rte_vdev_device *vdev) -{ > - const char *name; > - int ret =3D 0; > - > - name =3D rte_vdev_device_name(vdev); > - > - DPAA2_CMDIF_INFO("Init %s on NUMA node %d", name, > rte_socket_id()); > - > - ret =3D dpaa2_cmdif_create(name, vdev, rte_socket_id()); > - > - return ret; > -} > - > -static int > -dpaa2_cmdif_remove(struct rte_vdev_device *vdev) -{ > - const char *name; > - int ret; > - > - name =3D rte_vdev_device_name(vdev); > - if (name =3D=3D NULL) > - return -1; > - > - DPAA2_CMDIF_INFO("Closing %s on NUMA node %d", name, > rte_socket_id()); > - > - ret =3D dpaa2_cmdif_destroy(name); > - > - return ret; > -} > - > -static struct rte_vdev_driver dpaa2_cmdif_drv =3D { > - .probe =3D dpaa2_cmdif_probe, > - .remove =3D dpaa2_cmdif_remove > -}; > - > -RTE_PMD_REGISTER_VDEV(DPAA2_CMDIF_PMD_NAME, dpaa2_cmdif_drv); > -RTE_LOG_REGISTER(dpaa2_cmdif_logtype, pmd.raw.dpaa2.cmdif, INFO); > diff --git a/drivers/raw/dpaa2_cmdif/dpaa2_cmdif_logs.h > b/drivers/raw/dpaa2_cmdif/dpaa2_cmdif_logs.h > deleted file mode 100644 > index 8991e8327d..0000000000 > --- a/drivers/raw/dpaa2_cmdif/dpaa2_cmdif_logs.h > +++ /dev/null > @@ -1,46 +0,0 @@ > -/* SPDX-License-Identifier: BSD-3-Clause > - * Copyright 2018 NXP > - */ > - > -#ifndef __DPAA2_CMDIF_LOGS_H__ > -#define __DPAA2_CMDIF_LOGS_H__ > - > -#ifdef __cplusplus > -extern "C" { > -#endif > - > -extern int dpaa2_cmdif_logtype; > - > -#define DPAA2_CMDIF_LOG(level, fmt, args...) \ > - rte_log(RTE_LOG_ ## level, dpaa2_cmdif_logtype, "dpaa2_cmdif: " \ > - fmt "\n", ## args) > - > -#define DPAA2_CMDIF_DEBUG(fmt, args...) \ > - rte_log(RTE_LOG_DEBUG, dpaa2_cmdif_logtype, > "dpaa2_cmdif: %s(): " \ > - fmt "\n", __func__, ## args) > - > -#define DPAA2_CMDIF_FUNC_TRACE() DPAA2_CMDIF_DEBUG(">>") > - > -#define DPAA2_CMDIF_INFO(fmt, args...) \ > - DPAA2_CMDIF_LOG(INFO, fmt, ## args) > -#define DPAA2_CMDIF_ERR(fmt, args...) \ > - DPAA2_CMDIF_LOG(ERR, fmt, ## args) > -#define DPAA2_CMDIF_WARN(fmt, args...) \ > - DPAA2_CMDIF_LOG(WARNING, fmt, ## args) > - > -/* DP Logs, toggled out at compile time if level lower than current leve= l */ - > #define DPAA2_CMDIF_DP_LOG(level, fmt, args...) \ > - RTE_LOG_DP(level, PMD, "dpaa2_cmdif: " fmt "\n", ## args) > - > -#define DPAA2_CMDIF_DP_DEBUG(fmt, args...) \ > - DPAA2_CMDIF_DP_LOG(DEBUG, fmt, ## args) > -#define DPAA2_CMDIF_DP_INFO(fmt, args...) \ > - DPAA2_CMDIF_DP_LOG(INFO, fmt, ## args) > -#define DPAA2_CMDIF_DP_WARN(fmt, args...) \ > - DPAA2_CMDIF_DP_LOG(WARNING, fmt, ## args) > - > -#ifdef __cplusplus > -} > -#endif > - > -#endif /* __DPAA2_CMDIF_LOGS_H__ */ > diff --git a/drivers/raw/dpaa2_cmdif/meson.build > b/drivers/raw/dpaa2_cmdif/meson.build > deleted file mode 100644 > index 3b1d3371b2..0000000000 > --- a/drivers/raw/dpaa2_cmdif/meson.build > +++ /dev/null > @@ -1,7 +0,0 @@ > -# SPDX-License-Identifier: BSD-3-Clause -# Copyright 2018 NXP > - > -deps +=3D ['rawdev', 'mempool_dpaa2', 'bus_vdev'] -sources =3D > files('dpaa2_cmdif.c') > - > -headers =3D files('rte_pmd_dpaa2_cmdif.h') diff --git > a/drivers/raw/dpaa2_cmdif/rte_pmd_dpaa2_cmdif.h > b/drivers/raw/dpaa2_cmdif/rte_pmd_dpaa2_cmdif.h > deleted file mode 100644 > index 483b66eaae..0000000000 > --- a/drivers/raw/dpaa2_cmdif/rte_pmd_dpaa2_cmdif.h > +++ /dev/null > @@ -1,35 +0,0 @@ > -/* SPDX-License-Identifier: BSD-3-Clause > - * Copyright 2018 NXP > - */ > - > -#ifndef __RTE_PMD_DPAA2_CMDIF_H__ > -#define __RTE_PMD_DPAA2_CMDIF_H__ > - > -/** > - * @file > - * > - * NXP dpaa2 AIOP CMDIF PMD specific structures. > - * > - */ > - > -#ifdef __cplusplus > -extern "C" { > -#endif > - > -/** The context required in the I/O path for DPAA2 AIOP Command > Interface */ -struct rte_dpaa2_cmdif_context { > - /** Size to populate in QBMAN FD */ > - uint32_t size; > - /** FRC to populate in QBMAN FD */ > - uint32_t frc; > - /** FLC to populate in QBMAN FD */ > - uint64_t flc; > - /** Priority of the command. This priority determines DPCI Queue*/ > - uint8_t priority; > -}; > - > -#ifdef __cplusplus > -} > -#endif > - > -#endif /* __RTE_PMD_DPAA2_CMDIF_H__ */ > diff --git a/drivers/raw/dpaa2_cmdif/version.map > b/drivers/raw/dpaa2_cmdif/version.map > deleted file mode 100644 > index 78c3585d7c..0000000000 > --- a/drivers/raw/dpaa2_cmdif/version.map > +++ /dev/null > @@ -1,3 +0,0 @@ > -DPDK_23 { > - local: *; > -}; > diff --git a/drivers/raw/meson.build b/drivers/raw/meson.build index > 48e84d586e..226fea556d 100644 > --- a/drivers/raw/meson.build > +++ b/drivers/raw/meson.build > @@ -8,7 +8,6 @@ endif > drivers =3D [ > 'cnxk_bphy', > 'cnxk_gpio', > - 'dpaa2_cmdif', > 'ifpga', > 'ioat', > 'ntb', > -- > 2.25.1