From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E9062A00C2; Mon, 30 May 2022 06:31:43 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9127840A89; Mon, 30 May 2022 06:31:43 +0200 (CEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70043.outbound.protection.outlook.com [40.107.7.43]) by mails.dpdk.org (Postfix) with ESMTP id 5EA5240A82 for ; Mon, 30 May 2022 06:31:42 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=b3kks0OlGE1/p9RzOuDt/C49JEAekmk5yHMCs0frUmApuGzGEfpdKdWn1Wex14y9LoXERoYcU6xZRQDjB7TEJzvRb1+fFrGwJsGnHbnDm1zaNqBJuTeq7Tys0NGj1MA7q8405MX6QyfDgOVU6vKZlxJ4WpXj6dVFELUHGFfZR1WcNAZh92dzm2xiLqvHMPtkQJYNvHXQmGkosgsQlOUONZ/jWt9g+04RBbS1AfmEsOjylbOEBeOwamfs7Zi+3cMZY7K6tiiaC9/9WF9UEOBpsfwOrbmcdg2waCC3Hk6+POn/DFFRv2YC4N5op8j+3Dgyt8JZC+ydb46ysdfBKAF7hQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+4zb1XFA0EluioKpY0hsDFzFQdh6jGqadBP8Yc/UxWQ=; b=SFQjB1TIlqGCKPvAUvumK6Cx7ll77+6mDH1XbEIBjkjFravwQg1Up7Q8ldtwk13Yb/6lWD33JqlDcmJZqdzPzury5og29cSzpjGA7FtotgaBnHx1E/eWFTXVJ6pdaRDnEixAatJjKH8I/AXzBQNd+iJfP4Hf0HDrypDjdum5kNY7pfA/a/DY/nSrXeVbMicRTdsoU6ycckmILL8LCS1ICiaLdE4SXUBpxy6DM8iTcO/UySHjtXBBU8HpRZ9/3B1VuS26JRkGl08yzipA3CTEoCtb+QMNm4Ze2Q0E3REn904MdHdYUuU+L+aWXP+LgIhEX0WvzfSnzx19dEnqOndJGA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+4zb1XFA0EluioKpY0hsDFzFQdh6jGqadBP8Yc/UxWQ=; b=XdWlhdTG9cKHzL6I6E9yiJ9tOF8g6+lmYZOhRgbgNhM3+1BmXIro/8UJA3IvE2Ppfm6xquaiheeeKkLp/ymwWfh8tpNdGwvjuuMUBsI86MMIVzDAmCLVrE3NvH/Ya3wI/iJN1BA3pq7WV47nDnwPfL9xmmhgr/+bbelWUKJxTZg= Received: from AS8PR04MB8198.eurprd04.prod.outlook.com (2603:10a6:20b:3b0::14) by AM0PR04MB4498.eurprd04.prod.outlook.com (2603:10a6:208:73::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.18; Mon, 30 May 2022 04:31:40 +0000 Received: from AS8PR04MB8198.eurprd04.prod.outlook.com ([fe80::20be:bf68:bdb3:d4f8]) by AS8PR04MB8198.eurprd04.prod.outlook.com ([fe80::20be:bf68:bdb3:d4f8%7]) with mapi id 15.20.5293.019; Mon, 30 May 2022 04:31:40 +0000 From: Gagandeep Singh To: Akhil Goyal , "dev@dpdk.org" Subject: RE: [EXT] [PATCH v3 1/7] app/test-crypto-perf: support SDAP for PDCP operations Thread-Topic: [EXT] [PATCH v3 1/7] app/test-crypto-perf: support SDAP for PDCP operations Thread-Index: AQHYbAERENjpoa5CqU24cHswxLmezq0xN78AgAWrc8A= Date: Mon, 30 May 2022 04:31:40 +0000 Message-ID: References: <20220517033858.40394-2-g.singh@nxp.com> <20220520042104.3784908-1-g.singh@nxp.com> <20220520042104.3784908-2-g.singh@nxp.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f6d14950-7528-4e44-5bd8-08da41f54b0c x-ms-traffictypediagnostic: AM0PR04MB4498:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 4d9KQW2a22eaGwuXxYmxv3O8f5QhLpgwiFYRpwn7EpUF8iHIWxvuonmnqTspQizxjic5B5tviKHYxrix3YVl/gXDQWM4v3Go4ph7LFW+TgP5anSGTGwEupCI6BD1DnVYB9RXiT+DU/rVQ+OhNHLI+lTqDHTSHzqNNPcEUy9QsWbQ+24Dxux5niNeOch97beaYgkJFZ6GmcqMdqNv0+f6TcT8leytg+i++TH/dP+bc9uen7KwW5vOeaILzapfi8+szU4/d6kSJ1rr7lxOxKrz0QM69FcvAASuO6rFvpCyWfFngcWah6CMFht6Cuc5Ta1LaCtbcyQXGrRctpeWH84gzieE6K7FPp34JwfKy6az3c1KOj0e82mQ9PA8IGs0jpDdanzl4acszeJm5mj8JvRe9AaWolGb+p7iBLU2rmC4q8/uGfsGwBJ/HbjXq8nOOYGDmvN/HbvPxPZ7+puXw5rVCfAHso88Db4rYT0GToDZJPe9ly/WHgWWbC8Szkr44xZVIaHRjGNGbHhVuY2gLrykp8Ayvow+M1soopBstBpvTxHEdwnBd1YW4UsJQ9PSOHhbX4bvaxhps5POAAS+4BSpM2dhAXqJYf0hONFkpQsclwQUrk0r8w82579HkzH7aIFhkuMrTwPBEaSnhhsIqjy+cbC+dP5n5KIeSGE1cPwF1lm0bXjls/HqpYa1BgMAXJtzfWVTw4zq0sxyErGXBnsqFg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AS8PR04MB8198.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(7696005)(71200400001)(8676002)(6506007)(53546011)(86362001)(38070700005)(2906002)(83380400001)(52536014)(122000001)(8936002)(55016003)(9686003)(5660300002)(26005)(508600001)(33656002)(316002)(38100700002)(110136005)(64756008)(66476007)(66446008)(66946007)(66556008)(186003)(76116006)(55236004); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ZJC8qhwDnQryyyzpzRkecx2dYw30CjhCrycd/UX6bGhjEaD1477DI1r1pbvt?= =?us-ascii?Q?RtxmY2rKw4cAr0EU/ugPN3XvrWcYh2/xNVv6KqGSdIEjTmMoEq0t3esI7Uhi?= =?us-ascii?Q?FaucVuknbU6KzZnNhLdDbfp7zSJXIF94mh/Jxw9K+JBgsez4BChM1APXchmC?= =?us-ascii?Q?eWzE+Nupe/WSTb/vU5SmuuRBihzCbMLQukXbfs5MilWJ181b3ebXa9TeU7n7?= =?us-ascii?Q?+/wDba+bcR6XtxdR0kvEeM0+8q05y4lB/W66tt30xeqDX5SYBe1Et1PQ1/sZ?= =?us-ascii?Q?2n+zLuhiTnTK09PD+YgkXVpqjmRx8aeG0OY5wLcBjPowJPBPouIiiZip7tC2?= =?us-ascii?Q?J/S+4lN2K5giji4HcnqM7+HJ1bYAsUQXxf3or40UbpYfkIts+iJi209WYSw0?= =?us-ascii?Q?3JchYd3Ccp2oGFvbmE76iCng19US3O1gIHuRsLCoVCQ5yW7fZ4B93dqC8g81?= =?us-ascii?Q?EdnQVAwMHt6T0O9Hu2+2pvk9+IeZKas7yeNiiplbmuVgbsZQZ7S8araru9Sq?= =?us-ascii?Q?/m+iP8MFWwVWtHDo4JmcWU6mrVBitNgKOliY2WAhm7t9F72y6mFKLf8dBFlb?= =?us-ascii?Q?qe0QW3jAlaChhkGvrvSqtbBwAMkbmpbWWT0/2qOyvBKDBdu4RoD0ADoUB9Be?= =?us-ascii?Q?b1kautG03FSZBTdE+PZ5oK+JjvD3BB+tY3S6TcxCm077DCuvibg8jDgwy0tZ?= =?us-ascii?Q?dPY/MjSAmZoNdqt8rQidJ7NZRgLFs2weYLDnrX1/C6h35uYP0LKW5bcT+nuF?= =?us-ascii?Q?9gvcGmkrOG688OuQ5CGhXJpy7Xa4eEJjtlZ2ml+ppD8ZlzjfrfJfsyvNdAP7?= =?us-ascii?Q?QZcIEThUsiS42pr5B2YQNh45qx+K4jyL/itrU8qLvLHjLhBqt3jS80Ff++Ec?= =?us-ascii?Q?P1WSaFcIh9PHS5ykdLksDMPvOaUcRiNuC82itaK/z1GrmcuKm5cZ5UhuKgej?= =?us-ascii?Q?nT2wV2/T1X+ZZSV8bHWHx5Pq5JkhgKgnfqItgzagdNQ7cS152++rC/qGEcub?= =?us-ascii?Q?e2V3asOm8i/XJUCQA8ZNmLq68G26k90QkVJmjoTz4VJXWeXuVHWGxIOnX+/q?= =?us-ascii?Q?oug2jjrgVNK0iVd+SHyYih+YY3utX+qfx1bGvYN84zs12QqTj6RkXgXggAWU?= =?us-ascii?Q?C9B8lwT36Ob2qC+n6gPRoo3pZhGx+7ijXNiwGOwSYokenApzJaNix4BOYIVP?= =?us-ascii?Q?EYhC+kEUu6uCkS7XndgJaKxFpTWulysxpVji48zOAlEpuGXsGFOUyONGH8yK?= =?us-ascii?Q?sBRzZPfJvNZeqhTinWRAcdh3uDgtFtw0MLERQYkI/tRuLoFsmer62bW37vVu?= =?us-ascii?Q?sXwqsCMBktLa/eR9RkAwmA1fBl4I7EQN/FVXM/6lLqD9+Js4HaowqiPVTkHh?= =?us-ascii?Q?gFZMUz9CFBAuiwLt7pdlJ3MRpAJBXJ4pUtANYH6W9JKjNwJb9uL3uO5mtHFv?= =?us-ascii?Q?6nWp5SuXacGZ27l3awMiXKv6+Z8EI76IyhJvqM+kAZC5ByFVsT1LY80OZSY4?= =?us-ascii?Q?GvniizM2pgsIgPa1RyDhpA9u8k7//zFR/HHRjjJ4hV/4UQTTE6t53sDrwwvu?= =?us-ascii?Q?QhA+ALdWMRJ+27GMRVRkqClTV0naa8npAsZSOEMe7CcmqTuyg0yYfU1P9KVA?= =?us-ascii?Q?G+ZExONtJFYnyt6VD7Rf3ps8FIwJeVfKDnagyNGUEd3IVlKjOvj/271Ywnri?= =?us-ascii?Q?SVtYeIN6SI6pluNcvHWtuusq2jnUGaPCqANzCkbvaYSJiGAz?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8198.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f6d14950-7528-4e44-5bd8-08da41f54b0c X-MS-Exchange-CrossTenant-originalarrivaltime: 30 May 2022 04:31:40.7928 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: LF6wFM5PczmeE60AjFfBj2Vy7U1WgJwQirjqkroaWQ1IxP2UOwjdaq82Cvd3WC5q X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB4498 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi, > -----Original Message----- > From: Akhil Goyal > Sent: Thursday, May 26, 2022 7:23 PM > To: Gagandeep Singh ; dev@dpdk.org > Subject: RE: [EXT] [PATCH v3 1/7] app/test-crypto-perf: support SDAP for = PDCP > operations >=20 > > Add a command line option "--enable-sdap" to enable Service Data > > Adaptation Protocol. > > > > example command: > > ./dpdk-test-crypto-perf -c 0xc --log-level=3D8 -- --devtype > > crypto_dpaa2_sec --optype pdcp --cipher-algo aes-ctr --cipher-op > > encrypt --auth-algo zuc-eia3 --auth-op generate --auth-key-sz 16 > > --ptest throughput --total-ops 100000 --burst-sz 64 --buffer-sz > > 64,390,1512 --pool-sz 4096 --silent --pdcp-sn-sz 12 --pdcp-domain > > control --enable-sdap > > > > Signed-off-by: Gagandeep Singh > > --- > > app/test-crypto-perf/cperf_ops.c | 1 + > > app/test-crypto-perf/cperf_options.h | 2 ++ > > app/test-crypto-perf/cperf_options_parsing.c | 12 ++++++++++++ > > doc/guides/tools/cryptoperf.rst | 4 ++++ > > 4 files changed, 19 insertions(+) > > > > diff --git a/app/test-crypto-perf/cperf_ops.c > > b/app/test-crypto-perf/cperf_ops.c > > index cbefce8d6c..4295656a0b 100644 > > --- a/app/test-crypto-perf/cperf_ops.c > > +++ b/app/test-crypto-perf/cperf_ops.c > > @@ -861,6 +861,7 @@ cperf_create_session(struct rte_mempool *sess_mp, > > .hfn =3D options->pdcp_ses_hfn_en ? > > PDCP_DEFAULT_HFN : 0, > > .hfn_threshold =3D 0x70C0A, > > + .sdap_enabled =3D options->pdcp_sdap, > > .hfn_ovrd =3D !(options->pdcp_ses_hfn_en), > > } }, > > .crypto_xform =3D &cipher_xform > > diff --git a/app/test-crypto-perf/cperf_options.h b/app/test-crypto- > > perf/cperf_options.h index 09caefde22..613d6d31e2 100644 > > --- a/app/test-crypto-perf/cperf_options.h > > +++ b/app/test-crypto-perf/cperf_options.h > > @@ -14,6 +14,7 @@ > > #define CPERF_PTEST_TYPE ("ptest") > > #define CPERF_MODEX_LEN ("modex-len") > > #define CPERF_SILENT ("silent") > > +#define CPERF_ENABLE_SDAP ("enable-sdap") > > > > #define CPERF_POOL_SIZE ("pool-sz") > > #define CPERF_TOTAL_OPS ("total-ops") > > @@ -129,6 +130,7 @@ struct cperf_options { #ifdef RTE_LIB_SECURITY > > uint16_t pdcp_sn_sz; > > uint16_t pdcp_ses_hfn_en; > > + uint16_t pdcp_sdap; > > enum rte_security_pdcp_domain pdcp_domain; > > uint16_t docsis_hdr_sz; > > #endif > > diff --git a/app/test-crypto-perf/cperf_options_parsing.c > > b/app/test-crypto- perf/cperf_options_parsing.c index > > 09c98121c8..28680347f1 100644 > > --- a/app/test-crypto-perf/cperf_options_parsing.c > > +++ b/app/test-crypto-perf/cperf_options_parsing.c > > @@ -64,6 +64,7 @@ usage(char *progname) > > " --pdcp-sn-sz N: set PDCP SN size N <5/7/12/15/18>\n" > > " --pdcp-domain DOMAIN: set PDCP domain \n" > > " --pdcp-ses-hfn-en: enable session based fixed HFN\n" > > + " --enable-sdap: enable sdap\n" > > " --docsis-hdr-sz: set DOCSIS header size\n" > > #endif > > " -h: prints this help\n", > > @@ -548,6 +549,15 @@ parse_silent(struct cperf_options *opts, > > return 0; > > } > > > > +static int > > +parse_enable_sdap(struct cperf_options *opts, > > + const char *arg __rte_unused) > > +{ > > + opts->pdcp_sdap =3D 1; > > + > > + return 0; > > +} >=20 > You should also set a default value of this flag. Default functionality is disable SDAP. Application is defining the cperf op= tions with all values 0s in its main(): "struct cperf_options opts =3D {0};= ". Is n't it sufficient?