From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 27A28A0C43; Tue, 16 Nov 2021 12:47:35 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9F0C940141; Tue, 16 Nov 2021 12:47:34 +0100 (CET) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2047.outbound.protection.outlook.com [40.107.21.47]) by mails.dpdk.org (Postfix) with ESMTP id ECC8C40040 for ; Tue, 16 Nov 2021 12:47:33 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ixAXE5Znh7XfCYIi5gaHKql6QyXku+uejLpPa4ovtFvCPWaaE+CSyjmRo2ds1oUpUQT6loH/m+Zr/OMX87GlBpjzTykNoN39ph8uhRhmqeoCAzUrVA4loAm3SChJiflWyr7Tsrs6+5L7oiKg7mwPC7pH15NWBtRApIoat8glGuFw4fNGBC+X3Xkz4vS/jurOFINxMggbmr3A84lLyvXWoNWZeLU1CT6m1uw/9jzwMYEb68C/g4tBy2gMxkVaI9pWmmM27RdenAHFrgbHo7nvc8LQgmp3JIgPYiqv6kTfolkDHRrxC9yNYbWMyPY5/DzgqYumBUeuXUJ+9/usRUrYlw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/DMJ+X3gDZpTWH/lxQK9b6caQ0mfoSnyG7ftyBe7N3E=; b=lGZPKsnDM1tAK8IYSsySVftG9++3Q8e9H956WsIWlRqJN9BQg5OnzY6kvq3WA43PPNpEcx1AfvrQyBRdazXx+S4y5cxCMlIi+Ea7ZDKqeaersyo8x+VPSBTyUPZLrdfAblVIbQBfw0EYLC0DSNBGVtK1cDVbr8EHfsAqZZJRaQi9OgNAjKgNp4Y8fP/7gI4pxuFnjVwkFAoRAX/5LpnXn3X7gCBroDwFU1MafkgBO38NKrxxgh0aiINII1jmMBrF4TK/VRAI1mG6HTSgvRFaRcjyhePGow/sJ9xQF+m0u2im/VhMXJqJtCnNETvvRZzLe0MqLvdeVzDQEP6dNNXaUQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/DMJ+X3gDZpTWH/lxQK9b6caQ0mfoSnyG7ftyBe7N3E=; b=cfUSVQ5Rg7iPDhfXbvcMHNwaIUKk4bjbuvLg3WzL8YoTxIxlgjVygHcJOIVBh9k4ALZ/SKUKCF4HwND6gAbWb89i8/yrkrsa3b/GrFVxQ8n0nV9u5gwFqkVF6bKHvVmDoyzL2OO57kpANEeoLGIWPoflpKrVuhu4hT2Pm9gABps= Received: from AS8PR04MB8198.eurprd04.prod.outlook.com (2603:10a6:20b:3b0::14) by AM5PR0401MB2548.eurprd04.prod.outlook.com (2603:10a6:203:37::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.26; Tue, 16 Nov 2021 11:47:33 +0000 Received: from AS8PR04MB8198.eurprd04.prod.outlook.com ([fe80::9895:b941:f782:6999]) by AS8PR04MB8198.eurprd04.prod.outlook.com ([fe80::9895:b941:f782:6999%9]) with mapi id 15.20.4649.017; Tue, 16 Nov 2021 11:47:33 +0000 From: Gagandeep Singh To: Akhil Goyal , "dev@dpdk.org" Subject: RE: [EXT] [PATCH v2] app/test-crypto-perf: fix segment size for IPsec operation Thread-Topic: [EXT] [PATCH v2] app/test-crypto-perf: fix segment size for IPsec operation Thread-Index: AQHX2tX17ugmRO/jcEaE8qG0T7fv+awF94YAgAANuVA= Date: Tue, 16 Nov 2021 11:47:32 +0000 Message-ID: References: <20211116102301.2142361-1-g.singh@nxp.com> <20211116103714.2148007-1-g.singh@nxp.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 02188378-3fa7-4f57-5281-08d9a8f6e07d x-ms-traffictypediagnostic: AM5PR0401MB2548: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1751; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: c320QCQwWm8s4FqUl6szl72Crbatz9ws5PTyMguT3SUi5GVMUoTPZg7vV5l/NiAN8ePTnXU6AhHSLb0wlWLLJQbEWkHPH7QJgcx6DWNVltrJyb3aC1JN2yJYppPg9SwGJLMHXTk0dYycooe6t0jQzfnzA2YsGeZVZp/X9nwCpaHUDBF0eLSiSxoAYM6MxDWekybhabapjoHyCR++DL7IAiQh9O1V2FNJKhA4Lhp5/EC3igiWOBkBm8lVQchWvYZWafcz7vlE6whc+m/HDDCsxChxQEggRRDNW/OwpJI6WfpsqlvQsy1Y4j/uqrtsBpWaZsvrsIXQGYh5Qfye5dVcRUWQwzcMaOoTvMp3SN1hIltbOz0jNvO2/7M89IlCA8o5RJH4ITWp5C5b6pcsyi1LdF62njM2IxZM7Dz8HhWqEPdsyxH36/2gMdZ1/EZuzpltcyPuMG8RZhHjIn4KNSl/bFQy5OUw8qiOrarTrpWBrCxDWlMCgqN7/DD/Qn0E6GH2xojndeflZCUOmfXrjThNjG4pdM3Zyx91sithj6J0rTvU5cl/1aJh6ey7JTQQ0N7EPKjYq5MGCq/xjFHfxTZ7j+fBZiZOfbBfapVtTw3ZQY7l1RVQ9LteiiGUfcJYKlciqigAJWJpYzUqCzUDGiOUTk4kXXb1WBWhJ+/Yf7g/G9tikfd6s/nWwQOuADjKcykjc7oDLcczb1KO+vig6fDl/A== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AS8PR04MB8198.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(71200400001)(2906002)(55016002)(5660300002)(316002)(26005)(8936002)(38100700002)(7696005)(8676002)(9686003)(6506007)(40140700001)(122000001)(53546011)(52536014)(76116006)(110136005)(66476007)(64756008)(66446008)(508600001)(66556008)(66946007)(86362001)(83380400001)(33656002)(186003)(38070700005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?XyrWC077b6sSBIqpSzQbmo7pIwuzpgZMUplvIoYygDH0unKb17+3QLnX0IgT?= =?us-ascii?Q?QpRuAug52OErtXWYbe4+2KIODsE6/4hY+styCDVIy2J0vbc2R17u/F268+/J?= =?us-ascii?Q?lGSGYMp10jHA8lkXVLNMy0dTND04jrkTEbDKoiFKjAj08XCpPVfkuPK8DC4p?= =?us-ascii?Q?rx0RJY/VavfgeJOYAz+xSefs0/k0HoZubwCubXFuLZEhGxn0rGcfST6necnp?= =?us-ascii?Q?i7+RtQKRNG12UcZo8pH3oC3mLzJfeSUOPq0fM6zuz1MocxLRftJXxRIvgzRn?= =?us-ascii?Q?+Vv6uH4Ieq9hDFHcshNMOyscYmtWBUFj3Hp3joOQ8KrRUFWbDFZNz/cbS256?= =?us-ascii?Q?r731DmX8wlaFsLr15LKE2GaFZPQdZXIM4rBakp9dvWbKFyjlyq3dfK94uvWk?= =?us-ascii?Q?OL67L/ZnjWqp2iRJyhcsaCa1kdiUSi3O6CaVJiFbaFPwdqczB0Cmlms9oo3O?= =?us-ascii?Q?xtFK68PvLFlDJUI+kNXOdOPjB11SFm8xmwMuO9ZeNYpCDQ7bFj79CsxRd6iT?= =?us-ascii?Q?aJ/DVDWrPXiJ5658/kz3u1ayMERu3vp51CSHAgHCGowD9gdZ91VxVkihysjK?= =?us-ascii?Q?1bqHbDUWRHWsgawtHiPyFjZIQ6zdEogs+GC42TNNBb3KCJnHtIBtW0eAdG9z?= =?us-ascii?Q?R9zp0H/Qej2rc7mg4YCj3ep6T9ctdBMYWFs2YnJhNW43gzLbzd2ML/vPN8GM?= =?us-ascii?Q?pUmZXuIIq2ZY5nna+1T1xBach70/i49mqdKWY0Q/K+YoBTr1s6nAD4Q2YH/H?= =?us-ascii?Q?UP9W0ZeQOFiSY6v+yFJJ5OsImsWAxTHaOJIhEkATJR+IQNDXukZLo5LmdYn0?= =?us-ascii?Q?y9i76swRMpJI0rWTbnp+fmw8leueTvpRvSUOVkzEUhT7WmloORR/qGHgdP2u?= =?us-ascii?Q?lbF332isD5jm/QNXcpVIwdrN9GWiFKNYgr235OTRs0+tzXbSKVxckrM4SXZC?= =?us-ascii?Q?uZexEqvzM1f3BQc9CA8girIXmwX5rRx1elphOOIi5p3a6UnTJrs4bOE07KKf?= =?us-ascii?Q?zSifyFLiK7omgU0qb7fcfcXbNXOR0Qj6KXGr2qZKiaLA0PeSmg5aO6PyfuB3?= =?us-ascii?Q?uhLvbhGhFlNj8ezNBd0OxjmmrlLhEJ7HN/TGh6HPHOSU2mHOOiUqx/Crf+gz?= =?us-ascii?Q?8XeB++gFzIUEeL9l5RpgfvJC0Q3lWk6irw4lJ73CKhNpp/t0C9GB1/HHTdp+?= =?us-ascii?Q?LARoYBKk89sosjESqct4hHGlNa7WUwUf5tuuiu3jPV3JTPbj1HwIuisHGzQB?= =?us-ascii?Q?dwSUIHxi1mpAytIjjYUb5e8JaawL8qnc9R6Y46FUdSRuYIx+yDbZSlk7u0tS?= =?us-ascii?Q?HoW1a7Zgdhlqazv8KT5VUfejMKUGGLAINZqDy9SkGm6dqfHbsZfifMWRhKmU?= =?us-ascii?Q?EU0SYew8zpAAHFYmB5hWkuHEoTp/T991s7K9rxA+uP8GWkqVGNxXSVJHmx92?= =?us-ascii?Q?apDMnEz/oVBT1DXedyrMuzl2OCKliTpKPpVi8oqd/IKRMJ7skyxMtZMpW/Bs?= =?us-ascii?Q?ODXCjN9pQgInD/JNCOJCirZ5+BNRsbMm4A9hPXlKQa88LC1l6A2AApFzuw?= =?us-ascii?Q?=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8198.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 02188378-3fa7-4f57-5281-08d9a8f6e07d X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Nov 2021 11:47:33.0649 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: FPmU5Ntjj5b86NI34zZe6n4v/Gj1GDuJxsiJZXYslZCGFzfBHcYm/QvLGxSqdfAR X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0401MB2548 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Akhil Goyal > Sent: Tuesday, November 16, 2021 4:12 PM > To: Gagandeep Singh ; dev@dpdk.org > Subject: RE: [EXT] [PATCH v2] app/test-crypto-perf: fix segment size for = IPsec > operation >=20 > > Application calculates segment size based on buffer size plus > > digest size only, But if the operation mode is IPsec then > > packet length can be increased up to 73 bytes due to IPsec > > overhead. > > >=20 > Can you explain the calculation for 73 bytes in the code? > Will it be sufficient for IPv6? No, it will not cover IPv6, As currently only IPv4 test cases are there in = the app. But I guess it covers all the scenario which are supported by the app. 73 are the maximum bytes which can be added in=20 AES - SHA algo mode (41 +12 + 20 (including any padding))=20 But it will also not cover other complex scenario like NAT-T, AH. I have verified this change with aes-cbc-hmac-sha1 and aes-gcm algos for 64= ,128,256, 512, 1280 bytes. What's your opinion on this?=20 >=20 > > In this patch, adding the IPsec overhead length in segment size > > when there is no user given segment size. > > > > Fixes: 28dde5da503e ("app/crypto-perf: support lookaside IPsec") > > > > Signed-off-by: Gagandeep Singh > > --- > > v2-change-log: > > Update commit message with fixline. > > > > app/test-crypto-perf/cperf_options.h | 1 + > > app/test-crypto-perf/cperf_options_parsing.c | 5 ++++- > > 2 files changed, 5 insertions(+), 1 deletion(-) > > > > diff --git a/app/test-crypto-perf/cperf_options.h b/app/test-crypto- > > perf/cperf_options.h > > index 031b238b20..cdbc027b89 100644 > > --- a/app/test-crypto-perf/cperf_options.h > > +++ b/app/test-crypto-perf/cperf_options.h > > @@ -61,6 +61,7 @@ > > #define CPERF_PMDCC_DELAY_MS ("pmd-cyclecount-delay-ms") > > > > #define MAX_LIST 32 > > +#define CPERF_IPSEC_OVERHEAD 73 > > > > enum cperf_perf_test_type { > > CPERF_TEST_TYPE_THROUGHPUT, > > diff --git a/app/test-crypto-perf/cperf_options_parsing.c b/app/test-cr= ypto- > > perf/cperf_options_parsing.c > > index c244f81bbf..268f544936 100644 > > --- a/app/test-crypto-perf/cperf_options_parsing.c > > +++ b/app/test-crypto-perf/cperf_options_parsing.c > > @@ -1132,9 +1132,12 @@ cperf_options_check(struct cperf_options > > *options) > > * If segment size is not set, assume only one segment, > > * big enough to contain the largest buffer and the digest > > */ > > - if (options->segment_sz =3D=3D 0) > > + if (options->segment_sz =3D=3D 0) { > > options->segment_sz =3D options->max_buffer_size + > > options->digest_sz; > > + if (options->op_type =3D=3D CPERF_IPSEC) > > + options->segment_sz +=3D CPERF_IPSEC_OVERHEAD; > > + } > > > > if (options->segment_sz < options->digest_sz) { > > RTE_LOG(ERR, USER1, > > -- > > 2.25.1