From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9330CA0A04; Thu, 20 Oct 2022 05:33:12 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 830AB42C7D; Thu, 20 Oct 2022 05:33:12 +0200 (CEST) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2049.outbound.protection.outlook.com [40.107.21.49]) by mails.dpdk.org (Postfix) with ESMTP id 340CE42C31 for ; Thu, 20 Oct 2022 05:33:11 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=g9CwHRrrATjJNpSPjW82DBYm7ZuSu7AIV4+TMvRMDzLPWZDENm9qZZhxh37JDsscu7cRRTZX8m30UHq3UsLzITnpILFDVps0oL4f54Sxf4fZ1wdZKDvt8cgtzCMuMBrI17EURZoowjZH/f0dw5Qh8nYvEg1EixsFFAaI1+A/sKjxJ+q4wawnPC6EeLED5bvX5RcJoBY2HznTxbi2Le/A59tlBnDD1g1bxFA6E3S5Z+X9g9HyaYADqq3kyMWtG4ASv9j4js6xBC2aSgSjuycDtVI34RCFn+WwyS4D35lRiPM+/BkWtiLbMR9c9KXyx60QVYBlPh5W8eMXV8e5Y04iig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=e3OUBloM2pGq0Rn1z3DhlSgbO+RLB3AbN9dTJtCWk/s=; b=nDwOtsHO7Au5HAAY4TmyNEfw/VnohIJ3GFIRZ88RnZKpHzmb46DsN4yhKNmVxiH5Td4Js/ziaSFw35KqVfVDXn+SZ39TmojkQu+BlT4YCbhd7qWiSqrU9jNwAWrH3jXbxSbDy/95/+ieqNCO4+YXkvVk2LKc4J5a/FlI+XnNrV3IMAYJLy2U2rs2+wtGJKGOWOMWhWZqsUxlXQZneexKjXUPzfbUgmWIshCLcFHwgtzgGd2xP4kl2QHbGLywHSXufmP6EHA0Kdbu9mPsqJ+WACujXCtrS/GGRV0oZn1kKIq58iOUhakBLz8B6/uh1PmEH7p127E2rJgYcPvmfqby/Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=e3OUBloM2pGq0Rn1z3DhlSgbO+RLB3AbN9dTJtCWk/s=; b=bgpTj4Yag3sIwvq6PuNudQshlVxAo98sZy8HHDLZzfldDUffsjuyByKDBnRuH4nZoDYnZ0T2UKedCfpXQ+nXiXwZ+F0awx42LbD51hIcM5KctvXC1PUtJtuwCsqiezc4Qa2YH8bgpvPO8ZSd7rgwuWUqQCDGnM4OAHWWu532Kdw= Received: from AS8PR04MB9064.eurprd04.prod.outlook.com (2603:10a6:20b:447::17) by PR3PR04MB7386.eurprd04.prod.outlook.com (2603:10a6:102:85::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Thu, 20 Oct 2022 03:33:09 +0000 Received: from AS8PR04MB9064.eurprd04.prod.outlook.com ([fe80::f7e8:d402:a393:6205]) by AS8PR04MB9064.eurprd04.prod.outlook.com ([fe80::f7e8:d402:a393:6205%3]) with mapi id 15.20.5723.033; Thu, 20 Oct 2022 03:33:09 +0000 From: Hemant Agrawal To: Ferruh Yigit , Junfeng Guo , "qi.z.zhang@intel.com" , "jingjing.wu@intel.com" , Stephen Hemminger CC: "dev@dpdk.org" , "xiaoyun.li@intel.com" , "awogbemila@google.com" , "bruce.richardson@intel.com" , "xueqin.lin@intel.com" , Haiyue Wang Subject: RE: [PATCH v5 1/8] net/gve/base: introduce GVE PMD base code Thread-Topic: [PATCH v5 1/8] net/gve/base: introduce GVE PMD base code Thread-Index: AQHY3JG+nPx9x/rt+0S3uQQFTzYA1a4VyNMAgAAYABCAAAIqgIAAAbQA Date: Thu, 20 Oct 2022 03:33:09 +0000 Message-ID: References: <20220927073255.1803892-2-junfeng.guo@intel.com> <20221010101757.878317-1-junfeng.guo@intel.com> <20221010101757.878317-2-junfeng.guo@intel.com> <22ffbe85-8b30-c6c5-7c0d-117776e48b9c@amd.com> In-Reply-To: <22ffbe85-8b30-c6c5-7c0d-117776e48b9c@amd.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: AS8PR04MB9064:EE_|PR3PR04MB7386:EE_ x-ms-office365-filtering-correlation-id: 2fa5cc2a-7d95-45c2-df74-08dab24bcf31 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: NBnKBEtkM+9MvjIUdlm5hOil5SajLh0Vwj4sCV+WTmO0Dmxlf7pnZRWuuVlZVIvBqv3ap5TtlAo+TiFtupBEPRSTkA7b2cw1syvg+kwqfvVE8z+Nu81goIOu7jse/PvdztUZ6zcmAA4EeagO223CiVJ4jdLWnekSD84CW1O+NcwZRVIHr/OWGRrRUUJ8nh7TmmajA0aBsv56OTw47aq2nE1vEC78U8k5QoStO+DHXe60Rh89Eehpg88u1tIFKgwLuncDVmPN4FXEryZ5JjIc4stV9c8Gcbzby+Ik6EG+6ePirb4tMhgfj6U7vJ9KuOXw5BtoBLE55vW5ux+PyNaRWvf6wSsu2upetcI/Xgl7DbGjGHGm8gimNmyNS7ifsH6N72wbxyL4ddrNEeAHOem5MerulwE8mHGFH3YJf+p0x/okPEn56fpJUextVyHTSLBbrbydcDDC/KeKL1G93QfHEUxBgZav75Li2sVcevWatYLgD/LRWaVoFVfg0TjnrFioRbt32Q2F/svZ5IKDZ5r7aUIWQh2c2q45WpZ+Sv/2tjMPhhi6CszPkT3xO3YAwJcavci4BnAT5QIKVSGz1iVYwbNnNiKr8jTTr0pU24faREaVKYT+a1Duzotdhet0WPrxrEgQpzc1MrFO2Irqm604L80+EqW0sB5BquegFI2odKzvcnoBkT1jrFjZ3LZTZf26oaY4E2cIUGilI/PWYuPsUVgJbRn6sinY7tLr9Z9kkKyuxTNC4mIvxb34qBIBmfolpkq1BIAuyyIg6BAJ+881Rr4CflOvImdq+f/5I0jMCNM= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AS8PR04MB9064.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(39860400002)(346002)(376002)(396003)(366004)(136003)(451199015)(4326008)(66556008)(76116006)(66946007)(64756008)(8676002)(66446008)(66476007)(55016003)(45080400002)(316002)(71200400001)(110136005)(54906003)(33656002)(7416002)(5660300002)(8936002)(2906002)(44832011)(122000001)(52536014)(41300700001)(38100700002)(966005)(53546011)(7696005)(6506007)(186003)(9686003)(26005)(83380400001)(38070700005)(478600001)(86362001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?QXq0Oe6pDg+O+G95d/THIHRP8m3sYTd7H+0UXTTDem1tDelXpIXW4eFXx04C?= =?us-ascii?Q?uOCVtChw6Hn4jm7powyUlzD32sywQGROvy1tWSQgOycjzHabDm2dBPwvsRRc?= =?us-ascii?Q?RJ0Nq2EpVGiKeMi/6zpyV+5F+S9clYV4elnDvVe6i7hD6FdAzeP9EaMvpKzN?= =?us-ascii?Q?LLRFEsLp0XTsRHcbBlE+C7I0aPHzoFsS/xrb/1SHs89LOLY8uMtU1hT/JfBJ?= =?us-ascii?Q?RtrUfr6dA+qAFI8WOsNhdei8jU56YmDfrTTXl6fTAqkHkCcmUzJ6wjobVRWz?= =?us-ascii?Q?FhkW33vulsb89raWOJkuUAPiH2KooAP+QQ2lnqTGMMY/WEJiDpbcfBXp16A2?= =?us-ascii?Q?hQF4xgqKiFTHaWGBiPKAyvcIgG5jJP7V8cOamdAEAacO1+SX/FOImepCD82f?= =?us-ascii?Q?pPOGk3sgwkay9CMFAsg28rK1RE9FA3Ffp/H0OuZEbyqpG5m+LwAZumtIehJP?= =?us-ascii?Q?26YpdnCeignnLfwLkf8pva3YaFLQRU0h7MH4DuZ3NZov2lUJ7jgEqVvhq/KX?= =?us-ascii?Q?BCdAwZPyADe7/wMSZdB1r9HA3CpG00CJikCsGPTjfu01pDH4y5b3kyJsvTYQ?= =?us-ascii?Q?pRCALPSfCuar/tnnlaUoo9yOTbNJl/fTqlM/KT7SM9T8TMcLqYmIZ1E/VCrR?= =?us-ascii?Q?D/eG5UZIBqhWHAqD7C5D189KLI6reBCoqK/tcvcR9ZYsXC2MOBl/ozyOEewu?= =?us-ascii?Q?KHRLOo4/6gWNOYz6sum42DC6sGfoj831uZAgGOYMFKd+TPkumN4uRqB0lRYB?= =?us-ascii?Q?RpmYgAojmMeBeh8wsBoyK5PaOef04T2UCB5QPWrwoVvkmEc9moWLVMtVh0sb?= =?us-ascii?Q?+Yith6eku85qZaCEkeSKJCliKwtYFFsoafqAc8BKEje4m+mTQXYIM/c6lDTm?= =?us-ascii?Q?4edtUjj4ip9TNI3CKxadfIIFbK0Qdx0PNf0FHlPIxipWTa1HmhVp0SvLVSuM?= =?us-ascii?Q?f2dtTC93XrJFte+kTw9LbVgwfi5mpF78GqQrJHtw3p69QOauhP0QrIY54169?= =?us-ascii?Q?669xytz6aglJV6XJKhCN7/rLeMTAOu4dxuCjENgTdaWH9ZjwjjrEF4/71pCb?= =?us-ascii?Q?jV/CDCNBy7xGbMJpjvYZjF9a6f1r/M7KMRyO74yn4VUPp2dQbiFPaVTFeNYx?= =?us-ascii?Q?D4pxPIN0UZHsnktk/nBIJbgSpO8+rJKs42HnK1Z9gL95QgoHKoYIkfEZAsr1?= =?us-ascii?Q?qqBYWjQ7M384x4Nq8tZZpugFgSk4VJEWHywjClWDOqhF4I0LkwXaX8CHGPCh?= =?us-ascii?Q?hnJzbGOwbG5R7i6Kv733lggCDiuDuVLKLQNYUO+F55kyxsqffCmrZkiFjFtY?= =?us-ascii?Q?MQ001IJPigAZV2t5WHwcBT4DIXzVO7ySFtn2zcjBzhGbID7Hx8ylfZKq6nB0?= =?us-ascii?Q?/nr1MOoSjVLQB3UdrmamNJY3eJnuL7ScI78fc+74iwytsw7NacOGJ4C9O61p?= =?us-ascii?Q?o5xx+RqPaXMfShvLUa6QjDDdGA3mbysylN1GzdxnktlTIfEwaIJPKC7QWUFE?= =?us-ascii?Q?X+tYWLquLU+Q9l1NVNWdt34PQUDS1AeeB5B+FqqSRooMBQE6n2/9es5kuSsX?= =?us-ascii?Q?OWwpNYz4PVHAliq5Oum0rQoXJVwnVcR29AP/HWB9?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB9064.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2fa5cc2a-7d95-45c2-df74-08dab24bcf31 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Oct 2022 03:33:09.4477 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: IGw5N/xkENy/WHqolJWuMBoJqNJ6sYpzAiBqCTr9JXpuZtVvi9zGPlFBIRyW3XPAnZn1OE4xJejEu4yfdyDIOA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR04MB7386 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > On 10/19/2022 4:13 PM, Hemant Agrawal wrote: > >> On 10/10/2022 11:17 AM, Junfeng Guo wrote: > >>> The following base code is based on Google Virtual Ethernet (gve) > >>> driver v1.3.0 under MIT license. > >>> - gve_adminq.c > >>> - gve_adminq.h > >>> - gve_desc.h > >>> - gve_desc_dqo.h > >>> - gve_register.h > >>> - gve.h > >>> > >>> The original code is in: > >>> https://eur01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fg= i > >>> th > >>> ub.com%2FGoogleCloudPlatform%2Fcompute-virtual-ethernet- > >> linux%2F%2F&am > >>> > >> > p;data=3D05%7C01%7Chemant.agrawal%40nxp.com%7C45cbc9718dcc40d04e4 > >> 508dab1 > >>> > >> > d82440%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C6380178391 > >> 21579415 > >>> %7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2lu > MzIi > >> LCJBTiI6I > >>> > >> > k1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=3DLHunq53xMl8i > >> W6%2B3scjZ > >>> q0Bx7oF08yLWk424aw5lnwA%3D&reserved=3D0 > >>> tree/v1.3.0/google/gve > >>> > >>> Note that these code are not Intel files and they come from the > >>> kernel community. The base code there has the statement of > >>> SPDX-License-Identifier: (GPL-2.0 OR MIT). Here we just follow the > >>> required MIT license as an exception to DPDK. > >>> > >>> Signed-off-by: Xiaoyun Li > >>> Signed-off-by: Haiyue Wang > >>> Signed-off-by: Junfeng Guo > >> > >> <...> > >> > >>> diff --git a/drivers/net/gve/base/gve.h b/drivers/net/gve/base/gve.h > >>> new file mode 100644 index 0000000000..1b0d59b639 > >>> --- /dev/null > >>> +++ b/drivers/net/gve/base/gve.h > >>> @@ -0,0 +1,58 @@ > >>> +/* SPDX-License-Identifier: MIT > >>> + * Google Virtual Ethernet (gve) driver > >>> + * Version: 1.3.0 > >> > >> There is a version macro in the code, is version information required > >> in the file comment? > >> > >>> + * Copyright (C) 2015-2022 Google, Inc. > >>> + * Copyright(C) 2022 Intel Corporation > >> > >> I don't know if it is OK to add Intel copyright, as far as I know > >> this requires big enough contribution to the code, if this is copy of > >> existing code, may be only original copyright should exist. > >> > > [Hemant] Yes, the general guideline is that one should add their copyri= ght if > they have big enough contribution. But at the end it is a guideline - no= t the > rule. > > It is up-to the original copyright holder to object. >=20 > Does this mean as long as original copyright holder did not object, it is= OK to > add more copyright? > I don't think they are represented or aware of it this change at all, I b= elieve > we (as community) also have responsibility to make these things correct, = in > our capacity. [Hemant] I tried to convey the same in decent words. =20 Yes, it is incorrect to add copyright without major contribution change. Intel team shall provide details about what is their contribution over the = original code. Or they should remove their copyright > > > >> cc'ed @Hemant and @Stephen for more comment.